GNU bug report logs - #42935
[PATCH] gnu: Add nicotine.

Previous Next

Full log

Message #10 received at 42935-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Martin Becze <mjbecze <at> riseup.net>
Cc: 42935-done <at> debbugs.gnu.org
Subject: Re: [bug#42935] [PATCH] gnu: Add nicotine.
Date: Sat, 22 Aug 2020 12:52:24 -0400

On Wed, Aug 19, 2020 at 12:03:18PM -0500, Martin Becze wrote:
> * gnu/packages/nicotine.scm (nicotine): New variable.

Thank you! Awesome! Back to the future :)

I pushed with the following changes:

I also registered the new file in gnu/local.mk. Otherwise, it won't be
included in distribution tarballs.

> +(define-public nicotine
> +  (package
> +    (name "nicotine")

I changed it to be named "nicotine+". The plus sign is okay for Guix and
more accurate.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/Nicotine-Plus/nicotine-plus")
> +                    (commit version)))
> +              (sha256 (base32 "07xagm6kwy8b6gcdv5vx78yqfllkz1gvlakkf0hi2c9ivncq457g"))))

I added a file-name field so that the source code checkout would have a
descriptive name, and to satisfy `guix lint`.

> +         (add-after 'install 'wrap-assword

I renamed this phase to 'wrap-program'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.