From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 11:03:12 2020 Received: (at submit) by debbugs.gnu.org; 19 Aug 2020 15:03:12 +0000 Received: from localhost ([127.0.0.1]:40725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8PcN-0006m5-KB for submit@debbugs.gnu.org; Wed, 19 Aug 2020 11:03:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:60956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8PcL-0006lw-KY for submit@debbugs.gnu.org; Wed, 19 Aug 2020 11:03:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8PcJ-0001Ki-UD for bug-guix@gnu.org; Wed, 19 Aug 2020 11:03:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49767) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8PcJ-00060p-LU for bug-guix@gnu.org; Wed, 19 Aug 2020 11:03:07 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:55672 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k8PcJ-0005rs-1k for bug-guix@gnu.org; Wed, 19 Aug 2020 11:03:07 -0400 From: Marius Bakke To: bug-guix@gnu.org Subject: GHC does not remove unnecessary references for non-standard store prefixes Date: Wed, 19 Aug 2020 17:01:48 +0200 Message-ID: <87a6yqptlv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, The 'remove-unnecessary-references' phase in GHC added by commit f737d3ddd8018f89b0fa9f80aee4490cd726903a introduces a regression where users with a non-standard store prefix will get a different end result. The code should be changed to use %store-directory instead of hard-coding "/gnu/store". While at it, it would be good to add '#:disallowed-references ("doc")' to catch regressions in that area. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl89PtwACgkQoqBt8qM6 VPrYcAgAjBqS+h9feYvwMViSnxO1xBWiIL80sCax7c6NBwIOpqGY3xqWuWzoWq4G GhsCAWTuUGg7exbfFr85eRyZS7/sOb5gnKcDv444DM7RTDQW4s5kC3Q72WQvoxAL T/ns4hpgXXU3cSsbDcyHzBKLjYB/MhkBRsfVCBI0qNrZq4z0czwm5Z3+bhnMe4hN nTxzm/k8G6cBWJ4AwfAAj2OmmUCzxRjUWuA0rXB7iBvxTkNlHXJ0KlD755utpxwD DeC5SR8qa/Txugc9AZu9/PY541NFdbwxpVUUAmoBTeZzqd/W67iRt3wpj53CMIFD gAJtLt88D1KMz+Kv/fcbLi+y6shVOA== =JXWP -----END PGP SIGNATURE----- --=-=-=--