GNU bug report logs - #4293
23.1; use pop-to-buffer, not switch...other-window, in bookmark.el

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Sun, 30 Aug 2009 15:00:06 UTC

Severity: normal

Done: Karl Fogel <kfogel <at> red-bean.com>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 4293 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>, 4293 <at> debbugs.gnu.org
Subject: Re: bug#4293: 23.1;	use pop-to-buffer, not switch...other-window,
 in bookmark.el
Date: Wed, 02 Sep 2009 11:58:59 +0200

> In bookmark-jump-other-window and bookmark-bmenu-other-window we call
> switch-to-buffer-other-window. We should use pop-to-buffer, instead.
>
> With non-nil pop-up-frames, switch-to-buffer-other-window creates a
> new frame each time, even if the destination buffer is already showing
> in some frame. pop-to-buffer DTRT: it reuses the existing frame.

I'm not sure what the problem is here.  `switch-to-buffer-other-window'
has a clear purpose - do _not reuse the selected window_ (which is the
bookmarks window, IIUC).  OTOH `display-buffer-reuse-frames' non-nil
should assure that another frame is reused.

martin
This bug report was last modified 15 years and 230 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.