GNU bug report logs - #42914
[PATCH] Fixed indentation and mix used of space and tabs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42914 in the body.
You can then email your comments to 42914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jen-Chieh Shen <jcs090218 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fixed indentation and mix used of space and tabs.
Date: Tue, 18 Aug 2020 22:02:43 +0800

[Message part 1 (text/plain, inline)]

When I am editing the file `lisp/window.el` I found some indentation issues
and mixed use of space and tab. Is there a specific reason that these
issues exist?

Best,

Jen-Chieh Shen

[Message part 2 (text/html, inline)]

[ind-and-mix.patch (application/octet-stream, attachment)]

Message #8 received at 42914 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jen-Chieh Shen <jcs090218 <at> gmail.com>
Cc: 42914 <at> debbugs.gnu.org
Subject: Re: bug#42914: [PATCH] Fixed indentation and mix used of space and
 tabs.
Date: Tue, 18 Aug 2020 17:11:02 +0300

> From: Jen-Chieh Shen <jcs090218 <at> gmail.com>
> Date: Tue, 18 Aug 2020 22:02:43 +0800
> 
> When I am editing the file `lisp/window.el` I found some indentation issues and mixed use of space and tab.

Thanks, but we prefer not to make whitespace-only changes, they make
repository forensics harder.  Instead, we fix whitespace where other
changes are being made.

> Is there a specific reason that these issues exist?

History.

Message #11 received at 42914 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jen-Chieh Shen <jcs090218 <at> gmail.com>
Cc: 42914 <at> debbugs.gnu.org
Subject: Re: bug#42914: [PATCH] Fixed indentation and mix used of space and
 tabs.
Date: Tue, 18 Aug 2020 16:13:18 +0200

Jen-Chieh Shen <jcs090218 <at> gmail.com> writes:

> When I am editing the file `lisp/window.el` I found some indentation
> issues

We generally don't do whitespace-only fixes, because that makes looking
at the history of changes more difficult (as well as applying patches).

> and mixed use of space and tab. Is there a specific reason that
> these issues exist?

We generally don't care very much about whether something uses tabs or
spaces or a mix thereof.

So I'm not going to apply this patch, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.