From unknown Fri Aug 15 12:50:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42912 <42912@debbugs.gnu.org> To: bug#42912 <42912@debbugs.gnu.org> Subject: Status: cran.git importer fails because with-store swallows extra values. Reply-To: bug#42912 <42912@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:50:57 +0000 retitle 42912 cran.git importer fails because with-store swallows extra val= ues. reassign 42912 guix submitter 42912 Ricardo Wurmus severity 42912 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 05:50:29 2020 Received: (at submit) by debbugs.gnu.org; 18 Aug 2020 09:50:29 +0000 Received: from localhost ([127.0.0.1]:34060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7yGC-0002Tr-PW for submit@debbugs.gnu.org; Tue, 18 Aug 2020 05:50:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:50288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7yGB-0002Tj-7m for submit@debbugs.gnu.org; Tue, 18 Aug 2020 05:50:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7yGA-0006Tu-Oi for bug-guix@gnu.org; Tue, 18 Aug 2020 05:50:26 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k7yG8-0004Aw-WF for bug-guix@gnu.org; Tue, 18 Aug 2020 05:50:26 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597744218; cv=none; d=zohomail.com; s=zohoarc; b=nKPTLSWeKJRflAMqhD+IqlXIHPlfWGF1MFSX54rkEiJV9IlUr+HpjvT7E9dac4EFkAyypBLrt7okXxr0XyKqI/aWdk8UjNcCoSOva1FNzLbjh3iF+sH1eE2TBRv1aDNYYRndMWflAUM5aR09oDw/jbGdvucUgpUtV9L3PZ0p+eI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597744218; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=AaUZNXuIavLj2DHFs4IhlkhSYf4IFT7lLqjCVTNmL0Y=; b=Flv5I9CJK2Yz3043FEH9C6la+hWhn7KLohApCYRBIcR9Mr8T1b3avbBxUZpeR7uE3+Fapcge57vYS1+lfgvknFEudddWF/4mMyn24eVq3hWnqa/v7CaPP/YsL4ugKrUeInc2N425BPOtlNdTbdP51lVUuaOUOPajWHOXGaQ2PUk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1597744218; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=AaUZNXuIavLj2DHFs4IhlkhSYf4IFT7lLqjCVTNmL0Y=; b=HfeSm1Veca/+uHeigOvVeDDF/nxqGUiJbodbWHXY/fLooMlVGEtmN9GAdnEak4H7 Vjfxl4x5EHyTgz4JfSWvxuX4EdE61la3LcCMIDM9PIBeh97kJr1LwGnWLg5ORfPpoPE LDxhghVtcZ51GJkg6l66cR/6SNDQSaeRDN8t0zxY= Received: from localhost (p54ad4c5e.dip0.t-ipconnect.de [84.173.76.94]) by mx.zohomail.com with SMTPS id 1597744214262705.9074730389926; Tue, 18 Aug 2020 02:50:14 -0700 (PDT) User-agent: mu4e 1.4.10; emacs 26.3 From: Ricardo Wurmus To: bug-guix@gnu.org Subject: cran.git importer fails because with-store swallows extra values. X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Tue, 18 Aug 2020 11:50:09 +0200 Message-ID: <87y2mcxoz2.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/18 05:50:19 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The =E2=80=9Ccran=E2=80=9D importer has support for git and hg repositories= . This no longer works, because the =E2=80=9Cdownload=E2=80=9D is supposed to return = multiple values. Seemingly due to the use of =E2=80=9Cwith-store=E2=80=9D it no lon= ger returns multiple values, so the =E2=80=9Cgit=E2=80=9D and =E2=80=9Chg=E2=80=9D arch= ives no longer work. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 18 06:41:12 2020 Received: (at 42912) by debbugs.gnu.org; 18 Aug 2020 10:41:12 +0000 Received: from localhost ([127.0.0.1]:34176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7z3I-00060Z-7X for submit@debbugs.gnu.org; Tue, 18 Aug 2020 06:41:12 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7z3D-00060L-Fs for 42912@debbugs.gnu.org; Tue, 18 Aug 2020 06:41:11 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597747265; cv=none; d=zohomail.com; s=zohoarc; b=R9i0ooEA441gk73filKtG8zcz6/JMJdBJXTq7lk1fq5KRNwaw8WSuTBq571XAasvBtfUye0oxoMFn6FoES6Y8ZLMZ+WkVbUGfCCLWuTqvRFGaTXgIEelF3XbyoAEiFGwmk1DspfV+FgurmccAAmiZIlzgTqdp3EsY/l7HYtJdZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597747265; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=VvNbySY5/JE+uYrr+KpTqj4nrRSa5k3onR4N66AreGQ=; b=X1gO3ZNP9kVrm+DZI0eRCAfUszXrPY0V1DcPr2rIyOASIb62MI7/NL8rgyeRVhILdoYEY0SpAxpmJ9YyuIXxI+vueVAU2pSbAugB8FbRqt2rr4BhOPbU5wG8MedYPAzOtUssvabYjnocysmxiszCjHx+S07vizcOE/Pd1Yrel5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1597747265; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; bh=VvNbySY5/JE+uYrr+KpTqj4nrRSa5k3onR4N66AreGQ=; b=DGBFxbpIjI4B9DOFNXp5GZJaTRwQgXOdgb/3XfXI1f3jRwlG1+ilW1iaOd+P77J8 8qL5OrWXw7yftAGp7tOah9jLp4zUI1ZXFL1CYxkIl+2ekE59g5ljmhZ2ckPSz24P/EG ITTs0V8Tp2Vg6f429BXVb+pkfDuoP7HU99xAg/eY= Received: from localhost (p54ad4c5e.dip0.t-ipconnect.de [84.173.76.94]) by mx.zohomail.com with SMTPS id 1597747261328476.43155413921477; Tue, 18 Aug 2020 03:41:01 -0700 (PDT) References: <87y2mcxoz2.fsf@elephly.net> User-agent: mu4e 1.4.10; emacs 26.3 From: Ricardo Wurmus To: 42912@debbugs.gnu.org Subject: Re: bug#42912: Acknowledgement (cran.git importer fails because with-store swallows extra values.) In-reply-to: X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Tue, 18 Aug 2020 12:40:58 +0200 Message-ID: <87pn7oxmmd.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42912 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This hack works around the problem: --8<---------------cut here---------------start------------->8--- diff --git a/guix/import/cran.scm b/guix/import/cran.scm index a1275b4822..e10ea25587 100644 --- a/guix/import/cran.scm +++ b/guix/import/cran.scm @@ -197,10 +197,17 @@ bioconductor package NAME, or #F if the package is unknown." (define download (memoize (lambda* (url #:key method) + (define v1 #f) + (define v2 #f) (with-store store (cond ((eq? method 'git) - (latest-repository-commit store url)) + (call-with-values + (lambda () + (latest-repository-commit store url)) + (lambda (dir commit) + (set! v1 dir) + (set! v2 commit)))) ((eq? method 'hg) (call-with-temporary-directory (lambda (dir) @@ -214,8 +221,10 @@ bioconductor package NAME, or #F if the package is unknown." (find-files dir "^\\.hg$" #:directories? #t)) (let ((store-directory (add-to-store store (basename url) #t "sha256" dir))) - (values store-directory changeset))))))) - (else (download-to-store store url))))))) + (set! v1 store-directory) + (set! v2 changeset))))))) + (else (set! v1 (download-to-store store url))))) + (values v1 v2)))) (define (fetch-description repository name) "Return an alist of the contents of the DESCRIPTION file for the R package --8<---------------cut here---------------end--------------->8--- -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 28 17:31:15 2020 Received: (at 42912) by debbugs.gnu.org; 28 Aug 2020 21:31:15 +0000 Received: from localhost ([127.0.0.1]:47567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBlxr-0001Ah-DF for submit@debbugs.gnu.org; Fri, 28 Aug 2020 17:31:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBlxn-0001AT-3e for 42912@debbugs.gnu.org; Fri, 28 Aug 2020 17:31:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40405) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBlxh-0002Dr-7O; Fri, 28 Aug 2020 17:31:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBlxg-0001m7-Bh; Fri, 28 Aug 2020 17:31:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: bug#42912: cran.git importer fails because with-store swallows extra values. References: <87y2mcxoz2.fsf@elephly.net> Date: Fri, 28 Aug 2020 23:31:01 +0200 In-Reply-To: <87y2mcxoz2.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 18 Aug 2020 11:50:09 +0200") Message-ID: <87o8mump9m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42912 Cc: 42912@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Howdy Ricardo! Ricardo Wurmus skribis: > The =E2=80=9Ccran=E2=80=9D importer has support for git and hg repositori= es. This no > longer works, because the =E2=80=9Cdownload=E2=80=9D is supposed to retur= n multiple > values. Seemingly due to the use of =E2=80=9Cwith-store=E2=80=9D it no l= onger returns > multiple values, so the =E2=80=9Cgit=E2=80=9D and =E2=80=9Chg=E2=80=9D ar= chives no longer work. I believe 3d9ea605c8dfb7fc43689e12975218b032b3175a fixes this, though I don=E2=80=99t know how to test it. If you can confirm it does, feel free to close this bug. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 29 03:36:28 2020 Received: (at 42912-done) by debbugs.gnu.org; 29 Aug 2020 07:36:28 +0000 Received: from localhost ([127.0.0.1]:47875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBvPX-0000y0-Nj for submit@debbugs.gnu.org; Sat, 29 Aug 2020 03:36:27 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBvPU-0000xq-03 for 42912-done@debbugs.gnu.org; Sat, 29 Aug 2020 03:36:26 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1598686577; cv=none; d=zohomail.com; s=zohoarc; b=VCRYS0ltWovK3sc71isSFsUDUi1sC0XT8j/GViQr6fIyC1gW2sVwlsV4mpz+PBPvEhszitnRXGBBKjQ1xSKYivjHkaBQsly3AnP1xbTPEWs9+cEw6BVsgAzfczycsQdzDEdT+A6+DfM/lyGypg6g0gdKxKoB1ezwr3QHtxOWSPw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598686577; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wvsuCHXs9/lewu5pbyCm1JFQEl4TaAJWBe4QxcNjJz4=; b=JEZXUwAT+0QLwp4PeFRLIrnbW0q4rwd0RNNiwPUvonJBd89UOjqcKCEhTeUJgtA1TyAMDCwQ1bHL9z1kG6RbwEA7hhBOB240G+K67wXcwk8VQ3gWbwcz9KOhqgBBk55lsOMAYF61DOVc94Wy/9QwCruBi/Lb3UE83zmmM4WTEJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1598686577; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=wvsuCHXs9/lewu5pbyCm1JFQEl4TaAJWBe4QxcNjJz4=; b=f64imkxMfKugjxveQ+i/+NDvmDvzaFKk3T3OkJUrNpfw1PWgMr/ofcwR78FA2BEw hYA3eLV594r20YUJOxFbFKxrcZDmNNQdJYqLHz6knxjavaj4+DGRB0eFMVjQge7Vv+f 5kaeUPVJz/Zm1DkobwrSqST7fvjzijC7Sm4gixek= Received: from localhost (p54ad4aa5.dip0.t-ipconnect.de [84.173.74.165]) by mx.zohomail.com with SMTPS id 1598686572821318.4723155910784; Sat, 29 Aug 2020 00:36:12 -0700 (PDT) References: <87y2mcxoz2.fsf@elephly.net> <87o8mump9m.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 26.3 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#42912: cran.git importer fails because with-store swallows extra values. In-reply-to: <87o8mump9m.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 29 Aug 2020 09:36:08 +0200 Message-ID: <87r1rpoqdz.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42912-done Cc: 42912-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > I believe 3d9ea605c8dfb7fc43689e12975218b032b3175a fixes this, though I > don=E2=80=99t know how to test it. > > If you can confirm it does, feel free to close this bug. It looks like it=E2=80=99s indeed fixed. Thank you! I tested with this command: guix import cran -a git https://github.com/immunogenomics/harmony --=20 Ricardo From unknown Fri Aug 15 12:50:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Sep 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator