From bremner-dated-1252195334.03c7a6@pivot.cs.unb.ca Sat Aug 29 17:02:23 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 30 Aug 2009 00:02:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7U02Lf3031406 for ; Sat, 29 Aug 2009 17:02:23 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhXsD-0000Gd-96 for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 20:02:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhXs8-0000GA-Dx for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 20:02:20 -0400 Received: from [199.232.76.173] (port=56656 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhXs8-0000G7-BU for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 20:02:16 -0400 Received: from pivot.cs.unb.ca ([131.202.240.57]:41884) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MhXs7-0003cz-Qo for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 20:02:16 -0400 Received: from bremner by pivot.cs.unb.ca with local (Exim 4.69) (envelope-from ) id 1MhXs6-0008Py-6W for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 21:02:14 -0300 Received: by pivot.cs.unb.ca (tmda-sendmail, from uid 1266); Sat, 29 Aug 2009 21:02:12 -0300 Received: from fctnnbsc27w-142167175181.pppoe-dynamic.nb.aliant.net ([142.167.175.181] helo=localhost) by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MhXs4-0008Pr-Iz for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 21:02:12 -0300 Received: from bremner by localhost with local (Exim 4.69) (envelope-from ) id 1MhXrz-0005yJ-3B for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2009 21:02:07 -0300 To: bug-gnu-emacs@gnu.org Subject: 23.1; doc-view-mode temporary directory vulnerable to denial of service Message-Id: Date: Sat, 29 Aug 2009 21:02:07 -0300 X-Sender-Verified: bremner@pivot.cs.unb.ca X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) From: David Bremner X-TMDA-Fingerprint: RD7Gx12WIO1pr9JDNmQFTr7H2OI X-Primary-Address: bremner@unb.ca Reply-To: David Bremner X-Tmda-Bare: David Bremner X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) By default doc-view-mode makes a directory /tmp/docview$uid . Since this is easily predictable, a malicious person could cause docview to fail simply by creating a directory with the same name. In GNU Emacs 23.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2009-08-03 on raven, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10603000 configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=athena' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_CA.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: diff-auto-refine-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x C-g C-x C-f t e a SPC c s SPC 2 SPC SPC w i SPC c SPC SPC SPC SPC M-x r e p SPC o SPC SPC r SPC SPC SPC Recent messages: Loading /home/bremner/.emacs-custom.el (source)... Loading epa-mail...done Loading /home/bremner/.emacs-custom.el (source)...done Loading /usr/share/emacs/site-lisp/haskell-mode/haskell-site-file.el (source)...done For information about GNU Emacs and the GNU system, type C-h C-a. Quit Making completion list... [2 times] File mode specification error: (file-error "Doing chmod" "operation not permitted" "/tmp/docview1000") Loading vc-git...done Making completion list... [3 times] From rgm@gnu.org Sun Aug 30 18:42:53 2009 Received: (at 4291) by emacsbugs.donarmstrong.com; 31 Aug 2009 01:42:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7V1gqrj020867 for <4291@emacsbugs.donarmstrong.com>; Sun, 30 Aug 2009 18:42:53 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Mhvv1-00044g-Pg; Sun, 30 Aug 2009 21:42:51 -0400 From: Glenn Morris To: David Bremner Cc: 4291@debbugs.gnu.org Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service References: X-Spook: insurgency Janet Reno DES Legion of Doom terrorism mania X-Ran: &{C(F^JLG,+:$nnMW[sV:yf,jnrS|:o/FENpbS X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sun, 30 Aug 2009 21:42:51 -0400 In-Reply-To: (David Bremner's message of "Sat, 29 Aug 2009 21:02:07 -0300") Message-ID: <1x7hwk3gis.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii David Bremner wrote: > By default doc-view-mode makes a directory /tmp/docview$uid . Since > this is easily predictable, a malicious person could cause docview to > fail simply by creating a directory with the same name. Couldn't they do the same thing by simply filling /tmp with junk, no matter what filename is used? (Emacs server also uses the same name every time AFAIK.) From monnier@iro.umontreal.ca Mon Aug 31 07:55:47 2009 Received: (at 4291) by emacsbugs.donarmstrong.com; 31 Aug 2009 14:55:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7VEtkXk016850 for <4291@emacsbugs.donarmstrong.com>; Mon, 31 Aug 2009 07:55:47 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqIEAJuBm0pFpYuS/2dsb2JhbACBU9ZUgjeBYwWHaA X-IronPort-AV: E=Sophos;i="4.44,305,1249272000"; d="scan'208";a="44605143" Received: from 69-165-139-146.dsl.teksavvy.com (HELO ceviche.home) ([69.165.139.146]) by ironport2-out.teksavvy.com with ESMTP; 31 Aug 2009 10:54:35 -0400 Received: by ceviche.home (Postfix, from userid 20848) id E7DA570048; Mon, 31 Aug 2009 10:55:40 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Cc: 4291@debbugs.gnu.org, David Bremner Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service Message-ID: References: <1x7hwk3gis.fsf@fencepost.gnu.org> Date: Mon, 31 Aug 2009 10:55:40 -0400 In-Reply-To: <1x7hwk3gis.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 30 Aug 2009 21:42:51 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> By default doc-view-mode makes a directory /tmp/docview$uid . Since >> this is easily predictable, a malicious person could cause docview to >> fail simply by creating a directory with the same name. > Couldn't they do the same thing by simply filling /tmp with junk, no > matter what filename is used? Yes, tho it's a bit different: your case can be avoided by appropriate use of quotas on /tmp (yes, I realize this is highly unlikely), and your case cannot be obtained without impacting the system as a whole (i.e. it's less discrete). > (Emacs server also uses the same name every time AFAIK.) Yes, and Emacs server needs this name to be predictable (an "ls /tmp" shows that other services, such as `orbit', are similarly vulnerable). IIRC /tmp/docview$uid is predictable because doc-view tries to reuse previouly-rendered pages. I'm not convinced this is really a good feature, but obviously the author thought it was important, so I'd rather not drop it without a discussion. Stefan From rgm@gnu.org Tue Sep 1 14:15:56 2009 Received: (at 4291) by emacsbugs.donarmstrong.com; 1 Sep 2009 21:15:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.8 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81LFtYs023091 for <4291@emacsbugs.donarmstrong.com>; Tue, 1 Sep 2009 14:15:56 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Miahm-0006WC-87; Tue, 01 Sep 2009 17:15:54 -0400 From: Glenn Morris To: Stefan Monnier Cc: 4291@debbugs.gnu.org, David Bremner , tassilo@member.fsf.org Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service References: <1x7hwk3gis.fsf@fencepost.gnu.org> X-Spook: brigand MD5 AIEWS Bruxelles Defcon Al Jazeera X-Ran: ,dz^k{AloEDUUC=kNKyaUce*0&Y;Qiz9'snf4;zOs_1\YR{~O$Jb5WC<\euPh%nhw\V!>{ X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 01 Sep 2009 17:15:54 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: > Yes, tho it's a bit different: your case can be avoided by appropriate > use of quotas on /tmp (yes, I realize this is highly unlikely), and your > case cannot be obtained without impacting the system as a whole > (i.e. it's less discrete). The original scenario doesn't seem likely (or discreet). I suggest just making docview give an explicit error if its cache dir: a) cannot be created; or b) exists but cannot be read or written to. From rgm@gnu.org Tue Sep 1 14:13:41 2009 Received: (at control) by emacsbugs.donarmstrong.com; 1 Sep 2009 21:13:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,ONEWORD,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81LDeho022608 for ; Tue, 1 Sep 2009 14:13:41 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Miafb-0006Qs-84; Tue, 01 Sep 2009 17:13:39 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19101.36483.153585.984037@fencepost.gnu.org> Date: Tue, 1 Sep 2009 17:13:39 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes forcemerge 4122 4134 reassign 4309 emacs,ns reassign 4305 spam reassign 4302 spam reassign 4299 spam severity 4296 minor reassign 4297 emacs,ns reassign 4295 emacs,ns severity 4291 minor tags 4285 moreinfo From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 17:19:13 2011 Received: (at 4291) by debbugs.gnu.org; 12 Jul 2011 21:19:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgkMG-0004R9-V8 for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:19:13 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgkM9-0004QV-IW for 4291@debbugs.gnu.org; Tue, 12 Jul 2011 17:19:05 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgkLx-000657-Lt; Tue, 12 Jul 2011 23:18:49 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service In-Reply-To: (Stefan Monnier's message of "Mon, 31 Aug 2009 10:55:40 -0400") Date: Tue, 12 Jul 2011 23:18:43 +0200 Message-ID: References: <1x7hwk3gis.fsf@fencepost.gnu.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Peter Gabriel's _Plays Live (1)_: "D.I.Y." X-Hashcash: 1:23:110712:4291@debbugs.gnu.org::kCn3O3TKLwPd++UE:000000000000000000000000000000000000000006rKY X-Hashcash: 1:23:110712:bremner-dated-1252800134.2fccb3@pivot.cs.unb.ca::fw20F/Kdt7IoBx4w:00000000000000Gyg2 X-Hashcash: 1:23:110712:rgm@gnu.org::cDlCt477RGGyWMH8:000001F79K X-Hashcash: 1:23:110712:monnier@iro.umontreal.ca::wnXn+OB1ax8ujd3w:0000000000000000000000000000000000001Q8fr MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QgkLx-000657-Lt X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311110329.77326@Cro8MRr5yl65AzrHtM96NQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4291 Cc: Glenn Morris , David Bremner , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: > IIRC /tmp/docview$uid is predictable because doc-view tries to reuse > previouly-rendered pages. I'm not convinced this is really a good > feature, but obviously the author thought it was important, so I'd > rather not drop it without a discussion. It could just stash the directory name in a variable, and use the normal `make-temp-file' to create the directory, couldn't it? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 17:45:02 2011 Received: (at 4291) by debbugs.gnu.org; 12 Jul 2011 21:45:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgklJ-00051g-Ol for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:45:01 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgklI-00051M-0r for 4291@debbugs.gnu.org; Tue, 12 Jul 2011 17:45:00 -0400 Received: from localhost ([127.0.0.1]:55855) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgklC-00077U-9c; Tue, 12 Jul 2011 17:44:54 -0400 From: Glenn Morris To: Lars Magne Ingebrigtsen Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service References: <1x7hwk3gis.fsf@fencepost.gnu.org> X-Spook: LABLINK Delta Force Leitrim Fortezza Axis of Evil $400 X-Ran: EH~qUE^FBenw[6)q7YSwxuc.'hklj>#BIPG&ex8Oz5x/%W\At#:]$J^Z2Aom||@_0QiJe) X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 12 Jul 2011 17:44:53 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 23:18:43 +0200") Message-ID: <7kzkkj897u.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 4291 Cc: David Bremner , Stefan Monnier , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Lars Magne Ingebrigtsen wrote: > Stefan Monnier writes: > >> IIRC /tmp/docview$uid is predictable because doc-view tries to reuse >> previouly-rendered pages. I'm not convinced this is really a good >> feature, but obviously the author thought it was important, so I'd >> rather not drop it without a discussion. > > It could just stash the directory name in a variable, and use the normal > `make-temp-file' to create the directory, couldn't it? I think the idea referred to above is to potentially re-use pages converted by a previous Emacs instance (which seems like a bad feature to me too). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 17:46:55 2011 Received: (at 4291) by debbugs.gnu.org; 12 Jul 2011 21:46:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgkn5-0005vC-1S for submit@debbugs.gnu.org; Tue, 12 Jul 2011 17:46:55 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qgkmz-0005uq-EG for 4291@debbugs.gnu.org; Tue, 12 Jul 2011 17:46:49 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qgkmn-0006Tx-Ui; Tue, 12 Jul 2011 23:46:34 +0200 From: Lars Magne Ingebrigtsen To: Glenn Morris Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service In-Reply-To: <7kzkkj897u.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 12 Jul 2011 17:44:53 -0400") Date: Tue, 12 Jul 2011 23:46:27 +0200 Message-ID: References: <1x7hwk3gis.fsf@fencepost.gnu.org> <7kzkkj897u.fsf@fencepost.gnu.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUIAwpxY10wKCzTxbgN CA8GAQd30LQGAAACTElEQVQ4jVWTUW7sIAxFaQT/NaT/g8MsgPAWQFz3PxoN+99Kr0mnT7UUTYbD ta8NcdqdexDdhoQxg+7zx6k674m+nnhs4UkfB08AxRhh5E6FgY4aKBpA+HAK1bvkeh9L+hhHM9A9 H8y5Uh+PeH+mfYw3GucJ4DJRqkhz3M+jofSjjAHg3NEQVMr2vrX9snZOsKQKQDGtW/26AGp3dy6N OAGlNZpD7DdP3QVPOTKh0H5zbrZ5TmCSVonw7Nga3BVQnA+y8q1u1Z2QnJNpD8OTSY62VehdePYJ bmG8YXvUz5Yi6xdq+u502s2WR4+WVrXRKaY0wVu1GqqtddeDC/0FlpgpUdRctf8Y+gHFcrXc/nX3 B8xGLEpRy4/SegHnrkbwX7051fIClqhVrAh3NYEBU2OEmndLLipduQjeJZco1CIAYulApWScoCS0 7Vvc9jAMWCZTeE7w71lSdMP3xbzO4iqNj3pToRjC+R+oV8qpvQMwJm4A5FKk2YIBHN9jujWFAWqs EuUv8PMiUBE4Qa7HbyqXGm5PW2Hfzlv6HInZTatpVumCcZ6Xq8jWh+rW2s5OTtyFpWNdImFSXoqB 4pAKAKUZt8ws8IpGVgwNggvgRKc3/twJPsS+FZmCOgF21IKRsr0K1vMPELIzZaxwYQuiajVkqyih /Bv4kKx4P5K14f+umwKWYrQVHDiTJXopGkqjp5dirjOAXmCfWeIFMBLcJACP4U9wlcCr2QVw5XIV J7B6Bra9aLTKL4Z+1KZwAGxzdq+Yd/gCR/mVWCLVb78PtK9uKqCIAAAAAElFTkSuQmCC X-Now-Playing: Peter Gabriel's _Plays Live (2)_: "San Jacinto" X-Hashcash: 1:23:110712:bremner-dated-1252800134.2fccb3@pivot.cs.unb.ca::N2DSRToN/FZgQ6f/:000000000000008GxI X-Hashcash: 1:23:110712:monnier@iro.umontreal.ca::rVj+uKpQrWlPH5sE:0000000000000000000000000000000000000WP9I X-Hashcash: 1:23:110712:4291@debbugs.gnu.org::CSpvu6XZZgQ5LzRP:00000000000000000000000000000000000000000Ql6k X-Hashcash: 1:23:110712:rgm@gnu.org::eljX2xxrBNNkjvYL:000001Y2qe MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qgkmn-0006Tx-Ui X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311111994.04031@Fqwa/Z3+Abll+Ha5VAvNjA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4291 Cc: David Bremner , Stefan Monnier , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Glenn Morris writes: >>> IIRC /tmp/docview$uid is predictable because doc-view tries to reuse >>> previouly-rendered pages. I'm not convinced this is really a good >>> feature, but obviously the author thought it was important, so I'd >>> rather not drop it without a discussion. >> >> It could just stash the directory name in a variable, and use the normal >> `make-temp-file' to create the directory, couldn't it? > > I think the idea referred to above is to potentially re-use pages > converted by a previous Emacs instance (which seems like a bad feature > to me too). Oh, I see. Hm. Sounds like a bad idea to me, too. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 18:16:16 2011 Received: (at 4291) by debbugs.gnu.org; 12 Jul 2011 22:16:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QglFX-0007Qp-Gb for submit@debbugs.gnu.org; Tue, 12 Jul 2011 18:16:15 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QglFW-0007Qf-8w for 4291@debbugs.gnu.org; Tue, 12 Jul 2011 18:16:14 -0400 Received: from furball (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p6CMG7Uq027257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 12 Jul 2011 18:16:07 -0400 From: Chong Yidong To: Lars Magne Ingebrigtsen Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service References: <1x7hwk3gis.fsf@fencepost.gnu.org> <7kzkkj897u.fsf@fencepost.gnu.org> Date: Tue, 12 Jul 2011 18:16:06 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 12 Jul 2011 23:46:27 +0200") Message-ID: <87zkkj9mc9.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 4291 Cc: Glenn Morris , David Bremner , Stefan Monnier , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lars Magne Ingebrigtsen writes: >>>> IIRC /tmp/docview$uid is predictable because doc-view tries to reuse >>>> previouly-rendered pages. I'm not convinced this is really a good >>>> feature, but obviously the author thought it was important, so I'd >>>> rather not drop it without a discussion. >>> >>> It could just stash the directory name in a variable, and use the normal >>> `make-temp-file' to create the directory, couldn't it? >> >> I think the idea referred to above is to potentially re-use pages >> converted by a previous Emacs instance (which seems like a bad feature >> to me too). > > Oh, I see. Hm. Sounds like a bad idea to me, too. :-) I think the idea is that if you view the same pdf N times in Emacs, the disk space won't increase monotonically (Emacs doesn't delete any of those files AFAIK). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 18:18:38 2011 Received: (at 4291) by debbugs.gnu.org; 12 Jul 2011 22:18:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QglHm-0007Tw-Oi for submit@debbugs.gnu.org; Tue, 12 Jul 2011 18:18:38 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QglHh-0007Th-98 for 4291@debbugs.gnu.org; Tue, 12 Jul 2011 18:18:33 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QglHT-0006yB-DU; Wed, 13 Jul 2011 00:18:15 +0200 From: Lars Magne Ingebrigtsen To: Chong Yidong Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service In-Reply-To: <87zkkj9mc9.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 12 Jul 2011 18:16:06 -0400") Date: Wed, 13 Jul 2011 00:18:12 +0200 Message-ID: References: <1x7hwk3gis.fsf@fencepost.gnu.org> <7kzkkj897u.fsf@fencepost.gnu.org> <87zkkj9mc9.fsf@stupidchicken.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUIAwpxY10wKCzTxbgN CA8GAQd30LQGAAACTElEQVQ4jVWTUW7sIAxFaQT/NaT/g8MsgPAWQFz3PxoN+99Kr0mnT7UUTYbD ta8NcdqdexDdhoQxg+7zx6k674m+nnhs4UkfB08AxRhh5E6FgY4aKBpA+HAK1bvkeh9L+hhHM9A9 H8y5Uh+PeH+mfYw3GucJ4DJRqkhz3M+jofSjjAHg3NEQVMr2vrX9snZOsKQKQDGtW/26AGp3dy6N OAGlNZpD7DdP3QVPOTKh0H5zbrZ5TmCSVonw7Nga3BVQnA+y8q1u1Z2QnJNpD8OTSY62VehdePYJ bmG8YXvUz5Yi6xdq+u502s2WR4+WVrXRKaY0wVu1GqqtddeDC/0FlpgpUdRctf8Y+gHFcrXc/nX3 B8xGLEpRy4/SegHnrkbwX7051fIClqhVrAh3NYEBU2OEmndLLipduQjeJZco1CIAYulApWScoCS0 7Vvc9jAMWCZTeE7w71lSdMP3xbzO4iqNj3pToRjC+R+oV8qpvQMwJm4A5FKk2YIBHN9jujWFAWqs EuUv8PMiUBE4Qa7HbyqXGm5PW2Hfzlv6HInZTatpVumCcZ6Xq8jWh+rW2s5OTtyFpWNdImFSXoqB 4pAKAKUZt8ws8IpGVgwNggvgRKc3/twJPsS+FZmCOgF21IKRsr0K1vMPELIzZaxwYQuiajVkqyih /Bv4kKx4P5K14f+umwKWYrQVHDiTJXopGkqjp5dirjOAXmCfWeIFMBLcJACP4U9wlcCr2QVw5XIV J7B6Bra9aLTKL4Z+1KZwAGxzdq+Yd/gCR/mVWCLVb78PtK9uKqCIAAAAAElFTkSuQmCC X-Now-Playing: Peter Gabriel's _Plays Live (2)_: "Biko" X-Hashcash: 1:23:110712:rgm@gnu.org::nxBslZfQkl0LI4P6:0000001eYU X-Hashcash: 1:23:110712:4291@debbugs.gnu.org::c/JxbnhgN1LZQFUr:000000000000000000000000000000000000000003dY3 X-Hashcash: 1:23:110712:cyd@stupidchicken.com::dR906a0dAThIeG6V:0000000000000000000000000000000000000000EnUe X-Hashcash: 1:23:110712:monnier@iro.umontreal.ca::4SuF62WlQmjCp8p+:0000000000000000000000000000000000000gdy0 X-Hashcash: 1:23:110712:bremner-dated-1252800134.2fccb3@pivot.cs.unb.ca::MpOAlJEo9LPZdN0+:00000000000000bJJ0 MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QglHT-0006yB-DU X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311113895.82719@BsmOR8PoDIOVrOO/xAKc6A X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4291 Cc: Glenn Morris , David Bremner , Stefan Monnier , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Chong Yidong writes: > I think the idea is that if you view the same pdf N times in Emacs, the > disk space won't increase monotonically (Emacs doesn't delete any of > those files AFAIK). If they aren't deleted, then using a single directory per UID seems like a good choice. Perhaps the right fix here is to make the error message better? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 15:39:35 2011 Received: (at 4291) by debbugs.gnu.org; 16 Jul 2011 19:39:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAi3-00057S-AM for submit@debbugs.gnu.org; Sat, 16 Jul 2011 15:39:35 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAhx-000579-RH for 4291@debbugs.gnu.org; Sat, 16 Jul 2011 15:39:29 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QiAhh-00042P-Gw; Sat, 16 Jul 2011 21:39:09 +0200 From: Lars Magne Ingebrigtsen To: Chong Yidong Subject: Re: bug#4291: 23.1; doc-view-mode temporary directory vulnerable to denial of service In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 13 Jul 2011 00:18:12 +0200") Date: Sat, 16 Jul 2011 21:38:57 +0200 Message-ID: References: <1x7hwk3gis.fsf@fencepost.gnu.org> <7kzkkj897u.fsf@fencepost.gnu.org> <87zkkj9mc9.fsf@stupidchicken.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Laurie Freelove's _Heaven On Earth_: "Heaven On Earth (Freelove On Earth Part 1)" X-Hashcash: 1:23:110716:rgm@gnu.org::9HiWcOLsodlvZuqx:0000008eiK X-Hashcash: 1:23:110716:bremner-dated-1252800134.2fccb3@pivot.cs.unb.ca::tfTQKOKiISJ7KDj6:00000000000000D3zt X-Hashcash: 1:23:110716:4291@debbugs.gnu.org::HvgbQjcW5OW7b9ku:00000000000000000000000000000000000000000iqGn X-Hashcash: 1:23:110716:cyd@stupidchicken.com::QaSwp3TT0QGcGW3N:0000000000000000000000000000000000000000kphZ X-Hashcash: 1:23:110716:monnier@iro.umontreal.ca::RyM1U/raEcw5U7aT:00000000000000000000000000000000000017Nst MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QiAhh-00042P-Gw X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311449949.65915@CZxVc25wUYvPHIZtMZv/1g X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4291 Cc: Glenn Morris , David Bremner , Stefan Monnier , 4291@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lars Magne Ingebrigtsen writes: >> I think the idea is that if you view the same pdf N times in Emacs, the >> disk space won't increase monotonically (Emacs doesn't delete any of >> those files AFAIK). > > If they aren't deleted, then using a single directory per UID seems like > a good choice. Perhaps the right fix here is to make the error message > better? I've now done this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 15:39:21 2011 Received: (at control) by debbugs.gnu.org; 16 Jul 2011 19:39:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAht-00057A-1l for submit@debbugs.gnu.org; Sat, 16 Jul 2011 15:39:21 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAhq-00056w-Kc for control@debbugs.gnu.org; Sat, 16 Jul 2011 15:39:19 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QiAhe-00042I-ED for control@debbugs.gnu.org; Sat, 16 Jul 2011 21:39:06 +0200 Date: Sat, 16 Jul 2011 21:39:05 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4291 X-MailScanner-ID: 1QiAhe-00042I-ED X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311449946.61846@5EZBzSA0mFG3fIFnLYAXmg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 4291 fixed close 4291 24.1 From unknown Sat Jun 21 03:29:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Aug 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator