GNU bug report logs - #42909
feature/native-comp; comp.el: Pass comp-eln-load-path to child

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42909 in the body.
You can then email your comments to 42909 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Whatson <whatson <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Andrew Whatson <whatson <at> gmail.com>
Subject: feature/native-comp; comp.el: Pass comp-eln-load-path to child
Date: Tue, 18 Aug 2020 12:19:21 +1000

The `comp-eln-load-path' must be passed to the child to ensure that .eln
files are written to the correct location.

Without this, when a custom `comp-eln-load-path' is used, Emacs will
crash with "Native elisp load failed: file does not exist".

---
 lisp/emacs-lisp/comp.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 85b5562f28..3176351b37 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2580,6 +2580,7 @@ comp-run-async-workers
                             (setf comp-speed ,comp-speed
                                   comp-debug ,comp-debug
                                   comp-verbose ,comp-verbose
+                                  comp-eln-load-path ',comp-eln-load-path
                                   load-path ',load-path)
                             ,comp-async-env-modifier-form
                             (message "Compiling %s..." ,source-file)
-- 
2.28.0

Message #8 received at 42909 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Andrew Whatson <whatson <at> gmail.com>
Cc: 42909 <at> debbugs.gnu.org
Subject: Re: bug#42909: feature/native-comp;
 comp.el: Pass comp-eln-load-path to child
Date: Tue, 18 Aug 2020 07:36:48 +0000

Hi Andrew,

oops, thanks for catching that!

Have you already done the copyright paperwork?  This is small enough
that it should be exempt, but is for annotating it correctly.

Thanks

  Andrea

-- 
akrl <at> sdf.org

Message #11 received at 42909 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Whatson <whatson <at> gmail.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 42909 <at> debbugs.gnu.org
Subject: Re: bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path
 to child
Date: Tue, 18 Aug 2020 19:16:15 +1000

[Message part 1 (text/plain, inline)]

Hi Andrea,

Yes, I've already done copyright assignment to the FSF for Emacs.

Cheers


On Tue, 18 Aug 2020, 5:36 pm Andrea Corallo, <akrl <at> sdf.org> wrote:

> Hi Andrew,
>
> oops, thanks for catching that!
>
> Have you already done the copyright paperwork?  This is small enough
> that it should be exempt, but is for annotating it correctly.
>
> Thanks
>
>   Andrea
>
> --
> akrl <at> sdf.org
>

[Message part 2 (text/html, inline)]

Message #16 received at 42909-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Andrew Whatson <whatson <at> gmail.com>
Cc: 42909-done <at> debbugs.gnu.org
Subject: Re: bug#42909: feature/native-comp;
 comp.el: Pass comp-eln-load-path to child
Date: Tue, 18 Aug 2020 09:44:20 +0000

Andrew Whatson <whatson <at> gmail.com> writes:

> Hi Andrea,
>
> Yes, I've already done copyright assignment to the FSF for Emacs.
>
> Cheers

Great, I've added a ChangeLog and committed fc9b68636b at your name.

Closing it.

Thanks!

  Andrea

-- 
akrl <at> sdf.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.