GNU bug report logs - #42906
[feature/native-comp] out-of-tree build process broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42906 in the body.
You can then email your comments to 42906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ovidiu Toader <ovi <at> phas.ubc.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: [feature/native-comp] out-of-tree build process broken
Date: Mon, 17 Aug 2020 08:16:26 -0700

When feature/native-comp branch is built out-of-tree, emacs cannot find the .eln files during start.

The patch below fixes this issue. The problem is caused by the fact that during an out-of-tree build, default-directory points inside the build tree while the .eln files are found in the source tree and because of that the subsequent replace-regexp-in-string fails to adjust the file path of the compilation unit.


modified   lisp/loadup.el
@@ -454,7 +454,7 @@
   ;; when installed or if the source directory got moved.  This is set to be
   ;; a pair in the form: (rel-path-from-install-bin . rel-path-from-local-bin).
   (let ((h (make-hash-table :test #'eq))
-        (lisp-src-dir (expand-file-name (concat default-directory "../lisp")))
+        (lisp-src-dir (expand-file-name "lisp" source-directory))
         (bin-dest-dir (cadr (member "--bin-dest" command-line-args)))
         (lisp-dest-dir (cadr (member "--lisp-dest" command-line-args))))
     (mapatoms (lambda (s)

Message #8 received at 42906 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Ovidiu Toader <ovi <at> phas.ubc.ca>
Cc: 42906 <at> debbugs.gnu.org
Subject: Re: bug#42906: [feature/native-comp] out-of-tree build process broken
Date: Mon, 17 Aug 2020 18:49:53 +0000

Ovidiu Toader <ovi <at> phas.ubc.ca> writes:

> When feature/native-comp branch is built out-of-tree, emacs cannot find the .eln files during start.
>
> The patch below fixes this issue. The problem is caused by the fact
> that during an out-of-tree build, default-directory points inside the
> build tree while the .eln files are found in the source tree and
> because of that the subsequent replace-regexp-in-string fails to
> adjust the file path of the compilation unit.

Hi Ovidiu,

thanks for the feedback and the patch!

I just pushed this evening a branch that reworks also the eln file
placement on the file-system and partially this mechanism.

https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00535.html

It should cure also this problem.

It would be great if you cold try it out and give a feedback if it works
for you.

Thanks!

  Andrea

-- 
akrl <at> sdf.org

Message #13 received at 42906-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: 42906-done <at> debbugs.gnu.org
Cc: Ovidiu Toader <ovi <at> phas.ubc.ca>
Subject: Re: bug#42906: [feature/native-comp] out-of-tree build process broken
Date: Tue, 18 Aug 2020 07:24:12 +0000

Ovidiu Toader <ovi <at> phas.ubc.ca> writes:

> On 2020-08-17 11:49 a.m., Andrea Corallo wrote:
>> It would be great if you cold try it out and give a feedback if it works
>> for you.
>
> I confirm that the new version works well with an out-of-tree build.

Great, closing it.

Thanks!

  Andrea

-- 
akrl <at> sdf.org

Message #16 received at 42906 <at> debbugs.gnu.org (full text, mbox):

From: Ovidiu Toader <ovi <at> phas.ubc.ca>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 42906 <at> debbugs.gnu.org
Subject: Re: bug#42906: [feature/native-comp] out-of-tree build process broken
Date: Mon, 17 Aug 2020 21:22:18 -0700

On 2020-08-17 11:49 a.m., Andrea Corallo wrote:
> It would be great if you cold try it out and give a feedback if it works
> for you.

I confirm that the new version works well with an out-of-tree build.


Thank you for all the great work!

Ovidiu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.