GNU bug report logs - #42874
[PATCH] Mark XEmacs compat alias user-original-login-name obsolete

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Sat, 15 Aug 2020 16:26:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42874 in the body.
You can then email your comments to 42874 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#42874; Package emacs. (Sat, 15 Aug 2020 16:26:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 15 Aug 2020 16:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Mark XEmacs compat alias user-original-login-name obsolete
Date: Fri, 14 Aug 2020 20:10:44 -0700

[Message part 1 (text/plain, inline)]
The XEmacs compatibility alias `user-original-login-name' was declared
obsolete even in XEmacs:

https://bitbucket.org/xemacs/xemacs/src/e2ac728aa576a39ca5a7de608a1914dde5b1b083/lisp/obsolete.el#lines-461

Searching for its name on github gives 1383 code matches, most of which
seem to be copies of Emacs itself.

Are there any objections to marking it obsolete?

Best regards,
Stefan Kangas

[0001-Mark-XEmacs-compat-alias-as-obsolete.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#42874; Package emacs. (Sun, 16 Aug 2020 10:18:02 GMT) Full text and rfc822 format available.

Message #8 received at 42874 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 42874 <at> debbugs.gnu.org
Subject: Re: bug#42874: [PATCH] Mark XEmacs compat alias
 user-original-login-name obsolete
Date: Sun, 16 Aug 2020 12:17:33 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> -(defalias 'user-original-login-name 'user-login-name)
> +(define-obsolete-function-alias 'user-original-login-name
> +  'user-login-name "28.1")

Sounds good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#42874; Package emacs. (Sun, 16 Aug 2020 13:42:02 GMT) Full text and rfc822 format available.

Message #11 received at 42874 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 42874 <at> debbugs.gnu.org
Subject: Re: bug#42874: [PATCH] Mark XEmacs compat alias
 user-original-login-name obsolete
Date: Sun, 16 Aug 2020 06:41:37 -0700

close 42874 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Sounds good to me.

Thanks.  So I pushed it to master as commit b06ef8d5e9.

If anyone disagrees, feel free to revert.

Best regards,
Stefan Kangas
bug marked as fixed in version 28.1, send any further explanations to 42874 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 16 Aug 2020 13:42:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 14 Sep 2020 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 277 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.