GNU bug report logs - #42868
[PATCH] maint: Only run `make authenticate` when pushing commits.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Fri, 14 Aug 2020 20:32:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] maint: Only run `make authenticate` when pushing commits.
Date: Thu, 20 Aug 2020 00:29:27 +0200

[Message part 1 (text/plain, inline)]
On Fri, Aug 14, 2020 at 04:30:47PM -0400, Leo Famulari wrote:
> +z40=0000000000000000000000000000000000000000
> +
> +# If deleting a branch, there are no commits to check.
> +if [ "$local_sha" = $z40 ]
> +then
> +	true
> +else

Is there a reason this `if' is written like that? I would use != and get
rid of the do-nothing branch entirely.

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 4 years and 155 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.