From unknown Sun Jun 15 09:03:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42868 <42868@debbugs.gnu.org> To: bug#42868 <42868@debbugs.gnu.org> Subject: Status: [PATCH] maint: Only run `make authenticate` when pushing commits. Reply-To: bug#42868 <42868@debbugs.gnu.org> Date: Sun, 15 Jun 2025 16:03:25 +0000 retitle 42868 [PATCH] maint: Only run `make authenticate` when pushing comm= its. reassign 42868 guix-patches submitter 42868 Leo Famulari severity 42868 normal tag 42868 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 16:31:03 2020 Received: (at submit) by debbugs.gnu.org; 14 Aug 2020 20:31:03 +0000 Received: from localhost ([127.0.0.1]:53966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6gLv-0002MP-94 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 16:31:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:34400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6gLs-0002Lx-92 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 16:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6gLs-0005QV-0X for guix-patches@gnu.org; Fri, 14 Aug 2020 16:31:00 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:40685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6gLq-0003a9-AS for guix-patches@gnu.org; Fri, 14 Aug 2020 16:30:59 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 68D875D2; Fri, 14 Aug 2020 16:30:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 14 Aug 2020 16:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=1sCdLnYEkC0bykw7mZ1SYin 6+ZZ3w12SlwWwHapYuQ8=; b=hDR5gEXlh+ysrkWKyjG8CysSSMWEcPN9xUM84AI OP6WbCtnJyhizTbAHXqVta1Ae26I6/uYJRdfF9vaSlyOMDgKdd29G8BnCh2iynM0 igNjnYUQc0Uj3ChpzgLDWcEqSaqfn588D/lxilbXxAboGt0DYhIWI+9aYuirv+CM ZRBU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=1sCdLnYEkC0bykw7m Z1SYin6+ZZ3w12SlwWwHapYuQ8=; b=hbsU+RO8yoWAvDAyrqjvfIUHtqvefULbY kFFObRgMcBz0bNtiyJxmEDaf+SDb30IHmLfPfhT0CJZ335xuBWreSL3GN+EB900E boOBzKfx58gwjQAsJpzVI6awKRhBgB55ZCqwvxGtkJrdNoD1NcwYW6jXhulG63zV n5ne2c0tSNBzoajteQpYOefCv+CXXzBFmbyMXF0tNkjsHD4dapKZyDQrwps4ozGS kuhthBuCPUZs925wrdYcwgRjzqT8KSdvB8hVDH47Gk1nWpx3LXowCiQbPaE7GfXY ZwJa21uvwpa+jJrVC2KSp0L4TF/IYOK3OTOI4+ali3XFmkID8PFJg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrleejgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepvdeiteehgffhtdduffffteehiedvueejge fhkefgkeduudejteeuvefgkedutdehnecuffhomhgrihhnpehgnhhurdhorhhgnecukfhp pedujedvrdehkedrvddvjedrkeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from jasmine.lan (unknown [172.58.227.86]) by mail.messagingengine.com (Postfix) with ESMTPA id ABAA93280059 for ; Fri, 14 Aug 2020 16:30:54 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] maint: Only run `make authenticate` when pushing commits. Date: Fri, 14 Aug 2020 16:30:47 -0400 Message-Id: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@famulari.name; helo=wout4-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/14 16:30:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When deleting a remote branch, no commits are pushed to the remote, and thus there are no signatures to be verified. * etc/git/pre-push: Exit early when deleting a branch. --- etc/git/pre-push | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 415345fc75..689673dcc9 100755 --- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -20,13 +20,21 @@ # # -# Only use the hook when pushing to Savannah. -case "$2" in - *.gnu.org*) - exec make authenticate check-channel-news - exit 127 - ;; - *) - exit 0 - ;; -esac +z40=0000000000000000000000000000000000000000 + +# If deleting a branch, there are no commits to check. +if [ "$local_sha" = $z40 ] +then + true +else + # Only use the hook when pushing to Savannah. + case "$2" in + *.gnu.org*) + exec make authenticate check-channel-news + exit 127 + ;; + *) + exit 0 + ;; + esac +fi -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 18:29:36 2020 Received: (at submit) by debbugs.gnu.org; 19 Aug 2020 22:29:36 +0000 Received: from localhost ([127.0.0.1]:41200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8WaN-0000wF-Ro for submit@debbugs.gnu.org; Wed, 19 Aug 2020 18:29:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:51698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8WaM-0000w7-2n for submit@debbugs.gnu.org; Wed, 19 Aug 2020 18:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8WaL-00068F-Sa for guix-patches@gnu.org; Wed, 19 Aug 2020 18:29:33 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:41060) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8WaJ-00075u-PI for guix-patches@gnu.org; Wed, 19 Aug 2020 18:29:33 -0400 Received: (qmail 25192 invoked by uid 1009); 20 Aug 2020 00:29:29 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25904. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.053104 secs); 19 Aug 2020 22:29:29 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 20 Aug 2020 00:29:29 +0200 Date: Thu, 20 Aug 2020 00:29:27 +0200 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Leo Famulari Subject: Re: [PATCH] maint: Only run `make authenticate` when pushing commits. Message-ID: <20200819222927.l5hcfqrjvenpufhy@gravity> References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tgw6jhfbpuz27joj" Content-Disposition: inline In-Reply-To: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> Received-SPF: none client-ip=37.59.186.212; envelope-from=kuba@kadziolka.net; helo=pat.zlotemysli.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/19 17:38:45 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --tgw6jhfbpuz27joj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 14, 2020 at 04:30:47PM -0400, Leo Famulari wrote: > +z40=3D0000000000000000000000000000000000000000 > + > +# If deleting a branch, there are no commits to check. > +if [ "$local_sha" =3D $z40 ] > +then > + true > +else Is there a reason this `if' is written like that? I would use !=3D and get rid of the do-nothing branch entirely. Regards, Jakub K=C4=85dzio=C5=82ka --tgw6jhfbpuz27joj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl89p8cACgkQ4xWnWEYT FWTAhhAAsEnqBYe0l51UZmujyo1JyAKwVkBA+t6Soh/FOeFnm138vGADoEKKPKmY r9jyiIcIcFSK9Bb/sFc3JpMEqgshURnpgXVMybCWavoH1CmoDttNtAniEmoP0SDS fK9xMiDC0RTgqpNHMNRx+H+jWBMT75dbtu+Bb1drOcIwySbOAwbQeZ0LH1rm2/pA 7hbxMGaNYvbwMuh9EjeqmmqyiMYUQuccY9b0TJ0bfdNUzHynvrFm/cG8+Bpfiy64 qQtoMb7cY8/pzRrwQoiZoqK9WKShs2BXHb8E78STVHrQvUOSmAMrjHnIxtsODINo eYVC34BTItbNpTGECq9HTv0P3GLzAky5uDa8fiUuqAi8yH8R+uEZoA+2i8rTjVuP DUZaf7DHXdrNUIJVarx3aOp4Um120uFlvV1gLSECVEmXTNrqafiXFASMJNN6H/kh PfgogJylZggBOBGQ+dmpKIoaFXsyaHExOiqnd38uS+3vEXzM0Vjn1kCOXH5bKSYl tyr8zOvCEyoBfb7HMYplxY4Nlt6iqWwNLkJj6QtzR5/bw7XTDHvU/Nmjo1XjyZKC nYIMv82KPnHUyYU2qBnj21JSMakgv7MzvNRH7gRz4zaFM1cHQurrFFSNu6tL/hRY NdybCnCaew+Vj42v4gxYWVFBwHUCJ155k9/OKSMFps4LMFeGGpw= =SGHl -----END PGP SIGNATURE----- --tgw6jhfbpuz27joj-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 15:48:08 2020 Received: (at 42868) by debbugs.gnu.org; 30 Aug 2020 19:48:08 +0000 Received: from localhost ([127.0.0.1]:50791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTJA-0005Zp-18 for submit@debbugs.gnu.org; Sun, 30 Aug 2020 15:48:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTJ9-0005Ze-Bm for 42868@debbugs.gnu.org; Sun, 30 Aug 2020 15:48:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44132) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCTJ4-0006xw-13; Sun, 30 Aug 2020 15:48:02 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43500 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCTJ3-00064d-Cy; Sun, 30 Aug 2020 15:48:01 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Leo Famulari Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits. References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> Date: Sun, 30 Aug 2020 21:47:59 +0200 In-Reply-To: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> (Leo Famulari's message of "Fri, 14 Aug 2020 16:30:47 -0400") Message-ID: <873643j4pc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42868 Cc: 42868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Leo Famulari skribis: > When deleting a remote branch, no commits are pushed to the remote, and > thus there are no signatures to be verified. > > * etc/git/pre-push: Exit early when deleting a branch. I agree with Jakub regarding the =E2=80=98if=E2=80=99 :-), but other than t= hat it LGTM. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 15:35:33 2020 Received: (at 42868) by debbugs.gnu.org; 13 Dec 2020 20:35:33 +0000 Received: from localhost ([127.0.0.1]:50447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koY5c-0004Em-Tc for submit@debbugs.gnu.org; Sun, 13 Dec 2020 15:35:33 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koY5b-0004EH-Qd for 42868@debbugs.gnu.org; Sun, 13 Dec 2020 15:35:32 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B422F5C00E9; Sun, 13 Dec 2020 15:35:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 13 Dec 2020 15:35:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=5g4bBNIi1k6SCz0Nq8XVLYSe XmTjEej/TSIAwSNpPro=; b=r+i0fxL3FIx/TLssofvTh8qQVKad9B4HUksk5j1E OuzBYVlZ/k7+eVhUoQl8lJNYF7l7bJzG8OPK/gJMzz32PGqBkw4xlohsi1i/9gYn vyWGLMZdIee7F/+qb8ev8yd4f34gJML80Mq9lKskt1u7qhl70HiTxXwZJiqGC/LE /aw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5g4bBN Ii1k6SCz0Nq8XVLYSeXmTjEej/TSIAwSNpPro=; b=FSguhs0wLTVLuc20Qlv20j jWRyRerdAJ8syE2bTgoY2rZP137dyoLXRdlT+tqPU1uy7AaYZIdUfqMAaWHV0yv5 Jt4F6X68lxk6jgQkoRIe+HIhOXKxXku24D0l2or+F8QDuSOxi0t6l58bEalY5S+v RAgcFvURKy5XyUn6ryJcGqloYXVvlsten1XvELtWDfpJ9f+ck7XEjczsy0DLc0Y+ E667m/9x9RGhlqgBSn6wAfrPax/fw+1DI65ZJqQW4EMBK73vA/WDqt7O3vv4xGpt vM9RHT5hlrQ4BHuIB7YoSgpxZFSBtzlkJxD3d+B9XXA9NQU+TNDDsVG6XdtmK+YQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekiedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepiefghfeffedtffekveektddtieekfeffledtgfevkeekteeufedtfefhgefh keefnecukfhppeejfedrudeguddruddvjedrudegieenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 328A924005C; Sun, 13 Dec 2020 15:35:26 -0500 (EST) Date: Sun, 13 Dec 2020 15:35:24 -0500 From: Leo Famulari To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits. Message-ID: References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> <873643j4pc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NEwhEoJ5M9AxA3VA" Content-Disposition: inline In-Reply-To: <873643j4pc.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42868 Cc: 42868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --NEwhEoJ5M9AxA3VA Content-Type: multipart/mixed; boundary="6Qd2uZAI4StQ5LC4" Content-Disposition: inline --6Qd2uZAI4StQ5LC4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 30, 2020 at 09:47:59PM +0200, Ludovic Court=C3=A8s wrote: > Hi, >=20 > Leo Famulari skribis: >=20 > > When deleting a remote branch, no commits are pushed to the remote, and > > thus there are no signatures to be verified. > > > > * etc/git/pre-push: Exit early when deleting a branch. >=20 > I agree with Jakub regarding the =E2=80=98if=E2=80=99 :-), but other than= that it LGTM. The previous version of this patch was untested and broken! Here is a new one that is actually tested and working. --6Qd2uZAI4StQ5LC4 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-maint-Only-run-make-authenticate-when-pushing-commit.patch" Content-Transfer-Encoding: quoted-printable =46rom e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Fri, 14 Aug 2020 16:30:47 -0400 Subject: [PATCH] maint: Only run `make authenticate` when pushing commits. * etc/git/pre-push: Exit early when deleting a branch. --- etc/git/pre-push | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 415345fc75..59671b0d58 100755 --- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -20,13 +20,26 @@ # # =20 -# Only use the hook when pushing to Savannah. -case "$2" in - *.gnu.org*) - exec make authenticate check-channel-news - exit 127 - ;; - *) - exit 0 - ;; -esac +# This is the "empty hash" used by Git when pushing a branch deletion. +z40=3D0000000000000000000000000000000000000000 + +while read local_ref local_hash remote_ref remote_hash +do + # When deleting a remote branch, no commits are pushed to the remote, and + # thus there are no signatures to be verified. + if [ "$local_hash" !=3D $z40 ] + then + # Only use the hook when pushing to Savannah. + case "$2" in + *.gnu.org*) + exec make authenticate check-channel-news + exit 127 + ;; + *) + exit 0 + ;; + esac + fi +done + +exit 0 --=20 2.29.2 --6Qd2uZAI4StQ5LC4-- --NEwhEoJ5M9AxA3VA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl/WewwACgkQJkb6MLrK fwgBfQ//Qri2GagSN+5KFYHZa4mRf8yMhAw81+t6/0HMBaOcWNPpmzpGuxNykN11 LJFiOaRL2AgXS72D8/VGoWmpqIlzHsoF4Rx2v+JqVSJ83tWfyPNpM6+lB48+gBB7 TLcYCASlqzAH0VBm49uA51GenC3KPray66v4tAhJl/YMcCP+Dde43lqFnAUv8Y8q +xn83krNMOBjYuVRIL34A1xbSSW7x2eTcvgnlIQ/bGovb6vbbfphVwUzGNOzNYw1 4+tVRXhIWs1ncRj4NliuuTpoSzk7PVaGfhu7wpq2SOQMb/5pyI3dV4RamlHafSK1 tuUt4JhI2uA/SJ1fnlRw+xjxEK2Cp/3RdfKwros4EMfVaHSLIYJE9pN25/E8eeO2 v/lGC+K3PxxLxl+7lwNXvbGEsFqZy1hfjOs951Es9yNuGk6kQ02rKK7XtCWvYA2c AFv+VHECZw+X7nnk9SRQ+p4pVaRgDd83/f8nbUvf9CvoDQmkbsTwhOyNeCbRVVQo byECaxduVgI7Sr0eNRIRHvmhGWlLD4N3hLSYLom+Z0+57hRmXKnkYjN5Eb/9LGpN KazQE0HbvQkwURqdeMEIMXlxaMKUX1DtKiuwHak3Iy8yD3mzEUtMyrsP7tgSuPAb tSlSRe8cyVsBiUzVzEYcxnbU6mYq6KTowgNFGxvfxcnmSQD0GJw= =+FVi -----END PGP SIGNATURE----- --NEwhEoJ5M9AxA3VA-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 03:28:10 2020 Received: (at 42868) by debbugs.gnu.org; 14 Dec 2020 08:28:11 +0000 Received: from localhost ([127.0.0.1]:50984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kojDG-0002Hb-MK for submit@debbugs.gnu.org; Mon, 14 Dec 2020 03:28:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kojDF-0002HN-1j for 42868@debbugs.gnu.org; Mon, 14 Dec 2020 03:28:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48512) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kojD9-0002pk-Pt; Mon, 14 Dec 2020 03:28:03 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38078 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kojD9-00033w-05; Mon, 14 Dec 2020 03:28:03 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Leo Famulari Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits. References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> <873643j4pc.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 14 Dec 2020 09:28:01 +0100 In-Reply-To: (Leo Famulari's message of "Sun, 13 Dec 2020 15:35:24 -0500") Message-ID: <87a6ugyepa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42868 Cc: 42868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Leo Famulari skribis: > From e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Fri, 14 Aug 2020 16:30:47 -0400 > Subject: [PATCH] maint: Only run `make authenticate` when pushing commits. > > * etc/git/pre-push: Exit early when deleting a branch. LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 12:17:22 2020 Received: (at 42868-done) by debbugs.gnu.org; 14 Dec 2020 17:17:23 +0000 Received: from localhost ([127.0.0.1]:54139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1korTO-0001gP-Lp for submit@debbugs.gnu.org; Mon, 14 Dec 2020 12:17:22 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:56411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1korTN-0001bM-Rz for 42868-done@debbugs.gnu.org; Mon, 14 Dec 2020 12:17:22 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 34336A93; Mon, 14 Dec 2020 12:17:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 14 Dec 2020 12:17:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=NP7/NEOuwAKmOFp9k50Qk6QwU0napjvFPn2+hT1AwqM=; b=TvLJuCt86YCA T/GQEnDyY1p480+bZtzhn1wJ0jsKeVkjsrt02lbwKNKnH5e+Je8SHfofzUkJ73cl pZErY+pgqiWtyxCa1cysRYWvnIgDCDmZf4SuENf3CMc/MkVE2EzMINrCxxyskyMa vytsuJCgtsXad+NVCXzHxOrdVisfPMM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NP7/NEOuwAKmOFp9k50Qk6QwU0napjvFPn2+hT1Aw qM=; b=YcYW+QdoNDokzZW7bN+H4FfO56cBteuN42j1MgK8E3j5ExsgYFK0pvt0F ES0S6lzl2T6c9HQ80ztfY9ivrxlfT7Ho3rzcR/zutPrA9GESQg2hCvhHfGk4B2Y5 OnaJ50/pXckn80TSuqEr9C9UxpE/d5yNDRFruj5rs0WpBKRcmLmYJPh3KeLl3/xl DhGEOFeEBzGqOKJ9khhvKrzp/PMF9PXujh4NExgx8VBcHxKs1JvIxv7Wl9tVIkgj KoVzNzRu7D7y0ffGFjLeeSHKw/F2tMopdYyOTUZc44eTCMpo6PM66CMXJkF24vc7 ALyem5fsoiVd1KqyBwP4JU29WlW0w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeuueegudfgvdfgveeuvdeludelfeejhfeggfejtefggeekudekhfdvfeel jeehgfenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm vg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 37C89108005B; Mon, 14 Dec 2020 12:17:15 -0500 (EST) Date: Mon, 14 Dec 2020 12:17:13 -0500 From: Leo Famulari To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits. Message-ID: References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> <873643j4pc.fsf@gnu.org> <87a6ugyepa.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a6ugyepa.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42868-done Cc: 42868-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Dec 14, 2020 at 09:28:01AM +0100, Ludovic Courtès wrote: > Hi, > > Leo Famulari skribis: > > > From e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001 > > From: Leo Famulari > > Date: Fri, 14 Aug 2020 16:30:47 -0400 > > Subject: [PATCH] maint: Only run `make authenticate` when pushing commits. > > > > * etc/git/pre-push: Exit early when deleting a branch. > > LGTM, thanks! Thanks! Pushed as 80ebcdd100a82fdc582e62f35042c74ce38ea753 From unknown Sun Jun 15 09:03:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 Jan 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator