Subject: bug#42868: closed (Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 14 Dec 2020 17:18:02 +0000

Your bug report

#42868: [PATCH] maint: Only run `make authenticate` when pushing commits.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
42868: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42868
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits.
From: Leo Famulari <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Mon, 14 Dec 2020 12:17:13 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

On Mon, Dec 14, 2020 at 09:28:01AM +0100, Ludovic Courtès wrote:
> Hi,
> 
> Leo Famulari <[email-masked]> skribis:
> 
> > From e8546a590a560825c3231af14724329c3d2bfee7 Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <[email-masked]>
> > Date: Fri, 14 Aug 2020 16:30:47 -0400
> > Subject: [PATCH] maint: Only run `make authenticate` when pushing commits.
> >
> > * etc/git/pre-push: Exit early when deleting a branch.
> 
> LGTM, thanks!

Thanks! Pushed as 80ebcdd100a82fdc582e62f35042c74ce38ea753

Subject: [PATCH] maint: Only run `make authenticate` when pushing commits.
From: Leo Famulari <[email-masked]>
To: [email-masked]
Date: Fri, 14 Aug 2020 16:30:47 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

When deleting a remote branch, no commits are pushed to the remote, and
thus there are no signatures to be verified.

* etc/git/pre-push: Exit early when deleting a branch.
---
 etc/git/pre-push | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/etc/git/pre-push b/etc/git/pre-push
index 415345fc75..689673dcc9 100755
--- a/etc/git/pre-push
+++ b/etc/git/pre-push
@@ -20,13 +20,21 @@
 #
 #   <local ref> <local sha1> <remote ref> <remote sha1>
 
-# Only use the hook when pushing to Savannah.
-case "$2" in
-    *.gnu.org*)
-	exec make authenticate check-channel-news
-	exit 127
-	;;
-    *)
-	exit 0
-	;;
-esac
+z40=0000000000000000000000000000000000000000
+
+# If deleting a branch, there are no commits to check.
+if [ "$local_sha" = $z40 ]
+then
+	true
+else
+	# Only use the hook when pushing to Savannah.
+	case "$2" in
+	    *.gnu.org*)
+		exec make authenticate check-channel-news
+		exit 127
+		;;
+	    *)
+		exit 0
+		;;
+	esac
+fi
-- 
2.28.0