GNU bug report logs - #4286
[PATCH] Emacs CVS: lisp/ido.el -- improve ido-ignore-files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4286 in the body.
You can then email your comments to 4286 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: Emacs bug BTS <submit <at> debbugs.gnu.org>
Subject: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Sat, 29 Aug 2009 11:56:19 +0300

[Message part 1 (text/plain, inline)]

Change against Emacs CVS tree as of 2009-08-29 11:5 UTC

2009-08-29  Jari Aalto  <jari.aalto <at> cante.net>

        * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
        version control directories.

[0001-lisp-ido.el-ido-ignore-files-add-more-version-contro.patch (text/x-diff, inline)]

From 510e3bbded329dd9ce03f3eb94e8ffc2d6d5b9be Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sat, 29 Aug 2009 11:51:32 +0300
Subject: [PATCH] lisp/ido.el: (ido-ignore-files): add more version control directories


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/ido.el |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/lisp/ido.el b/lisp/ido.el
index 2336fea..6316bdf 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -391,7 +391,21 @@ example functions that filter buffer names."
   :group 'ido)
 
 (defcustom ido-ignore-files
-  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
+  '(;; Version control system directories (VCS)
+    "\\`CVS/"
+    "\\`RCS/"
+    "\\`\\.svn/"
+    ;;  Distributed version control system directories (DVCS)
+    "\\`\\.darcs/"
+    "\\`\\.hg/"
+    "\\`\\.git/"
+    "\\`\\.mtn/"
+    ;; Backup files
+    "\\`#"
+    "\\`.#"
+    ;; Directory components
+    "\\`\\.\\./"
+    "\\`\\./")
   "List of regexps or functions matching file names to ignore.
 For example, traditional behavior is not to list files whose names begin
 with a #, for which the regexp is `\\`#'.  See the source file for
-- 
1.6.3.3

Message #14 received at 4286 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Mon, 31 Aug 2009 22:42:50 +0300

>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>         version control directories.

Better to initialize its default value from either
`vc-directory-exclusion-list' or `completion-ignored-extensions'.
The former is a subset of the latter.

> diff --git a/lisp/ido.el b/lisp/ido.el
> index 2336fea..6316bdf 100644
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -391,7 +391,21 @@ example functions that filter buffer names."
>    :group 'ido)
>
>  (defcustom ido-ignore-files
> -  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
> +  '(;; Version control system directories (VCS)
> +    "\\`CVS/"
> +    "\\`RCS/"
> +    "\\`\\.svn/"
> +    ;;  Distributed version control system directories (DVCS)
> +    "\\`\\.darcs/"
> +    "\\`\\.hg/"
> +    "\\`\\.git/"
> +    "\\`\\.mtn/"
> +    ;; Backup files
> +    "\\`#"
> +    "\\`.#"
> +    ;; Directory components
> +    "\\`\\.\\./"
> +    "\\`\\./")
>    "List of regexps or functions matching file names to ignore.
>  For example, traditional behavior is not to list files whose names begin
>  with a #, for which the regexp is `\\`#'.  See the source file for

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #19 received at 4286 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Sat, 05 Dec 2009 15:28:13 -0500

> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>
> 2009-08-29  Jari Aalto  <jari.aalto <at> cante.net>
>
>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>         version control directories.

This change makes sense only if we never want to change these
directories.  In practice, if you are trying to complete a dotfile, you
are already planning to do something funky, so Emacs probably shouldn't
try to do any second-guessing.

Message #26 received at 4286 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Sun, 06 Dec 2009 12:47:44 +0200

Chong Yidong <cyd <at> stupidchicken.com> writes:

>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>
>> 2009-08-29  Jari Aalto  <jari.aalto <at> cante.net>
>>
>>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>         version control directories.
>
> This change makes sense only if we never want to change these
> directories.  In practice, if you are trying to complete a dotfile, you
> are already planning to do something funky, so Emacs probably shouldn't
> try to do any second-guessing.

Dot-file is not the same as version controlled control directory.

Jari

Message #31 received at 4286 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Sun, 06 Dec 2009 10:26:05 -0500

Jari Aalto <jari.aalto <at> cante.net> writes:

> Chong Yidong <cyd <at> stupidchicken.com> writes:
>
>>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>>
>>> 2009-08-29  Jari Aalto  <jari.aalto <at> cante.net>
>>>
>>>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>>         version control directories.
>>
>> This change makes sense only if we never want to change these
>> directories.  In practice, if you are trying to complete a dotfile, you
>> are already planning to do something funky, so Emacs probably shouldn't
>> try to do any second-guessing.
>
> Dot-file is not the same as version controlled control directory.

By version control directories, you mean .svn, .bzr, etc., right?  If I
understand your proposal correctly, it's to prevent ido from offering
these directories if the user tries types "." in the minibuffer.  But in
that case, as I said, the intention is clearly to edit a dotfile, so
something funky is already intended.  Correct me if I misunderstand.

Message #36 received at 4286 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Sun, 06 Dec 2009 21:28:53 +0200

Chong Yidong <cyd <at> stupidchicken.com> writes:

>>>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>>>
>>>> 2009-08-29 Jari Aalto <jari.aalto <at> cante.net>
>>>>
>>>> * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>>> version control directories.
>>>
>>> This change makes sense only if we never want to change these
>>> directories. In practice, if you are trying to complete a dotfile, you
>>> are already planning to do something funky, so Emacs probably shouldn't
>>> try to do any second-guessing.
>> Dot-file is not the same as version controlled control directory.
>
> By version control directories, you mean .svn, .bzr, etc., right? If I
> understand your proposal correctly, it's to prevent ido from offering
> these directories if the user tries types "." in the minibuffer. But
> in that case, as I said, the intention is clearly to edit a dotfile,
> so something funky is already intended. Correct me if I misunderstand.

Correct.

It's very rare for user to try to edit content of Version Control
directories. These are nor considered "dot-files" in a sense, that they
would be user editable by default. The content of Version Control
directories is managed by external programs.

Examples (Emacs CVS and directory lisp/) where Version Control
directories are ignored:

    loaddefs.el
    bindings.el
    find-cmd.el
    vc-hooks.el

Jari

Message #39 received at 4286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 4286 <at> debbugs.gnu.org
Subject: Re: bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Wed, 11 Apr 2012 15:35:07 +0200

Jari Aalto <jari.aalto <at> cante.net> writes:

>  (defcustom ido-ignore-files
> -  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
> +  '(;; Version control system directories (VCS)
> +    "\\`CVS/"
> +    "\\`RCS/"
> +    "\\`\\.svn/"
> +    ;;  Distributed version control system directories (DVCS)
> +    "\\`\\.darcs/"
> +    "\\`\\.hg/"

(etc.)

I think this makes perfect sense.  It already ignores "CVS" and ".#", so
why not .svn and friends, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #42 received at 4286 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 4286 <at> debbugs.gnu.org, Jari Aalto <jari.aalto <at> cante.net>
Subject: Re: bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Wed, 11 Apr 2012 21:43:37 +0800

On 2012-04-11 21:35 +0800, Lars Magne Ingebrigtsen wrote:
> I think this makes perfect sense.  It already ignores "CVS" and ".#", so
> why not .svn and friends, too?

,----[ C-h v ido-ignore-extensions RET ]
| ido-ignore-extensions is a variable defined in `ido.el'.
| Its value is t
| 
| Documentation:
| Non-nil means ignore files in `completion-ignored-extensions' list.
| 
| You can customize this variable.
| 
| [back]
`----

Leo

Message #45 received at 4286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 4286 <at> debbugs.gnu.org, Jari Aalto <jari.aalto <at> cante.net>
Subject: Re: bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files
Date: Wed, 11 Apr 2012 15:45:24 +0200

Leo <sdl.web <at> gmail.com> writes:

> On 2012-04-11 21:35 +0800, Lars Magne Ingebrigtsen wrote:
>> I think this makes perfect sense.  It already ignores "CVS" and ".#", so
>> why not .svn and friends, too?
>
> ,----[ C-h v ido-ignore-extensions RET ]
> | ido-ignore-extensions is a variable defined in `ido.el'.
> | Its value is t
> | 
> | Documentation:
> | Non-nil means ignore files in `completion-ignored-extensions' list.

That explains why it already ignored .bzr.  :-)

I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.