From unknown Mon Jun 23 07:53:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42806: [PATCH 0/1] Parse whole buffer of compilation output at once Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 42806@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159709488530195 (code B ref -1); Mon, 10 Aug 2020 21:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2020 21:28:05 +0000 Received: from localhost ([127.0.0.1]:37701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5FKu-0007qw-TU for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:28:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:42814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5FKs-0007qo-Rq for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5FKs-0002DM-ME for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:28:02 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5FKq-0007mw-Va for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:28:02 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id B673516B2A; Mon, 10 Aug 2020 23:27:56 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ene8BsPPB7xI; Mon, 10 Aug 2020 23:27:56 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8620F15FD0; Mon, 10 Aug 2020 23:27:56 +0200 (CEST) From: Jonas Bernoulli Date: Mon, 10 Aug 2020 23:27:56 +0200 Message-Id: <20200810212756.25696-1-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/10 17:27:57 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Remove the comment that mentioned that it is an option to do it in one go as we now actually start doing. As the existence of that comment suggested, there is not really a reason to process the buffer in small chunks. On the contrary, processing the output in arbitrary units can result in certain constructs not being recognized because they begin in one arbitrary chunk, while ending in another. `rustc' was one compiler that was often affected by this. I am sure there are others. Cheers, Jonas Jonas Bernoulli (1): Parse whole buffer of compilation output at once lisp/progmodes/compile.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.28.0 From unknown Mon Jun 23 07:53:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42806: [PATCH 1/1] Parse whole buffer of compilation output at once Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 42806@debbugs.gnu.org Received: via spool by 42806-submit@debbugs.gnu.org id=B42806.159709506330589 (code B ref 42806); Mon, 10 Aug 2020 21:32:01 +0000 Received: (at 42806) by debbugs.gnu.org; 10 Aug 2020 21:31:03 +0000 Received: from localhost ([127.0.0.1]:37716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5FNm-0007xJ-IY for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:31:02 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5FNk-0007ws-Op for 42806@debbugs.gnu.org; Mon, 10 Aug 2020 17:31:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 72B4E16B2B; Mon, 10 Aug 2020 23:30:59 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id P60H_TfwXEbT; Mon, 10 Aug 2020 23:30:59 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 495CE15FD0; Mon, 10 Aug 2020 23:30:59 +0200 (CEST) From: Jonas Bernoulli Date: Mon, 10 Aug 2020 23:30:59 +0200 Message-Id: <20200810213059.26441-1-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810212756.25696-1-jonas@bernoul.li> References: <20200810212756.25696-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * lisp/progmodes/compile.el (compilation-next-single-property-change): Parse whole buffer at once. Remove the comment that mentioned that it is an option to do it in one go as we now actually start doing. As the existence of that comment suggested, there is not really a reason to process the buffer in small chunks. On the contrary, processing the output in arbitrary units can result in certain constructs not being recognized because they begin in one arbitrary chunk, while ending in another. --- lisp/progmodes/compile.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 0b9f417845..5b171fe966 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2417,12 +2417,9 @@ compilation-next-single-property-change &optional object limit) (let (parsed res) (while (progn - ;; We parse the buffer here "on-demand" by chunks of 500 chars. - ;; But we could also just parse the whole buffer. (compilation--ensure-parse (setq parsed (max compilation--parsed - (min (+ position 500) - (or limit (point-max)))))) + (or limit (point-max))))) (and (or (not (setq res (next-single-property-change position prop object limit))) (eq res limit)) -- 2.28.0 From unknown Mon Jun 23 07:53:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42806: [PATCH 1/1] Parse whole buffer of compilation output at once Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 14:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jonas Bernoulli Cc: 42806@debbugs.gnu.org Received: via spool by 42806-submit@debbugs.gnu.org id=B42806.15974147632681 (code B ref 42806); Fri, 14 Aug 2020 14:20:01 +0000 Received: (at 42806) by debbugs.gnu.org; 14 Aug 2020 14:19:23 +0000 Received: from localhost ([127.0.0.1]:53385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6aYE-0000hA-NC for submit@debbugs.gnu.org; Fri, 14 Aug 2020 10:19:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6aYA-0000gs-Ma for 42806@debbugs.gnu.org; Fri, 14 Aug 2020 10:19:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Shqueaq3II87gfmXhDuLWBLMEAoncGfEKUq5O1CayZQ=; b=Cby4aaWiuPTXXzcFYeHt8qF1Xt 6dkKddpgMALR6nB1xSlnk2DC/+Tqz+U73WZbC/CBGeB+jc+iYnMtMD7wgFOrWWuGO7PjlfSu0Mpyh avYY1EP7ld/zSjV6Heb+0t8tb32l4ZoJoUu5fWCvv16p//HjIupMtmWXLmGMwz6f4QBY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6aY1-0002tO-Aj; Fri, 14 Aug 2020 16:19:12 +0200 From: Lars Ingebrigtsen References: <20200810212756.25696-1-jonas@bernoul.li> <20200810213059.26441-1-jonas@bernoul.li> Date: Fri, 14 Aug 2020 16:19:08 +0200 In-Reply-To: <20200810213059.26441-1-jonas@bernoul.li> (Jonas Bernoulli's message of "Mon, 10 Aug 2020 23:30:59 +0200") Message-ID: <874kp571k3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jonas Bernoulli writes: > * lisp/progmodes/compile.el (compilation-next-single-property-change): > Parse whole buffer at once. > > Remove the comment that mentioned that it is an option to do it in one > go as we now actuall [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jonas Bernoulli writes: > * lisp/progmodes/compile.el (compilation-next-single-property-change): > Parse whole buffer at once. > > Remove the comment that mentioned that it is an option to do it in one > go as we now actually start doing. As the existence of that comment > suggested, there is not really a reason to process the buffer in small > chunks. On the contrary, processing the output in arbitrary units can > result in certain constructs not being recognized because they begin > in one arbitrary chunk, while ending in another. Makes sense to me, but I wonder what the reason for this 500-chars-at-a-time parsing was in the first place. I guess we'll find out if it breaks something, and should be ready to revert. :-) So I've applied this to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 10:19:28 2020 Received: (at control) by debbugs.gnu.org; 14 Aug 2020 14:19:28 +0000 Received: from localhost ([127.0.0.1]:53388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6aYK-0000hS-05 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 10:19:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6aYI-0000h3-7u for control@debbugs.gnu.org; Fri, 14 Aug 2020 10:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qUOs2tDQMGZoV9U0CvwdPIy/rRmXfS/zN65H8r/voTA=; b=KR9CsvaUywxm0rS+YYWxqoPb5T dDJzLG791pPTN0rDzBcJzrRW90y4MMsii1t7xg2HU3CEffcsLoEKW2z5q/3rbx4k1HN6n+Tfs0I7D I3RPAzOb7yBV68l99DRmSXZTPHAe/n5nWl1uBuwbqh4vwMRylMQM6eRCCO5tttElIt/Y=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6aYA-0002tZ-Hk for control@debbugs.gnu.org; Fri, 14 Aug 2020 16:19:20 +0200 Date: Fri, 14 Aug 2020 16:19:16 +0200 Message-Id: <87364p71jv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #42806 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 42806 fixed close 42806 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 42806 fixed close 42806 28.1 quit From unknown Mon Jun 23 07:53:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42806: [PATCH 1/1] Parse whole buffer of compilation output at once Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen Cc: Jonas Bernoulli , 42806@debbugs.gnu.org Received: via spool by 42806-submit@debbugs.gnu.org id=B42806.159741699323571 (code B ref 42806); Fri, 14 Aug 2020 14:57:01 +0000 Received: (at 42806) by debbugs.gnu.org; 14 Aug 2020 14:56:33 +0000 Received: from localhost ([127.0.0.1]:53523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6b8C-000687-Tu for submit@debbugs.gnu.org; Fri, 14 Aug 2020 10:56:33 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:41989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6b8A-00067t-9B for 42806@debbugs.gnu.org; Fri, 14 Aug 2020 10:56:31 -0400 Received: by mail-qk1-f173.google.com with SMTP id b79so8553588qkg.9 for <42806@debbugs.gnu.org>; Fri, 14 Aug 2020 07:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=z9z6xegQKl+r/6x/0Coi2G9PVigTsJiXwWEfayjjjIU=; b=p2M/wvGTEc9eAh7rfwACg10K2PmhS3jtdmfF7/kQJuXzzezJvoC41FMLjX5DFR/zGi H5QfBrFaZETa/OhHYPRKa73m5P65TQeX5vZ7wVvmY5STv2FUZXrrUn1fAGNdWIiT8m/Q 4jq4TbyQxBugbFYnBSjX66HQHP2jkeZDgueWdNHSGaSMScjcJMcEb6ddvlJMNBbWlRfk Wmu/fgf3Q02vnhVHFnlve5ddZxLO4IALpW1asA0+etPGfYmPCf+IMfxSZ7uhJhbpgT3T fnLy/1gAv6O4UNDQ5v6/ITsUZXBPVwQY/fZCNt3h7bShbaWlu9sWfwtx41H64KW4uFK9 K3ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=z9z6xegQKl+r/6x/0Coi2G9PVigTsJiXwWEfayjjjIU=; b=mJN1kMuMjy3vlFfZ/TwdhETMxyDn+1WdK4dETTwVMQbYZvm3mgerlABuatngONW4qC p/W+fZ6XmVtqnh+/k+1nQmWhTl9ld5mcFmo6iCfoRz0kkn2TZU61CCnXSiBblSD36/l6 l1NLUNH8jgUr9F7Xd143Jh79MXtgtTwhFKtV+pyj6wd30E3TdOioyONpnrrO54pvm9Ft w+ItOol+SNMHBEtSFcZXmps5qfUpVAFukTfALFO0rUr7zDVG6gO63Zt03KXgO7HNFryQ gh5ZuAWBLarOWltPwxQmsTQjj2qfztqWJqLtzXCM0RCq9wmNsqR6y1CoY/3pJnGV/xFh eRUg== X-Gm-Message-State: AOAM532yn5ZeA9oqIblS0vDbVfP3jyMqZF9QU3X4tIUS5FZeQXhdHu37 qwgVEHvYmHk2PTUJntOG5vQKlFy6Hnw= X-Google-Smtp-Source: ABdhPJxqXMoQs4mjwH4//L+PAhv6sMnUz5JXySLXcwI5DIvlzAOjnM4oAYhOu3o3IXeIkvNZ+zGr5Q== X-Received: by 2002:a37:a291:: with SMTP id l139mr2179687qke.117.1597416984544; Fri, 14 Aug 2020 07:56:24 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id a3sm9971235qtj.21.2020.08.14.07.56.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Aug 2020 07:56:24 -0700 (PDT) From: Noam Postavsky References: <20200810212756.25696-1-jonas@bernoul.li> <20200810213059.26441-1-jonas@bernoul.li> <874kp571k3.fsf@gnus.org> Date: Fri, 14 Aug 2020 10:56:19 -0400 In-Reply-To: <874kp571k3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 14 Aug 2020 16:19:08 +0200") Message-ID: <85eeo91dkc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Jonas Bernoulli writes: > >> * lisp/progmodes/compile.el (compilation-next-single-property-change): >> Parse whole buffer at once. >> >> Remove the comment that mentioned that it is an option to do it in one >> go as we now actually start doing. As the existence of that comment >> suggested, there is not really a reason to process the buffer in small >> chunks. On the contrary, processing the output in arbitrary units can >> result in certain constructs not being recognized because they begin >> in one arbitrary chunk, while ending in another. > > Makes sense to me, but I wonder what the reason for this > 500-chars-at-a-time parsing was in the first place. > > I guess we'll find out if it breaks something, and should be ready to > revert. :-) I suspect it would be to avoid long pauses if there is a lot of output from the subprocess at once.