GNU bug report logs - #42801
26.3; customize-apropos shows bogus State buttons after saving

Previous Next

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Szunti <szunti <at> gmail.com>, 42801 <at> debbugs.gnu.org
Subject: bug#42801: 26.3; customize-apropos shows bogus State buttons after saving
Date: Sun, 16 Aug 2020 11:05:00 -0300

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> I can reproduce this bug in Emacs 26.3.  On current master, the bug
manifests
>> differently: we don't get the State buttons, but we do get the message:
>> Symbol's function definition is void: nil
>>
>> The difference lies in `custom-variable-modified-p' bugging out before
we draw
>> the bogus State buttons for all options, because it is not supposed to
handle
>> hidden widgets.
>>
>> The bug is that Custom-save recalculates the state and redraws all
widgets,
>> even the hidden ones.  I propose the attached patch, that changes
>> Custom-save to only act on edited widgets in the buffer.
>
> Thanks; applied to Emacs 28.1.

Thank you!

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.