GNU bug report logs - #42801
26.3; customize-apropos shows bogus State buttons after saving

Previous Next

Package: emacs;

Reported by: Szunti <szunti <at> gmail.com>

Date: Mon, 10 Aug 2020 16:28:01 UTC

Severity: normal

Tags: fixed, moreinfo, patch

Merged with 40853, 46355, 48531

Found in versions 26.3, 27.1, 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: Szunti <szunti <at> gmail.com>, 42801 <at> debbugs.gnu.org
Subject: bug#42801: 26.3; customize-apropos shows bogus State buttons after saving
Date: Fri, 14 Aug 2020 16:41:03 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> I can reproduce this bug in Emacs 26.3.  On current master, the bug manifests
> differently: we don't get the State buttons, but we do get the message:
> Symbol's function definition is void: nil
>
> The difference lies in `custom-variable-modified-p' bugging out before we draw
> the bogus State buttons for all options, because it is not supposed to handle
> hidden widgets.
>
> The bug is that Custom-save recalculates the state and redraws all widgets,
> even the hidden ones.  I propose the attached patch, that changes
> Custom-save to only act on edited widgets in the buffer.

Thanks; applied to Emacs 28.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 57 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.