GNU bug report logs - #42800
[PATCH] Add (guix git-repo-download).

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] Add (guix git-repo-download).
Date: Mon, 10 Aug 2020 16:50:58 +0200

[Message part 1 (text/plain, inline)]

On Mon, Aug 10, 2020 at 01:39:31PM +0200, Danny Milosavljevic wrote:
> * guix/build/git-repo.scm: New file.
> * guix/git-repo-download.scm: New file.
> * Makefile.am (MODULES): Add them.
> ---
>  Makefile.am                |   2 +
>  guix/build/git-repo.scm    |  74 +++++++++++++++++
>  guix/git-repo-download.scm | 158 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 234 insertions(+)
>  create mode 100644 guix/build/git-repo.scm
>  create mode 100644 guix/git-repo-download.scm

Danny,

I think the commit message and/or commentary is written somewhat
confusingly here. It took me a while to realize that "git-repo" is the
name of a tool that manages a multi-repository, and not just short for
"git repository".

How about replacing "git-repo repository" with "repository managed with
the git-repo tool" or "git-repo-based multirepository"?

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.