GNU bug report logs - #42792
[PATCH] gnu: Add python-pydantic.

Previous Next

Full log

Message #13 received at 42792-done <at> debbugs.gnu.org (full text, mbox):

From: Tanguy Le Carrour <tanguy <at> bioneland.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 42792-done <at> debbugs.gnu.org
Subject: Re: [bug#42792] [PATCH] gnu: Add python-pydantic.
Date: Mon, 10 Aug 2020 16:19:11 +0200

Hi Mathieu,


Le 08/10, Mathieu Othacehe a écrit :
> > * gnu/packages/python-xyz.scm (python-pydantic): New variable.
> 
> Applied with the following diff:
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index a36e99aa32..4102902465 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -3829,30 +3829,32 @@ Language (TOML) configuration files.")
>         (method git-fetch)
>         (uri (git-reference
>               (url "https://github.com/samuelcolvin/pydantic")
> -              (commit (string-append "v" version))))
> +             (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
> -       (sha256 (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
> +       (sha256
> +        (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))

Thanks for paying attention to every details!!
Actually, those things have been bothering me for quiet a while…
They are not reported by `./pre-inst-env guix lint python-pydantic` or
fixed by `emacs --script etc/indent-code.el gnu/packages/python-xyz.scm python-pydantic`. :-(

Would the following have been acceptable?

```
> +       (sha256 (base32
> +                "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
```

And what about this? (2-space indent instead of 1, like `add-before` below)

```
> +       (sha256
> +         (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8"))))
```


>      (build-system python-build-system)
>      (arguments
>       '(#:phases
>         (modify-phases %standard-phases
> -         ;; Reported upstream: <https://github.com/samuelcolvin/pydantic/issues/1580>
> -         ;; Not sure how to apply the suggested fix!?
> +         ;; Reported upstream:
> +         ;; <https://github.com/samuelcolvin/pydantic/issues/1580>.
> +         ;; Disable the faulty test as the fix is unclear.

Much better, thanks!
In retrospect, I realize that I should have put the question in the
commit message for a maintainer to read, not in the package definition.
Would that have been better?!


>           (add-before 'check 'disable-test
>             (lambda _
>               (substitute* "tests/test_validators.py"
>                 (("test_assert_raises_validation_error")
> -                 "_test_assert_raises_validation_error"))
> +                "_test_assert_raises_validation_error"))
>               #t))
>           (replace 'check
>             (lambda _ (invoke "pytest" "-vv" "tests"))))))
>      (native-inputs
>       `(("python-pytest" ,python-pytest)))
>      (home-page "https://github.com/samuelcolvin/pydantic")
> -    (synopsis "Data validation and settings management using python type hinting")
> +    (synopsis "Python data validation and settings management")

Sorry, I still suck at synopsis! :-(


>      (description
> -      "Pydantic enforces type hints at runtime, and provides user friendly errors
> -when data is invalid.")
> +     "Pydantic enforces type hints at runtime, and provides user friendly
> +errors when data is invalid.")
>      (license license:expat)))

Thanks!

-- 
Tanguy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.