From unknown Fri Aug 15 02:03:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42771 <42771@debbugs.gnu.org> To: bug#42771 <42771@debbugs.gnu.org> Subject: Status: smalltalk fails to build Reply-To: bug#42771 <42771@debbugs.gnu.org> Date: Fri, 15 Aug 2025 09:03:06 +0000 retitle 42771 smalltalk fails to build reassign 42771 guix submitter 42771 Michael Rohleder severity 42771 normal tag 42771 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 08 14:53:45 2020 Received: (at submit) by debbugs.gnu.org; 8 Aug 2020 18:53:45 +0000 Received: from localhost ([127.0.0.1]:59600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4TyK-0001e1-BW for submit@debbugs.gnu.org; Sat, 08 Aug 2020 14:53:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:33130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4TyH-0001ds-AD for submit@debbugs.gnu.org; Sat, 08 Aug 2020 14:53:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4TyG-0007Cg-Ue for bug-guix@gnu.org; Sat, 08 Aug 2020 14:53:32 -0400 Received: from wp224.webpack.hosteurope.de ([2a01:488:42:1000:50ed:84e7::]:35888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4TyE-00015h-SE for bug-guix@gnu.org; Sat, 08 Aug 2020 14:53:32 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1k4TyA-00080S-6z; Sat, 08 Aug 2020 20:53:26 +0200 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1k4Ty8-0007zU-77 for bug-guix@gnu.org; Sat, 08 Aug 2020 20:53:25 +0200 From: Michael Rohleder To: bug-guix@gnu.org Subject: smalltalk fails to build X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Sat, 08 Aug 2020 20:53:14 +0200 Message-ID: <87sgcxc6lh.fsf@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1596912810;3b5b5546; X-HE-SMSGID: 1k4TyA-00080S-6z Received-SPF: permerror client-ip=2a01:488:42:1000:50ed:84e7::; envelope-from=mike@rohleder.de; helo=wp224.webpack.hosteurope.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/08 13:53:21 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable As reported by zelphirkaltstahl@posteo.de, smalltalk fails in tests: ... /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash '.= /testsuite'=20 ## ------------------------------- ## ## GNU Smalltalk 3.2.5 test suite. ## ## ------------------------------- ## Regression tests. 1: arrays.st ok 2: classes.st ok 3: blocks.st ok 4: sets.st ok 5: processes.st ok 6: exceptions.st ok 7: intmath.st FAILED (testsuite.at:3= 3) ^C =2D-=20 A baby is God's opinion that the world should go on. -- Carl Sandburg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl8u9JoACgkQfHr/vv7y yyVICgf9EwwUXUZnrw0qYwAPmAk2ARkGhMmsWl4JCZ8Cr8OJYdf+GerCbXeqj7PE a+90rdf/PmoDLBZx0BvQnHPBh5+ObSI6mX8Uho592wqUvGsGsc1WAyk7VqqOqd4x Bxkd/cb7ULy8ndh1xlpkYuae8D5tMvMmZklRD7C6KFAf6FdOxzQYWuSkHuN+YK5S QFoznmazHemQb6jHqYv3iI4Tpbm1DPVWUR7c7rPKXoJkvuFOJ4/mM+VzJQwW0WkY q528NgRotreaTyj5a70OeQcdfv73oa4jo/LLT48V/wNApBiNzsVT0BfbHzqyYVbk KGGXqrih8BdT4aCSSvTC/na64OPPvQ== =iZcz -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 28 17:13:08 2020 Received: (at 42771) by debbugs.gnu.org; 28 Nov 2020 22:13:08 +0000 Received: from localhost ([127.0.0.1]:49291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj8Sn-0005Wq-Gh for submit@debbugs.gnu.org; Sat, 28 Nov 2020 17:13:08 -0500 Received: from mout01.posteo.de ([185.67.36.65]:52616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj8Sj-0005WJ-2z for 42771@debbugs.gnu.org; Sat, 28 Nov 2020 17:13:04 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8FDFD16005F for <42771@debbugs.gnu.org>; Sat, 28 Nov 2020 23:12:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1606601574; bh=QXX7DwzOIRP6my4qwJXNNS3ryMMnn5t6be3WVTaPnFo=; h=From:To:Cc:Subject:Date:From; b=bprglo+Lt2MY8/Nx/kQAtVa5zz5V6KG3fvYI9EoUhr6z7/AlghH/Uw/AobDUK++OK 714VG99B9I9FniFZpmaWmAiGIFwFx6k/Hi/VO+csA27BCwM0Joij8XjLfHYIcpM673 +KQ7yu2LNC1EastewP02oAk2wy1U/BHxBT3tmvBzzZY9KcjflHJ7tCgyDSsSzJ982N wF9OBGBqZq9ZNudhn40OCtOF2yg4AJwsTxdnO8tA65dl5zs2a2GhdW76Dz6sYk1CWL bBT8tb1eP8n/Nbg/FiRpZqXX7IgRLFUwWwqz/mL1nCbNo4rOeZzSEBZM1Fmz1cixGC 3CYd8AbdAJmTA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ck5N55tDPz9rxB; Sat, 28 Nov 2020 23:12:53 +0100 (CET) From: Holger Peters To: 42771@debbugs.gnu.org Subject: [PATCH] Disable tests for smalltalk and add candidate releases Date: Sat, 28 Nov 2020 23:09:45 +0100 Message-Id: <20201128220944.520616-1-holger.peters@posteo.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 42771 Cc: zelphirkaltstahl@posteo.de, mike@rohleder.de, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) Last stable GNU smalltalk release dates back to 2013-04-08. Disabled tests as they were also failing for my non-guix build. Also added the latest alpha release as `smalltalk-next` and a build from vcs where we actually pass the tests. * gnu/packages/ruby.scm (smalltalk): Disable tests (smalltalk-next): New variable. (smalltalk-next-from-vcs): New variable. --- gnu/packages/smalltalk.scm | 63 +++++++++++++++++++++++++++++++++++++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm index 5d35f563e2..c96f4b1730 100644 --- a/gnu/packages/smalltalk.scm +++ b/gnu/packages/smalltalk.scm @@ -24,20 +24,26 @@ #:use-module ((guix licenses) #:prefix license:) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix git-download) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages base) + #:use-module (gnu packages bison) #:use-module (gnu packages compression) + #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) + #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages libffi) #:use-module (gnu packages libsigsegv) #:use-module (gnu packages linux) + #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages texinfo) #:use-module (gnu packages xorg)) (define-public smalltalk @@ -61,7 +67,8 @@ (inputs `(("zip" ,zip))) (arguments - `(#:phases + `(#:tests? #f ; failing tests, 3.2.5 has been released years ago + #:phases (modify-phases %standard-phases (add-before 'configure 'fix-libc (lambda _ @@ -145,3 +152,57 @@ also includes a customisable framework for creating dynamic HTTP servers and interactively extensible Web sites.") (home-page "http://squeakvm.org/") (license license:x11))) + +;;; alpha release +(define-public smalltalk-next + (package (inherit smalltalk) + (name "smalltalk-next") + (version "3.2.91") + (source + (origin + (method url-fetch) + (uri (string-append "https://alpha.gnu.org/gnu/smalltalk/smalltalk-" + version ".tar.xz")) + (sha256 + (base32 "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0")))))) + +;;; This version from the main development branch can be built with passing +;;; tests +(define-public smalltalk-next-from-vcs + (let ((revision "18") + (commit "dfe4b5660037c4d178853ee00458a75e51a88563") + (git-url "git://git.sv.gnu.org/smalltalk.git")) + (package (inherit smalltalk) + (name "smalltalk-next-from-vcs") + (version (git-version "3.2.91" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url git-url) + (commit commit))) + (file-name (git-file-name name version)) + (sha256 (base32 "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r")))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool) + ("flex" ,flex) + ("texinfo" ,texinfo) + ("perl" ,perl) + ("gettext" ,gettext-minimal) + ("libffi" ,libffi) + ("libltdl" ,libltdl) + ("bison" ,bison) + ("libsigsegv" ,libsigsegv) + ("pkg-config" ,pkg-config))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'configure 'fix-libc + (lambda _ + (let ((libc (assoc-ref %build-inputs "libc"))) + (substitute* "libc.la.in" + (("@LIBC_SO_NAME@") "libc.so") + (("@LIBC_SO_DIR@") (string-append libc "/lib")))) + #t)))))))) + -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 03:43:55 2020 Received: (at 42771) by debbugs.gnu.org; 29 Nov 2020 08:43:55 +0000 Received: from localhost ([127.0.0.1]:49628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjIJA-0002bx-VK for submit@debbugs.gnu.org; Sun, 29 Nov 2020 03:43:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:41838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjIJ6-0002be-6M for 42771@debbugs.gnu.org; Sun, 29 Nov 2020 03:43:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 99E2E160062 for <42771@debbugs.gnu.org>; Sun, 29 Nov 2020 09:43:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1606639417; bh=bV3jR1O+mdq1n5VggIEiv8oYRvmlI7hAYBJuB1jd4Mg=; h=From:To:Cc:Subject:Date:From; b=L6lXE1DFPyftb2zYu24eil0mdR8rJ7wqFg6iJ/EF7bJu/eP7T4r+q6wPRD/CcsOdl afsKNy3t+1A3VKbJftQar4MnhVajW6WP//JFUUYvS+6o/hle9ekH0fa2P8EagisGtI xxZzb7xBUmFfNxRpN1w5fXi98whQQTQZ2UAVga5cY96pBlDSKnQsDEjcFAzdVjQ7aR wRSrDt4un/r0BrLpXLcS0hDQZzz6OaEcmuVWIi0V1iguM94TBc2Ijp9/Spuyn1U3t6 lbxSGdcd4rmRoWEFlVnqQw6GwNrRIfVUBXAEil1PsSLvSdEE/VXtppTEjj70C0g3mP YH97lwqjj8Qfw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CkMMs0ffRz6tmM; Sun, 29 Nov 2020 09:43:36 +0100 (CET) From: Holger Peters To: 42771@debbugs.gnu.org Subject: [PATCH] Disable tests for smalltalk and add candidate releases Date: Sun, 29 Nov 2020 09:43:28 +0100 Message-Id: <20201129084328.545720-1-holger.peters@posteo.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 42771 Cc: mike@rohleder.de, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) * gnu/packages/smalltalk.scm (smalltalk): disable tests (smalltalk-next): New variable. (smalltalk-next-from-vcs): New variable. --- gnu/packages/smalltalk.scm | 64 +++++++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm index 5d35f563e2..7136751a81 100644 --- a/gnu/packages/smalltalk.scm +++ b/gnu/packages/smalltalk.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2016 Nicolas Goaziou ;;; Copyright © 2016 Ludovic Courtès ;;; Copyright © 2018 Tobias Geerinckx-Rice +;;; Copyright © 2020 Holger Peters ;;; ;;; This file is part of GNU Guix. ;;; @@ -24,20 +25,26 @@ #:use-module ((guix licenses) #:prefix license:) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix git-download) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages base) + #:use-module (gnu packages bison) #:use-module (gnu packages compression) + #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) + #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages libffi) #:use-module (gnu packages libsigsegv) #:use-module (gnu packages linux) + #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) + #:use-module (gnu packages texinfo) #:use-module (gnu packages xorg)) (define-public smalltalk @@ -61,7 +68,8 @@ (inputs `(("zip" ,zip))) (arguments - `(#:phases + `(#:tests? #f ; failing tests, 3.2.5 has been released years ago + #:phases (modify-phases %standard-phases (add-before 'configure 'fix-libc (lambda _ @@ -145,3 +153,57 @@ also includes a customisable framework for creating dynamic HTTP servers and interactively extensible Web sites.") (home-page "http://squeakvm.org/") (license license:x11))) + +;;; alpha release +(define-public smalltalk-next + (package (inherit smalltalk) + (name "smalltalk-next") + (version "3.2.91") + (source + (origin + (method url-fetch) + (uri (string-append "https://alpha.gnu.org/gnu/smalltalk/smalltalk-" + version ".tar.xz")) + (sha256 + (base32 "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0")))))) + +;;; This version from the main development branch can be built with passing +;;; tests +(define-public smalltalk-next-from-vcs + (let ((revision "18") + (commit "dfe4b5660037c4d178853ee00458a75e51a88563") + (git-url "git://git.sv.gnu.org/smalltalk.git")) + (package (inherit smalltalk) + (name "smalltalk-next-from-vcs") + (version (git-version "3.2.91" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url git-url) + (commit commit))) + (file-name (git-file-name name version)) + (sha256 (base32 "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r")))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool) + ("flex" ,flex) + ("texinfo" ,texinfo) + ("perl" ,perl) + ("gettext" ,gettext-minimal) + ("libffi" ,libffi) + ("libltdl" ,libltdl) + ("bison" ,bison) + ("libsigsegv" ,libsigsegv) + ("pkg-config" ,pkg-config))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'configure 'fix-libc + (lambda _ + (let ((libc (assoc-ref %build-inputs "libc"))) + (substitute* "libc.la.in" + (("@LIBC_SO_NAME@") "libc.so") + (("@LIBC_SO_DIR@") (string-append libc "/lib")))) + #t)))))))) + -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 06:35:09 2020 Received: (at 42771) by debbugs.gnu.org; 4 Dec 2020 11:35:09 +0000 Received: from localhost ([127.0.0.1]:43092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl9Mf-0002u9-Ly for submit@debbugs.gnu.org; Fri, 04 Dec 2020 06:35:09 -0500 Received: from mout02.posteo.de ([185.67.36.66]:60353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl9Mc-0002tO-Pi for 42771@debbugs.gnu.org; Fri, 04 Dec 2020 06:35:04 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 3D2112400FC for <42771@debbugs.gnu.org>; Fri, 4 Dec 2020 12:34:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1607081696; bh=sQMThkdyrRUjqBcDSVdpoYlI1ocYFLTMHrXqKBe9gMM=; h=From:Subject:Date:To:From; b=PITdkumhsDVTgFdEANyxpHg+79ELv+aOZRPZVTyCdo4kdnu4UQEvWd6Na9bZ9P5kn 4bg04CUKHZjlqb8jHSxbDmT6oARCsCYei80fKJKNKcu0gugSpf29/0kCLduTx26j5+ Wk5wnWO5Fy+D8vPzxZvIELs5yxEooieKwI5qnaV7fhFNoROy03RrHEFe8bQFXALNRe ihLe8fUldtFFKI7RMlL17J72ExSRcssfmCgCcfRo2FukxwR1x6ZR3nfguf+aBL12ms dPRu1gSa+j8QbVe3nXU5DCJ548z9jO1PRfKNIrnRX0LQT8qnUOBJhGCf6KNR6oLrfz oonVy33WitWig== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CnVxC4gd2z6tm6 for <42771@debbugs.gnu.org>; Fri, 4 Dec 2020 12:34:55 +0100 (CET) From: Holger Peters Content-Type: multipart/alternative; boundary="Apple-Mail=_2FD9B7D6-7701-40A2-9908-2728F92C7A9C" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH] Disable tests for smalltalk and add candidate releases Date: Fri, 4 Dec 2020 12:34:54 +0100 References: <20201128220944.520616-1-holger.peters@posteo.de> To: 42771@debbugs.gnu.org In-Reply-To: <20201128220944.520616-1-holger.peters@posteo.de> Message-Id: X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 42771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --Apple-Mail=_2FD9B7D6-7701-40A2-9908-2728F92C7A9C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Investigating the test failures, I found = https://lists.gnu.org/archive/html/help-smalltalk/2015-02/msg00001.html = = which is the reference in gnu smalltalk mailinglists that matches the = observed test failures when I build on my machine. > Am 28.11.2020 um 23:09 schrieb Holger Peters = : >=20 > Last stable GNU smalltalk release dates back to 2013-04-08. Disabled = tests as > they were also failing for my non-guix build. Also added the latest = alpha > release as `smalltalk-next` and a build from vcs where we actually = pass the > tests. >=20 > * gnu/packages/ruby.scm (smalltalk): Disable tests > (smalltalk-next): New variable. > (smalltalk-next-from-vcs): New variable. > --- > gnu/packages/smalltalk.scm | 63 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 62 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm > index 5d35f563e2..c96f4b1730 100644 > --- a/gnu/packages/smalltalk.scm > +++ b/gnu/packages/smalltalk.scm > @@ -24,20 +24,26 @@ > #:use-module ((guix licenses) #:prefix license:) > #:use-module (guix packages) > #:use-module (guix download) > + #:use-module (guix git-download) > #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > #:use-module (gnu packages audio) > #:use-module (gnu packages autotools) > #:use-module (gnu packages base) > + #:use-module (gnu packages bison) > #:use-module (gnu packages compression) > + #:use-module (gnu packages flex) > #:use-module (gnu packages fontutils) > + #:use-module (gnu packages gettext) > #:use-module (gnu packages gl) > #:use-module (gnu packages glib) > #:use-module (gnu packages libffi) > #:use-module (gnu packages libsigsegv) > #:use-module (gnu packages linux) > + #:use-module (gnu packages perl) > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages pulseaudio) > + #:use-module (gnu packages texinfo) > #:use-module (gnu packages xorg)) >=20 > (define-public smalltalk > @@ -61,7 +67,8 @@ > (inputs > `(("zip" ,zip))) > (arguments > - `(#:phases > + `(#:tests? #f ; failing tests, 3.2.5 has been released years = ago > + #:phases > (modify-phases %standard-phases > (add-before 'configure 'fix-libc > (lambda _ > @@ -145,3 +152,57 @@ also includes a customisable framework for = creating dynamic HTTP servers and > interactively extensible Web sites.") > (home-page "http://squeakvm.org/") > (license license:x11))) > + > +;;; alpha release > +(define-public smalltalk-next > + (package (inherit smalltalk) > + (name "smalltalk-next") > + (version "3.2.91") > + (source > + (origin > + (method url-fetch) > + (uri (string-append = "https://alpha.gnu.org/gnu/smalltalk/smalltalk-" > + version ".tar.xz")) > + (sha256 > + (base32 = "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0")))))) > + > +;;; This version from the main development branch can be built with = passing > +;;; tests > +(define-public smalltalk-next-from-vcs > + (let ((revision "18") > + (commit "dfe4b5660037c4d178853ee00458a75e51a88563") > + (git-url "git://git.sv.gnu.org/smalltalk.git")) > + (package (inherit smalltalk) > + (name "smalltalk-next-from-vcs") > + (version (git-version "3.2.91" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url git-url) > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 = "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r")))) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("flex" ,flex) > + ("texinfo" ,texinfo) > + ("perl" ,perl) > + ("gettext" ,gettext-minimal) > + ("libffi" ,libffi) > + ("libltdl" ,libltdl) > + ("bison" ,bison) > + ("libsigsegv" ,libsigsegv) > + ("pkg-config" ,pkg-config))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'fix-libc > + (lambda _ > + (let ((libc (assoc-ref %build-inputs "libc"))) > + (substitute* "libc.la.in" > + (("@LIBC_SO_NAME@") "libc.so") > + (("@LIBC_SO_DIR@") (string-append libc "/lib")))) > + #t)))))))) > + > --=20 > 2.28.0 >=20 --Apple-Mail=_2FD9B7D6-7701-40A2-9908-2728F92C7A9C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Investigating the test failures, I found https://lists.gnu.org/archive/html/help-smalltalk/2015-02/msg00= 001.html which is the reference in gnu smalltalk mailinglists = that matches the observed test failures when I build on my machine.

Am 28.11.2020 um 23:09 schrieb Holger Peters <holger.peters@posteo.de>:

Last = stable GNU smalltalk release dates back to 2013-04-08.  Disabled = tests as
they were also failing for my non-guix build. =  Also added the latest alpha
release as = `smalltalk-next` and a build from vcs where we actually pass the
tests.

* gnu/packages/ruby.scm = (smalltalk): Disable tests
(smalltalk-next): New = variable.
(smalltalk-next-from-vcs): New variable.
---
gnu/packages/smalltalk.scm | 63 = +++++++++++++++++++++++++++++++++++++-
1 file changed, 62 = insertions(+), 1 deletion(-)

diff --git = a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm
index 5d35f563e2..c96f4b1730 100644
--- = a/gnu/packages/smalltalk.scm
+++ = b/gnu/packages/smalltalk.scm
@@ -24,20 +24,26 @@
  #:use-module ((guix licenses) #:prefix = license:)
  #:use-module (guix packages)
  #:use-module (guix download)
+ =  #:use-module (guix git-download)
=   #:use-module (guix build-system cmake)
=   #:use-module (guix build-system gnu)
=   #:use-module (gnu packages audio)
=   #:use-module (gnu packages autotools)
=   #:use-module (gnu packages base)
+ =  #:use-module (gnu packages bison)
=   #:use-module (gnu packages compression)
+ =  #:use-module (gnu packages flex)
=   #:use-module (gnu packages fontutils)
+ =  #:use-module (gnu packages gettext)
=   #:use-module (gnu packages gl)
=   #:use-module (gnu packages glib)
=   #:use-module (gnu packages libffi)
=   #:use-module (gnu packages libsigsegv)
=   #:use-module (gnu packages linux)
+ =  #:use-module (gnu packages perl)
=   #:use-module (gnu packages pkg-config)
=   #:use-module (gnu packages pulseaudio)
+ =  #:use-module (gnu packages texinfo)
=   #:use-module (gnu packages xorg))

(define-public smalltalk
@@ -61,7 +67,8 @@
    (inputs
=      `(("zip" ,zip)))
=     (arguments
- =     `(#:phases
+ =     `(#:tests? #f  ; failing tests, 3.2.5 has = been released years ago
+ =       #:phases
=        (modify-phases = %standard-phases
=          (add-before = 'configure 'fix-libc
=            (lambda = _
@@ -145,3 +152,57 @@ also includes a customisable = framework for creating dynamic HTTP servers and
= interactively extensible Web sites.")
=     (home-page "http://squeakvm.org/")
=     (license license:x11)))
+
+;;; alpha release
+(define-public = smalltalk-next
+  (package (inherit smalltalk)
+    (name "smalltalk-next")
+ =    (version "3.2.91")
+ =    (source
+ =     (origin
+ =       (method url-fetch)
+ =       (uri (string-append "https://alpha.gnu.org/gnu/smalltalk/smalltalk-"
+ =             &n= bsp;           &nbs= p; version ".tar.xz"))
+ =       (sha256
+ =        (base32 = "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0"))))))
+
+;;; This version from the main development = branch can be built with passing
+;;; tests
+(define-public smalltalk-next-from-vcs
+ =  (let ((revision "18")
+ =        (commit = "dfe4b5660037c4d178853ee00458a75e51a88563")
+ =        (git-url "git://git.sv.gnu.org/smalltalk.git"))
+ =    (package (inherit smalltalk)
+ =      (name "smalltalk-next-from-vcs")
+      (version (git-version = "3.2.91" revision commit))
+ =      (source (origin
+ =             &n= bsp;  (method git-fetch)
+ =             &n= bsp;  (uri (git-reference
+ =             &n= bsp;        (url git-url)
+ =             &n= bsp;        (commit commit)))
+ =             &n= bsp;  (file-name (git-file-name name version))
+ =             &n= bsp;  (sha256 (base32 = "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r"))))
+=      (native-inputs
+ =       `(("autoconf" ,autoconf)
+         ("automake" = ,automake)
+ =         ("libtool" ,libtool)
+         ("flex" = ,flex)
+ =         ("texinfo" ,texinfo)
+         ("perl" = ,perl)
+ =         ("gettext" = ,gettext-minimal)
+ =         ("libffi" ,libffi)
+         ("libltdl" = ,libltdl)
+ =         ("bison" ,bison)
+ =         ("libsigsegv" = ,libsigsegv)
+ =         ("pkg-config" = ,pkg-config)))
+ =      (arguments
+ =       `(#:phases
+ =         (modify-phases = %standard-phases
+ =           (add-before = 'configure 'fix-libc
+ =             (l= ambda _
+ =             &n= bsp; (let ((libc (assoc-ref %build-inputs "libc")))
+ =             &n= bsp;   (substitute* "libc.la.in"
+ =             &n= bsp;     (("@LIBC_SO_NAME@") "libc.so")
+ =             &n= bsp;     (("@LIBC_SO_DIR@") =  (string-append libc "/lib"))))
+ =             &n= bsp; #t))))))))
+
--
2.28.0


= --Apple-Mail=_2FD9B7D6-7701-40A2-9908-2728F92C7A9C-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 07:07:05 2020 Received: (at 42771) by debbugs.gnu.org; 4 Dec 2020 12:07:05 +0000 Received: from localhost ([127.0.0.1]:43256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl9rZ-00084b-Ok for submit@debbugs.gnu.org; Fri, 04 Dec 2020 07:07:05 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl9rW-00084M-Q2 for 42771@debbugs.gnu.org; Fri, 04 Dec 2020 07:07:00 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7427916005C for <42771@debbugs.gnu.org>; Fri, 4 Dec 2020 13:06:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1607083612; bh=tJHVVZcy8ki7ALGsCD/HBr8VeTErUMw7y92omNq9CPA=; h=From:Subject:Date:To:From; b=E/5GXSHziiLSCsLKkduESk63+b7V5sPoPEwFtf63kKat68J+VyKZp1HxD4YwB2gH4 Q4ty4e5Kap1nYUcVctyZBHz4tz13fe5pXUnHgyLgAJI2vitvfxbpJlE/HdXVa90ja6 YfTjHjmflQ9SyaaS1h08vBMba1xWvL/hMczlXO/VCfnaCufIfOFeJePcZMKWBh4JoM 4dBcHi1RETCE2YpnvTQyXpAvOTe4ClB2xJgxJdFPU6PklQvryLbaETMUj8W+jj8zRG gf7z6OFlboDK1rwlGaxX4mgd4Z3pD2elCKMUuhpWBsyIaVDPYvPNT+0fWPcSrI/TKD cfDUy35/Hr3zQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CnWf366GKz9rxP for <42771@debbugs.gnu.org>; Fri, 4 Dec 2020 13:06:51 +0100 (CET) From: Holger Peters Content-Type: multipart/alternative; boundary="Apple-Mail=_FEE3DF9E-73C1-4B4F-B871-EAA8BAB6FCB9" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH] Disable tests for smalltalk and add candidate releases Date: Fri, 4 Dec 2020 13:06:50 +0100 References: <20201128220944.520616-1-holger.peters@posteo.de> To: 42771@debbugs.gnu.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 42771 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --Apple-Mail=_FEE3DF9E-73C1-4B4F-B871-EAA8BAB6FCB9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Update: Better upstream reference, I will try to include a patch. > Am 04.12.2020 um 12:34 schrieb Holger Peters = : >=20 > Investigating the test failures, I found = https://lists.gnu.org/archive/html/help-smalltalk/2015-02/msg00001.html = = which is the reference in gnu smalltalk mailinglists that matches the = observed test failures when I build on my machine. >=20 >> Am 28.11.2020 um 23:09 schrieb Holger Peters >: >>=20 >> Last stable GNU smalltalk release dates back to 2013-04-08. Disabled = tests as >> they were also failing for my non-guix build. Also added the latest = alpha >> release as `smalltalk-next` and a build from vcs where we actually = pass the >> tests. >>=20 >> * gnu/packages/ruby.scm (smalltalk): Disable tests >> (smalltalk-next): New variable. >> (smalltalk-next-from-vcs): New variable. >> --- >> gnu/packages/smalltalk.scm | 63 = +++++++++++++++++++++++++++++++++++++- >> 1 file changed, 62 insertions(+), 1 deletion(-) >>=20 >> diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm >> index 5d35f563e2..c96f4b1730 100644 >> --- a/gnu/packages/smalltalk.scm >> +++ b/gnu/packages/smalltalk.scm >> @@ -24,20 +24,26 @@ >> #:use-module ((guix licenses) #:prefix license:) >> #:use-module (guix packages) >> #:use-module (guix download) >> + #:use-module (guix git-download) >> #:use-module (guix build-system cmake) >> #:use-module (guix build-system gnu) >> #:use-module (gnu packages audio) >> #:use-module (gnu packages autotools) >> #:use-module (gnu packages base) >> + #:use-module (gnu packages bison) >> #:use-module (gnu packages compression) >> + #:use-module (gnu packages flex) >> #:use-module (gnu packages fontutils) >> + #:use-module (gnu packages gettext) >> #:use-module (gnu packages gl) >> #:use-module (gnu packages glib) >> #:use-module (gnu packages libffi) >> #:use-module (gnu packages libsigsegv) >> #:use-module (gnu packages linux) >> + #:use-module (gnu packages perl) >> #:use-module (gnu packages pkg-config) >> #:use-module (gnu packages pulseaudio) >> + #:use-module (gnu packages texinfo) >> #:use-module (gnu packages xorg)) >>=20 >> (define-public smalltalk >> @@ -61,7 +67,8 @@ >> (inputs >> `(("zip" ,zip))) >> (arguments >> - `(#:phases >> + `(#:tests? #f ; failing tests, 3.2.5 has been released years = ago >> + #:phases >> (modify-phases %standard-phases >> (add-before 'configure 'fix-libc >> (lambda _ >> @@ -145,3 +152,57 @@ also includes a customisable framework for = creating dynamic HTTP servers and >> interactively extensible Web sites.") >> (home-page "http://squeakvm.org/ ") >> (license license:x11))) >> + >> +;;; alpha release >> +(define-public smalltalk-next >> + (package (inherit smalltalk) >> + (name "smalltalk-next") >> + (version "3.2.91") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append = "https://alpha.gnu.org/gnu/smalltalk/smalltalk- = " >> + version ".tar.xz")) >> + (sha256 >> + (base32 = "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0")))))) >> + >> +;;; This version from the main development branch can be built with = passing >> +;;; tests >> +(define-public smalltalk-next-from-vcs >> + (let ((revision "18") >> + (commit "dfe4b5660037c4d178853ee00458a75e51a88563") >> + (git-url "git://git.sv.gnu.org/smalltalk.git = ")) >> + (package (inherit smalltalk) >> + (name "smalltalk-next-from-vcs") >> + (version (git-version "3.2.91" revision commit)) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url git-url) >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 (base32 = "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r")))) >> + (native-inputs >> + `(("autoconf" ,autoconf) >> + ("automake" ,automake) >> + ("libtool" ,libtool) >> + ("flex" ,flex) >> + ("texinfo" ,texinfo) >> + ("perl" ,perl) >> + ("gettext" ,gettext-minimal) >> + ("libffi" ,libffi) >> + ("libltdl" ,libltdl) >> + ("bison" ,bison) >> + ("libsigsegv" ,libsigsegv) >> + ("pkg-config" ,pkg-config))) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-before 'configure 'fix-libc >> + (lambda _ >> + (let ((libc (assoc-ref %build-inputs "libc"))) >> + (substitute* "libc.la.in " >> + (("@LIBC_SO_NAME@") "libc.so") >> + (("@LIBC_SO_DIR@") (string-append libc = "/lib")))) >> + #t)))))))) >> + >> --=20 >> 2.28.0 >>=20 >=20 --Apple-Mail=_FEE3DF9E-73C1-4B4F-B871-EAA8BAB6FCB9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Update: Better upstream reference, I will try to include a = patch.



Am 04.12.2020 um 12:34 schrieb Holger Peters <holger.peters@posteo.de>:

Investigating the test = failures, I found https://lists.gnu.org/archive/html/help-smalltalk/2015-02/msg00= 001.html which is the reference in gnu smalltalk mailinglists = that matches the observed test failures when I build on my machine.

Am 28.11.2020 um 23:09 schrieb Holger Peters = <holger.peters@posteo.de>:

Last = stable GNU smalltalk release dates back to 2013-04-08.  Disabled = tests as
they were also failing for my non-guix build. =  Also added the latest alpha
release as = `smalltalk-next` and a build from vcs where we actually pass the
tests.

* gnu/packages/ruby.scm = (smalltalk): Disable tests
(smalltalk-next): New = variable.
(smalltalk-next-from-vcs): New variable.
---
gnu/packages/smalltalk.scm | 63 = +++++++++++++++++++++++++++++++++++++-
1 file changed, 62 = insertions(+), 1 deletion(-)

diff --git = a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm
index 5d35f563e2..c96f4b1730 100644
--- = a/gnu/packages/smalltalk.scm
+++ = b/gnu/packages/smalltalk.scm
@@ -24,20 +24,26 @@
  #:use-module ((guix licenses) #:prefix = license:)
  #:use-module (guix packages)
  #:use-module (guix download)
+ =  #:use-module (guix git-download)
=   #:use-module (guix build-system cmake)
=   #:use-module (guix build-system gnu)
=   #:use-module (gnu packages audio)
=   #:use-module (gnu packages autotools)
=   #:use-module (gnu packages base)
+ =  #:use-module (gnu packages bison)
=   #:use-module (gnu packages compression)
+ =  #:use-module (gnu packages flex)
=   #:use-module (gnu packages fontutils)
+ =  #:use-module (gnu packages gettext)
=   #:use-module (gnu packages gl)
=   #:use-module (gnu packages glib)
=   #:use-module (gnu packages libffi)
=   #:use-module (gnu packages libsigsegv)
=   #:use-module (gnu packages linux)
+ =  #:use-module (gnu packages perl)
=   #:use-module (gnu packages pkg-config)
=   #:use-module (gnu packages pulseaudio)
+ =  #:use-module (gnu packages texinfo)
=   #:use-module (gnu packages xorg))

(define-public smalltalk
@@ -61,7 +67,8 @@
    (inputs
=      `(("zip" ,zip)))
=     (arguments
- =     `(#:phases
+ =     `(#:tests? #f  ; failing tests, 3.2.5 has = been released years ago
+ =       #:phases
=        (modify-phases = %standard-phases
=          (add-before = 'configure 'fix-libc
=            (lambda = _
@@ -145,3 +152,57 @@ also includes a customisable = framework for creating dynamic HTTP servers and
= interactively extensible Web sites.")
=     (home-page "http://squeakvm.org/")
=     (license license:x11)))
+
+;;; alpha release
+(define-public = smalltalk-next
+  (package (inherit smalltalk)
+    (name "smalltalk-next")
+ =    (version "3.2.91")
+ =    (source
+ =     (origin
+ =       (method url-fetch)
+ =       (uri (string-append "https://alpha.gnu.org/gnu/smalltalk/smalltalk-"
+ =             &n= bsp;           &nbs= p; version ".tar.xz"))
+ =       (sha256
+ =        (base32 = "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0"))))))
+
+;;; This version from the main development = branch can be built with passing
+;;; tests
+(define-public smalltalk-next-from-vcs
+ =  (let ((revision "18")
+ =        (commit = "dfe4b5660037c4d178853ee00458a75e51a88563")
+ =        (git-url "git://git.sv.gnu.org/smalltalk.git"))
+ =    (package (inherit smalltalk)
+ =      (name "smalltalk-next-from-vcs")
+      (version (git-version = "3.2.91" revision commit))
+ =      (source (origin
+ =             &n= bsp;  (method git-fetch)
+ =             &n= bsp;  (uri (git-reference
+ =             &n= bsp;        (url git-url)
+ =             &n= bsp;        (commit commit)))
+ =             &n= bsp;  (file-name (git-file-name name version))
+ =             &n= bsp;  (sha256 (base32 = "11dm1qricq7fwn1gfyn9ik7f1axw7l3ivipsh11dywa42pmb5j2r"))))
+=      (native-inputs
+ =       `(("autoconf" ,autoconf)
+         ("automake" = ,automake)
+ =         ("libtool" ,libtool)
+         ("flex" = ,flex)
+ =         ("texinfo" ,texinfo)
+         ("perl" = ,perl)
+ =         ("gettext" = ,gettext-minimal)
+ =         ("libffi" ,libffi)
+         ("libltdl" = ,libltdl)
+ =         ("bison" ,bison)
+ =         ("libsigsegv" = ,libsigsegv)
+ =         ("pkg-config" = ,pkg-config)))
+ =      (arguments
+ =       `(#:phases
+ =         (modify-phases = %standard-phases
+ =           (add-before = 'configure 'fix-libc
+ =             (l= ambda _
+ =             &n= bsp; (let ((libc (assoc-ref %build-inputs "libc")))
+ =             &n= bsp;   (substitute* "libc.la.in"
+ =             &n= bsp;     (("@LIBC_SO_NAME@") "libc.so")
+ =             &n= bsp;     (("@LIBC_SO_DIR@") =  (string-append libc "/lib"))))
+ =             &n= bsp; #t))))))))
+
--
2.28.0



= --Apple-Mail=_FEE3DF9E-73C1-4B4F-B871-EAA8BAB6FCB9-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 05 09:30:23 2020 Received: (at 42771) by debbugs.gnu.org; 5 Dec 2020 14:30:23 +0000 Received: from localhost ([127.0.0.1]:46831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jz-WA for submit@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jY-7q for 42771@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46215) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klYZi-00061e-8J; Sat, 05 Dec 2020 09:30:16 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58398 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klYZh-0000Jq-4I; Sat, 05 Dec 2020 09:30:13 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Holger Peters Subject: Re: bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 05 Dec 2020 15:30:11 +0100 In-Reply-To: <20201129084328.545720-1-holger.peters@posteo.de> (Holger Peters's message of "Sun, 29 Nov 2020 09:43:28 +0100") Message-ID: <87mtys72bw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Holger, Holger Peters skribis: > * gnu/packages/smalltalk.scm (smalltalk): disable tests > (smalltalk-next): New variable. > (smalltalk-next-from-vcs): New variable. I have mostly two comments, as discussed on IRC (restating them here for those following along): 1. Instead of disabling tests wholesale, what we usually do is (1) investigate why the test is failing (I think it=E2=80=99s a single test failure here), (2) try to determine whether it=E2=80=99s serious or no= t, (3) see if we can work around it with reasonable effort, and if not, skip just this test. 2. I think we should just have =E2=80=98smalltalk=E2=80=99 (latest releas= e) and =E2=80=98smalltalk-next=E2=80=99 (VCS snapshot). Having an extra pack= age for the release candidate is not really useful IMO, and not something we generally do. HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 06:43:19 2020 Received: (at 42771) by debbugs.gnu.org; 28 Dec 2020 11:43:19 +0000 Received: from localhost ([127.0.0.1]:34429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktqvf-00006o-QK for submit@debbugs.gnu.org; Mon, 28 Dec 2020 06:43:19 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:33052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktqvb-00006D-Gr for 42771@debbugs.gnu.org; Mon, 28 Dec 2020 06:43:10 -0500 Received: by mail-wr1-f47.google.com with SMTP id t30so11120418wrb.0 for <42771@debbugs.gnu.org>; Mon, 28 Dec 2020 03:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=G+6deA5gc/Hwuu6TOMi/OBGGtZxUwHSMIlbUwgZVOPg=; b=XlAWhhjQieIChGGJBWyj+KIW+lRcIwgmixgdB9F9uif3FjP+K68IQBktx22aJ8Xg9a C6+6BVcgfEB63MPz5Ki8h1ZIR/0ZA2j+3rWMBf1usp+cXO1v8kXJ+DxQ8v7MmN6Zvfe0 NxvL9ibXC+wSuh06+m27N3GscM+/mUVJM4Im1tYJK1gNqHkGk/AGadycmHeoaDXktZIk kmCn9p+AsDOav6joouW6XFwGSmaRJWDX0xchGxHe0pn7XZKBXsZN0rnXNe8OPbnNq2Eq EYptjLeXMnt8zH/kPCcT+CVtzrQtLGl5KDY8nP8REtimnqubmTA5NyCW6fcGZUMPQTAf WC0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=G+6deA5gc/Hwuu6TOMi/OBGGtZxUwHSMIlbUwgZVOPg=; b=SlrA4vMh1zSk3akZ23WINNHIe49L3Exl+5m/Eksf39anEtv3zgWmAVZVVIB9NJ3N4K aX0xjn842by2gC7J9ghOwRXjn2qj0QOPEQoeLdFAHNOEAUFwSgtO8nFpGDwmLOBM+aqB k5JKHXp59NPdSzKnuuCwcqkdoHNuvpzoVCVOtukASWwVp6V3hTW3w6eV2oWXHW6961ok dTG0YCSVyE64QPCk+zSDVbSEjkXWsH88MjOLaWLkbCmV8IZa1GO2nluHOoGizwsY8jg9 WKeIPDZFbwG7TJeS6OsTRjNcLeqJe3OHAUXyOlddZHrEZY6yntPC4XULcw1A8yJ6FeE1 UOPg== X-Gm-Message-State: AOAM5301nKfwYvUBF3pv7zr2bL2IvGFljZcf8I4BteDyIcEa5Th2wsk0 g7n9idHF+YuCOEUFZDfkOEBw6ZFEXxI= X-Google-Smtp-Source: ABdhPJzP0SIniCyAUtUlgefL1z5qugL4oRim/tA71Nu4F/ceQPNkR1d0mrqrEsSXLJ4CYOp/0plBgA== X-Received: by 2002:a5d:6682:: with SMTP id l2mr50131497wru.213.1609155781570; Mon, 28 Dec 2020 03:43:01 -0800 (PST) Received: from unfall (36.193.158.146.dynamic.jazztel.es. [146.158.193.36]) by smtp.gmail.com with ESMTPSA id s20sm18428440wmj.46.2020.12.28.03.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 03:43:00 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#42771: smalltalk fails to build References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> <87mtys72bw.fsf@gnu.org> Date: Mon, 28 Dec 2020 12:42:56 +0100 In-Reply-To: <87mtys72bw.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 05 Dec 2020 15:30:11 +0100") Message-ID: <877dp240n3.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I've been investigating just a bit about this. Ludovic Court=C3=A8s writes: > (1) investigate why the test is failing (I think it=E2=80=99s a single te= st > failure here), Currently there are two main problems with 3.2.5: - Integer multiplication overflow handling invokes undefined behavior, which is "cleaned up" by the compiler. This is why [ 100 fact / 99 fact ] returns 0, and it's solved with the first patch---trimmed down from the upstream patch, to avoid conflicts. - ANSI test suite fails with errors like these: ----------------------------------8<----------------------------------- --- /dev/null 2020-12-24 20:38:33.836725540 +0000 +++ /tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/tests/testsuite.d= ir/at-groups/47/stderr 2020-12-28 09:25:57.283891452 +0000 @@ -0,0 +1,13 @@ +gst: Aborted +gst: Error occurred while not in byte code interpreter!! +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/libgst/.libs/libgst.= so.7(+0x72d97)[0x7ffff7f5ed97] +/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/libc.so.6(+0x36= b20)[0x7ffff7b3bb20] +/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/libc.so.6(gsign= al+0xca)[0x7ffff7b3baba] +/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/libc.so.6(abort= +0x165)[0x7ffff7b3cbf5] +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/libgst/.libs/libgst.= so.7(+0x2c936)[0x7ffff7f18936] +/gnu/store/yrwirrblml57nwga1aza6rg3l9s8qga0-libsigsegv-2.12/lib/libsigsegv= .so.2(+0x128c)[0x7ffff7ee728c] +/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/lib/libc.so.6(+0x36= b20)[0x7ffff7b3bb20] +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/libgst/.libs/libgst.= so.7(+0x569f0)[0x7ffff7f429f0] +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/libgst/.libs/libgst.= so.7(+0x72919)[0x7ffff7f5e919] +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/libgst/.libs/libgst.= so.7(+0x2e4c7)[0x7ffff7f1a4c7] +/tmp/guix-build-smalltalk-3.2.5.drv-0/smalltalk-3.2.5/tests/testsuite.dir/= at-groups/47/test-source: line 20: 21205 Aborted $TIMEOUT g= st $image_path -f $abs_srcdir/AnsiRun.st ArrayANSITest stdout: ./testsuite.at:83: exit code was 134, expected 0 47. testsuite.at:83: 47. ArrayANSITest (testsuite.at:83): FAILED (testsuite= .at:83) ---------------------------------->8----------------------------------- > (2) try to determine whether it=E2=80=99s serious or not, The first one is pretty serious. The second one might as bad as the first one or may be a flaw on the tests and could be omitted. > (3) see if we can work around it with reasonable effort, and if > not, skip just this test. This only should be the case when the problem is on the test side: either it's using something we don't want to provide, as side channels, or the check itself is buggy; never when the test is working properly because we would be delivering buggy software after we have been warned about it. I cannot spot where the second error was fixed, but 3.2.91 as provided with the second patch doesn't manifest it. > 2. I think we should just have =E2=80=98smalltalk=E2=80=99 (latest rele= ase) and > =E2=80=98smalltalk-next=E2=80=99 (VCS snapshot). Having an extra pa= ckage for the > release candidate is not really useful IMO, and not something we > generally do. The last change made to GNU Smalltalk's master branch was more than 2 years ago, the latest change affecting executable paths was February 2017. IMHO, providing a patched release candidate (or even the snapshot) seems the best option until the project release a new version, as in fact we aren't providing currently a useful package. Happy hacking! Miguel PS: Its build isn't reproducible: - gst.im has inside some kind of timestamp. This probably needs changes on the source code. - package.xml and kernel/ folders contain different timestamps inside dot-star files---a wrapper to zip or something like reset-gzip-timestamps could solve this issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-smalltalk-Fix-integer-multiplication-overflow.patch Content-Description: fix-integer.patch >From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?= Date: Mon, 28 Dec 2020 10:36:48 +0100 Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow. * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch from upstream commit 72ada189aba0283c551ead16635c1983968080b8. * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp and lightning libraries instead of the included source. --- .../smalltalk-multiplication-overflow.patch | 121 ++++++++++++++++++ gnu/packages/smalltalk.scm | 43 ++++++- 2 files changed, 159 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/patches/smalltalk-multiplication-overflow.patch diff --git a/gnu/packages/patches/smalltalk-multiplication-overflow.patch b/gnu/packages/patches/smalltalk-multiplication-overflow.patch new file mode 100644 index 0000000000..7a0b4d02f7 --- /dev/null +++ b/gnu/packages/patches/smalltalk-multiplication-overflow.patch @@ -0,0 +1,121 @@ +Extracted from this commit without the ChangeLog to avoid conflicts: +http://git.savannah.gnu.org/cgit/smalltalk.git/commit/?id=72ada189aba0283c551ead16635c1983968080b8 + +The upstream commit message is +From 72ada189aba0283c551ead16635c1983968080b8 Mon Sep 17 00:00:00 2001 +From: Holger Hans Peter Freyther +Date: Sat, 7 Nov 2015 18:09:31 +0100 +Subject: libgst: Add alternative multiplication overflow check + +Apple clang on OSX and the version on FreeBSD optimize the +multiplication check away. Clang introduced a family of +builtins to do the multiplication and check for the overflow +and GCC made the API usable. For clang we would need to know +if intptr_t is of type int, long int, long long int and +then use the smul, smull smulll. +Luckily clang is adopting the better interface and this is +what we are starting to use now. This means the new code +will be used on GCC5 (and later) and some future versions of +clang. + +2015-11-07 Holger Hans Peter Freyther + + * build-aux/overflow-builtins.m4: Add new macro. + * configure.ac: Use GST_C_OVERFLOW_BUILTINS macro. + +2015-11-07 Holger Hans Peter Freyther + + * interp.inl: Add alternative mul_with_check implementation. +--- + ChangeLog | 5 +++++ + build-aux/overflow-builtins.m4 | 23 +++++++++++++++++++++++ + configure.ac | 1 + + libgst/ChangeLog | 4 ++++ + libgst/interp.inl | 22 ++++++++++++++++++++++ + 5 files changed, 55 insertions(+) + create mode 100644 build-aux/overflow-builtins.m4 + +diff --git a/build-aux/overflow-builtins.m4 b/build-aux/overflow-builtins.m4 +new file mode 100644 +index 00000000..9d050196 +--- /dev/null ++++ b/build-aux/overflow-builtins.m4 +@@ -0,0 +1,23 @@ ++dnl Check whether the host supports synchronization builtins. ++ ++AC_DEFUN([GST_C_OVERFLOW_BUILTINS], [ ++ AC_REQUIRE([AC_CANONICAL_HOST]) ++ AC_CACHE_CHECK([whether the host supports __builtin_mul_overflow], ++ gst_cv_have_builtin_mul_overflow, [ ++ save_CFLAGS="$CFLAGS" ++ case $host in ++ i?86-apple-darwin*) ;; ++ i?86-*-*) CFLAGS="$CFLAGS -march=i486" ;; ++ esac ++ AC_LINK_IFELSE([AC_LANG_PROGRAM([[int foovar = 0;]], [[ ++if (__builtin_mul_overflow(44444, 55555, &foovar)) ++ return 23;]])], ++ [gst_cv_have_builtin_mul_overflow=yes], ++ [gst_cv_have_builtin_mul_overflow=no]) ++ CFLAGS="$save_CFLAGS" ++ ]) ++ if test $gst_cv_have_builtin_mul_overflow = yes; then ++ AC_DEFINE(HAVE_OVERFLOW_BUILTINS, 1, ++ [Define to 1 if the host supports __builtin_*_overflow builtins]) ++ fi ++]) +diff --git a/configure.ac b/configure.ac +index e789be45..0bac23ef 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -243,6 +243,7 @@ GST_C_SYNC_BUILTINS + if test $gst_cv_have_sync_fetch_and_add = no; then + AC_MSG_ERROR([Synchronization primitives not found, please use a newer compiler.]) + fi ++GST_C_OVERFLOW_BUILTINS + + GST_LOCK + AC_SYS_LARGEFILE +diff --git a/libgst/interp.inl b/libgst/interp.inl +index e18e27c7..dbc631bc 100644 +--- a/libgst/interp.inl ++++ b/libgst/interp.inl +@@ -159,6 +159,27 @@ sub_with_check (OOP op1, OOP op2, mst_Boolean *overflow) + OOP + mul_with_check (OOP op1, OOP op2, mst_Boolean *overflow) + { ++#ifdef HAVE_OVERFLOW_BUILTINS ++ intptr_t a = TO_INT (op1); ++ intptr_t b = TO_INT (op2); ++ intptr_t result; ++ ++ if (__builtin_mul_overflow(a, b, &result)) ++ { ++ *overflow = true; ++ return FROM_INT(0); ++ } ++ ++ ++ if (result < MIN_ST_INT || result > MAX_ST_INT) ++ { ++ *overflow = true; ++ return FROM_INT(0); ++ } ++ ++ *overflow = false; ++ return FROM_INT(result); ++#else + intptr_t a = TO_INT (op1); + intptr_t b = TO_INT (op2); + intmax_t result = (intmax_t)a * b; +@@ -188,6 +209,7 @@ mul_with_check (OOP op1, OOP op2, mst_Boolean *overflow) + } + + return FROM_INT (0); ++#endif + } + + /* State of the random generator. +-- +2.29.2 + diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm index 5d35f563e2..8c152cfd04 100644 --- a/gnu/packages/smalltalk.scm +++ b/gnu/packages/smalltalk.scm @@ -26,6 +26,8 @@ #:use-module (guix download) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) + #:use-module (gnu packages) + #:use-module (gnu packages assembly) #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages base) @@ -36,6 +38,7 @@ #:use-module (gnu packages libffi) #:use-module (gnu packages libsigsegv) #:use-module (gnu packages linux) + #:use-module (gnu packages multiprecision) #:use-module (gnu packages pkg-config) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages xorg)) @@ -51,18 +54,48 @@ version ".tar.xz")) (sha256 (base32 - "1k2ssrapfzhngc7bg1zrnd9n2vyxp9c9m70byvsma6wapbvib6l1")))) + "1k2ssrapfzhngc7bg1zrnd9n2vyxp9c9m70byvsma6wapbvib6l1")) + ;; XXX: To be removed with the next release of Smalltalk. + (patches (search-patches "smalltalk-multiplication-overflow.patch")))) (build-system gnu-build-system) (native-inputs - `(("libffi" ,libffi) + `(("pkg-config" ,pkg-config) + ;; XXX: To be removed with the next release of Smalltalk. + ("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool))) + ;; XXX: Missing optional dependencies: + ;; - glib + ;; - gtk+-2 + ;; - mesa + ;; - SDL + ;; - sqlite + ;; - zlib + (inputs + `(("gmp" ,gmp) + ("libffi" ,libffi) ("libltdl" ,libltdl) ("libsigsegv" ,libsigsegv) - ("pkg-config" ,pkg-config))) - (inputs - `(("zip" ,zip))) + ("lightning" ,lightning) + ("zip" ,zip))) (arguments `(#:phases (modify-phases %standard-phases + ;; XXX: To be removed with the next release of Smalltalk. + ;; The overflow patch modifies configure.ac, therefore remove + ;; old configure script and enforce an autoreconf. + (add-before 'bootstrap 'remove-unpatched-configure + (lambda _ + (delete-file "configure") + #t)) + ;; XXX: To be removed with the next release of Smalltalk. + ;; We don't want to regenerate the info files. + (add-after 'build 'keep-generated-info-manual + (lambda _ + (for-each (lambda (file) + (invoke "touch" file)) + (find-files "doc" "\\.info")) + #t)) (add-before 'configure 'fix-libc (lambda _ (let ((libc (assoc-ref %build-inputs "libc"))) -- 2.29.2 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-gnu-smalltalk-Update-to-version-3.2.91.patch Content-Description: update-to-91.patch >From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?= Date: Mon, 28 Dec 2020 11:42:31 +0100 Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91. * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91. Co-Authored-By: Holger Peters --- gnu/packages/smalltalk.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/smalltalk.scm b/gnu/packages/smalltalk.scm index 8c152cfd04..c7c56f87b4 100644 --- a/gnu/packages/smalltalk.scm +++ b/gnu/packages/smalltalk.scm @@ -46,15 +46,15 @@ (define-public smalltalk (package (name "smalltalk") - (version "3.2.5") + (version "3.2.91") (source (origin (method url-fetch) - (uri (string-append "mirror://gnu/smalltalk/smalltalk-" + (uri (string-append "https://alpha.gnu.org/gnu/smalltalk/smalltalk-" version ".tar.xz")) (sha256 (base32 - "1k2ssrapfzhngc7bg1zrnd9n2vyxp9c9m70byvsma6wapbvib6l1")) + "1zb2h5cbz1cwybqjl24lflw359lwj7sjvvhwb4x6miypzhwq4qh0")) ;; XXX: To be removed with the next release of Smalltalk. (patches (search-patches "smalltalk-multiplication-overflow.patch")))) (build-system gnu-build-system) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 03 10:34:27 2021 Received: (at 42771) by debbugs.gnu.org; 3 Jan 2021 15:34:27 +0000 Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw5Ok-0004if-FJ for submit@debbugs.gnu.org; Sun, 03 Jan 2021 10:34:26 -0500 Received: from mout02.posteo.de ([185.67.36.66]:40931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kw5Oi-0004iS-Lf for 42771@debbugs.gnu.org; Sun, 03 Jan 2021 10:34:25 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 6B8BA240100 for <42771@debbugs.gnu.org>; Sun, 3 Jan 2021 16:34:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1609688058; bh=Ds3mBeZD/U5NoL77HtlC5ReWh69AE409Ml+FTKY+KEs=; h=Subject:From:To:Cc:Date:From; b=mSxEIQV/ErPt2HaY3k9o4nYmeKGmAu1gA91AedlvSDtkrOpB6kUuFWvIrUPQtD17T HHW1TIFh6Rm50pQwz5FhIBLxB/av2UMQxRmsvvpdLd5TOyjYVbCaykAGZPh3nDrSSb AiJB9ZWv873XIQ3xOqVd5AMnApp/YDteXPZD+2zxp4hoGKPsL932iGqKzpIvWLimK3 kDkVX8EFuzNN1XpzP14ibMp0TcPkUbe4AqbZR3SaJHZxLD+6tg+2VVx9tlQgR0AEMW 3t+h54mqZmHm2pjyN5fAIFuufWTYrcc/P6yIH9Phxf0XocvybrIiVfGKQdvSISCEYr 2e0FuI2jhhiMg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4D82qY2x62z9rxG; Sun, 3 Jan 2021 16:34:16 +0100 (CET) Message-ID: <93bb20f770baa66f25b1f0839794b5d4faac96c6.camel@posteo.de> Subject: Re: bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases From: Holger Peters To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Sun, 03 Jan 2021 16:34:10 +0100 In-Reply-To: <87mtys72bw.fsf@gnu.org> References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> <87mtys72bw.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VG4aOaDO19cv9fUDC0gq" User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42771 Cc: mike@rohleder.de, 42771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-VG4aOaDO19cv9fUDC0gq Content-Type: multipart/mixed; boundary="=-RdpzTLAPebI1Yrpo0u05" --=-RdpzTLAPebI1Yrpo0u05 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I am not sure I will have the time to solve the remaining issues, but I would like to share some intermediate results with you. Find attached the smalltalk file I have in my personal channel, it contains 2 package definitions. smalltalk-alt: corresponds to the `normal' smalltalk package with various fixes over the one currently in gui (a) added dependencies, (b) uses gcc-5 for building because I found a reference in the smalltalk mailing list about newer GCC releases optimizing some statements away that are crucial for GNU Smalltalk to build. As a result the test failures for intmath and others that are present in the current `smalltalk' recipe in guix are resolved in this variant. Note that there are still failing tests for this release, namely all the ANSI compliancy tests. I do feel like since each and every one of these tests fails, it might be a build-system-setup/autotest related failure. `smalltalk-next' is a derived clean build from the VCS. I dropped the pre-release build as you suggested in (2). As for going forward I am not quite sure whether I'll find time to do more debugging. If I were a heavy GNU Smalltalk user I'd probably use `smalltalk-next' anyway as it seems to build flawlessly. -- Failing Tests for `smalltalk-alt' ANSI compliancy tests. 47: ArrayANSITest FAILED (testsuite.at:83) 48: ArrayFactoryANSITest FAILED (testsuite.at:84) 49: BagANSITest FAILED (testsuite.at:85) 50: BagFactoryANSITest FAILED (testsuite.at:86) 51: BooleanANSITest FAILED (testsuite.at:87) 52: ByteArrayANSITest FAILED (testsuite.at:88) 53: ByteArrayFactoryANSITest FAILED (testsuite.at:89) 54: CharacterANSITest FAILED (testsuite.at:90) 55: CharacterFactoryANSITest FAILED (testsuite.at:91) 56: DateAndTimeANSITest FAILED (testsuite.at:92) 57: DateAndTimeFactoryANSITest FAILED (testsuite.at:93) 58: DictionaryANSITest FAILED (testsuite.at:94) 59: DictionaryFactoryANSITest FAILED (testsuite.at:95) 60: DurationANSITest FAILED (testsuite.at:96) 61: DurationFactoryANSITest FAILED (testsuite.at:97) 62: DyadicValuableANSITest FAILED (testsuite.at:98) 63: ErrorANSITest FAILED (testsuite.at:99) 64: ErrorClassANSITest FAILED (testsuite.at:100) 65: ExceptionANSITest FAILED (testsuite.at:101) 66: ExceptionClassANSITest FAILED (testsuite.at:102) 67: ExceptionSetANSITest FAILED (testsuite.at:103) 68: FailedMessageANSITest FAILED (testsuite.at:104) 69: FileStreamFactoryANSITest FAILED (testsuite.at:105) 70: FloatANSITest FAILED (testsuite.at:106) 71: FloatCharacterizationANSITest FAILED (testsuite.at:107) 72: FractionANSITest FAILED (testsuite.at:108) 73: FractionFactoryANSITest FAILED (testsuite.at:109) 74: IdentityDictionaryANSITest FAILED (testsuite.at:110) 75: IdentityDictionaryFactoryANSITest FAILED (testsuite.at:111) 76: IntegerANSITest FAILED (testsuite.at:112) 77: IntervalANSITest FAILED (testsuite.at:113) 78: IntervalFactoryANSITest FAILED (testsuite.at:114) 79: MessageNotUnderstoodANSITest FAILED (testsuite.at:115) 80: MessageNotUnderstoodSelectorANSITest FAILED (testsuite.at:116) 81: MonadicBlockANSITest FAILED (testsuite.at:117) 82: NilANSITest FAILED (testsuite.at:118) 83: NiladicBlockANSITest FAILED (testsuite.at:119) 84: NotificationANSITest FAILED (testsuite.at:120) 85: NotificationClassANSITest FAILED (testsuite.at:121) 86: ObjectANSITest FAILED (testsuite.at:122) 87: ObjectClassANSITest FAILED (testsuite.at:123) 88: OrderedCollectionANSITest FAILED (testsuite.at:124) 89: OrderedCollectionFactoryANSITest FAILED (testsuite.at:125) 90: ReadFileStreamANSITest FAILED (testsuite.at:126) 91: ReadStreamANSITest FAILED (testsuite.at:127) 92: ReadStreamFactoryANSITest FAILED (testsuite.at:128) 93: ReadWriteStreamANSITest FAILED (testsuite.at:129) 94: ReadWriteStreamFactoryANSITest FAILED (testsuite.at:130) 95: ScaledDecimalANSITest FAILED (testsuite.at:131) 96: SelectorANSITest FAILED (testsuite.at:132) 97: SetANSITest FAILED (testsuite.at:133) 98: SetFactoryANSITest FAILED (testsuite.at:134) 99: SortedCollectionANSITest FAILED (testsuite.at:135) 100: SortedCollectionFactoryANSITest FAILED (testsuite.at:136) 101: StringANSITest FAILED (testsuite.at:137) 102: StringFactoryANSITest FAILED (testsuite.at:138) 103: SymbolANSITest FAILED (testsuite.at:139) 104: TranscriptANSITest FAILED (testsuite.at:140) 105: WarningANSITest FAILED (testsuite.at:141) 106: WarningClassANSITest FAILED (testsuite.at:142) 107: WriteFileStreamANSITest FAILED (testsuite.at:143) 108: WriteStreamANSITest FAILED (testsuite.at:144) 109: WriteStreamFactoryANSITest FAILED (testsuite.at:145) 110: ZeroDivideANSITest FAILED (testsuite.at:146) 111: ZeroDivideFactoryANSITest FAILED (testsuite.at:147) On Sat, 2020-12-05 at 15:30 +0100, Ludovic Court=C3=A8s wrote: > Hi Holger, >=20 > Holger Peters skribis: >=20 > > * gnu/packages/smalltalk.scm (smalltalk): disable tests > > (smalltalk-next): New variable. > > (smalltalk-next-from-vcs): New variable. >=20 > I have mostly two comments, as discussed on IRC (restating them here > for > those following along): >=20 > =C2=A0 1. Instead of disabling tests wholesale, what we usually do is (1) > =C2=A0=C2=A0=C2=A0=C2=A0 investigate why the test is failing (I think it= =E2=80=99s a single test > =C2=A0=C2=A0=C2=A0=C2=A0 failure here), (2) try to determine whether it= =E2=80=99s serious or not, > =C2=A0=C2=A0=C2=A0=C2=A0 (3) see if we can work around it with reasonable= effort, and if > =C2=A0=C2=A0=C2=A0=C2=A0 not, skip just this test. >=20 > =C2=A0 2. I think we should just have =E2=80=98smalltalk=E2=80=99 (latest= release) and > =C2=A0=C2=A0=C2=A0=C2=A0 =E2=80=98smalltalk-next=E2=80=99 (VCS snapshot).= =C2=A0 Having an extra package for=20 > the release candidate is not really useful IMO, and not something we > =C2=A0=C2=A0=C2=A0=C2=A0 generally do. --=-RdpzTLAPebI1Yrpo0u05 Content-Disposition: attachment; filename="smalltalk.scm" Content-Type: text/x-scheme; name="smalltalk.scm"; charset="UTF-8" Content-Transfer-Encoding: base64 CihkZWZpbmUtbW9kdWxlICh5YXMgcGFja2FnZXMgc21hbGx0YWxrKQogICM6dXNlLW1vZHVsZSAo KGd1aXggbGljZW5zZXMpICM6cHJlZml4IGxpY2Vuc2U6KQogICM6dXNlLW1vZHVsZSAoZ3VpeCBw YWNrYWdlcykKICAjOnVzZS1tb2R1bGUgKGd1aXggZG93bmxvYWQpCiAgIzp1c2UtbW9kdWxlIChn dWl4IGdpdC1kb3dubG9hZCkKICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGNtYWtl KQogICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gZ251KQogICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGF1ZGlvKQogICM6dXNl LW1vZHVsZSAoZ251IHBhY2thZ2VzIGF1dG90b29scykKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBiYXNlKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGJpc29uKQogICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIGNvbXByZXNzaW9uKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIGVtYWNzKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGZsZXgpCiAgIzp1c2UtbW9k dWxlIChnbnUgcGFja2FnZXMgZm9udHV0aWxzKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2Vz IGdjYykKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnZXR0ZXh0KQogICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGdsKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsaWIpCiAg Izp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ3RrKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIGxpYmZmaSkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBsaWJzaWdzZWd2KQogICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGxpbnV4KQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIG5jdXJzZXMpCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcGVybCkKICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHB1bHNlYXVkaW8pCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGV4aW5mbykKICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB0bHMpCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgeG9yZykpCgoKCihkZWZpbmUtcHVibGljIHNtYWxsdGFsay1hbHQKICAocGFja2FnZQogICAg KG5hbWUgInNtYWxsdGFsay1hbHQiKQogICAgKHZlcnNpb24gIjMuMi41IikKICAgIChzb3VyY2UK ICAgICAob3JpZ2luCiAgICAgIChtZXRob2QgdXJsLWZldGNoKQogICAgICAodXJpIChzdHJpbmct YXBwZW5kICJtaXJyb3I6Ly9nbnUvc21hbGx0YWxrL3NtYWxsdGFsay0iCiAgICAgICAgICAgICAg ICAgICAgICAgICAgdmVyc2lvbiAiLnRhci54eiIpKQogICAgICAoc2hhMjU2CiAgICAgICAoYmFz ZTMyCiAgICAgICAgIjFrMnNzcmFwZnpobmdjN2JnMXpybmQ5bjJ2eXhwOWM5bTcwYnl2c21hNndh cGJ2aWI2bDEiKSkpKQoKICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgIChu YXRpdmUtaW5wdXRzCiAgICAgYCgoImdjY0A1IiAsZ2NjLTUpCiAgICAgICAoImxpYnRvb2wiICxs aWJ0b29sKQogICAgICAgKCJwZXJsIiAscGVybCkKICAgICAgICgiZ2V0dGV4dCIgLGdldHRleHQt bWluaW1hbCkKICAgICAgICgibGliZmZpIiAsbGliZmZpKQogICAgICAgKCJsaWJsdGRsIiAsbGli bHRkbCkKICAgICAgICgibGlic2lnc2VndiIgLGxpYnNpZ3NlZ3YpCiAgICAgICAoInBrZy1jb25m aWciICxwa2ctY29uZmlnKSkpCiAgICAoaW5wdXRzCiAgICAgYCgoImVtYWNzIiAsZW1hY3MpCiAg ICAgICAoImdsaWIiICxnbGliKQogICAgICAgKCJndGsrIiAsZ3RrKy0yKQogICAgICAgKCJnbnV0 bHMiICxnbnV0bHMpCiAgICAgICAoIm5jdXJzZXMiICxuY3Vyc2VzKQogICAgICAgKCJ6aXAiICx6 aXApCiAgICAgICAoInpsaWIiICx6bGliKSkpCiAgICAoYXJndW1lbnRzCiAgICAgYCgjOnBoYXNl cwogICAgICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwogICAgICAgICAoYWRkLWJl Zm9yZSAnY29uZmlndXJlICdmaXgtbGliYwogICAgICAgICAgIChsYW1iZGEgXwogICAgICAgICAg ICAgKGxldCAoKGxpYmMgKGFzc29jLXJlZiAlYnVpbGQtaW5wdXRzICJsaWJjIikpKQogICAgICAg ICAgICAgICAoc3Vic3RpdHV0ZSogImxpYmMubGEuaW4iCiAgICAgICAgICAgICAgICAgKCgiQExJ QkNfU09fTkFNRUAiKSAibGliYy5zbyIpCiAgICAgICAgICAgICAgICAgKCgiQExJQkNfU09fRElS QCIpICAoc3RyaW5nLWFwcGVuZCBsaWJjICIvbGliIikpKSkKICAgICAgICAgICAgICN0KSkpKSkK ICAgIChob21lLXBhZ2UgImh0dHA6Ly9zbWFsbHRhbGsuZ251Lm9yZy8iKQogICAgKHN5bm9wc2lz ICJTbWFsbHRhbGsgZW52aXJvbm1lbnQiKQogICAgKGRlc2NyaXB0aW9uCiAgICAgIkdOVSBTbWFs bHRhbGsgaXMgYSBmcmVlIGltcGxlbWVudGF0aW9uIG9mIHRoZSBTbWFsbHRhbGsgbGFuZ3VhZ2Uu ICBJdAppbXBsZW1lbnRzIHRoZSBBTlNJIHN0YW5kYXJkIGZvciB0aGUgbGFuZ3VhZ2UgYW5kIGFs c28gaW5jbHVkZXMgZXh0cmEgY2xhc3NlcwpzdWNoIGFzIG9uZXMgZm9yIG5ldHdvcmtpbmcgYW5k IEdVSSBwcm9ncmFtbWluZy4iKQogICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykpKQoKKGRlZmlu ZS1wdWJsaWMgc21hbGx0YWxrLW5leHQKICAobGV0ICgocmV2aXNpb24gIjE4IikKICAgICAgICAo Y29tbWl0ICJkZmU0YjU2NjAwMzdjNGQxNzg4NTNlZTAwNDU4YTc1ZTUxYTg4NTYzIikKICAgICAg ICAoZ2l0LXVybCAiZ2l0Oi8vZ2l0LnN2LmdudS5vcmcvc21hbGx0YWxrLmdpdCIpKQogICAgKHBh Y2thZ2UgKGluaGVyaXQgc21hbGx0YWxrLWFsdCkKICAgICAgKG5hbWUgInNtYWxsdGFsay1uZXh0 IikKICAgICAgKHZlcnNpb24gKGdpdC12ZXJzaW9uICIzLjIuOTEiIHJldmlzaW9uIGNvbW1pdCkp CiAgICAgIChzb3VyY2UgKG9yaWdpbgogICAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gp CiAgICAgICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCiAgICAgICAgICAgICAgICAgICAg ICAodXJsIGdpdC11cmwpCiAgICAgICAgICAgICAgICAgICAgICAoY29tbWl0IGNvbW1pdCkpKQog ICAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQog ICAgICAgICAgICAgICAgKHNoYTI1NiAoYmFzZTMyICIxMWRtMXFyaWNxN2Z3bjFnZnluOWlrN2Yx YXh3N2wzaXZpcHNoMTFkeXdhNDJwbWI1ajJyIikpKSkKICAgICAgKG5hdGl2ZS1pbnB1dHMKICAg ICAgIGAoKCJhdXRvY29uZiIgLGF1dG9jb25mKQogICAgICAgICAoImF1dG9tYWtlIiAsYXV0b21h a2UpCiAgICAgICAgICgibGlidG9vbCIgLGxpYnRvb2wpCiAgICAgICAgICgiZmxleCIgLGZsZXgp CiAgICAgICAgICgidGV4aW5mbyIgLHRleGluZm8pCiAgICAgICAgICgicGVybCIgLHBlcmwpCiAg ICAgICAgICgiZ2V0dGV4dCIgLGdldHRleHQtbWluaW1hbCkKICAgICAgICAgKCJsaWJmZmkiICxs aWJmZmkpCiAgICAgICAgICgibGlibHRkbCIgLGxpYmx0ZGwpCiAgICAgICAgICgiYmlzb24iICxi aXNvbikKICAgICAgICAgKCJsaWJzaWdzZWd2IiAsbGlic2lnc2VndikKICAgICAgICAgKCJwa2ct Y29uZmlnIiAscGtnLWNvbmZpZykpKSkpKQo= --=-RdpzTLAPebI1Yrpo0u05-- --=-VG4aOaDO19cv9fUDC0gq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQHMBAABCgA2FiEEnW3FwBvfXG9gL3NLOZFJfLITP6cFAl/x4/IYHGhvbGdlci5w ZXRlcnNAcG9zdGVvLmRlAAoJEDmRSXyyEz+nLnsMAKVR5POvupF3BGth0dQQ4ocs Lzf+lkzbHzplB8220nA0WFNXxOpmiHe+O/TPjxYPN61x1R0UAbhgMb1erqodjqDM u/j3x2H+jlFlUi1pgdW6CcJSuRYvDiH5iyXVzjsiGKGNU9l1IAroMQc61gUa159C zB/glNc3m2fWDqV5tQuYf2+PalwWjJuOXzZpMJ9BxJ5c/vntsybgYOGBC/Hkxlgn u2jgPI+55S07B9j8JCUxUzULUfk2TvN4YS6JyOmEUxiXk27YzZo89l+XG76lH3Yx 3wp4MVbyZE20dAwF+gqL+NLMeKuqymUPgE9MAcGRr7jA/MmBspLWLUYuaZ2iymAs 8HQk31N5fAqn6s3jrhRr0aV+7fqyc4T+u8cKXkpQZQ7hltZ++/pvOj67/DRnQ65d /+iA4wN0TiacyGjYKkjxAIWek39beDxZVSiI89mqQDpGRayiDTEhltBKyO/xyhky gmhjj7JTu+j6nyFPCbGkEbveWisInT0ECc33u5iDpg== =wh6E -----END PGP SIGNATURE----- --=-VG4aOaDO19cv9fUDC0gq-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 04:28:45 2021 Received: (at 42771) by debbugs.gnu.org; 4 Jan 2021 09:28:45 +0000 Received: from localhost ([127.0.0.1]:53610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMAP-0001MP-AL for submit@debbugs.gnu.org; Mon, 04 Jan 2021 04:28:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMAM-0001M6-Tl for 42771@debbugs.gnu.org; Mon, 04 Jan 2021 04:28:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59460) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwMAH-0007B1-MX; Mon, 04 Jan 2021 04:28:37 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35460 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwMAG-0007IR-IA; Mon, 04 Jan 2021 04:28:37 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas Subject: Re: bug#42771: smalltalk fails to build References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> <87mtys72bw.fsf@gnu.org> <877dp240n3.fsf_-_@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 =?utf-8?Q?Niv=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 04 Jan 2021 10:28:35 +0100 In-Reply-To: <877dp240n3.fsf_-_@gmail.com> ("Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Mon, 28 Dec 2020 12:42:56 +0100") Message-ID: <8735zhyrss.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Miguel, Miguel =C3=81ngel Arruga Vivas skribis: > I've been investigating just a bit about this. Nice! > From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D > > Date: Mon, 28 Dec 2020 10:36:48 +0100 > Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow. > > * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch > from upstream commit 72ada189aba0283c551ead16635c1983968080b8. > * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp > and lightning libraries instead of the included source. > --- > .../smalltalk-multiplication-overflow.patch | 121 ++++++++++++++++++ > gnu/packages/smalltalk.scm | 43 ++++++- Please make sure to add the patch to =E2=80=98gnu/local.mk=E2=80=99 as well= . Otherwise LGTM. > From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D > > Date: Mon, 28 Dec 2020 11:42:31 +0100 > Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91. > > * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91. > > Co-Authored-By: Holger Peters LGTM. Thanks for investigating! We can address the non-reproducibility issues separately. Perhaps you can send your findings to bug-guix so we can keep track of it. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 07:09:26 2021 Received: (at 42771) by debbugs.gnu.org; 5 Jan 2021 12:09:26 +0000 Received: from localhost ([127.0.0.1]:40982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwl9R-0005Bw-SS for submit@debbugs.gnu.org; Tue, 05 Jan 2021 07:09:26 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:50831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwl9P-0005Bg-Vl for 42771@debbugs.gnu.org; Tue, 05 Jan 2021 07:09:24 -0500 Received: by mail-wm1-f51.google.com with SMTP id 190so2825416wmz.0 for <42771@debbugs.gnu.org>; Tue, 05 Jan 2021 04:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=e8ouqNlzT5FLir99Q3o6HPeHUGs0lV4avhxnGcl617Y=; b=Q7qNfETXkbUmi8f4Bo8T931/FF0TgWfrWCF5uEzfIJf64Z76H/PtNAnRBP7hFmV5yQ KtU6gs144HW2jUU/QDKnAn1Yq5Q1u1rt4f3fjJTsTQ0Pq9TQ/R0nuC1r1HzFRhOUzeyD MinUa4sRuL7nbjghwpBA2tcA29xcWXxXxemTPkt3Y6bl69j5WTMMeDdyKyoA5MVqRQRn uQ1cV86wOlTKmDjzz9HYCJiHSzu9ujNlWN5WFY9XVnCDkjZdi35KiCAPaXNBbEVj/jam FUQJ8dpwh/7bB2lu2KBu+ojEn7FTWEaBNuZbKbIWGQAS1LIOS+xgubvjSHUeFpwKfFLt o9Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=e8ouqNlzT5FLir99Q3o6HPeHUGs0lV4avhxnGcl617Y=; b=lyenHtxbt7Nwf54OfcIjUnwsL0AvuLjGzEQPLuUYwoG/I/6tEbSY+9/ZbAspl7+qio Hk9i0eWML8mIc7n7JVqfldSVbrw8HSEcNvYn16eKuzjKkv+BicbZU3qL2T9Keh8hFfwK NQkxhPTOBbyiWEB21NZKU+dDheqMa19/G2VbAAWrFI0a/YsBUJ+b8ksoKZsLIpDhkNnB nLwDYfvasZcdWBpSH8OGepUz5V8a++Q1g1HcZASS7u9t9C9N+58YlM1ooTtJiZ3XIIp/ apFUERjlrIpsdY7Y74FjetYFBjsts4J+Q01707KqMipI4B3Dfc/yJF0h3kMhSw1PsWjJ q5/Q== X-Gm-Message-State: AOAM533cDspsNtD5kAl406YNrUaHwOI31LTLsY5CjoSsVFftR87RM703 +GmN8Pbc7mgwWvKXI9FM0SCuQHwg7tw= X-Google-Smtp-Source: ABdhPJz0KYFFrHX/QXKWesvkTx2AI9a/7Mp2G9xYUym/8Ew4Vqdzfq3w+A2qU7Qw0J6XvfyNr2nhpA== X-Received: by 2002:a1c:1d1:: with SMTP id 200mr3295233wmb.98.1609848557989; Tue, 05 Jan 2021 04:09:17 -0800 (PST) Received: from unfall (36.193.158.146.dynamic.jazztel.es. [146.158.193.36]) by smtp.gmail.com with ESMTPSA id g78sm3899024wme.33.2021.01.05.04.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 04:09:17 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#42771: smalltalk fails to build References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> <87mtys72bw.fsf@gnu.org> <877dp240n3.fsf_-_@gmail.com> <8735zhyrss.fsf@gnu.org> Date: Tue, 05 Jan 2021 13:09:15 +0100 In-Reply-To: <8735zhyrss.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 04 Jan 2021 10:28:35 +0100") Message-ID: <87h7nv37ro.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Bonne ann=C3=A9e, Ludo! Ludovic Court=C3=A8s writes: >> From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D >> >> Date: Mon, 28 Dec 2020 10:36:48 +0100 >> Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow. >> >> * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch >> from upstream commit 72ada189aba0283c551ead16635c1983968080b8. >> * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp >> and lightning libraries instead of the included source. >> --- >> .../smalltalk-multiplication-overflow.patch | 121 ++++++++++++++++++ >> gnu/packages/smalltalk.scm | 43 ++++++- > > Please make sure to add the patch to =E2=80=98gnu/local.mk=E2=80=99 as we= ll. Otherwise > LGTM. Oops, I forgot about that, thank you. I've pushed with this change and some extra comments about optional packages and closure size as e3281657c8 to master. >> From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D >> >> Date: Mon, 28 Dec 2020 11:42:31 +0100 >> Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91. >> >> * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91. >> >> Co-Authored-By: Holger Peters > > LGTM. I've pushed this, together with a comment about reverting to the mirror when a new release be available, as df965a54e1 to master. > Thanks for investigating! I had it on my backlog from long time ago. Thank you for your review. :-) > We can address the non-reproducibility issues separately. Perhaps you > can send your findings to bug-guix so we can keep track of it. Sure; nonetheless, I think it will relate to two more generic issues I'm opening too. Happy hacking! Miguel From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 07:51:22 2021 Received: (at control) by debbugs.gnu.org; 5 Jan 2021 12:51:22 +0000 Received: from localhost ([127.0.0.1]:41057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwlo2-0008MQ-76 for submit@debbugs.gnu.org; Tue, 05 Jan 2021 07:51:22 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:34961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwlo1-0008ME-7F for control@debbugs.gnu.org; Tue, 05 Jan 2021 07:51:21 -0500 Received: by mail-wr1-f45.google.com with SMTP id r3so36097787wrt.2 for ; Tue, 05 Jan 2021 04:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=4Q/9/yzf8V/szAyzsUkE/Q33g4xjZ/jeFOs8SAUTw/M=; b=Ralc80qpAGHTLnIv3DMes9ZbONe8pvhxpGIaYx5zA+bxW1M6kpDxMovNC7PAbiXKLT 5totoe90CyX7xFTjwJuED/YuO0Sny12QX1dUBa/ks50f5tWbZr8xr0CwxBpNrqneN8bn fxbOo5ntOFiNccFFzr8jr0abD/33qpTn9xcdi/oPiVAqmNOBY7Df2OXsRTGi7d9/3iaJ 65WQm6fTW4TkGV4m+b1XeyzfB9K6e1m9PQqi4INLsVLYbvbpq/usyeghPZxQNUaaWV7t PobZJJlmMG0naF9m/IhgKVz3w6Lo17Jd+tSPDgfC/0tvkZEmVYUdhTZeCUnkGMDO/ukC K3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=4Q/9/yzf8V/szAyzsUkE/Q33g4xjZ/jeFOs8SAUTw/M=; b=PzbCfYjUXIbyoG1/4X+YN3KK7phjMOGJO5SfxMKugR3Wq2e1Cu/zZ3zFdZQSM0E/Sb Sie68xF6PiL+oUFdImdJwyGz5WUP2MhIJFxY/7cJHltJRBoCcVnAfcyWJguyAHOkHCqB skUCB3cOpoNknvIklXqdYCYFOe79hMJA/T5jPCY8Xvpk9snQHRAAIxedUPh8avJuMGBA HOKCb+oDCTHDY8Oc6k7elnCxxtpNYhtibeQf8vjtAEurEnPRtlO67fLVbOzhU9F6Hntw eGyDh5lrXl33bhIY0GhmuyKYT2QAAY2/ZYNKRxPx30xLP2LU1cYaVwmr+B9d/uGuhM/N 26Og== X-Gm-Message-State: AOAM531owfDxKMndY1Gml3rNgcC1UVtipP8NX7sGjcTWPJes4fapEsuH lNFke+ZySAhdwfGL3hvu4p2K+T1HA50= X-Google-Smtp-Source: ABdhPJyLQVZCar7dDajdvaqPyhIgJw8Om1Tf0MyrrVzjUkPnj91UHkX6RhJZiEB5QAnh5QRaWe5g5A== X-Received: by 2002:a5d:40d2:: with SMTP id b18mr82476527wrq.369.1609851075378; Tue, 05 Jan 2021 04:51:15 -0800 (PST) Received: from unfall (36.193.158.146.dynamic.jazztel.es. [146.158.193.36]) by smtp.gmail.com with ESMTPSA id r20sm3723930wmh.15.2021.01.05.04.51.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 04:51:14 -0800 (PST) Date: Tue, 05 Jan 2021 13:51:14 +0100 Message-Id: <87ble335tp.fsf@gmail.com> To: control@debbugs.gnu.org From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= Subject: control message for bug #42771 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 42771 fixed close 42771 quit Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosen644835[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (rosen644835[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.9 MALFORMED_FREEMAIL Bad headers on message from free email service X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 42771 fixed close 42771 quit Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosen644835[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (rosen644835[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.9 MALFORMED_FREEMAIL Bad headers on message from free email service tags 42771 fixed close 42771 quit From unknown Fri Aug 15 02:03:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 03 Feb 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator