Subject: [bug#42767] [PATCH] gnu: Add rttr.

From: Mathieu Othacehe <[email-masked]>
Date: Mon, 10 Aug 2020 11:34:33 +0200

Hello Michael,

Thanks for this patch. Did you change something to the way you are
sending patches? I have troubles to apply them, with errors such as:

--8<---------------cut here---------------start------------->8---
Applying: gnu: Add rttr.
Using index info to reconstruct a base tree...
M	gnu/packages/cpp.scm
error: patch failed: gnu/packages/cpp.scm:82
error: gnu/packages/cpp.scm: patch does not apply
error: Did you hand edit your patch?
--8<---------------cut here---------------end--------------->8---

> +    (home-page "https://github.com/rttrorg/rttr/")

This field is traditionally at the end of the package definition, right
before synopsis.

> +    (source
> +     '(#:tests? #f                      ; TODO

You could elaborate on why they are not enabled. Something to fix in particular?

> +       #:configure-flags
> +         '("-DBUILD_UNIT_TESTS=OFF"
> +           "-DBUILD_DOCUMENTATION=OFF")))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (synopsis "C++ Reflection Library")
> +    (description
> +     "RTTR stands for Run Time Type Reflection. It describes the ability of a
> +computer program to introspect and modify an object at runtime. It is also the
> +name of the library itself, which is written in C++ and released as open
> +source library.")

There are a couple of linting warnings on this description. No need to
mention that it's open source :).

Thanks,

Mathieu