GNU bug report logs - #42767
[PATCH] gnu: Add rttr.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Sat, 8 Aug 2020 17:54:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42767 in the body.
You can then email your comments to 42767 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#42767; Package guix-patches. (Sat, 08 Aug 2020 17:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Michael Rohleder <mike <at> rohleder.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 08 Aug 2020 17:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: Add rttr.
Date: Sat,  8 Aug 2020 19:53:20 +0200
* gnu/packages/cpp.scm (rttr): New variable.
---
A newer version of kdenlive needs this.

 gnu/packages/cpp.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 5e83bb69f6..9ff4dc864b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,7 +83,35 @@ strings, configuration, bit streams, threading, translation, and cross-platform
 operating system functions.")
     (license license:zlib)))
 
+(define-public rttr
+  (package
+    (name "rttr")
+    (version "0.9.6")
+    (home-page "https://github.com/rttrorg/rttr/")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "1yxad8sj40wi75hny8w6imrsx8wjasjmsipnlq559n4b6kl84ijp"))
+       (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f                      ; TODO
+       #:configure-flags
+         '("-DBUILD_UNIT_TESTS=OFF"
+           "-DBUILD_DOCUMENTATION=OFF")))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (synopsis "C++ Reflection Library")
+    (description
+     "RTTR stands for Run Time Type Reflection. It describes the ability of a
+computer program to introspect and modify an object at runtime. It is also the
+name of the library itself, which is written in C++ and released as open
+source library.")
+    (license license:expat)))
+
 (define-public rct
   (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
          (revision "2"))
-- 
2.28.0





Information forwarded to guix-patches <at> gnu.org:
bug#42767; Package guix-patches. (Mon, 10 Aug 2020 09:35:02 GMT) Full text and rfc822 format available.

Message #8 received at 42767 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 42767 <at> debbugs.gnu.org
Subject: Re: [bug#42767] [PATCH] gnu: Add rttr.
Date: Mon, 10 Aug 2020 11:34:33 +0200
Hello Michael,

Thanks for this patch. Did you change something to the way you are
sending patches? I have troubles to apply them, with errors such as:

--8<---------------cut here---------------start------------->8---
Applying: gnu: Add rttr.
Using index info to reconstruct a base tree...
M	gnu/packages/cpp.scm
error: patch failed: gnu/packages/cpp.scm:82
error: gnu/packages/cpp.scm: patch does not apply
error: Did you hand edit your patch?
--8<---------------cut here---------------end--------------->8---

> +    (home-page "https://github.com/rttrorg/rttr/")

This field is traditionally at the end of the package definition, right
before synopsis.

> +    (source
> +     '(#:tests? #f                      ; TODO

You could elaborate on why they are not enabled. Something to fix in particular?

> +       #:configure-flags
> +         '("-DBUILD_UNIT_TESTS=OFF"
> +           "-DBUILD_DOCUMENTATION=OFF")))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (synopsis "C++ Reflection Library")
> +    (description
> +     "RTTR stands for Run Time Type Reflection. It describes the ability of a
> +computer program to introspect and modify an object at runtime. It is also the
> +name of the library itself, which is written in C++ and released as open
> +source library.")

There are a couple of linting warnings on this description. No need to
mention that it's open source :).

Thanks,

Mathieu




Information forwarded to guix-patches <at> gnu.org:
bug#42767; Package guix-patches. (Mon, 10 Aug 2020 18:21:02 GMT) Full text and rfc822 format available.

Message #11 received at 42767 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 42767 <at> debbugs.gnu.org
Subject: Re: [bug#42767] [PATCH] gnu: Add rttr.
Date: Mon, 10 Aug 2020 20:19:17 +0200
[Message part 1 (text/plain, inline)]
Hello Mathieu,

Thank you very much for reviewing (my mess, as I was too focused on making
kdenlive run...).

Here is a (hopefully) better version.

It includes running 528 unit_tests, except the ones for library_test.cpp
where I couldn't figure out why they fail, so I substitute it away.

[0001-gnu-Add-rttr.patch (text/x-patch, inline)]
From 46a38e83b831cf0c5a0e31b2d905ac9d4d77a5a8 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Mon, 10 Aug 2020 20:17:07 +0200
Subject: [PATCH] gnu: Add rttr.

* gnu/packages/cpp.scm (rttr): New variable.
---
 gnu/packages/cpp.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index bf89ff12ea..8c0afe4955 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,6 +83,42 @@ strings, configuration, bit streams, threading, translation, and cross-platform
 operating system functions.")
     (license license:zlib)))
 
+(define-public rttr
+  (package
+    (name "rttr")
+    (version "0.9.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/rttrorg/rttr/")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "1yxad8sj40wi75hny8w6imrsx8wjasjmsipnlq559n4b6kl84ijp"))
+       (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f ; no check target. Setting test-target to "unit_test" runs
+                   ; it twice.
+       #:configure-flags
+       '("-DBUILD_DOCUMENTATION=OFF" "-DBUILD_EXAMPLES=OFF")
+       #:phases
+       (modify-phases %standard-phases
+         ;; library_test fails in chroot.
+         (add-after 'unpack 'skip-library-test
+           (lambda _
+             (substitute* "src/unit_tests/unit_tests.cmake"
+               (("misc/library_test.cpp") ""))
+             #t)))))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/rttrorg/rttr/")
+    (synopsis "C++ Reflection Library")
+    (description
+     "RTTR stands for Run Time Type Reflection.  It describes the ability of a
+computer program to introspect and modify an object at runtime.  It is also
+the name of the library itself, which is written in C++.")
+    (license license:expat)))
+
 (define-public rct
   (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
          (revision "2"))
-- 
2.28.0

[signature.asc (application/pgp-signature, inline)]

Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Tue, 11 Aug 2020 09:02:02 GMT) Full text and rfc822 format available.

Notification sent to Michael Rohleder <mike <at> rohleder.de>:
bug acknowledged by developer. (Tue, 11 Aug 2020 09:02:03 GMT) Full text and rfc822 format available.

Message #16 received at 42767-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 42767-done <at> debbugs.gnu.org
Subject: Re: [bug#42767] [PATCH] gnu: Add rttr.
Date: Tue, 11 Aug 2020 11:01:28 +0200
Hey,

> It includes running 528 unit_tests, except the ones for library_test.cpp
> where I couldn't figure out why they fail, so I substitute it away.

This looks fine, pushed!

Thanks,

Mathieu




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 08 Sep 2020 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 337 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.