Subject: Re: [PATCH] gnu: Add cfunge.

From: Hendur Saga <[email-masked]>
Date: Sat, 15 Aug 2020 17:21:01 +0000 (UTC)

Patch updated and attached.
> The repository does contain a tests/ folder, did you try running these?
I've ran pretty much all the tests and quite frankly, they are manual, human-graded tests. There is no unified way to tell if a test passed, etc. That might be why there is no test target.
> How about this Texinfo markup?
I modified your suggestion a little to more resemble the specs' language: http://quadium.net/funge/spec98.html
> it's actually gpl3+, what gives?
Mea culpa. I mistyped that.
> I don't know where the blame lies.
The tio.run links linked from those two Befunge-98 examples use the FBBI fingerprint, which currently isn't supported by cfunge. I tested a few examples from  https://esolangs.org/wiki/Befunge  and everything seems to work fine.
    On Sunday, August 9, 2020, 04:50:37 PM EDT, Jakub Kądziołka <[email-masked]> wrote:  
 
 On Fri, Aug 07, 2020 at 05:02:40PM +0000, Hendur Saga wrote:
> I added a new file, esolangs.scm, because I could not find any other place to be more appropriate, for this and forthcoming packages.

Not a bad idea, though toys.scm somewhat fits. Please add the new file
to the list in gnu/local.mk, though.

Also, could you run your code through etc/indent-code.el?

> +  (arguments
> +    '(#:tests? #f)) ; no make target 'test'

The repository does contain a tests/ folder, did you try running these?
You can check the rgbds package from assembly.scm for some inspiration
as to how you can handle a custom testsuite entrypoint.

> +  (inputs
> +    `(("ncurses" ,ncurses)))
> +  (home-page "https://github.com/VorpalBlade/cfunge")
> +  (synopsis "Fast conforming Befunge93/98/109 interpreter in C")
> +  (description "cfunge is a fast conforming Befunge93/98/109 interpreter written in C.
          @command{cfunge}

> +It supports several fingerprints.")

It would be nice to define what a fingerprint is, as even though there
was once a summer when I was fluent in Befunge, I still needed a longer
moment to recall what those are. How about this Texinfo markup?

@dfn{fingerprints} (opt-in language extensions identified by a
four-character code).

> +  (license license:gpl2+)))

COPYING and the headers in src/*.c (well, I checked diagnostic.c)
suggest that it's actually gpl3+, what gives?

Could you send an updated patch?

Regards,
Jakub Kądziołka

P.S. I tried to test the package by running this CGCC answer in it, but
it loops infinitely. I didn't have time to debug this, so I don't know
where the blame lies.

https://codegolf.stackexchange.com/a/150920/55934  

From a30d2ce2870964c78c82469750e5bc8a34a0a477 Mon Sep 17 00:00:00 2001
From: Hendursaga <[email-masked]>
Date: Sat, 15 Aug 2020 17:05:57 +0000
Subject: [PATCH] gnu: Add cfunge.

* gnu/packages/esolangs.scm: New file.
* gnu/packages/esolangs.scm (cfunge): New variable.
* gnu/local.mk: Add esolangs.scm.
---
 gnu/local.mk              |  1 +
 gnu/packages/esolangs.scm | 50 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100644 gnu/packages/esolangs.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 27dcf965ca..2e320512d8 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -197,6 +197,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/enlightenment.scm		\
   %D%/packages/entr.scm				\
   %D%/packages/erlang.scm			\
+  %D%/packages/esolangs.scm			\
   %D%/packages/fabric-management.scm		\
   %D%/packages/fcitx.scm			\
   %D%/packages/figlet.scm			\
diff --git a/gnu/packages/esolangs.scm b/gnu/packages/esolangs.scm
new file mode 100644
index 0000000000..f9848799e3
--- /dev/null
+++ b/gnu/packages/esolangs.scm
@@ -0,0 +1,50 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Hendursaga <[email-masked]>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages esolangs)
+  #:use-module (gnu packages ncurses)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+(define-public cfunge
+  (package
+    (name "cfunge")
+    (version "0.9.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/VorpalBlade/cfunge")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "18ir0h10vxdb5jb57w5hjbgi8spjxg9x2148agadhhmbhsja02m7"))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f)) ; no make target 'test'
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (home-page "https://github.com/VorpalBlade/cfunge")
+    (synopsis "Fast conforming Befunge93/98/109 interpreter in C")
+    (description "@command{cfunge} is a fast conforming Befunge93/98/109 interpreter
+written in C.  It supports several @dfn{fingerprints} (opt-in language extensions
+identified by unique ID codes).")
+    (license license:gpl3+)))
-- 
2.28.0