From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 03:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42736@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159677029024473 (code B ref -1); Fri, 07 Aug 2020 03:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Aug 2020 03:18:10 +0000 Received: from localhost ([127.0.0.1]:55367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3stW-0006Mf-59 for submit@debbugs.gnu.org; Thu, 06 Aug 2020 23:18:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:46198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3stT-0006MW-QO for submit@debbugs.gnu.org; Thu, 06 Aug 2020 23:18:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3stT-0000lj-LF for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:07 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:51272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3stR-000119-OO for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:07 -0400 Received: from cpe-107-15-18-231.nc.res.rr.com ([107.15.18.231] helo=alperton.home.eronel.org) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1k3stP-0002BY-Oz for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:03 -0400 From: Jack Hill Date: Thu, 6 Aug 2020 23:17:49 -0400 Message-Id: <20200807031749.27160-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/06 23:18:03 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-doom-themes): Update to 2.1.6-5. This commit revision add support for Emacs 27. --- gnu/packages/emacs-xyz.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f857b594eb..7dc8e42f81 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22053,8 +22053,8 @@ contrast and few colors.") (license license:gpl3+)))) (define-public emacs-doom-themes - (let ((commit "54039c5171e3f8c9cef1f82122549b66cd8c8f7b") - (revision "4") + (let ((commit "e803fc4ac8cf7118e2d1544d8241b848b5e79e9f") + (revision "5") (version "2.1.6")) (package (name "emacs-doom-themes") @@ -22066,7 +22066,7 @@ contrast and few colors.") (commit commit))) (file-name (git-file-name name version)) (sha256 - (base32 "1iwdjq4q2gkhi6jwas3ywgmdz5dg14sfb3fzhqd7wih6j3i2l3cr")))) + (base32 "128hdmf0jkzr12fv2r6z349qiwba6q97hsb6b1n2qlhi0v5v3mfh")))) (build-system emacs-build-system) (native-inputs `(("emacs-ert-runner" ,emacs-ert-runner))) -- 2.28.0 From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 03:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159677143426407 (code B ref 42736); Fri, 07 Aug 2020 03:38:02 +0000 Received: (at 42736) by debbugs.gnu.org; 7 Aug 2020 03:37:14 +0000 Received: from localhost ([127.0.0.1]:55393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3tBs-0006ri-MN for submit@debbugs.gnu.org; Thu, 06 Aug 2020 23:37:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3tBq-0006rD-KL for 42736@debbugs.gnu.org; Thu, 06 Aug 2020 23:37:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34616) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3tBk-000360-SS; Thu, 06 Aug 2020 23:37:00 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=57178 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k3tBk-0001h6-Al; Thu, 06 Aug 2020 23:37:00 -0400 From: Brett Gilio References: <20200807031749.27160-1-jackhill@jackhill.us> Date: Thu, 06 Aug 2020 22:37:11 -0500 In-Reply-To: <20200807031749.27160-1-jackhill@jackhill.us> (Jack Hill's message of "Thu, 6 Aug 2020 23:17:49 -0400") Message-ID: <878serjfdk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jack Hill writes: > * gnu/packages/emacs-xyz.scm (emacs-doom-themes): Update to 2.1.6-5. This > commit revision add support for Emacs 27. > --- > gnu/packages/emacs-xyz.scm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index f857b594eb..7dc8e42f81 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -22053,8 +22053,8 @@ contrast and few colors.") > (license license:gpl3+)))) > > (define-public emacs-doom-themes > - (let ((commit "54039c5171e3f8c9cef1f82122549b66cd8c8f7b") > - (revision "4") > + (let ((commit "e803fc4ac8cf7118e2d1544d8241b848b5e79e9f") > + (revision "5") > (version "2.1.6")) > (package > (name "emacs-doom-themes") > @@ -22066,7 +22066,7 @@ contrast and few colors.") > (commit commit))) > (file-name (git-file-name name version)) > (sha256 > - (base32 "1iwdjq4q2gkhi6jwas3ywgmdz5dg14sfb3fzhqd7wih6j3i2l3cr")))) > + (base32 "128hdmf0jkzr12fv2r6z349qiwba6q97hsb6b1n2qlhi0v5v3mfh")))) > (build-system emacs-build-system) > (native-inputs > `(("emacs-ert-runner" ,emacs-ert-runner))) Hey Jack, Thanks for taking time to revise this package. When I originally wrote it I made notice to the fact that some elisp bytecompilations were failing or not behaving appropriately. Since then I am pretty sure hlissner has disabled the bytecompilation completely? Could you review this for me, and if true please revise the appropriate arguments. If you aren't sure what I am talking about, please let me know. Thanks, Brett Gilio From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 04:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159677454431286 (code B ref 42736); Fri, 07 Aug 2020 04:30:02 +0000 Received: (at 42736) by debbugs.gnu.org; 7 Aug 2020 04:29:04 +0000 Received: from localhost ([127.0.0.1]:55436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3u08-00088Y-2a for submit@debbugs.gnu.org; Fri, 07 Aug 2020 00:29:04 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:49770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3u05-000881-5b for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 00:29:03 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k3tzz-0004kb-Qw; Fri, 07 Aug 2020 00:28:55 -0400 Date: Fri, 7 Aug 2020 00:28:55 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <878serjfdk.fsf@gnu.org> Message-ID: References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 6 Aug 2020, Brett Gilio wrote: > > Hey Jack, > > Thanks for taking time to revise this package. When I originally wrote > it I made notice to the fact that some elisp bytecompilations were > failing or not behaving appropriately. Since then I am pretty sure > hlissner has disabled the bytecompilation completely? Could you review > this for me, and if true please revise the appropriate arguments. If you > aren't sure what I am talking about, please let me know. Brett, I saw your lovely comment, but in my excitement that the update solved the problem I was having with Emacs 27 compatibility, I didn't think too hard about it. I believe that I understand what you're asking. I'll take a look tomorrow to see if we should change the package definition in light of upstream changes. If I get stuck, I'll be sure to let you know. Best, Jack From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159682383514480 (code B ref 42736); Fri, 07 Aug 2020 18:11:02 +0000 Received: (at 42736) by debbugs.gnu.org; 7 Aug 2020 18:10:35 +0000 Received: from localhost ([127.0.0.1]:57543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46p8-0003lU-Ug for submit@debbugs.gnu.org; Fri, 07 Aug 2020 14:10:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k46p5-0003lG-Rb for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 14:10:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59041) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k46oz-000519-6R; Fri, 07 Aug 2020 14:10:26 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=43036 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k46oy-0001tf-Nd; Fri, 07 Aug 2020 14:10:25 -0400 From: Brett Gilio References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> Date: Fri, 07 Aug 2020 13:10:43 -0500 In-Reply-To: (Jack Hill's message of "Fri, 7 Aug 2020 00:28:55 -0400 (EDT)") Message-ID: <87ft8y5nto.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jack Hill writes: > On Thu, 6 Aug 2020, Brett Gilio wrote: > >> >> Hey Jack, >> >> Thanks for taking time to revise this package. When I originally wrote >> it I made notice to the fact that some elisp bytecompilations were >> failing or not behaving appropriately. Since then I am pretty sure >> hlissner has disabled the bytecompilation completely? Could you review >> this for me, and if true please revise the appropriate arguments. If you >> aren't sure what I am talking about, please let me know. > > Brett, > > I saw your lovely comment, but in my excitement that the update solved > the problem I was having with Emacs 27 compatibility, I didn't think > too hard about it. > > I believe that I understand what you're asking. I'll take a look > tomorrow to see if we should change the package definition in light of > upstream changes. If I get stuck, I'll be sure to let you know. > > Best, > Jack Sounds great! Thanks. From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Aug 2020 02:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159685258625133 (code B ref 42736); Sat, 08 Aug 2020 02:10:02 +0000 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:09:46 +0000 Received: from localhost ([127.0.0.1]:57790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EIs-0006XI-Jv for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:09:46 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:60350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EIq-0006X5-Sv for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:09:45 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k4EIl-0003IM-KE; Fri, 07 Aug 2020 22:09:39 -0400 Date: Fri, 7 Aug 2020 22:09:39 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87ft8y5nto.fsf@gnu.org> Message-ID: References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> <87ft8y5nto.fsf@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> On Thu, 6 Aug 2020, Brett Gilio wrote: >> >>> >>> Hey Jack, >>> >>> Thanks for taking time to revise this package. When I originally wrote >>> it I made notice to the fact that some elisp bytecompilations were >>> failing or not behaving appropriately. Since then I am pretty sure >>> hlissner has disabled the bytecompilation completely? Could you review >>> this for me, and if true please revise the appropriate arguments. If you >>> aren't sure what I am talking about, please let me know. Brett, I think the way forward is to follow upstream's choices and not enable or disable byte compilation in Guix. After upstream introduced commit 9cd6872 [0], our trick to selectively leave batch compilation enabled for some files didn't work because they already had `-*- no-byte-compile: t; -*-` at the top of the file. In my testing, I added a phase to substitute this away. Indeed, this allowed our trick to work again. However, the material, snazzy, and tomorrow-day themes now have problems with byte compilation. Therefore, I removed the disable-breaking-compilation phase entirely. With it removed, doom-themes-autoloads.el, doom-themes-base.el, doom-themes.el, doom-themes-ext-org.el, and doom-themes-ext-visual-bell.el do get byte compiled. From this evidence I concluded that upstream is aware of this issue and is only disabling byte compilation where necessary. I'll send a version 2 of the patch with the phase removed shortly. [0] https://github.com/hlissner/emacs-doom-themes/commit/9cd6872b1af88165834230abd45743036861f925 Best, Jack From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH v2] gnu: emacs-doom-themes: Update to 2.1.6-5. References: <20200807031749.27160-1-jackhill@jackhill.us> In-Reply-To: <20200807031749.27160-1-jackhill@jackhill.us> Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Aug 2020 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159685270925345 (code B ref 42736); Sat, 08 Aug 2020 02:12:01 +0000 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:11:49 +0000 Received: from localhost ([127.0.0.1]:57797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EKr-0006aj-Ja for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:11:49 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:60374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EKp-0006aX-Sf for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:11:48 -0400 Received: from cpe-107-15-18-231.nc.res.rr.com ([107.15.18.231] helo=alperton.home.eronel.org) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1k4EKk-0003O7-NT for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:11:42 -0400 From: Jack Hill Date: Fri, 7 Aug 2020 22:11:30 -0400 Message-Id: <20200808021130.20027-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-doom-themes): Update to 2.1.6-5. This commit revision add support for Emacs 27. [arguments]: Remove disable-breaking-compilation phase. --- gnu/packages/emacs-xyz.scm | 31 +++---------------------------- 1 file changed, 3 insertions(+), 28 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f857b594eb..0b66e9507b 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22053,8 +22053,8 @@ contrast and few colors.") (license license:gpl3+)))) (define-public emacs-doom-themes - (let ((commit "54039c5171e3f8c9cef1f82122549b66cd8c8f7b") - (revision "4") + (let ((commit "e803fc4ac8cf7118e2d1544d8241b848b5e79e9f") + (revision "5") (version "2.1.6")) (package (name "emacs-doom-themes") @@ -22066,7 +22066,7 @@ contrast and few colors.") (commit commit))) (file-name (git-file-name name version)) (sha256 - (base32 "1iwdjq4q2gkhi6jwas3ywgmdz5dg14sfb3fzhqd7wih6j3i2l3cr")))) + (base32 "128hdmf0jkzr12fv2r6z349qiwba6q97hsb6b1n2qlhi0v5v3mfh")))) (build-system emacs-build-system) (native-inputs `(("emacs-ert-runner" ,emacs-ert-runner))) @@ -22086,31 +22086,6 @@ contrast and few colors.") (for-each (lambda (f) (rename-file f (basename f))) (find-files "./themes" ".*\\.el$")) - #t)) - ;; There is a byte-code overflow issue in the latest checkout - ;; which affects byte-compilation for several (read `most') theme - ;; files. In order to cope with this issue, we disable - ;; byte-compilation until this issue is resolved. - ;; - ;; - ;; NOTE: Byte-comp has been disabled in/after commit 9cd6872. - ;; However our method of selective disabling is preferential to - ;; just widely disabling byte-compilation. - (add-after 'move-themes 'disable-breaking-compilation - (lambda _ - (for-each (lambda (file) - (chmod file #o600) ; needed to write changes. - (emacs-batch-disable-compilation file)) - (cons "doom-themes-ext-neotree.el" - ;; NOTE: When updating this package, determine - ;; whether changed theme files can byte-compile. - ;; If they can successfully byte-compile, add them - ;; to this list of exceptions. - (lset-difference string-contains - (find-files "." ".*-theme.el") - '("material" - "snazzy" - "tomorrow-day")))) #t))))) (synopsis "Wide collection of color themes for Emacs") (description "Emacs-doom-themes contains numerous popular color themes for -- 2.28.0 From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Aug 2020 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159685367126911 (code B ref 42736); Sat, 08 Aug 2020 02:28:02 +0000 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:27:51 +0000 Received: from localhost ([127.0.0.1]:57820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaM-0006zz-HP for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaI-0006zj-Iv for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39055) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4EaD-0007gF-0u; Fri, 07 Aug 2020 22:27:41 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=48148 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4EaC-0000cZ-26; Fri, 07 Aug 2020 22:27:40 -0400 From: Brett Gilio References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> <87ft8y5nto.fsf@gnu.org> Date: Fri, 07 Aug 2020 21:27:58 -0500 In-Reply-To: (Jack Hill's message of "Fri, 7 Aug 2020 22:09:39 -0400 (EDT)") Message-ID: <87o8nlc1n5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jack Hill writes: >>> On Thu, 6 Aug 2020, Brett Gilio wrote: >>> >>>> >>>> Hey Jack, >>>> >>>> Thanks for taking time to revise this package. When I originally wrote >>>> it I made notice to the fact that some elisp bytecompilations were >>>> failing or not behaving appropriately. Since then I am pretty sure >>>> hlissner has disabled the bytecompilation completely? Could you review >>>> this for me, and if true please revise the appropriate arguments. If you >>>> aren't sure what I am talking about, please let me know. > > Brett, > > I think the way forward is to follow upstream's choices and not enable > or disable byte compilation in Guix. > > After upstream introduced commit 9cd6872 [0], our trick to selectively > leave batch compilation enabled for some files didn't work because > they already had `-*- no-byte-compile: t; -*-` at the top of the > file. In my testing, I added a phase to substitute this away. Indeed, > this allowed our trick to work again. However, the material, snazzy, > and tomorrow-day themes now have problems with byte compilation. > > Therefore, I removed the disable-breaking-compilation phase > entirely. With it removed, doom-themes-autoloads.el, > doom-themes-base.el, doom-themes.el, doom-themes-ext-org.el, and > doom-themes-ext-visual-bell.el do get byte compiled. From this > evidence I concluded that upstream is aware of this issue and is only > disabling byte compilation where necessary. > > I'll send a version 2 of the patch with the phase removed shortly. > > [0] https://github.com/hlissner/emacs-doom-themes/commit/9cd6872b1af88165834230abd45743036861f925 > > Best, > Jack Jack, Thank you for investigating this issue. I agree with your solution, and I will apply your patch removing the phase. Brett From unknown Sat Aug 16 16:19:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jack Hill Subject: bug#42736: closed (Re: [bug#42736] [PATCH v2] gnu: emacs-doom-themes: Update to 2.1.6-5.) Message-ID: References: <87k0y9c1jy.fsf@gnu.org> <20200807031749.27160-1-jackhill@jackhill.us> X-Gnu-PR-Message: they-closed 42736 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 42736@debbugs.gnu.org Date: Sat, 08 Aug 2020 02:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1596853802-27123-1" This is a multi-part message in MIME format... ------------=_1596853802-27123-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42736: [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42736@debbugs.gnu.org. --=20 42736: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42736 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1596853802-27123-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42736-close) by debbugs.gnu.org; 8 Aug 2020 02:29:46 +0000 Received: from localhost ([127.0.0.1]:57824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EcE-00072m-5y for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:29:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EcC-00072a-LO for 42736-close@debbugs.gnu.org; Fri, 07 Aug 2020 22:29:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39072) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4Ec7-0007mB-Da; Fri, 07 Aug 2020 22:29:39 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=48152 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4Ec4-0004nX-Fg; Fri, 07 Aug 2020 22:29:36 -0400 From: Brett Gilio To: Jack Hill Subject: Re: [bug#42736] [PATCH v2] gnu: emacs-doom-themes: Update to 2.1.6-5. References: <20200807031749.27160-1-jackhill@jackhill.us> <20200808021130.20027-1-jackhill@jackhill.us> Date: Fri, 07 Aug 2020 21:29:53 -0500 In-Reply-To: <20200808021130.20027-1-jackhill@jackhill.us> (Jack Hill's message of "Fri, 7 Aug 2020 22:11:30 -0400") Message-ID: <87k0y9c1jy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42736-close Cc: 42736-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Applied with c9eb5ad6b0443fafe1cd1a18aae507c1ee5fea1f. Closing. Thanks! ------------=_1596853802-27123-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Aug 2020 03:18:10 +0000 Received: from localhost ([127.0.0.1]:55367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3stW-0006Mf-59 for submit@debbugs.gnu.org; Thu, 06 Aug 2020 23:18:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:46198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3stT-0006MW-QO for submit@debbugs.gnu.org; Thu, 06 Aug 2020 23:18:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3stT-0000lj-LF for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:07 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:51272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3stR-000119-OO for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:07 -0400 Received: from cpe-107-15-18-231.nc.res.rr.com ([107.15.18.231] helo=alperton.home.eronel.org) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1k3stP-0002BY-Oz for guix-patches@gnu.org; Thu, 06 Aug 2020 23:18:03 -0400 From: Jack Hill To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Date: Thu, 6 Aug 2020 23:17:49 -0400 Message-Id: <20200807031749.27160-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/06 23:18:03 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-doom-themes): Update to 2.1.6-5. This commit revision add support for Emacs 27. --- gnu/packages/emacs-xyz.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f857b594eb..7dc8e42f81 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22053,8 +22053,8 @@ contrast and few colors.") (license license:gpl3+)))) (define-public emacs-doom-themes - (let ((commit "54039c5171e3f8c9cef1f82122549b66cd8c8f7b") - (revision "4") + (let ((commit "e803fc4ac8cf7118e2d1544d8241b848b5e79e9f") + (revision "5") (version "2.1.6")) (package (name "emacs-doom-themes") @@ -22066,7 +22066,7 @@ contrast and few colors.") (commit commit))) (file-name (git-file-name name version)) (sha256 - (base32 "1iwdjq4q2gkhi6jwas3ywgmdz5dg14sfb3fzhqd7wih6j3i2l3cr")))) + (base32 "128hdmf0jkzr12fv2r6z349qiwba6q97hsb6b1n2qlhi0v5v3mfh")))) (build-system emacs-build-system) (native-inputs `(("emacs-ert-runner" ,emacs-ert-runner))) -- 2.28.0 ------------=_1596853802-27123-1-- From unknown Sat Aug 16 16:19:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Aug 2020 02:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42736 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 42736@debbugs.gnu.org Received: via spool by 42736-submit@debbugs.gnu.org id=B42736.159685441028212 (code B ref 42736); Sat, 08 Aug 2020 02:41:02 +0000 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:40:10 +0000 Received: from localhost ([127.0.0.1]:57831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EmI-0007Ky-Fj for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:40:10 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:60572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EmD-0007KI-Rw for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:40:09 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k4Em8-0004Y0-N1; Fri, 07 Aug 2020 22:40:00 -0400 Date: Fri, 7 Aug 2020 22:40:00 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87o8nlc1n5.fsf@gnu.org> Message-ID: References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> <87ft8y5nto.fsf@gnu.org> <87o8nlc1n5.fsf@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 7 Aug 2020, Brett Gilio wrote: > Jack, > > Thank you for investigating this issue. I agree with your solution, and > I will apply your patch removing the phase. > > Brett Thanks for the review! Best, Jack