GNU bug report logs - #42735
[PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH

Previous Next

Package: guix-patches;

Reported by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>

Date: Fri, 7 Aug 2020 02:28:02 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 42735 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Brett Gilio <brettg <at> gnu.org>
Cc: 42735 <at> debbugs.gnu.org
Subject: Re: [bug#42735] [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH
Date: Fri, 7 Aug 2020 08:02:04 +0200

[Message part 1 (text/plain, inline)]
On Thu, 06 Aug 2020 22:46:52 -0500
Brett Gilio <brettg <at> gnu.org> wrote:

> Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org> writes:
> 
> >  
> > +# Make sure we don't use local package definitions
> > +GUIX_PACKAGE_PATH=""
> > +export GUIX_PACKAGE_PATH
> > +
> >  exec "$@"
> 
> Wouldn't it make more sense to use `unset` instead of defining an
> empty variable?
I used export and defined an empty variable because I don't know how to
write portable shell scripts and export was already used in
build-aux/pre-inst-env.in.

Is unset portable? If so should I resend a patch with unset instead?

Denis.

[Message part 2 (application/pgp-signature, inline)]
This bug report was last modified 4 years and 284 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.