From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 42734@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15967614372224 (code B ref -1); Fri, 07 Aug 2020 00:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Aug 2020 00:50:37 +0000 Received: from localhost ([127.0.0.1]:55164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qaj-0000Zn-Jj for submit@debbugs.gnu.org; Thu, 06 Aug 2020 20:50:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qah-0000Zg-Q2 for submit@debbugs.gnu.org; Thu, 06 Aug 2020 20:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3qah-0000hR-EI for guix-patches@gnu.org; Thu, 06 Aug 2020 20:50:35 -0400 Received: from cyberdimension.org ([80.67.179.20]:54408 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k3qad-0002is-NW for guix-patches@gnu.org; Thu, 06 Aug 2020 20:50:35 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 5cfc1009 for ; Fri, 7 Aug 2020 00:47:29 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 2d89ede1 for ; Fri, 7 Aug 2020 00:47:29 +0000 (UTC) Date: Fri, 7 Aug 2020 02:44:23 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200807024423.1638d242@primarylaptop.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/06 20:50:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Here are two patches to export android-platform-system-core. This way it can be used as a dependency like that: > (native-inputs > `(("android-core" ,(android-platform-system-core > (android-platform-version))))) Denis. --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8so+gACgkQX138wUF3 4mN1KA/+NoyiqSWdzxoRs8lJ5nPpxL+Gg79a9TT86gWdUPc1QkOA69cZWsHw9EVh LD07qG+geQxq3LecXB8dv/mNdttDA386EOJjyqTzttR54KwpPnfyhEiv347ktBQ3 5236G+IUCuemC2z2iXLBNCI0kVaW3PU8VtFLouHy5QdGvYcIanaiLpQTH3odriTg 35ua09+m40OZH1RyCoNo1QoIzwVLLNcRHM86tUYg5fvwyEymDk2J6AQZbsrVBF3J vbptfc330ilpw5nqSI9M5RmXAPVZ8kw6YTDsLglh0HcRQSeXJPBW3oI4eAF61heB Uarjc/tKBuscoqg91VInBIDtMhKR8gbdAIqQKuJXacDoxYe8QyqW3aWlt5GlQ7BW CQ3tJXdaunrLDnI8G6Vajsjww0t6MgzgW7NMYzeTepzVPFCERpohgnlHwgt8nlNz jXqtcZaO/i3pclvNeQB4onWLCsdDsY3D5KmQqXZNlqWuCQh5s0uNrP0Rx7hF5ASv UZnnpLNzEEZQh4x5T9i/jrA1BjKKRxZvgldxeZrfSNlKozkSvqs1qQRXZKfCaP5z vR9FWEAMYEYhHdPfmgSVjBwd1yOvorSW7uTrc9CDsoyYNLVOND9P5P414t6oHkSi eO/hHUlqLhm2zobQIDnWLMYP5vGuDyAthV/tR3a5QBRegnE4rkk= =jR3f -----END PGP SIGNATURE----- --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] [PATCH 1/2] gnu: android: Export android-platform-version. References: <20200807024423.1638d242@primarylaptop.localdomain> In-Reply-To: <20200807024423.1638d242@primarylaptop.localdomain> Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 02:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 42734@debbugs.gnu.org Cc: Mathieu Othacehe , Denis 'GNUtoo' Carikli Received: via spool by 42734-submit@debbugs.gnu.org id=B42734.159676658918409 (code B ref 42734); Fri, 07 Aug 2020 02:17:01 +0000 Received: (at 42734) by debbugs.gnu.org; 7 Aug 2020 02:16:29 +0000 Received: from localhost ([127.0.0.1]:55248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3rvo-0004mq-UL for submit@debbugs.gnu.org; Thu, 06 Aug 2020 22:16:29 -0400 Received: from cyberdimension.org ([80.67.179.20]:43756 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3rvl-0004ma-3d for 42734@debbugs.gnu.org; Thu, 06 Aug 2020 22:16:27 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 2aef63ae; Fri, 7 Aug 2020 02:13:28 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 09247f90; Fri, 7 Aug 2020 02:13:28 +0000 (UTC) From: Denis 'GNUtoo' Carikli Date: Fri, 7 Aug 2020 04:10:26 +0200 Message-Id: <20200807021027.21817-1-GNUtoo@cyberdimension.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/android.scm (android-platform-version): Export it. Signed-off-by: Denis 'GNUtoo' Carikli --- gnu/packages/android.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index f7f3aca4a2..8a094d0827 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -126,7 +126,7 @@ use their packages mostly unmodified in our Android NDK build system.") ;; Big thanks to them for laying the groundwork. ;; The version tag is consistent between all repositories. -(define (android-platform-version) "7.1.2_r36") +(define-public (android-platform-version) "7.1.2_r36") (define (android-platform-system-core version) (origin -- 2.28.0 From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] [PATCH 2/2] gnu: android: Export android-platform-system-core. Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 02:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 42734@debbugs.gnu.org Cc: Mathieu Othacehe , Denis 'GNUtoo' Carikli Received: via spool by 42734-submit@debbugs.gnu.org id=B42734.159676658918415 (code B ref 42734); Fri, 07 Aug 2020 02:17:02 +0000 Received: (at 42734) by debbugs.gnu.org; 7 Aug 2020 02:16:29 +0000 Received: from localhost ([127.0.0.1]:55250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3rvp-0004ms-3c for submit@debbugs.gnu.org; Thu, 06 Aug 2020 22:16:29 -0400 Received: from cyberdimension.org ([80.67.179.20]:43756 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3rvn-0004ma-B0 for 42734@debbugs.gnu.org; Thu, 06 Aug 2020 22:16:27 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id f55da598; Fri, 7 Aug 2020 02:13:28 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 5de207e8; Fri, 7 Aug 2020 02:13:28 +0000 (UTC) From: Denis 'GNUtoo' Carikli Date: Fri, 7 Aug 2020 04:10:27 +0200 Message-Id: <20200807021027.21817-2-GNUtoo@cyberdimension.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200807021027.21817-1-GNUtoo@cyberdimension.org> References: <20200807021027.21817-1-GNUtoo@cyberdimension.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/android.scm (android-platform-system-core): Export it. Signed-off-by: Denis 'GNUtoo' Carikli --- gnu/packages/android.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm index 8a094d0827..544a65d0af 100644 --- a/gnu/packages/android.scm +++ b/gnu/packages/android.scm @@ -128,7 +128,7 @@ use their packages mostly unmodified in our Android NDK build system.") ;; The version tag is consistent between all repositories. (define-public (android-platform-version) "7.1.2_r36") -(define (android-platform-system-core version) +(define-public (android-platform-system-core version) (origin (method git-fetch) (uri (git-reference -- 2.28.0 From unknown Sat Jun 21 03:21:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Denis 'GNUtoo' Carikli Subject: bug#42734: closed (Re: [bug#42734] [PATCH 1/2] gnu: android: Export android-platform-version.) Message-ID: References: <87y2mqoocd.fsf@gnu.org> <20200807024423.1638d242@primarylaptop.localdomain> X-Gnu-PR-Message: they-closed 42734 X-Gnu-PR-Package: guix-patches Reply-To: 42734@debbugs.gnu.org Date: Fri, 07 Aug 2020 08:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1596788702-6314-1" This is a multi-part message in MIME format... ------------=_1596788702-6314-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42734: Export android-platform-system-core which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42734@debbugs.gnu.org. --=20 42734: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42734 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1596788702-6314-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42734-done) by debbugs.gnu.org; 7 Aug 2020 08:24:45 +0000 Received: from localhost ([127.0.0.1]:55635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3xgD-0001dC-ER for submit@debbugs.gnu.org; Fri, 07 Aug 2020 04:24:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3xgB-0001cy-M9 for 42734-done@debbugs.gnu.org; Fri, 07 Aug 2020 04:24:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38422) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3xg5-0003Dg-VO; Fri, 07 Aug 2020 04:24:37 -0400 Received: from pop.92-184-100-121.mobile.abo.orange.fr ([92.184.100.121]:42858 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k3xg5-0001QC-9u; Fri, 07 Aug 2020 04:24:37 -0400 From: Mathieu Othacehe To: Denis 'GNUtoo' Carikli Subject: Re: [bug#42734] [PATCH 1/2] gnu: android: Export android-platform-version. References: <20200807024423.1638d242@primarylaptop.localdomain> <20200807021027.21817-1-GNUtoo@cyberdimension.org> Date: Fri, 07 Aug 2020 10:24:34 +0200 In-Reply-To: <20200807021027.21817-1-GNUtoo@cyberdimension.org> (Denis Carikli's message of "Fri, 7 Aug 2020 04:10:26 +0200") Message-ID: <87y2mqoocd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Denis, > ; ; The version tag is consistent between all repositories. > -(define (android-platform-version) "7.1.2_r36") > +(define-public (android-platform-version) "7.1.2_r36") We could turn this procedure into a variable. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.92 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [92.184.100.121 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 42734-done Cc: 42734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hello Denis, > ;; The version tag is consistent between all repositories. > -(define (android-platform-version) "7.1.2_r36") > +(define-public (android-platform-version) "7.1.2_r36") We could turn this procedure into a variable. Anyway, pushed those two patches, Thanks, Mathieu ------------=_1596788702-6314-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Aug 2020 00:50:37 +0000 Received: from localhost ([127.0.0.1]:55164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qaj-0000Zn-Jj for submit@debbugs.gnu.org; Thu, 06 Aug 2020 20:50:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3qah-0000Zg-Q2 for submit@debbugs.gnu.org; Thu, 06 Aug 2020 20:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3qah-0000hR-EI for guix-patches@gnu.org; Thu, 06 Aug 2020 20:50:35 -0400 Received: from cyberdimension.org ([80.67.179.20]:54408 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k3qad-0002is-NW for guix-patches@gnu.org; Thu, 06 Aug 2020 20:50:35 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 5cfc1009 for ; Fri, 7 Aug 2020 00:47:29 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 2d89ede1 for ; Fri, 7 Aug 2020 00:47:29 +0000 (UTC) Date: Fri, 7 Aug 2020 02:44:23 +0200 From: Denis 'GNUtoo' Carikli To: guix-patches@gnu.org Subject: Export android-platform-system-core Message-ID: <20200807024423.1638d242@primarylaptop.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/06 20:50:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Here are two patches to export android-platform-system-core. This way it can be used as a dependency like that: > (native-inputs > `(("android-core" ,(android-platform-system-core > (android-platform-version))))) Denis. --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8so+gACgkQX138wUF3 4mN1KA/+NoyiqSWdzxoRs8lJ5nPpxL+Gg79a9TT86gWdUPc1QkOA69cZWsHw9EVh LD07qG+geQxq3LecXB8dv/mNdttDA386EOJjyqTzttR54KwpPnfyhEiv347ktBQ3 5236G+IUCuemC2z2iXLBNCI0kVaW3PU8VtFLouHy5QdGvYcIanaiLpQTH3odriTg 35ua09+m40OZH1RyCoNo1QoIzwVLLNcRHM86tUYg5fvwyEymDk2J6AQZbsrVBF3J vbptfc330ilpw5nqSI9M5RmXAPVZ8kw6YTDsLglh0HcRQSeXJPBW3oI4eAF61heB Uarjc/tKBuscoqg91VInBIDtMhKR8gbdAIqQKuJXacDoxYe8QyqW3aWlt5GlQ7BW CQ3tJXdaunrLDnI8G6Vajsjww0t6MgzgW7NMYzeTepzVPFCERpohgnlHwgt8nlNz jXqtcZaO/i3pclvNeQB4onWLCsdDsY3D5KmQqXZNlqWuCQh5s0uNrP0Rx7hF5ASv UZnnpLNzEEZQh4x5T9i/jrA1BjKKRxZvgldxeZrfSNlKozkSvqs1qQRXZKfCaP5z vR9FWEAMYEYhHdPfmgSVjBwd1yOvorSW7uTrc9CDsoyYNLVOND9P5P414t6oHkSi eO/hHUlqLhm2zobQIDnWLMYP5vGuDyAthV/tR3a5QBRegnE4rkk= =jR3f -----END PGP SIGNATURE----- --Sig_/ZiCFw=Sl0pt8T=Fk_ujcS6Z-- ------------=_1596788702-6314-1-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 42734@debbugs.gnu.org, GNUtoo@cyberdimension.org X-Debbugs-Original-To: guix-patches@gnu.org, Denis 'GNUtoo' Carikli , 42734@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159680002420763 (code B ref -1); Fri, 07 Aug 2020 11:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Aug 2020 11:33:44 +0000 Received: from localhost ([127.0.0.1]:55960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40d5-0005Op-RA for submit@debbugs.gnu.org; Fri, 07 Aug 2020 07:33:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:37126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k40d4-0005Oi-CA for submit@debbugs.gnu.org; Fri, 07 Aug 2020 07:33:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k40d4-0007VS-1S for guix-patches@gnu.org; Fri, 07 Aug 2020 07:33:42 -0400 Received: from lepiller.eu ([89.234.186.109]:40608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k40d1-00014k-TS for guix-patches@gnu.org; Fri, 07 Aug 2020 07:33:41 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 41979d7c; Fri, 7 Aug 2020 11:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:from:message-id; s=dkim; bh=3ZQfXT/YiUqbz7b83MMuWHpAWA9FUdwfONC/LDasq+Y=; b=nQ9rBvwc5SeH 9ai1u+i4a6uuD6NEbTvRuLNsS2nXQulkaKPLEchgwn8/L9oa0T7XMxxBNwYUFr/m tUKH/AdRsOdA2iJeJH3s3DyCrM/7E6S1Jhu454E/SvimcChuW5KH/bPVzQQKuCuS ++ynAefdDyPeTYYUuVQpI3KCOPWzdF1E7rLQchEjPJZLJjvt4MjJWyvWiO6W5+FU dxCBzlJSe+rxruKJbGv5xdW/xz1NdzBRMSaFDTAoXd2j4NY+RHYKuO8kggB1alV9 v8AKgljOG0sYqk0OXU254BtUopQSS1W2kEUE00F+jmHoz0PQi7Y078Hy4HMJN9P0 uos0RuoLoA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f3554918 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 7 Aug 2020 11:33:34 +0000 (UTC) Date: Fri, 07 Aug 2020 07:33:03 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20200807024423.1638d242@primarylaptop.localdomain> References: <20200807024423.1638d242@primarylaptop.localdomain> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----AGL55EJOL8NWEHP5SQHJ9WCIEQWSZG" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> Received-SPF: none client-ip=89.234.186.109; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/07 07:33:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ------AGL55EJOL8NWEHP5SQHJ9WCIEQWSZG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Unfortunately, android-platform-core should first be fixed to accept a hash= as an argument, otherwise any other version will fail=2E Don't know why we= haven't done that before=E2=80=A6 On 2020=E5=B9=B48=E6=9C=886=E6=97=A5 20:44:23 GMT-04:00, Denis 'GNUtoo' Ca= rikli wrote: >Hi, > >Here are two patches to export android-platform-system-core=2E > >This way it can be used as a dependency like that: >> (native-inputs >> `(("android-core" ,(android-platform-system-core >> (android-platform-version))))) > >Denis=2E ------AGL55EJOL8NWEHP5SQHJ9WCIEQWSZG Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Unfortunately, android-platform-core should first = be fixed to accept a hash as an argument, otherwise any other version will = fail=2E Don't know why we haven't done that before=E2=80=A6

On 2020=E5=B9=B48=E6=9C=886=E6=97=A5 20:44:23 GMT-04:00,= Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension=2Eorg> wrote: 
Hi,

Here are two patches to export android-pl=
atform-system-core=2E

This way it can be used as a dependency like t=
hat:
(native-inputs
=
`(("android-core" ,(android-platform-system-core
                   (and=
roid-platform-version)))))

Denis=2E
------AGL55EJOL8NWEHP5SQHJ9WCIEQWSZG-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 03:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 42734@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 42734@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159702969629825 (code B ref -1); Mon, 10 Aug 2020 03:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2020 03:21:36 +0000 Received: from localhost ([127.0.0.1]:33799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yNU-0007kz-0V for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:21:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:44874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yNQ-0007kq-DE for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4yNQ-0004h3-7b for guix-patches@gnu.org; Sun, 09 Aug 2020 23:21:32 -0400 Received: from cyberdimension.org ([80.67.179.20]:59086 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k4yNN-0007Za-Vl for guix-patches@gnu.org; Sun, 09 Aug 2020 23:21:31 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id e300430b; Mon, 10 Aug 2020 03:21:06 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 3e005ae7; Mon, 10 Aug 2020 03:21:06 +0000 (UTC) Date: Mon, 10 Aug 2020 05:19:49 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200810051949.737d799e@primarylaptop.localdomain> In-Reply-To: <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> References: <20200807024423.1638d242@primarylaptop.localdomain> <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/8nTri74povrZU4F_D+WD4TD"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/09 23:21:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Sig_/8nTri74povrZU4F_D+WD4TD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 07 Aug 2020 07:33:03 -0400 Julien Lepiller wrote: > Unfortunately, android-platform-core should first be fixed to accept > a hash as an argument, otherwise any other version will fail. Don't > know why we haven't done that before=E2=80=A6 I don't understand what the hash would be here, nor the consequences you describe. Do you have some pointers on the documentation or source code that I should read to better understand that? By the way I find it a bit strange to refer to have to manually extract=20 android-platform-system-core to be able to refer its include path. Beside the native-input, this results in the following code: > #:make-flags (list (string-append "CFLAGS=3D " > "-I core/include " > [...])) > > [...] > > #:phases > (modify-phases %standard-phases > (add-after 'unpack 'unpack-core > (lambda* (#:key inputs #:allow-other-keys) > (mkdir-p "core") > (with-directory-excursion "core" > (invoke "tar" "axf" (assoc-ref inputs "android-core") > "--strip-components=3D1")) > #t)) > [...]) Instead of just that: > #:make-flags (list (string-append "CFLAGS=3D " > "-I " (assoc-ref %build-inputs "android-core") > "/include ")) > [...])) Another potential improvement would be to remove the android-platform-version argument completely and set version to it in android.mk like that: > (define-public (android-platform-system-core > [...] > (version (android-platform-version)) > [...] That would make the native-input look like that: > (native-inputs > `( > ("android-core" ,android-platform-system-core))) And if we need the version 9.0.0_r3 we could define a new package: > (define-public android-platform-system-core-9 > (package > (inherit android-platform-system-core) > (version "9.0.0_r3")))) and use it: > (native-inputs > `( > ("android-core" ,android-platform-system-core-9))) Are both proposal a good idea? Or does it have any downsides that I didn't think of? Denis. --Sig_/8nTri74povrZU4F_D+WD4TD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8wvNUACgkQX138wUF3 4mMbew//QWCDdDPwInEmtWTlmecXVoOze13W2YNyGiiokobXtRSh3poXYkmdxAXG 9ytz0AD8kEmGsiUA3iTXzSpeyaU0C9WIvWjpXBP4YgHUyJ8Vw/refwsMxvHR1MrX suMKektikY0WPShh2NW4VsoaNiWjmrIhbTKtS30FOwO5gECKOYyts2VyTcaQCUTP cbjPGqOlOIiiZmF6vj0ETGEfJ6YIwmTaJtLEYhYKwMAGKWl6R86btKmT6cEauTyh ZlzdMyiWf/lxOB6OuCvzNInom9J0kXRdlk0rRsFKfMqLs2upjaGMyFGF9/lmV1O2 0OADkcIfqNGoNj0IgxUCTsvrwvCg4WbqqPmcLQWizQhBgpzLX60eTML1SVM47dar aISui4m3XywHBmUqfpmpKwxaxPh+VJ4qjF7iTt18D8GucjCDoWyavfT1MjBStZs9 V+QewJ/JRDhhtpOrZbHiHb2PWS//s6NEV2QNzJhEb5gljdwKC7l0FP4c2RF7KWqw NQBarApNStNXs0MfLmvRqDCCrlIgs5q/tWrXtqIApt92Po428eZ0eBEWunTxjNX+ JIjLgePle2uo0peXRZvVu6oZdfyR9BlVFshyin9VuD0oiB1uDsjo73Ko8jSNbU+B 1mpkyf0aDptp96wmkxd3gY4noutXLDs/l4I2I65pHeOLnxy2FXk= =/YNc -----END PGP SIGNATURE----- --Sig_/8nTri74povrZU4F_D+WD4TD-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 03:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 42734@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 42734@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159703017230565 (code B ref -1); Mon, 10 Aug 2020 03:30:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2020 03:29:32 +0000 Received: from localhost ([127.0.0.1]:33813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yVA-0007wv-Jg for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:29:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:47996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yV8-0007wn-IC for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:29:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4yV8-0006aq-Bc for guix-patches@gnu.org; Sun, 09 Aug 2020 23:29:30 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:39010 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k4yV6-0008R0-3V for guix-patches@gnu.org; Sun, 09 Aug 2020 23:29:30 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 5bbdb43b; Mon, 10 Aug 2020 03:29:05 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id bac8faa4; Mon, 10 Aug 2020 03:29:05 +0000 (UTC) Date: Mon, 10 Aug 2020 05:27:50 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200810052750.23795deb@primarylaptop.localdomain> In-Reply-To: <20200810051949.737d799e@primarylaptop.localdomain> References: <20200807024423.1638d242@primarylaptop.localdomain> <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> <20200810051949.737d799e@primarylaptop.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/yQKX=WNAWEcgTdrMFLdkU33"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=2001:910:1314:ffff::1; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Sig_/yQKX=WNAWEcgTdrMFLdkU33 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 10 Aug 2020 05:19:49 +0200 Denis 'GNUtoo' Carikli wrote: > On Fri, 07 Aug 2020 07:33:03 -0400 > Julien Lepiller wrote: >=20 > > Unfortunately, android-platform-core should first be fixed to accept > > a hash as an argument, otherwise any other version will fail. Don't > > know why we haven't done that before=E2=80=A6 >=20 > I don't understand what the hash would be here, nor the consequences > you describe. Do you have some pointers on the documentation or source > code that I should read to better understand that? >=20 > By the way I find it a bit strange to refer to have to manually > extract android-platform-system-core to be able to refer its include > path. > Instead of just that: > > #:make-flags (list (string-append "CFLAGS=3D " > > "-I " (assoc-ref %build-inputs "android-core") > > "/include ")) > > [...])) One way of doing that would be to create an android-system-core-header package and reference that. Does that look like a good idea? Denis. --Sig_/yQKX=WNAWEcgTdrMFLdkU33 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8wvrYACgkQX138wUF3 4mPD8w/+LY9698Fu0iUCKGztzWy2VT4PSikUharw66gwN8FIQI0DWN8bz6dmVPGt bCfNPsfPSCre1axYxvB1FgMMzR9l40LTAyorw7U1IxgdFBJQTTz8er9ti6AxTUBA bm4AIK/+Ny5lga4gG4zUmvInaTcmSS6czioZQ3IK/+3LS64zCeTG65+hJB6UUhlz aCACYu0tvJNO3BC8eC7bahzdMVjKsXuM0PMXxrBfiLpBTMoMVWsngzNIaezfe/9d pD+k1O/ZO/u5uNz4Z0whHEyeKclMpcQ9rFO5Q6IOeqCMZRUX9nWyd5u5b2/nWywH pdrviGShrhv8jdudGPE5fVr9xISL65zfWg9LLqmolbdoZlnloEwUDOXe3diE1Aio 99IUKzJEsRy3DXCsS+aLirTaaJla1KsJXAwDQECIBVoD86yhIuI9ed/+551pqaOk 2vltaNA5jfqfl5D0rk0U44B8/wZb4TDGBUmKYSqIawV/y9UeiQlEih0QwzOOI5CH eEI5Pvc0u+bAEsHZmCK+qu/ejuWYlxQe867VB3eb9IuZH5bttwGFbTzPHVfzh9C5 vi8JAKlRXCGvSlfVz/fS9E3zLybUMgeNqP5ReMLEdPWu8DW3nThqFUJABaJNrCaF +OfSABm+h3SAJVbpL7tSp8+R9Q0l8uwJkgEHX/3VPBrXVHdwMrk= =lBBx -----END PGP SIGNATURE----- --Sig_/yQKX=WNAWEcgTdrMFLdkU33-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 42734@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 42734@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159703127032286 (code B ref -1); Mon, 10 Aug 2020 03:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2020 03:47:50 +0000 Received: from localhost ([127.0.0.1]:33842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yms-0008Og-8L for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:47:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:48694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4ymq-0008OY-GS for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:47:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4ymq-0008DA-93 for guix-patches@gnu.org; Sun, 09 Aug 2020 23:47:48 -0400 Received: from cyberdimension.org ([2001:910:1314:ffff::1]:39036 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k4ymo-0001pT-6J for guix-patches@gnu.org; Sun, 09 Aug 2020 23:47:48 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id a817d4c2; Mon, 10 Aug 2020 03:47:23 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 08f82f5f; Mon, 10 Aug 2020 03:47:23 +0000 (UTC) Date: Mon, 10 Aug 2020 05:46:08 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200810054608.511a3dd9@primarylaptop.localdomain> In-Reply-To: <20200810052750.23795deb@primarylaptop.localdomain> References: <20200807024423.1638d242@primarylaptop.localdomain> <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> <20200810051949.737d799e@primarylaptop.localdomain> <20200810052750.23795deb@primarylaptop.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/f0yVu=_N74aLkISq_3BZwsQ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=2001:910:1314:ffff::1; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Sig_/f0yVu=_N74aLkISq_3BZwsQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 10 Aug 2020 05:27:50 +0200 Denis 'GNUtoo' Carikli wrote: > One way of doing that would be to create an android-system-core-header > package and reference that. >=20 > Does that look like a good idea? I keep sending mails too fast. Inside the tarball we have: > $ ls include/ > android backtrace binderwrapper cutils diskconfig log memtrack > mincrypt nativebridge netutils private system sysutils usbhost > utils ziparchive So that could be spitted somehow. For instance include/log/ would be packaged in android-liblog for instance. Denis. --Sig_/f0yVu=_N74aLkISq_3BZwsQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8wwwAACgkQX138wUF3 4mMAIQ//TEEr5xYGvXG9qGmc7U/Ekm9aI9JT2g8spFvIEXo6TxwE6EnjyJwwM8yU GfX7Zj9Fft/28dyk6qCPQ29SlZj08LS4HwGkfq5/B5/Zr6ZagMIlcq0/QjgCLbiO Z+XULsMDjs0NZnY3hdkULsJ5ophkbyC4ZPMhkwL2QTU2bV9XTKkzwO92zrtuTn99 HXhXVS+vu5OnZH9mlwbI3fA/8QUP6KrStIW2PxsqFfq1UZUhmF9miQ4gbH+P/BC+ +VI/Z72mr7b4wHK+FfA12LvD4FSjCQ7+gjgH6TfSRIUNk34atWGiw/bZ9u75ZpCD Op9etk9sbool1/NvJIVZeUZQ6wY/7eMQAY80noYsXCOiWJzgyc8j8zMcU856DZ/E aPXEpRWjnFKsyFbWQ7otAlIXH2oYqSKDaVQfBrjeSCfmCrRK2MxhRLMdsxsJrUJn ZdpZ79PuKPgBpqSADiCGb/NxZbyzj+77kscddlEXDKLVncP7sNvunM7ZO+xAuubG F2cgCG8pSTZk4HYm6RMFJyLvjh1cmJvIwkTLgWWyl1nMyszDiSeIAb6esqlo6vqP UXzqxdc7IDesqX1NXiOSMb+TpHp6QdRZmDWMJ5/rp6PdlMhsxVJNmx6fd2YZuiH8 TylzSZ3uaK/mkUxb/7l3MFsPFxRVHALR7DGIkw2GhvXXxgUFmpM= =JRk6 -----END PGP SIGNATURE----- --Sig_/f0yVu=_N74aLkISq_3BZwsQ-- From unknown Sat Jun 21 03:21:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 13:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Denis 'GNUtoo' Carikli Cc: 42734@debbugs.gnu.org Received: via spool by 42734-submit@debbugs.gnu.org id=B42734.159706748325316 (code B ref 42734); Mon, 10 Aug 2020 13:52:01 +0000 Received: (at 42734) by debbugs.gnu.org; 10 Aug 2020 13:51:23 +0000 Received: from localhost ([127.0.0.1]:35001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58Cw-0006aG-RQ for submit@debbugs.gnu.org; Mon, 10 Aug 2020 09:51:23 -0400 Received: from lepiller.eu ([89.234.186.109]:36262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58Cu-0006a5-1g for 42734@debbugs.gnu.org; Mon, 10 Aug 2020 09:51:22 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 2715b142; Mon, 10 Aug 2020 13:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=75oTckrrT5InNKSie03sU9+zEkPrBrA4LYwdcNwe+sc=; b=kZiXE9X IBzZACqwCyu/cDeugZjwweS9SMjfRrXn8j+LnhLuSVn612Our+bPtuq7Q5epAUr8 WuWSObVFMAr4YoMhRTj5cTvDRVwh+2xnlphqzSQt+BYk039aeWDX3iYRJorL6S4D noZwf77pKdX9PX1OfnD3Ul/eE1+cu7RZ2Gbh3hWCE59bdbmbenlGTTL/hOG0BfXx kGlHZ2l10426+4WzWxG/xS7jDGri3fXA2fcZTr13UDCvdirvasaMYV49yD+hMVEM nqNg8HBLh3MguqCaBSrTGQGvSbeOI1+m8My6Q8bRNwZV/MHXBHzJ9PXz6jAloHC+ PKpZwJqEsGJ+rkw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id c9e5b0d6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Mon, 10 Aug 2020 13:51:16 +0000 (UTC) Date: Mon, 10 Aug 2020 09:50:51 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20200810051949.737d799e@primarylaptop.localdomain> References: <20200807024423.1638d242@primarylaptop.localdomain> <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> <20200810051949.737d799e@primarylaptop.localdomain> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----GEN9Q3A30RWOOIESVXXJQEJZHBV5H7" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------GEN9Q3A30RWOOIESVXXJQEJZHBV5H7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think I confused a few things here=2E Currently android-platform-system-c= ore is a procedure that takes a version number and returns an origin record= (a source)=2E However, that record hard-codes a hash, so if you specify a = different version, the source can't be fetcged, as the hash mismatches=2E It also includes patches that may not work with other versions, so I'm not= sure why we allow to pass a version number in tge first place=E2=80=A6 How about this: android-platform-system-core is renamed to android-platform-system-core-so= urce and takes a version, a hash and a list patch names=2E android-platform-system-core is the result of calling this function with t= he default version, hash anl patch set=2E The other source procedures should probably be fixed in the same way=2E I also found out that android-liblog didn't install its headers=2E I'll fi= x that this evening if I remember=2E On 2020=E5=B9=B48=E6=9C=889=E6=97=A5 23:19:49 GMT-04:00, Denis 'GNUtoo' Ca= rikli wrote: >On Fri, 07 Aug 2020 07:33:03 -0400 >Julien Lepiller wrote: > >> Unfortunately, android-platform-core should first be fixed to accept >> a hash as an argument, otherwise any other version will fail=2E Don't >> know why we haven't done that before=E2=80=A6 > >I don't understand what the hash would be here, nor the consequences >you describe=2E Do you have some pointers on the documentation or source >code that I should read to better understand that? > >By the way I find it a bit strange to refer to have to manually extract > >android-platform-system-core to be able to refer its include path=2E > >Beside the native-input, this results in the following code: >> #:make-flags (list (string-append "CFLAGS=3D " >> "-I core/include " >> [=2E=2E=2E])) >> >> [=2E=2E=2E] >> >> #:phases >> (modify-phases %standard-phases >> (add-after 'unpack 'unpack-core >> (lambda* (#:key inputs #:allow-other-keys) >> (mkdir-p "core") >> (with-directory-excursion "core" >> (invoke "tar" "axf" (assoc-ref inputs "android-core") >> "--strip-components=3D1")) >> #t)) >> [=2E=2E=2E]) > >Instead of just that: >> #:make-flags (list (string-append "CFLAGS=3D " >> "-I " (assoc-ref %build-inputs "android-core") >> "/include ")) >> [=2E=2E=2E])) > >Another potential improvement would be to remove the >android-platform-version argument completely and set version to it in >android=2Emk like that: >> (define-public (android-platform-system-core >> [=2E=2E=2E] >> (version (android-platform-version)) >> [=2E=2E=2E] > >That would make the native-input look like that: >> (native-inputs >> `( >> ("android-core" ,android-platform-system-core))) > >And if we need the version 9=2E0=2E0_r3 we could define a new package: >> (define-public android-platform-system-core-9 >> (package >> (inherit android-platform-system-core) >> (version "9=2E0=2E0_r3")))) > >and use it: >> (native-inputs >> `( >> ("android-core" ,android-platform-system-core-9))) > >Are both proposal a good idea? Or does it have any downsides that I >didn't think of? > >Denis=2E ------GEN9Q3A30RWOOIESVXXJQEJZHBV5H7 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think I confused a few things here=2E Currently = android-platform-system-core is a procedure that takes a version number and= returns an origin record (a source)=2E However, that record hard-codes a h= ash, so if you specify a different version, the source can't be fetcged, as= the hash mismatches=2E

It also includes patches that may not work w= ith other versions, so I'm not sure why we allow to pass a version number i= n tge first place=E2=80=A6

How about this:

android-platform-s= ystem-core is renamed to android-platform-system-core-source and takes a ve= rsion, a hash and a list patch names=2E

android-platform-system-core= is the result of calling this function with the default version, hash anl = patch set=2E

The other source procedures should probably be fixed in= the same way=2E

I also found out that android-liblog didn't install= its headers=2E I'll fix that this evening if I remember=2E

On 2020=E5=B9=B48=E6=9C=889=E6=97=A5 23:19:49 GMT-04:00,= Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension=2Eorg> wrote: 
On Fri, 07 Aug 2020 07:33:03 -0400
Julien Lepille=
r <julien@lepiller=2Eeu> wrote:

Unfortunately, android-platform-core should first be fix=
ed to accept
a hash as an argument, otherwise any other version will fai=
l=2E Don't
know why we haven't done that before=E2=80=A6

I don't understand what the hash would be here, nor the consequencesyou describe=2E Do you have some pointers on the documentation or source<=
br>code that I should read to better understand that?

By the way I f=
ind it a bit strange to refer to have to manually extract 
android-platf=
orm-system-core to be able to refer its include path=2E

Beside the n=
ative-input, this results in the following code:
 #:make-flags (list (string-append "CFLAGS=3D "                                   "-I core/include "
 [=2E=2E=2E]))
 [=2E=2E=2E]

 #:phases
 (modify-phases %standard-phases
=
 (add-after 'unpack 'unpack-core
  (lambda* (#:key inputs #:allow-other-=
keys)
   (mkdir-p "core")
    (with-directory-excursion "core"
   =
  (invoke "tar" "axf" (assoc-ref inputs "android-core")
             "--=
strip-components=3D1"))
   #t))
 [=2E=2E=2E])

Ins=
tead of just that:
#:ma=
ke-flags (list (string-append "CFLAGS=3D "
                   "-I " (ass=
oc-ref %build-inputs "android-core")
                   "/include "))[=2E=2E=2E]))

Another potential improvement would be t=
o remove the
android-platform-version argument completely and set versio=
n to it in
android=2Emk like that:
(define-public (android-platform-system-core
[=2E=2E=2E]<=
br> (version (android-platform-version))
[=2E=2E=2E]
That would make the native-input look like that:
(native-inputs
 `(
   ("android-core" ,and=
roid-platform-system-core)))

And if we need the version=
 9=2E0=2E0_r3 we could define a new package:
(define-public android-platform-system-core-9
  (p=
ackage
   (inherit android-platform-system-core)
    (version "9=2E0=
=2E0_r3"))))

and use it:
(native-inputs
 `(
   ("android-core" ,android-=
platform-system-core-9)))

Are both proposal a good idea=
? Or does it have any downsides that I
didn't think of?

Denis=2E<=
br>
------GEN9Q3A30RWOOIESVXXJQEJZHBV5H7--