GNU bug report logs - #42725
[PATCH] drawpile package (sans upnp)

Previous Next

Full log

View this message in rfc822 format

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 42725 <at> debbugs.gnu.org
Subject: [bug#42725] [PATCH] drawpile package (sans upnp)
Date: Fri, 07 Aug 2020 10:34:22 +0200

Hello,

> +       (method url-fetch)
> +       (uri (string-append "https://github.com/drawpile/Drawpile/archive/"
> +                           version
> +                           ".tar.gz"))

We prefer not to use those github archives that can be re-generated and
prefer to use "git-fetch" method instead.

> +       (sha256
> +        (base32
> +         "0brscm95nay31xa1c02n1w144gg9hm8pxwa9sfnis0x5dj2nkrb7"))))
> +    (build-system qt-build-system)
> +    (arguments '(#:tests? #f))

You should explain why tests are not run with a comment.

> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)))
> +    (inputs
> +     `(("giflib" ,giflib)
> +       ("karchive" ,karchive)
> +       ("kdnssd" ,kdnssd)
> +       ("libmicrohttpd" ,libmicrohttpd)
> +       ("libsodium" ,libsodium)
> +       ("libvpx" ,libvpx)
> +       ;("miniupnpc" ,miniupnpc) ;; TODO segfaults for some reason

No need to comment twice.

> +       ("qtbase" ,qtbase)
> +       ("qtkeychain" ,qtkeychain)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("qtsvg" ,qtsvg)))
> +    (home-page "https://drawpile.net")
> +    (synopsis "Collaborative drawing program")
> +    (description
> +"Drawpile is a drawing program that lets you share the canvas with other users
> +in real time.
> +
> +Some feature highlights:
> +Runs on Linux, Windows and OSX

No need to talk about those operating systems I think.

> +Shared canvas using the built-in server or a dedicated server
> +Record, play back and export drawing sessions
> +Simple animation support
> +Layers and blending modes
> +Text layers
> +Supports pressure sensitive Wacom tablets
> +Built-in chat
> +Supports OpenRaster file format
> +Encrypted connections using SSL
> +Automatic port forwarding with UPnP")

You could use texinfo to render this list nicely. See "libmemcached"
package for an example.

Could you send an updated patch?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.