From unknown Wed Jun 18 23:05:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42716 <42716@debbugs.gnu.org> To: bug#42716 <42716@debbugs.gnu.org> Subject: Status: building adns 1.6 on FreeBSD fails Reply-To: bug#42716 <42716@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:42 +0000 retitle 42716 building adns 1.6 on FreeBSD fails reassign 42716 adns submitter 42716 Kurt Jaeger severity 42716 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 05 08:51:27 2020 Received: (at submit) by debbugs.gnu.org; 5 Aug 2020 12:51:27 +0000 Received: from localhost ([127.0.0.1]:50344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3ItB-0002Wd-Bk for submit@debbugs.gnu.org; Wed, 05 Aug 2020 08:51:27 -0400 Received: from fc.opsec.eu ([193.105.105.132]:28317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3IdK-0008N0-N6 for submit@debbugs.gnu.org; Wed, 05 Aug 2020 08:35:03 -0400 Received: from pi by fc.opsec.eu with local (Exim 4.94 (FreeBSD)) (envelope-from ) id 1k3IdG-000CT3-Uv; Wed, 05 Aug 2020 14:34:58 +0200 Date: Wed, 5 Aug 2020 14:34:58 +0200 From: Kurt Jaeger To: submit@debbugs.gnu.org Subject: building adns 1.6 on FreeBSD fails Message-ID: <20200805123458.GM1265@fc.opsec.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 05 Aug 2020 08:51:23 -0400 Cc: pi@freebsd.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Package: adns Hi! I'm the port maintainer for the FreeBSD port dns/adns. While trying to update the port to 1.6, it looks like the test harness / regress setup fails to generate the proper replacement files ? For example: n file included from ../client/adnstest.c:40: In file included from ./hredirect.h:3: ./hsyscalls.h:11:91: error: expected parameter declarator ...fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to , ); ^ The hsyscalls.h file generated from regress/hsyscalls.h.m4 and regress/hsyscalls.i4 seems to add a superflous 'comma' at the end of most calls in that and other files, like this: int Hselect( int max , fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to , ); #ifdef HAVE_POLL int Hpoll( struct pollfd *fds , int nfds , int timeout , ); #endif int Hsocket( int domain , int type , int protocol , ); int Hfcntl( int fd , int cmd , ... , ); int Hconnect( int fd , const struct sockaddr *addr , int addrlen , ); int Hbind( int fd , const struct sockaddr *addr , int addrlen , ); int Hlisten( int fd , int backlog , ); int Hsendto( int fd , const void *msg , int msglen , unsigned int flags , const struct sockaddr *addr , int addrlen , ); int Hrecvfrom( int fd , void *buf , int buflen , unsigned int flags , struct sockaddr *addr , int *addrlen , ); int Hread( int fd , void *buf , size_t buflen , ); int Hwrite( int fd , const void *buf , size_t len , ); -- pi@FreeBSD.org +49 171 3101372 Now what ? From debbugs-submit-bounces@debbugs.gnu.org Sun May 05 17:13:41 2024 Received: (at 42716) by debbugs.gnu.org; 5 May 2024 21:13:41 +0000 Received: from localhost ([127.0.0.1]:33591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3jAz-0007ZA-90 for submit@debbugs.gnu.org; Sun, 05 May 2024 17:13:41 -0400 Received: from permutation-city.chiark.greenend.org.uk ([2a00:1098:86:130::194]:45087 helo=chiark.greenend.org.uk) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3jAv-0007Z1-Be for 42716@debbugs.gnu.org; Sun, 05 May 2024 17:13:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=chiark.greenend.org.uk; s=l.chiark; h=DKIM-Signature-Warning:Subject:To: Date:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From: Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=A6TcJKbOlxa6e/cmOb4P6dvkhl2WhYKGquITLpTvta0=; b=V4dRMRm8NBn0 OqMMIVssN/kByDxTsTNFftG0z0oswt+t3IXNWS99oyxB/TrmDuQVtzy49bWaFZkVURoVutQ8gGCZv BRldEs2uUXU1tuVAJ2hCEtY/wFSafgB/MYris7p/OFctYgHBbATtatiCX+F4+nJ/7tOm3lxL2Qu+l 1umeE6FehX5w4SsQfCQ3dV/bvP4oTYtwRGk23Q/X6SG4IiXYkCOjzzdYCvnp39mkmGe5cd6VhmuNt DligJlKgldMwCknmo1TqUJ9dXsGelU0X3x2CfKK/hCwrgOWTM5kXJREFE28h7LVrjKHuT2USYjdbQ e0UAPUE3oRSQkJ11lJGl3g==; Received: by chiark.greenend.org.uk (Debian Exim 4.94.2 #2) with local (return-path ijackson@chiark.greenend.org.uk) id 1s3jAU-0007Ig-Ub for 42716@debbugs.gnu.org; Sun, 05 May 2024 22:13:10 +0100 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <26167.63078.913788.165779@chiark.greenend.org.uk> Date: Sun, 5 May 2024 22:13:10 +0100 To: 42716@debbugs.gnu.org Subject: Re: bug#42716: building adns 1.6 on FreeBSD fails X-Mailer: VM 8.2.0b under 27.1 (x86_64-pc-linux-gnu) DKIM-Signature-Warning: NOTE REGARDING DKIM KEY COMPROMISE https://www.chiark.greenend.org.uk/dkim-rotate/README.txt https://www.chiark.greenend.org.uk/dkim-rotate/b6/b66cafa4fc90bcf80ac6cbea03983aa6.pem X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42716 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi. This is a very long time ago now, but: > The hsyscalls.h file generated from regress/hsyscalls.h.m4 and > regress/hsyscalls.i4 seems to add a superflous 'comma' at > the end of most calls in that and other files, like this: > > int Hselect( int max , fd_set *rfds , fd_set *wfds , fd_set *efds , > struct timeval *to , ); They look correct to me when I generate them here. I looked at the m4 code. I think `hm_args_massage` at the top of hmacros.i4 is trying to strip trailing commas. Frankly, that code (which I must have written) is quite opaque to be now... I conjecture that: 1. This works in GNU m4, but you are building with FreeBSD's m4 2. Previously this worked for you only because adns prior to 1.6 shipped copies of the m4 output. If my guesses are righyt, you can probably fix it by building with GNU m4. If so, please let me know and I will add something to the docs. Otherwise, I'm mystified. Thanks, Ian. -- Ian Jackson These opinions are my own. Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.