Subject: bug#42716: building adns 1.6 on FreeBSD fails

From: Kurt Jaeger <[email-masked]>
Date: Wed, 5 Aug 2020 14:34:58 +0200

Package: adns

Hi!

I'm the port maintainer for the FreeBSD port dns/adns.

While trying to update the port to 1.6, it looks like the
test harness / regress setup fails to generate the proper replacement
files ?

For example:

n file included from ../client/adnstest.c:40:
In file included from ./hredirect.h:3:
./hsyscalls.h:11:91: error: expected parameter declarator
  ...fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to ,  );
                                                                           ^
The hsyscalls.h file generated from regress/hsyscalls.h.m4 and
regress/hsyscalls.i4 seems to add a superflous 'comma' at
the end of most calls in that and other files, like this:

int Hselect(    int max , fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to ,     );
#ifdef HAVE_POLL
int Hpoll(      struct pollfd *fds , int nfds , int timeout ,   );
#endif
int Hsocket(    int domain , int type , int protocol ,  );
int Hfcntl(     int fd , int cmd , ... ,        );
int Hconnect(   int fd , const struct sockaddr *addr , int addrlen ,    );
int Hbind(      int fd , const struct sockaddr *addr , int addrlen ,    );
int Hlisten(    int fd , int backlog ,  );
int Hsendto(    int fd , const void *msg , int msglen , unsigned int flags , const struct sockaddr *addr , int addrlen ,        );
int Hrecvfrom(  int fd , void *buf , int buflen , unsigned int flags , struct sockaddr *addr , int *addrlen ,   );
int Hread(      int fd , void *buf , size_t buflen ,    );
int Hwrite(     int fd , const void *buf , size_t len ,         );

-- 
[email-masked]         +49 171 3101372                  Now what ?