GNU bug report logs - #42716
building adns 1.6 on FreeBSD fails

Previous Next

To reply to this bug, email your comments to 42716 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kurt Jaeger <pi <at> freebsd.org>
To: submit <at> debbugs.gnu.org
Cc: pi <at> freebsd.org
Subject: building adns 1.6 on FreeBSD fails
Date: Wed, 5 Aug 2020 14:34:58 +0200

Package: adns

Hi!

I'm the port maintainer for the FreeBSD port dns/adns.

While trying to update the port to 1.6, it looks like the
test harness / regress setup fails to generate the proper replacement
files ?

For example:

n file included from ../client/adnstest.c:40:
In file included from ./hredirect.h:3:
./hsyscalls.h:11:91: error: expected parameter declarator
  ...fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to ,  );
                                                                           ^
The hsyscalls.h file generated from regress/hsyscalls.h.m4 and
regress/hsyscalls.i4 seems to add a superflous 'comma' at
the end of most calls in that and other files, like this:

int Hselect(    int max , fd_set *rfds , fd_set *wfds , fd_set *efds , struct timeval *to ,     );
#ifdef HAVE_POLL
int Hpoll(      struct pollfd *fds , int nfds , int timeout ,   );
#endif
int Hsocket(    int domain , int type , int protocol ,  );
int Hfcntl(     int fd , int cmd , ... ,        );
int Hconnect(   int fd , const struct sockaddr *addr , int addrlen ,    );
int Hbind(      int fd , const struct sockaddr *addr , int addrlen ,    );
int Hlisten(    int fd , int backlog ,  );
int Hsendto(    int fd , const void *msg , int msglen , unsigned int flags , const struct sockaddr *addr , int addrlen ,        );
int Hrecvfrom(  int fd , void *buf , int buflen , unsigned int flags , struct sockaddr *addr , int *addrlen ,   );
int Hread(      int fd , void *buf , size_t buflen ,    );
int Hwrite(     int fd , const void *buf , size_t len ,         );

-- 
pi <at> FreeBSD.org         +49 171 3101372                  Now what ?

Message #8 received at 42716 <at> debbugs.gnu.org (full text, mbox):

From: Ian Jackson <ijackson <at> chiark.greenend.org.uk>
To: 42716 <at> debbugs.gnu.org
Subject: Re: bug#42716: building adns 1.6 on FreeBSD fails
Date: Sun, 5 May 2024 22:13:10 +0100

Hi.  This is a very long time ago now, but:

> The hsyscalls.h file generated from regress/hsyscalls.h.m4 and
> regress/hsyscalls.i4 seems to add a superflous 'comma' at
> the end of most calls in that and other files, like this:
>
> int Hselect(    int max , fd_set *rfds , fd_set *wfds , fd_set *efds ,
> struct timeval *to ,     );

They look correct to me when I generate them here.  I looked at the m4
code.  I think `hm_args_massage` at the top of hmacros.i4 is trying to
strip trailing commas.  Frankly, that code (which I must have written)
is quite opaque to be now...

I conjecture that:

 1. This works in GNU m4, but you are building with FreeBSD's m4
 2. Previously this worked for you only because adns prior to 1.6
    shipped copies of the m4 output.

If my guesses are righyt, you can probably fix it by building with GNU
m4.  If so, please let me know and I will add something to the docs.

Otherwise, I'm mystified.

Thanks,
Ian.

-- 
Ian Jackson <ijackson <at> chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.