GNU bug report logs - #42708
Let users copy "*Char Help*" buffer

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>, 42708 <at> debbugs.gnu.org, rms <at> gnu.org
Subject: bug#42708: Let users copy "*Char Help*" buffer
Date: Thu, 12 Nov 2020 09:32:12 +0200

>> > I also wouldn't be happy about wholesale replacement of uses
>> > of `read-char-choice' by `read-char-from-minibuffer'.
>> > Maybe it makes sense to replace some such occurrences, but
>> > it would be good to see some justification case by case.
>>
>> Actually, only one occurrence of `read-char-choice'
>> was replaced by `read-char-from-minibuffer'.
>
> Good.
>
> Could we please know which occurrence you changed,
> and what the justification is?

The changed occurrence is 'dired-query',
and the justification is to fix the bug report #42708.

Also I checked other 4 occurrences of `read-char-choice' in
auth-source.el, emacs-lisp/package.el, net/tramp-cmds.el
and progmodes/octave.el.  But apparently they use more complex
logic, so replacing them with `read-char-from-minibuffer'
is not a straightforward task.

>> > But if `read-char-choice' can itself remain in the
>> > `read-char', `read-event', `read-key', etc. camp, then at
>> > least that will be good, IMO.  Thx.
>>
>> Yes, `read-char-choice' remains in that camp unchanged.
>
> Good.  Thanks for that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.