Subject: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli.

From: Mathieu Othacehe <[email-masked]>
Date: Mon, 03 Aug 2020 10:26:03 +0200

> +    (propagated-inputs
> +     `(("arm-none-eabi-gcc" ,gcc-arm-none-eabi-7-2018-q2-update)
> +       ("avr-gcc" ,avr-toolchain-5)
> +       ("avrdude" ,avrdude)
> +       ("dfu-programmer" ,dfu-programmer)
> +       ("dfu-util" ,dfu-util)
> +       ("git" ,git)
> +       ("python3" ,python)
> +       ("python-appdirs" ,python-appdirs)
> +       ("python-argcomplete" ,python-argcomplete)
> +       ("python-colorama" ,python-colorama)
> +       ("python-flake8" ,python-flake8)
> +       ("python-hjson" ,python-hjson)
> +       ("python-nose2" ,python-nose2)
> +       ("python-yapf" ,python-yapf)))

Do we really need to propagate all those inputs? Can't we hardcode the
path to those tools directly in the sources, if they are not registered at
build time?

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'check 'set-qmk-home
> +                    (lambda _
> +                      ;; tests fail without this variable set
> +                      (setenv "QMK_HOME"
> +                              "")

Who is supposed to set it otherwise?

> +     "A program to help users work with QMK Firmware.")

You also need to elaborate here :)

Thanks,

Mathieu