GNU bug report logs - #42650
[PATCH 1/2] gnu: python-protobuf: Update to 3.12.4.

Previous Next

Full log

Message #13 received at 42650-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 42650-done <at> debbugs.gnu.org
Subject: Re: [bug#42650] [PATCH 2/2] gnu: Add python-onnx.
Date: Mon, 03 Aug 2020 09:05:40 +0200

Hello,

A few comments on this one.

> * gnu/packages/machine-learning.scm (python-onnx): New variable.

You need to mention the added file in the commit message and also add it
to gnu/local.mk.

> +       ;; ONNX will build googletest from a git checkout.  Patch CMake
> +       ;; to use googletest from Guix and enable tests by default.

That seems to be a recurrent issue. Did you fix it by yourself or is
there a patch out there? 

Otherwise both patches look fine. I fixed the patch registering thing
and pushed.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.