From unknown Tue Jun 24 05:12:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh Resent-From: Nick Alcock Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jul 2020 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42633 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 42633@debbugs.gnu.org X-Debbugs-Original-To: GNU Coreutils Bug List Received: via spool by submit@debbugs.gnu.org id=B.159620595022762 (code B ref -1); Fri, 31 Jul 2020 14:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2020 14:32:30 +0000 Received: from localhost ([127.0.0.1]:38387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1W5G-0005v3-5p for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:32:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:44500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1W5E-0005ut-4H for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:32:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1W5D-0007Qs-Tk for bug-coreutils@gnu.org; Fri, 31 Jul 2020 10:32:27 -0400 Received: from icebox.esperi.org.uk ([81.187.191.129]:50974 helo=mail.esperi.org.uk) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1W5B-0007PE-PT for bug-coreutils@gnu.org; Fri, 31 Jul 2020 10:32:27 -0400 Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.15.2/8.15.2) with ESMTP id 06VEWEpP000616 for ; Fri, 31 Jul 2020 15:32:14 +0100 From: Nick Alcock Emacs: it's not slow --- it's stately. Date: Fri, 31 Jul 2020 15:32:14 +0100 Message-ID: <874kpnwya9.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1102; Body=1 Fuz1=1 Fuz2=1 Received-SPF: none client-ip=81.187.191.129; envelope-from=nix@esperi.org.uk; helo=mail.esperi.org.uk X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 10:32:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I get an ERROR when running rmdir/ignore.sh as root (but not when running as non-root). The running system has coreutils 8.31 installed; The source tree, /usr/src/coreutils/x86_64-loom, is a loopback mount of an xfs filesystem dedicated only to this build. (The build subdir shai-build has nothing special about it.) The failure observed is described in a comment in the test as applying only to 8.31 and below: I don't *think* it can be mistakenly running the host touch(1), can it? (This is all built from a bootstrapped git checkout with a locally-updated gnulib, updated five minutes before I did the build.) ERROR: tests/rmdir/ignore ========================= ++ initial_cwd_=/usr/src/coreutils/x86_64-loom/shai-build +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /usr/src/coreutils/x86_64-loom/shai-build gt-ignore.sh.XXXX +++ case $# in +++ destdir_=/usr/src/coreutils/x86_64-loom/shai-build +++ template_=gt-ignore.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ destdir_slash_=/usr/src/coreutils/x86_64-loom/shai-build/ +++ case $template_ in ++++ unset TMPDIR +++ d=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ case $d in +++ : +++ test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++++ ls -dgo /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ perms='drwx------ 2 10 Jul 31 15:23 /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ' +++ case $perms in +++ : +++ echo /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ return ++ test_dir_=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++ cd /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++ case $srcdir in ++ builddir=.. ++ export srcdir builddir ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/usr/src/coreutils/x86_64-loom/shai-build/./src + case $abs_path_dir_ in + PATH=/usr/src/coreutils/x86_64-loom/shai-build/./src:/usr/src/coreutils/x86_64-loom/shai-build/src:/bin:/usr/bin:/sbin:/usr/sbin + create_exe_shims_ /usr/src/coreutils/x86_64-loom/shai-build/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ rmdir + require_built_ rmdir + skip_=no + for i in "$@" + case " $built_programs " in + test no = yes + test yes = yes + local i + for i in $* + env rmdir --version rmdir (GNU coreutils) 8.32-dirty Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie. ++ pwd + cwd=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + mkdir -p /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/x + rmdir -p --ignore-fail-on-non-empty /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/x + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c + mkdir -p x/y + chmod a-w x + returns_ 1 rmdir --ignore-fail-on-non-empty x/y + fail=1 + test -d x/y + fail=1 + touch x/y/z touch: cannot touch 'x/y/z': No such file or directory + framework_failure_ + warn_ 'ignore.sh: set-up failure: ' + case $IFS in + printf '%s\n' 'ignore.sh: set-up failure: ' ignore.sh: set-up failure: + test 9 = 2 + printf '%s\n' 'ignore.sh: set-up failure: ' + sed 1q + Exit 99 + set +e + exit 99 + exit 99 + remove_tmp_ + __st=99 + cleanup_ + : + test '' = yes + cd /usr/src/coreutils/x86_64-loom/shai-build + chmod -R u+rwx /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + rm -rf /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + exit 99 ERROR tests/rmdir/ignore.sh (exit status: 99) From unknown Tue Jun 24 05:12:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jul 2020 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42633 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Nick Alcock , 42633@debbugs.gnu.org Received: via spool by 42633-submit@debbugs.gnu.org id=B42633.15962181949174 (code B ref 42633); Fri, 31 Jul 2020 17:57:01 +0000 Received: (at 42633) by debbugs.gnu.org; 31 Jul 2020 17:56:34 +0000 Received: from localhost ([127.0.0.1]:38574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1ZGj-0002Nt-Qg for submit@debbugs.gnu.org; Fri, 31 Jul 2020 13:56:34 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1ZGh-0002Nf-BN for 42633@debbugs.gnu.org; Fri, 31 Jul 2020 13:56:32 -0400 Received: from [192.168.101.10] ([91.12.165.12]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M76jv-1k7rrb3GGN-008ZlJ; Fri, 31 Jul 2020 19:56:24 +0200 References: <874kpnwya9.fsf@esperi.org.uk> From: Bernhard Voelker Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: Date: Fri, 31 Jul 2020 19:56:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874kpnwya9.fsf@esperi.org.uk> Content-Type: multipart/mixed; boundary="------------62B8E535FB98CFC08E3D64CE" Content-Language: en-US X-Provags-ID: V03:K1:TB1T/sUtpzbVhdssaOQIaLMVANman2TZpdFMu2D8t58H2ipCUEE 8oody0i5uxHIY0wA+kgY0M5lsJPh2QEq+G2KuMs1AvKh6XPnb9GwBRS1HtchBlBN/Pq/Bsd esCLBIi8Lq6q24/3Cd2ZXXEREyK1+mXSmhl/phE+fWaKLYGPwCluJqlbGinFUeQc8cKLmLt SrKvja1IS5/Yq33dgkXLQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/+xWGw9Wnqk=:qxAPtkA9YFY2UZKN3cBvVS ML+kudAgPCP1kofjrszCNCgvv84GyOu7cKB/0cfBtfvWdqxuRvhP5BRqZhio3n3CvFOugK+qk 90Sr+M88FMAjQ4O8mMRsuMloVCYkhON151JoceoZIsD4Xt8CTQcImgUD6zBjOKwSyg5BlLg7g njCgZfp0w6Ac9W8V+R63PxB5N256LbY0j2UA/mJFkybbQRhOIqV4zlDP/RBCh6kxjlep8bP6h ANHKIKa19BYoJrJZ/PcQWiXzI40h1/oFj/QHW21VhkysehIS4Z0oRxjxYMMHQizf9sNBAPoMT ozMmeUgtb1E+Kep77NUv8KcwoLG5dNUFkBYoi/fTpQaBgurJSPOc+GEybfU8vPwlIfnZ6A0A4 nvok+TayNrD47w91faXzXKJmvo2MVfQHPNTrzalCiCcH0eR+zDvsKIlw4B99KGRYYukVXqTZ9 gF2ofQRjeu8d8zdhrGGfjTMkk+dbhukpV/NEiE3s6unVOLsAbxL4MRViap3wPID1Un6qOi1r+ d4gvLNJUzGPOAA8SWOWDKEaKz18yE1nTuBEzcl5XfsWLY8fQ9Hq213PbT3Q7r2buTGZ3GHDrn uI8ALF3L7xbzzdCyc/MS52evc0gflHb6WREQlebNC2Z/1wZnJ5uzLO0/QHL5pcC9GkogyAuJL 5PnZ+3Bug4JdW7UJBXQKDMmBvDdD5Qo22ulDhAfNnMuNj3dVFarWuz9wk+KDnsLBgi0nowupR G6j61Bih8qEJ8lT+MxhUrAkiADRdlsulVLGL/LGes42Esf4azeLz0CegNAM+IXV4JqHZeXtea 8JxAsY9CbVpwfe6VBINUJtg6uCsiFq4FTt8htpXGjXGrq+6kYuexYN32UmgAb4SOw/QWKMkn0 3bkaxhSTxL5FGJNLOKVw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------62B8E535FB98CFC08E3D64CE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2020-07-31 16:32, Nick Alcock wrote: > I get an ERROR when running rmdir/ignore.sh as root (but not when > running as non-root). [...] > ERROR: tests/rmdir/ignore > ========================= [...] > + mkdir -p x/y > + chmod a-w x > + returns_ 1 rmdir --ignore-fail-on-non-empty x/y > + fail=1 Thanks for reporting this issue. Indeed, this test does not work as root. The comment in the test explains that it expects an EPERM error: # Ensure that with --ignore-fail-on-non-empty, we still fail, e.g., for EPERM. # Between 6.11 and 8.31, the following rmdir would mistakenly succeed. mkdir -p x/y || framework_failure_ chmod a-w x || framework_failure_ returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 but root does not see the EPERM; strace output: ... rmdir("x/y") = 0 close(1) = 0 close(2) = 0 exit_group(0) = ? +++ exited with 0 +++ The attached patch adds guards around the parts of the test which only work as non-privileged user. Have a nice day, Berny --------------62B8E535FB98CFC08E3D64CE Content-Type: text/x-patch; charset=UTF-8; name="0001-tests-skip-some-parts-of-tests-rmdir-ignore.sh-if-ru.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-skip-some-parts-of-tests-rmdir-ignore.sh-if-ru.pa"; filename*1="tch" >From c0e5f8c59b951ae13ca9cb9945cd77163489e1d9 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Fri, 31 Jul 2020 19:49:35 +0200 Subject: [PATCH] tests: skip some parts of 'tests/rmdir/ignore.sh' if run as root Parts of this test expect that the rmdir syscall returns with EPERM, but the root user does not see that. * tests/rmdir/ignore.sh: Add uid_is_privileged_ guards around parts of the test which expect rmdir() to fail with EPERM. Reported by Nick Alcock in https://bugs.gnu.org/42633 --- tests/rmdir/ignore.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tests/rmdir/ignore.sh b/tests/rmdir/ignore.sh index 65e92d012..b26ac533a 100755 --- a/tests/rmdir/ignore.sh +++ b/tests/rmdir/ignore.sh @@ -33,17 +33,24 @@ test -d "$cwd/a/b/c" && fail=1 # Between 6.11 and 8.31, the following rmdir would mistakenly succeed. mkdir -p x/y || framework_failure_ chmod a-w x || framework_failure_ -returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 + +if ! uid_is_privileged_; then # root does not get EPERM. + returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 +fi + test -d x/y || fail=1 # Between 6.11 and 8.31, the following rmdir would mistakenly fail, # and also give a non descript error touch x/y/z || framework_failure_ rmdir --ignore-fail-on-non-empty x/y || fail=1 test -d x/y || fail=1 -# assume empty dir if unreadable entries (so failure to remove diagnosed) -rm x/y/z || framework_failure_ -chmod a-r x/y || framework_failure_ -returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 -test -d x/y || fail=1 + +if ! uid_is_privileged_; then # root does not get EPERM. + # assume empty dir if unreadable entries (so failure to remove diagnosed) + rm x/y/z || framework_failure_ + chmod a-r x/y || framework_failure_ + returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 + test -d x/y || fail=1 +fi Exit $fail -- 2.27.0 --------------62B8E535FB98CFC08E3D64CE-- From unknown Tue Jun 24 05:12:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 31 Jul 2020 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42633 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker , Nick Alcock , 42633@debbugs.gnu.org Received: via spool by 42633-submit@debbugs.gnu.org id=B42633.159622458219071 (code B ref 42633); Fri, 31 Jul 2020 19:44:02 +0000 Received: (at 42633) by debbugs.gnu.org; 31 Jul 2020 19:43:02 +0000 Received: from localhost ([127.0.0.1]:38650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1avm-0004xW-CY for submit@debbugs.gnu.org; Fri, 31 Jul 2020 15:43:02 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:34299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1avi-0004x0-CM for 42633@debbugs.gnu.org; Fri, 31 Jul 2020 15:43:00 -0400 Received: by mail-wm1-f67.google.com with SMTP id g10so7018573wmc.1 for <42633@debbugs.gnu.org>; Fri, 31 Jul 2020 12:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zNN/qBPfTpMmwH5aCbUkTKQ1ao9fhXUI9JB3c8JS1Y8=; b=ctca4rJWzplMVNZY+An3Y/m4nRpewQJo4E17ewErWmFk9FSqp8d7twS5kFRo6xTvJM myQNXy+a7YjAfbtkJCj55c+jIdJHUdGUQ9a9+QP96Svz/mLlAup29qhHwzzQySuZuc+b qE+LmcxfmHN5D/JgJCfERgTceKyQvTMVsKTUxT4A4l5HkpeBWD7tLBrKlCnUvkALyMBu 3QmVzhexkTeC8g1rLRPEFIacRE9Ihtp6I5WJFxkkGWL3MK8f4luSEDvbK4GmTjMnrU07 Ioand4tyg85XabJv8rDL5CYuF1JXLiD7+LzvA9URMxc6Y3vyq/9yGvrQMX5u5/BlafR0 wbtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zNN/qBPfTpMmwH5aCbUkTKQ1ao9fhXUI9JB3c8JS1Y8=; b=XNrTouBKPeoo+At2uG4TZPlKuENhkNXekH5lOBwTlE8ZUD0J7rDmaX2VsoC2y22/0a qANnQg6aTQmQLC7AVZNB2+1uFD7khy8wg8tf8WAgP3vvieBPFNAk10yTHSQ5JO7csV0L qX29unc2tRleq1b0Se+zH4BdK5K9aUWcKXZV79nVj4PTiK3J6IjipVEoeYqZxjzvfDBq KP2nF9P1ZnOgdnIZ3qv4IbBEEKCKhAN+kDLSkDiP7UbO8eW6IFP9k6AlA0mXJldJIcy2 YZfL92qkIN3jG2AcRbZPerG+YOsli523t3bOs/0PqFAOMvJXmsKUF3fq7pGG/OBBorGM ol8w== X-Gm-Message-State: AOAM531hksQqNVTSCOA74XhcI8oTUh9Hh4F1AEY6BqzrDOgC8kEVAXcu 83D7Pa3l6IuOaclqG7bOee4yTzQZ X-Google-Smtp-Source: ABdhPJw6IREGidHCYOuPtfezLIEcZyysg4JwmYTQm1X67XDeh/1Ra1iNjJ9pGDxWmLtrctQ+CFu1Fg== X-Received: by 2002:a1c:750a:: with SMTP id o10mr5297488wmc.165.1596224571930; Fri, 31 Jul 2020 12:42:51 -0700 (PDT) Received: from localhost.localdomain (86-42-14-227-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.42.14.227]) by smtp.googlemail.com with ESMTPSA id m20sm21647907wmc.1.2020.07.31.12.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 12:42:51 -0700 (PDT) References: <874kpnwya9.fsf@esperi.org.uk> From: =?UTF-8?Q?P=C3=A1draig?= Brady Message-ID: <4cd4f928-888a-c818-806b-ed5b8bcc83dc@draigBrady.com> Date: Fri, 31 Jul 2020 20:42:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Thunderbird/79.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 31/07/2020 18:56, Bernhard Voelker wrote: > On 2020-07-31 16:32, Nick Alcock wrote: >> I get an ERROR when running rmdir/ignore.sh as root (but not when >> running as non-root). [...] > >> ERROR: tests/rmdir/ignore >> ========================= > [...] >> + mkdir -p x/y >> + chmod a-w x >> + returns_ 1 rmdir --ignore-fail-on-non-empty x/y >> + fail=1 > > Thanks for reporting this issue. > > Indeed, this test does not work as root. > The comment in the test explains that it expects an EPERM error: > > # Ensure that with --ignore-fail-on-non-empty, we still fail, e.g., for EPERM. > # Between 6.11 and 8.31, the following rmdir would mistakenly succeed. > mkdir -p x/y || framework_failure_ > chmod a-w x || framework_failure_ > returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 > > but root does not see the EPERM; strace output: > > ... > rmdir("x/y") = 0 > close(1) = 0 > close(2) = 0 > exit_group(0) = ? > +++ exited with 0 +++ > > The attached patch adds guards around the parts of the test which > only work as non-privileged user. > > Have a nice day, > Berny > Patch looks good thanks. An alternative could be to use rmdir itself to test, like: if ! rmdir x/y 2>/dev/null; then returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 fi cheers, Pádraig From unknown Tue Jun 24 05:12:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh Resent-From: Nick Alcock Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 01 Aug 2020 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42633 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Bernhard Voelker Cc: 42633@debbugs.gnu.org Received: via spool by 42633-submit@debbugs.gnu.org id=B42633.15962907149663 (code B ref 42633); Sat, 01 Aug 2020 14:06:01 +0000 Received: (at 42633) by debbugs.gnu.org; 1 Aug 2020 14:05:14 +0000 Received: from localhost ([127.0.0.1]:40842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1s8P-0002Vn-R9 for submit@debbugs.gnu.org; Sat, 01 Aug 2020 10:05:14 -0400 Received: from icebox.esperi.org.uk ([81.187.191.129]:38818 helo=mail.esperi.org.uk ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1s8N-0002Vb-Cs for 42633@debbugs.gnu.org; Sat, 01 Aug 2020 10:05:12 -0400 Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.15.2/8.15.2) with ESMTP id 071E54VY019018; Sat, 1 Aug 2020 15:05:04 +0100 From: Nick Alcock References: <874kpnwya9.fsf@esperi.org.uk> Emacs: it's not slow --- it's stately. Date: Sat, 01 Aug 2020 15:05:03 +0100 In-Reply-To: (Bernhard Voelker's message of "Fri, 31 Jul 2020 19:56:23 +0200") Message-ID: <87ime2qx68.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1481; Body=2 Fuz1=2 Fuz2=2 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 31 Jul 2020, Bernhard Voelker spake thusly: > On 2020-07-31 16:32, Nick Alcock wrote: >> I get an ERROR when running rmdir/ignore.sh as root (but not when >> running as non-root). [...] > >> ERROR: tests/rmdir/ignore >> ========================= > [...] >> + mkdir -p x/y >> + chmod a-w x >> + returns_ 1 rmdir --ignore-fail-on-non-empty x/y >> + fail=1 > > Thanks for reporting this issue. > > Indeed, this test does not work as root. This suggests that running make check as root is not a routine part of coreutils pre-release work, and that nobody has run a make check as root since Jan 30! That's quite surprising given that running a make check as root has long been encouraged. The README even says > If you can run the tests as root, please do so and report any > problems. We get much less test coverage in that mode, and it's > arguably more important that these tools work well when run by > root than when run by less privileged users. (This is not the first time I've hit test failures when checking released coreutils as root, though it isn't *common*.) > The comment in the test explains that it expects an EPERM error: *slaps self* so it does, I really should have noticed that. > The attached patch adds guards around the parts of the test which > only work as non-privileged user. Looks good to me, and fixes the bug. make check now passes as root. From unknown Tue Jun 24 05:12:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh Resent-From: Bernhard Voelker Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 03 Aug 2020 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42633 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: =?UTF-8?Q?P=C3=A1draig?= Brady , Nick Alcock , 42633@debbugs.gnu.org Received: via spool by 42633-submit@debbugs.gnu.org id=B42633.159648526520119 (code B ref 42633); Mon, 03 Aug 2020 20:08:02 +0000 Received: (at 42633) by debbugs.gnu.org; 3 Aug 2020 20:07:45 +0000 Received: from localhost ([127.0.0.1]:46086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2gkK-0005ER-Qn for submit@debbugs.gnu.org; Mon, 03 Aug 2020 16:07:44 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:35883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2gkJ-0005EE-5T for 42633@debbugs.gnu.org; Mon, 03 Aug 2020 16:07:43 -0400 Received: from [192.168.101.10] ([91.12.165.12]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MSKq0-1k9B0y16UK-00Scyy; Mon, 03 Aug 2020 22:07:36 +0200 References: <874kpnwya9.fsf@esperi.org.uk> <4cd4f928-888a-c818-806b-ed5b8bcc83dc@draigBrady.com> From: Bernhard Voelker Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <08a53e30-e348-c6be-ac99-2fb47c0d3467@bernhard-voelker.de> Date: Mon, 3 Aug 2020 22:07:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4cd4f928-888a-c818-806b-ed5b8bcc83dc@draigBrady.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:FugA7iq0OW3GSYC7lj6a52cMvdGayCs66CO1WlHy1d7Z0VD5uwK iA682Gb7eui9Nmk7+MWw71HRX0bp0JKg3bZ/Oi1X//rpPM0c8GJ+Y5us1k9GpvvX3Z2vdj2 3UdqYUaaY9cmqlZ71grZWlmGMIJTeZrqwzoQWu3an4GABGvkcsdUkGRnSsZKrKwZE9VDzEv qI8M/EB0tJd47Mz9xPQpQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:l9Mpi/MjVAI=:ia+ZrV7mamwknAineizcsJ NV3a93ViXPtnAo7ZpaWO3BybecRqkCUJ3YNG+6r/juTrnHPli7wjPomgqWvKTl1AHwlMYdhqx vXnTSZ233rD6iJp8Ii9PIH83H/tPdlNBJuUWIaCmHkYM/UHqzVCB3Eh9Vx/MjUQu8TR1U39iv Iusy+zm/bZv+DIqdiBPME2Sy3AMXdvdqRUkBIwqnbD7HMtMjWaeOIT+Y6bPq5SJWaEIJHIttJ d5zivI/PF5t6xoCr63d07U1M0vItMpAFhGM6z1RuMSY/xqUZc8+GdZffNlqtOFbDOh2yPXmhW 8r7wHheJEmxkS795EW7NJk2KKNbxGO412dpu0LepOzkz7K01HGsoswWTSw91DiXFvXZ4XzSO4 ZZFlGt4T/2pQbZd3eAqDS4n1B86wpiW/PxxwMHGfyvjZaJXPutMzFp+6yF3+rX+uXALRupxQm 2gVwT9yAKKL3ItrS0AWg5oQ9FSxXDdu2B6M30iZbBJGrJTxFQJxCpU8/bx5vC09x2kaDWNoj7 Hb4j9XOo6NkOnTEIQZAqcqrKxdNkbuvplo+ipYXKbpRDr/LwK7Y0sWLkfqc5RUX6s6jzisHSY ZSo9bj/s2jIY3DrAfDHWiQQOQ7aqAG6gfLusjYP+Y4cUdeYr91bcJR1b6f9ybyqAJHfOhJfoj lsR0Z14UFjEDbOX1IpUf46J9CiJEhr6A6dsEfylTWM2+wwhRidrT9KPuxtTyzLmkIhnymIsfD /kCY/jwH6hWUsXhIMmQHUrNQRBn0DrY8P00fmBBXDVUra8U7VUU9cZ67u1opQBwzxGb8Cr3Jx ND+kt2Cxrz6ma+HtDSJ3aw7q11TrSycVPPCHhN5hfb0X0xG5mbxBuxEuJYjgmdpcENjQBZs X-Spam-Score: -1.5 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 2020-07-31 21:42, Pádraig Brady wrote: > Patch looks good thanks. Thanks. > An alternative could be to use rmdir itself to test, like: > > if ! rmdir x/y 2>/dev/null; then > returns_ 1 rmdir --ignore-fail-on-non-empty x/y || fail=1 > fi I thought about that, but as there's a second hunk to be guarded a couple of lines later, we'd have to remember the result of the test in a variable, and test for that there. That's more code, so unless we're getting new FPs on some platform, I'd go with the standard uid_is_privileged_ function. Pushing soon ... unless there are objections. Thanks again - also for testing, Nick. Have a nice day, Berny From unknown Tue Jun 24 05:12:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nick Alcock Subject: bug#42633: closed (Re: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh) Message-ID: References: <49ef9e90-a019-f2a6-3308-7e83ade160f9@bernhard-voelker.de> <874kpnwya9.fsf@esperi.org.uk> X-Gnu-PR-Message: they-closed 42633 X-Gnu-PR-Package: coreutils Reply-To: 42633@debbugs.gnu.org Date: Mon, 10 Aug 2020 20:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1597091402-7001-1" This is a multi-part message in MIME format... ------------=_1597091402-7001-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42633: 8.32 make check as root failure of rmdir/ignore.sh which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42633@debbugs.gnu.org. --=20 42633: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42633 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1597091402-7001-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42633-done) by debbugs.gnu.org; 10 Aug 2020 20:29:51 +0000 Received: from localhost ([127.0.0.1]:37563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5EQY-0001nR-TY for submit@debbugs.gnu.org; Mon, 10 Aug 2020 16:29:51 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5EQV-0001nC-JJ for 42633-done@debbugs.gnu.org; Mon, 10 Aug 2020 16:29:49 -0400 Received: from [192.168.101.10] ([91.12.165.12]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MelWf-1kf78j2kOD-00akvG; Mon, 10 Aug 2020 22:29:40 +0200 Subject: Re: bug#42633: 8.32 make check as root failure of rmdir/ignore.sh From: Bernhard Voelker To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Nick Alcock , 42633-done@debbugs.gnu.org References: <874kpnwya9.fsf@esperi.org.uk> <4cd4f928-888a-c818-806b-ed5b8bcc83dc@draigBrady.com> <08a53e30-e348-c6be-ac99-2fb47c0d3467@bernhard-voelker.de> Autocrypt: addr=mail@bernhard-voelker.de; prefer-encrypt=mutual; keydata= mQENBFPirzMBCACyzYldTjQ4ufFOkByY5Nn5USb5GFoL48nWBwNHjd9KUbtRRNlQiPNKd6hK Gvd3BGi5aoFKA4ytfRk6jbAbW3jVb3R8wYaV08mOy4KVEKxqN4bxsXlMjNChXVR+rtKDmfI+ oPTL+cPH2X6gW4W02IRbVw0uUhNm6zEedC/gNrY/mTlf1enZ46jxZ7BTUZaG+kx38UMISIMB zSzLRtdkwgmHj4jS3p1fF2cwRqLclIfMjKGpbNFPEXeXKWrCLcqHw78795eAR9q0YvrDkfIn GdDBwfb3VM4NdulwIFzvYZMSXvSbbyPLB5YkHU5aAWQHUse4WlfT5ccDpbzUYldRAvF9ABEB AAG0K0Jlcm5oYXJkIFZvZWxrZXIgPG1haWxAYmVybmhhcmQtdm9lbGtlci5kZT6JATkEEwEC ACMFAlPirzMCGwMHCwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRBGUC73lpFxle5wCACC dbs0QaJ0vR3Sff2cKdTk41rUq3YfWngsR///IOU0C5DdkePmCnJE/lUsUy0LRTxcUDLxQR+x QHU8ssRT0JUO9726dI3miy36UdsgmBYaOtLvQcidGmW1R7o0PYYf04+TFtyqKgngOUBPpMgR 6o4UsQxy/OD4bN1WDqOgIjL+D/qJpkKmgp6L6+hhaBCpiOFKRmmV7YyQ3SqVlfQNiHs5ZtkR nXpIjgZARV+GllKucI17bO0CGmTJZ1tstVy0+W3DQT1lbBkTTc++5LONM99D3jjn23l1ocOp folR53F7I4cb2RNfT23v1I59RH37lB9wMOqrKj0UjYAC2YoPGQ3BuQENBFPirzMBCADXLWWp QihBldY6reca8ZKdc3T9qXEOa3akE3DWKztIBmNJhtYOjmpLYajQTkGa7UoJTnbmZE2Rn6ZE oNnvb0gcFNAIcY95KOI+bjOR8HEgh4cx2REXh6L6olIgyXqt/KFusE4wtVZAFxZl+30HzN6n D+1HvrjXxPJRX6MsIYOYyyX9/6OofwJK6QHODYGp8WL2olHDnmsXg4AT6Wlr7qKpKrQELlcF R4xkvdmgL/Ghw/tK0yJTxMIcewCCZWLPOXRmFRbvAadZWPAgVsJ63siNyUlVnVMSzDgTJl+s l/DMabXpqrJQx3/1Yy6mTaDs3XZT/wmBKaTLXx/LByaPxQQ7ABEBAAGJAR8EGAECAAkFAlPi rzMCGwwACgkQRlAu95aRcZWVPwgAqZT6iTXkoP37wYb41323RzhBcJ8JSk4cyBDBUXX0lMrM 3qhiClKG7phpxVdu817Gwc6Hsecg7FfjQAV8MHQ0ZFeEFdk3b2rKBqfsStc+h49/xF3Fb+if CzR9qeQF82fMSxkg18++7hMcHCMO/hPZ/Q0xRi+lrSr2QKDJQuLzSyVU14TxrCkevZjEhtma VNvcJlJzCbiBXee9Fpc5jITUXPFG8E8dxqo1n+duOyIMgozrAnzP7X5V/Ob/Ozf/aGGX9+Jd inyfCX18nWcHALKMU/36Eua/ylalf/2c2YkBp9KCLVmGgPkUgW52EeRPgroIsiwu+rwCSV6Z UyCJ+OymCg== Message-ID: <49ef9e90-a019-f2a6-3308-7e83ade160f9@bernhard-voelker.de> Date: Mon, 10 Aug 2020 22:29:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <08a53e30-e348-c6be-ac99-2fb47c0d3467@bernhard-voelker.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:SyHPhwIPFLwW00KerOk2qpd7Aomv/o8JglAozq7RyBEwSuvHDrW uMcTzPJ8CYryziiM9tQefnVSevUXvFjmiqfcoloksOaRYzhOKm6qTEeFwFe8NwxszvxFH3j TDxTczQ6VhXbzTIIz2xGRFBfgn+xLQ7Pwid1uDDGgqh0aC+p7lqxlZgqLFt7GzxnGJ7c2Am tyMZVzpnxaSrXQ6yzzQPQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:po5Rrb18TfY=:iFmgjzg5YMyPvaqQOrfzUd VG+i4OKyLboFsXFuMBlCJF9wdf0mGsRlUTLwELg8BgyK7Fa2rXZmViaQBiqdEKEwgX6yRl3Bb 3271yNiIxXOj4v7g9JAkhcVcwIRGngTxQAEPRCjXyCOPFVw8lKL2MTp2LKp1HMn8oN2bRs43b T+zH6Bmg1P8c23jQMxQsG+m9NF74Z/lGKbKC8Rc6i8YMmwLaoI8C/ZqrFBH1bpfdCs8Amgx6B YnCmT0eBFZyP4IHPp0JYl09RUXuWZXGCScxLj9HHkIH0dbxs9nH0zAERmdfAf5rSoCJwwoUln pM6nooX7mEaZJd6BgXLzifW4xlZp31Ea379vmjZIr8vDeYkPtyYpVleYQxMpMY1V2h7nLKxme NjWTfA8Oww3Qs2toKWuc45FK9fTrda+1LWTWUXqNRoabrj1V0FLr5daLIC6aohSeoyutcwrf7 IqJeqB+uVZOeWaMaLhQgWkEhPqXfxt/RJYyqnfbpUJl5cMtenOV0m3HjGSNy/P9w+bppFStGO wyRBD9jS1PEy3imA70v2rmA6DTD36FnKjUXxTnCYFOPEQCGwDrzCQF9Lzzz8eR/WC/IrsNNPE kbrnj5N9NtE3gvShRg94lR8E6rXGZG6qDmvFQkTWr+C4Q2u5Bg091UlzLlzbvNrJbX1rXesi/ Lteohm3nN45P1NkSJPgb4aAHSXbHhjTVV/pe/Jsi6X1aQZ9faXHiPiy35EAQGgqcSjNDyCmnd L9nNW35hYuwUWw1phqjxRirlEpqnLbTLYJgLrTR9T4lYyeWE6IZUJAkAFjsvBGvd5iocZOC/h E3jVkHf8QtEvY3nwMw5meg+Baoehvrf499w/ejY7FVxdFREGddtkR1upTo4K7wcKo1mpUd3Zs M7qOna8ddH9Rn+ajcN7Q== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42633-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2020-08-03 22:07, Bernhard Voelker wrote: > Pushing soon ... unless there are objections. Pushed some days ago, and therefore I'm hereby marking this issue as done. Have a nice day, Berny ------------=_1597091402-7001-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Jul 2020 14:32:30 +0000 Received: from localhost ([127.0.0.1]:38387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1W5G-0005v3-5p for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:32:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:44500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1W5E-0005ut-4H for submit@debbugs.gnu.org; Fri, 31 Jul 2020 10:32:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1W5D-0007Qs-Tk for bug-coreutils@gnu.org; Fri, 31 Jul 2020 10:32:27 -0400 Received: from icebox.esperi.org.uk ([81.187.191.129]:50974 helo=mail.esperi.org.uk) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1W5B-0007PE-PT for bug-coreutils@gnu.org; Fri, 31 Jul 2020 10:32:27 -0400 Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.15.2/8.15.2) with ESMTP id 06VEWEpP000616 for ; Fri, 31 Jul 2020 15:32:14 +0100 From: Nick Alcock To: GNU Coreutils Bug List Subject: 8.32 make check as root failure of rmdir/ignore.sh Emacs: it's not slow --- it's stately. Date: Fri, 31 Jul 2020 15:32:14 +0100 Message-ID: <874kpnwya9.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1102; Body=1 Fuz1=1 Fuz2=1 Received-SPF: none client-ip=81.187.191.129; envelope-from=nix@esperi.org.uk; helo=mail.esperi.org.uk X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 10:32:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=1, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I get an ERROR when running rmdir/ignore.sh as root (but not when running as non-root). The running system has coreutils 8.31 installed; The source tree, /usr/src/coreutils/x86_64-loom, is a loopback mount of an xfs filesystem dedicated only to this build. (The build subdir shai-build has nothing special about it.) The failure observed is described in a comment in the test as applying only to 8.31 and below: I don't *think* it can be mistakenly running the host touch(1), can it? (This is all built from a bootstrapped git checkout with a locally-updated gnulib, updated five minutes before I did the build.) ERROR: tests/rmdir/ignore ========================= ++ initial_cwd_=/usr/src/coreutils/x86_64-loom/shai-build +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /usr/src/coreutils/x86_64-loom/shai-build gt-ignore.sh.XXXX +++ case $# in +++ destdir_=/usr/src/coreutils/x86_64-loom/shai-build +++ template_=gt-ignore.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ destdir_slash_=/usr/src/coreutils/x86_64-loom/shai-build/ +++ case $template_ in ++++ unset TMPDIR +++ d=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ case $d in +++ : +++ test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++++ ls -dgo /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ perms='drwx------ 2 10 Jul 31 15:23 /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ' +++ case $perms in +++ : +++ echo /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ +++ return ++ test_dir_=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++ cd /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ ++ case $srcdir in ++ builddir=.. ++ export srcdir builddir ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/usr/src/coreutils/x86_64-loom/shai-build/./src + case $abs_path_dir_ in + PATH=/usr/src/coreutils/x86_64-loom/shai-build/./src:/usr/src/coreutils/x86_64-loom/shai-build/src:/bin:/usr/bin:/sbin:/usr/sbin + create_exe_shims_ /usr/src/coreutils/x86_64-loom/shai-build/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ rmdir + require_built_ rmdir + skip_=no + for i in "$@" + case " $built_programs " in + test no = yes + test yes = yes + local i + for i in $* + env rmdir --version rmdir (GNU coreutils) 8.32-dirty Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie. ++ pwd + cwd=/usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + mkdir -p /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/x + rmdir -p --ignore-fail-on-non-empty /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/x + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b + test -d /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ/a/b/c + mkdir -p x/y + chmod a-w x + returns_ 1 rmdir --ignore-fail-on-non-empty x/y + fail=1 + test -d x/y + fail=1 + touch x/y/z touch: cannot touch 'x/y/z': No such file or directory + framework_failure_ + warn_ 'ignore.sh: set-up failure: ' + case $IFS in + printf '%s\n' 'ignore.sh: set-up failure: ' ignore.sh: set-up failure: + test 9 = 2 + printf '%s\n' 'ignore.sh: set-up failure: ' + sed 1q + Exit 99 + set +e + exit 99 + exit 99 + remove_tmp_ + __st=99 + cleanup_ + : + test '' = yes + cd /usr/src/coreutils/x86_64-loom/shai-build + chmod -R u+rwx /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + rm -rf /usr/src/coreutils/x86_64-loom/shai-build/gt-ignore.sh.HNnQ + exit 99 ERROR tests/rmdir/ignore.sh (exit status: 99) ------------=_1597091402-7001-1--