GNU bug report logs - #42526
[PATCH] gnu: Add emacs-shx.

Previous Next

Package: guix-patches;

Reported by: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>

Date: Sat, 25 Jul 2020 02:41:01 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>, 42526 <at> debbugs.gnu.org
Subject: [bug#42526] [PATCH] gnu: Add emacs-shx.
Date: Sat, 25 Jul 2020 08:29:26 -0500
[Message part 1 (text/plain, inline)]
Oleg Pykhalov <go.wigust <at> gmail.com> writes:
> Could you also take a look on running test suite in a package 
> recipe, please?

Thank you for pointing that out.  A new patch file is attached 
with tests enabled and passing:
> starting phase `check'
> ✔ shx-tokenize works with apostrophes.
> ✔ shx-tokenize works with partial apostrophes.
> ✔ shx-tokenize returns nil when quoting doesn't match.
> ✔ shx-tokenize works with apostrophes and quotation marks.
> ✔ shx-tokenize works with escaped spaces.
> ✔ shx-tokenize works with escaped quotation marks.
> ✔ shx-tokenize works with escaped characters
> ✔ shx-tokenize works with a directory specified.
> ✔ shx--get-user-cmd returns nil for empty string
> ✔ shx--get-user-cmd returns command with correct prefix
> ✔ shx--safe-as-markup-p recognizes unsafe command
> ✔ shx--safe-as-markup-p recognizes a safe command
> ✔ shx--safe-as-markup-p handles undocumented command
> ✔ shx--quote-regexp matches escaped regexps correctly
> ✔ shx--quote-regexp matches unescaped regexps correctly
> ✔ shx--get-timer-list is empty
> ✔ shx--shx-timer-list grows by 1
> ✔ shx--get-timer-list becomes empty
> ✔ shx.el passes checkdoc
> ✔ shx-cat concatenates strings correctly
> ✔ shx-cat propertizes text correctly
> ✔ shx--shell-command finds the default shell
> ✔ shx--replace-from-list acts sequentially
> ✔ shx--replace-from-list performs the correct replacements
> ✔ shx-el passes check-declare-file
> ✔ shx-cmd-syntax recognizes command with arguments
> ✔ shx-cmd-syntax recognizes alphabetical command names
> ✔ shx-cmd-syntax recognizes hyphenated command names
> ✔ shx--shell-quote-no-quotation-marks escapes string
> ✔ shx.el passes byte-compilation
> ✔ shx-tokenize-filenames works with relative and absolute paths.
> ✔ shx--all-commands lists user command functions
> phase `check' succeeded after 0.2 seconds

--
Joseph LaFreniere
[0001-gnu-Add-emacs-shx.patch (text/x-patch, attachment)]

This bug report was last modified 4 years and 357 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.