GNU bug report logs - #42525
[PATCH 1/2] gnu: Add emacs-pretty-hydra.

Previous Next

Full log

Message #29 received at 42525 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Joseph LaFreniere <joseph <at> lafreniere.xyz>
Cc: 42525 <at> debbugs.gnu.org
Subject: Re: [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sun, 26 Jul 2020 16:04:51 +0200

Hello,

Joseph LaFreniere <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> Note that `guix lint` reports "the source file name should contain the
> package name"; I'm not sure how to resolve that.

You are missing a

  (file-name (git-file-name name version))

expression in `origin'.

> +(define-public emacs-pretty-hydra
> +  (package
> +    (name "emacs-pretty-hydra")
> +    (version "0.2.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jerrypnz/major-mode-hydra.el")
> +             (commit version)))
> +       (sha256
> +        (base32
> +         "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))

Nitpick: please move the string on the same line as `base32'.

> +    (build-system emacs-build-system)

There are some tests using ert-runner. Could you try to enable them?

> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-hydra" ,emacs-hydra)
> +       ("emacs-s" ,emacs-s)))
> +    (arguments
> +     `(#:install '("^pretty-hydra\\.el$")))
> +    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
> +    (synopsis "Major mode keybindings managed by Hydra")
> +    (description
> +     "This package offers an hydra-based method of managing major
> +mode-specific key bindings.  It is intended for use as a library only; see
> +package @code{emacs-major-mode-hydra} for a user-friendly interface.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-minions
>    (package
>      (name "emacs-minions")
> @@ -6148,6 +6176,34 @@ them easier to distinguish from other, less important buffers.")
>  for Ivy and Company that make use of the library.")
>      (license license:expat)))
>  
> +(define-public emacs-pretty-hydra

You added the package twice.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.