GNU bug report logs - #42525
[PATCH 1/2] gnu: Add emacs-pretty-hydra.

Previous Next

Full log

View this message in rfc822 format

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Joseph LaFreniere <joseph <at> lafreniere.xyz>, 42525 <at> debbugs.gnu.org
Subject: [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 25 Jul 2020 09:57:45 -0500

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:
> Joseph LaFreniere <joseph <at> lafreniere.xyz> writes:
>
>> Patch file is attached.  Note that `guix lint` reports "the 
>> source file name
>> should contain the package name";  I'm not sure how to resolve 
>> that.
>
> You could fix this by providing a ‘(file-name (git-file-name 
> name
> version))’ as in other Emacs packages.

Thanks.  Not sure how I missed that.

> 'emacs-build-system' handles '*.el' files, unless you exclude 
> them with
> the recipe bellow.  :-)

Thank you for the tip.  I have changed the include to an exclude.

> Also could you take a look on running a test suite?

The repo's test suite tests both pretty-hydra and 
major-mode-hydra.  Since major-mode-hydra is inheriting from and 
depends on this recipe, I'm assuming it would be rebuilt any time 
the pretty-hydra recipe changes.  Just to minimize the amount of 
work prying apart the repository I have left all of the tests to 
be run in the recipe for major-mode-hydra.  The updated patch for 
that will be following shortly.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-pretty-hydra.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.