Subject: [bug#42511] [PATCH v2 1/2] gnu: python-slugify: Update to 4.0.1.

From: Pierre Langlois <[email-masked]>
Date: Sat, 25 Jul 2020 18:59:31 +0100

Hi Tanguy!

Tanguy Le Carrour writes:

> * gnu/packages/patches/python-slugify-depend-on-unidecode.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): Adjust accordingly.
> * gnu/packages/python-web.scm (python-slugify): Update to 4.0.1. [source] Drop patch.
> ---
>  gnu/local.mk                                  |  1 -
>  .../python-slugify-depend-on-unidecode.patch  | 22 -------------------
>  gnu/packages/python-web.scm                   |  6 ++---
>  3 files changed, 2 insertions(+), 27 deletions(-)
>  delete mode 100644 gnu/packages/patches/python-slugify-depend-on-unidecode.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index f2a7b6b984..bb9b03bb6f 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -1478,7 +1478,6 @@ dist_patch_DATA =						\
>    %D%/packages/patches/python-pygpgme-fix-pinentry-tests.patch	\
>    %D%/packages/patches/python-robotframework-honor-source-date-epoch.patch \
>    %D%/packages/patches/python-shouldbe-0.1.2-cpy3.8.patch	\
> -  %D%/packages/patches/python-slugify-depend-on-unidecode.patch	\
>    %D%/packages/patches/python2-subprocess32-disable-input-test.patch	\
>    %D%/packages/patches/python-tinycss2-flake8-compat.patch	\
>    %D%/packages/patches/python-unittest2-python3-compat.patch	\
> diff --git a/gnu/packages/patches/python-slugify-depend-on-unidecode.patch b/gnu/packages/patches/python-slugify-depend-on-unidecode.patch
> deleted file mode 100644
> index 5ac749c19d..0000000000
> --- a/gnu/packages/patches/python-slugify-depend-on-unidecode.patch
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -diff --git a/setup.py b/setup.py
> -index 4800173..6bdd77f 100755
> ---- a/setup.py
> -+++ b/setup.py
> -@@ -14,8 +14,7 @@ url = 'https://github.com/un33k/python-slugify'
> - author = 'Val Neekman'
> - author_email = [email-masked]'
> - license = 'MIT'
> --install_requires = ['text-unidecode>=1.3']
> --extras_require = {'unidecode': ['Unidecode>=1.1.1']}
> -+install_requires = ['Unidecode']
> -
> - classifiers = [
> -     'Development Status :: 5 - Production/Stable',
> -@@ -67,7 +66,6 @@ setup(
> -     author_email=author_email,
> -     packages=find_packages(exclude=EXCLUDE_FROM_PACKAGES),
> -     install_requires=install_requires,
> --    extras_require=extras_require,
> -     classifiers=classifiers,
> -     entry_points={'console_scripts': ['slugify=slugify.slugify:main']},
> - )

I remember adding this patch, without it csvkit doesn't build with the
following error:

```
starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
Searching for text-unidecode>=1.3
Reading https://pypi.org/simple/text-unidecode/
Download error on https://pypi.org/simple/text-unidecode/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'text-unidecode' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for text-unidecode>=1.3
error: Could not find suitable distribution for Requirement.parse('text-unidecode>=1.3')
command "python" "-c" "import setuptools, tokenize;__file__='setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\\r\\n', '\\n');f.close();exec(compile(code, __file__, 'exec'))" "test" failed with status 1
builder for `/gnu/store/1dmzhmc1miszbwy84s5bvn2pw2zjzgkv-csvkit-1.0.5.drv' failed with exit code 1
build of /gnu/store/1dmzhmc1miszbwy84s5bvn2pw2zjzgkv-csvkit-1.0.5.drv failed
View build log at '/var/log/guix/drvs/1d/mzhmc1miszbwy84s5bvn2pw2zjzgkv-csvkit-1.0.5.drv.bz2'.
guix build: error: build of `/gnu/store/1dmzhmc1miszbwy84s5bvn2pw2zjzgkv-csvkit-1.0.5.drv' failed
```

I'm not familiar enough with the python build/test process to know for
sure if this is an issue with csvkit or python-slugify. We could just
package the python-text-unidecode package, but AFAIU the
python-unidecode package we already have is equivalent so it should be
OK. But somehow csvkit's check procedure doesn't see that.

Should we keep this patch around? Or maybe somebody has a better idea of
what's going on? I realise now I should have added a comment here :-).

Thanks!
Pierre