GNU bug report logs - #42489
[PATCH] services: nix: Provide nix commands.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Peng Mei Yu <i <at> pengmeiyu.com>
Subject: bug#42489: closed (Re: [bug#42489] [PATCH] services: nix: Provide
 nix commands.)
Date: Sat, 25 Jul 2020 09:34:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#42489: [PATCH] services: nix: Provide nix commands.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 42489 <at> debbugs.gnu.org.

-- 
42489: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42489
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Peng Mei Yu <pengmeiyu <at> riseup.net>
Cc: 42489-done <at> debbugs.gnu.org
Subject: Re: [bug#42489] [PATCH] services: nix: Provide nix commands.
Date: Sat, 25 Jul 2020 12:33:19 +0300

[Message part 3 (text/plain, inline)]

Peng Mei Yu <pengmeiyu <at> riseup.net> writes:

>> @@ -134,7 +135,9 @@ GID."
>>     (extensions
>>      (list (service-extension shepherd-root-service-type nix-shepherd-service)
>>            (service-extension account-service-type nix-accounts)
>> -          (service-extension activation-service-type nix-activation)))
>> +          (service-extension activation-service-type nix-activation)
>> +          (service-extension profile-service-type
>> +                             (compose list nix-configuration-package))))
>>     (description "Run the Nix daemon.")
>>     (default-value (nix-configuration))))
>
> The nix-service is useless without commands like nix, nix-env,
> nix-shell, etc.  I think it's a standard that a guix service should
> provide necessary commands in order to use that service.

Ah, good catch!  Pushed your changes to master.

Thanks again,
Oleg.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Peng Mei Yu <i <at> pengmeiyu.com>
To: guix-patches <at> gnu.org
Cc: Peng Mei Yu <i <at> pengmeiyu.com>
Subject: [PATCH] services: nix: Provide nix commands.
Date: Thu, 23 Jul 2020 17:24:13 +0800

* gnu/services/nix.scm (nix-service-type): Extend profile-service-type to
provide nix commands.
---
 gnu/services/nix.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/services/nix.scm b/gnu/services/nix.scm
index 75b2df02dc..e73203c2c5 100644
--- a/gnu/services/nix.scm
+++ b/gnu/services/nix.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019, 2020 Oleg Pykhalov <go.wigust <at> gmail.com>
+;;; Copyright © 2020 Peng Mei Yu <i <at> pengmeiyu.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -134,7 +135,9 @@ GID."
    (extensions
     (list (service-extension shepherd-root-service-type nix-shepherd-service)
           (service-extension account-service-type nix-accounts)
-          (service-extension activation-service-type nix-activation)))
+          (service-extension activation-service-type nix-activation)
+          (service-extension profile-service-type
+                             (compose list nix-configuration-package))))
    (description "Run the Nix daemon.")
    (default-value (nix-configuration))))
 
-- 
2.27.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.