From unknown Sat Jun 21 03:21:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42482 <42482@debbugs.gnu.org> To: bug#42482 <42482@debbugs.gnu.org> Subject: Status: 27.0.91; emacs modules memory leak Reply-To: bug#42482 <42482@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:21:43 +0000 retitle 42482 27.0.91; emacs modules memory leak reassign 42482 emacs submitter 42482 Milan Stanojevi=C4=87 severity 42482 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 22 19:26:05 2020 Received: (at submit) by debbugs.gnu.org; 22 Jul 2020 23:26:05 +0000 Received: from localhost ([127.0.0.1]:43364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyO7h-0000so-5n for submit@debbugs.gnu.org; Wed, 22 Jul 2020 19:26:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:35656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyO7e-0000sf-MW for submit@debbugs.gnu.org; Wed, 22 Jul 2020 19:26:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyO7e-000367-ES for bug-gnu-emacs@gnu.org; Wed, 22 Jul 2020 19:26:02 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:52002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyO7b-0003bT-Qi for bug-gnu-emacs@gnu.org; Wed, 22 Jul 2020 19:26:01 -0400 X-JS-Received: from [30.40.81.8] (helo=tot-qpr-mailcore1) by mxout5.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94) (envelope-from ) id 1jyO7a-0005Ed-Cc for bug-gnu-emacs@gnu.org; Wed, 22 Jul 2020 19:25:58 -0400 X-JS-Flow: external X-JS-Received: by tot-qpr-mailcore1 with ocaml/mailcore/main_production (a856a1269fd0) (envelope-from ) id BfGMsG-tJ-cQA-JV; 2020-07-22 19:25:58.360399-04:00 X-JS-Scanner-attachment: create_global_refs.c: not scanned (internal mail); create_global_refs_test.el: not scanned (internal mail) X-JS-Scanner-esets: Not scanned (internal mail) Received: from mail-wm1-f69.google.com ([209.85.128.69]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94) id 1jyO7Y-0007e1-TZ for bug-gnu-emacs@gnu.org; Wed, 22 Jul 2020 19:25:57 -0400 Received: by mail-wm1-f69.google.com with SMTP id v8so1181537wma.6 for ; Wed, 22 Jul 2020 16:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=hkrqcp1OsKm/xvDymqnxL+hv0G6jer/AIFnTmzTsfjc=; b=iokl3FxvK9wMxh+RvjYhowga4K+6ebcdznYGm+EWBEBKsTX47p/u9gBViZHY//Vg8Z H0RJIVMD9myw6PpEZ5w9ViirFtlw/EncBMHRYX+ISGYFk/hzgRDlV4msaAtJpSXQ4TVB bFO0FHXZuD71TfMqMkXqwrVX2dpPHX2uD1Df4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hkrqcp1OsKm/xvDymqnxL+hv0G6jer/AIFnTmzTsfjc=; b=IU33oTXDFQUDMGWCDOt45+/rAvqhHiYGI5Nq54tS5iYq769pDkIbSwIJvL8KHRJm6R t6Sht2ukNh05rz8kxT8hJgcW3Ti2jYMETW8sYjrlFebI5Koh3GWJZGUFRxiPUlyOHIWG Lr7Bt0BWzXBvfsr/iAZF0Pbr/MrXcjKT7o/Hh8MFcSoY0gXLq6dpApKpjwR95Yn4Ohwg jRpPg8+1z9gXXGYo7ZhKvSRTfBeKW9VSuBe6D8/KDFQX8NOYK8Gg8foIjXcHQOgJZwjs dIyk2RZD2jx8yj9cKU3oBb3y2o2N/0MekVGd7sdpYksYHxSsZiveAA9Mk+4Bz8sSW4RM bQTw== X-Gm-Message-State: AOAM531EFn3X83B2TjWzttybfwzLlyjEYaDpMYMXyvthxcflBH7PoNZL xG073oc55GL/rbV/xKn/TC3hye9QsxEJ+yjdMbGxSJu1opWcJHWQYKYWv8TXB3IU6jLRq5ZwalU qBmOFxqVbM4x75HFnIC4CgJFI1Ebtng== X-Received: by 2002:adf:dfc8:: with SMTP id q8mr1459224wrn.231.1595460356016; Wed, 22 Jul 2020 16:25:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWG3QV74NnMbu8A0c+q+Zf9+wUHERX7MCj9rwy7AfaqPTV4gYgsWSU7sfXsYgxUSVQ3J0Zg7CLbhIDhHDOH2M= X-Received: by 2002:adf:dfc8:: with SMTP id q8mr1459211wrn.231.1595460355673; Wed, 22 Jul 2020 16:25:55 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Date: Wed, 22 Jul 2020 19:25:19 -0400 Message-ID: Subject: 27.0.91; emacs modules memory leak To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000c1150f05ab100fe0" X-JS-Exim-Data-Received: 2020-07-22 19:25:57-0400 X-JS-Processed-by: mailcore Received-SPF: pass client-ip=64.215.233.18; envelope-from=mstanojevic@janestreet.com; helo=mxout5.mail.janestreet.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 19:25:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --000000000000c1150f05ab100fe0 Content-Type: text/plain; charset="UTF-8" env-make_global_ref adds a reference to the underlying Lisp_Object and allocates emacs_value from the global storage. env->free_global_ref on the other hand will only remove a reference to the underlying Lisp_Object and not free the emacs_value. Here is a simple recipe to reproduce the problem (I only tested this on linux). I'm attaching the necessary files. $ gcc -shared -fpic -std=c99 -I create_global_refs.c -o create_global_refs.so $ emacs --no-splash -q -l create_global_refs.so -l create_global_refs_test.el If you look at the memory usage of emacs (for example in htop) you'll see that with emacs-26 it is constant but with emacs-27 the resident memory quickly grows. --000000000000c1150f05ab100fe0 Content-Type: text/x-csrc; charset="US-ASCII"; name="create_global_refs.c" Content-Disposition: attachment; filename="create_global_refs.c" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcxzsbuv0 I2luY2x1ZGUgPHN0cmluZy5oPgojaW5jbHVkZSA8ZW1hY3MtbW9kdWxlLmg+CgppbnQgcGx1Z2lu X2lzX0dQTF9jb21wYXRpYmxlOwoKc3RhdGljIGVtYWNzX3ZhbHVlIGNyZWF0ZV9sb29wIChlbWFj c19lbnYgKmVudiwgcHRyZGlmZl90IF9uYXJncywgZW1hY3NfdmFsdWUgX2FyZ3NbXSwgdm9pZCog X2RhdGEpCnsKICBmb3IgKGludCBpID0gMDsgaSA8IDEwMDAwMDA7IGkrKykKICAgIGVudi0+ZnJl ZV9nbG9iYWxfcmVmCiAgICAgIChlbnYsCiAgICAgICBlbnYtPm1ha2VfZ2xvYmFsX3JlZgogICAg ICAgKGVudiwKICAgICAgICBlbnYtPm1ha2VfaW50ZWdlcihlbnYsIDApKSk7CgogIGNoYXIgbXNn W10gPSAiMU0gZ2xvYmFsIHJlZmVyZW5jZXMgY3JlYXRlZCBhbmQgZnJlZWQiOwogIGVtYWNzX3Zh bHVlIG1lc3NhZ2UgPSB7IGVudi0+bWFrZV9zdHJpbmcoZW52LCBtc2csIHN0cmxlbihtc2cpKSB9 OwogIGVudi0+ZnVuY2FsbChlbnYsIGVudi0+aW50ZXJuKGVudiwgIm1lc3NhZ2UiKSwgMSwgJm1l c3NhZ2UpOwoKICByZXR1cm4gZW52LT5pbnRlcm4oZW52LCAibmlsIik7Cn0KCmludCBlbWFjc19t b2R1bGVfaW5pdCAoc3RydWN0IGVtYWNzX3J1bnRpbWUgKmVydCkgewogIGVtYWNzX2VudiogZW52 ID0gZXJ0LT5nZXRfZW52aXJvbm1lbnQoZXJ0KTsKCiAgZW1hY3NfdmFsdWUgbG9vcGYgPSBlbnYt Pm1ha2VfZnVuY3Rpb24oZW52LCAwLCAwLCBjcmVhdGVfbG9vcCwgImNyZWF0ZSBhbmQgZnJlZSAx TSByZWZzIiwgTlVMTCk7CgogIGVtYWNzX3ZhbHVlIGFyZ3NbXSA9IHsgZW52LT5pbnRlcm4oZW52 LCAiY3JlYXRlLXJlZnMtbG9vcCIpLCBsb29wZiB9OwogIGVudi0+ZnVuY2FsbChlbnYsIGVudi0+ aW50ZXJuKGVudiwgImZzZXQiKSwgMiwgYXJncyk7CgogIGVtYWNzX3ZhbHVlIHNpbXBsZV9sb29w X2ZlYXR1cmUgPSBlbnYtPmludGVybihlbnYsICJjcmVhdGUtZ2xvYmFsLXJlZnMiKTsKICBlbnYt PmZ1bmNhbGwoZW52LCBlbnYtPmludGVybihlbnYsICJwcm92aWRlIiksIDEsICZzaW1wbGVfbG9v cF9mZWF0dXJlKTsKCiAgcmV0dXJuIDA7Cn0K --000000000000c1150f05ab100fe0 Content-Type: text/x-emacs-lisp; charset="US-ASCII"; name="create_global_refs_test.el" Content-Disposition: attachment; filename="create_global_refs_test.el" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcxzsizl1 KHJlcXVpcmUgJ2NyZWF0ZS1nbG9iYWwtcmVmcykKCihkZWZ1biBydW4tb25lLWl0ZXJhdGlvbi1h bmQtZ2MgKCkKICAoY3JlYXRlLXJlZnMtbG9vcCkKICAoZ2FyYmFnZS1jb2xsZWN0KSkKCihzd2l0 Y2gtdG8tYnVmZmVyIChnZXQtYnVmZmVyLWNyZWF0ZSAiKk1lc3NhZ2VzKiIpKQoKKHJ1bi13aXRo LXRpbWVyIDAuMSAxICdydW4tb25lLWl0ZXJhdGlvbi1hbmQtZ2MpCg== --000000000000c1150f05ab100fe0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 08:07:15 2020 Received: (at 42482-done) by debbugs.gnu.org; 23 Jul 2020 12:07:15 +0000 Received: from localhost ([127.0.0.1]:44290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jya0J-0005Eq-II for submit@debbugs.gnu.org; Thu, 23 Jul 2020 08:07:15 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:43688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jya0H-0005Ee-Qj for 42482-done@debbugs.gnu.org; Thu, 23 Jul 2020 08:07:14 -0400 Received: by mail-ot1-f49.google.com with SMTP id 95so4125950otw.10 for <42482-done@debbugs.gnu.org>; Thu, 23 Jul 2020 05:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jmgGuqVgxZ6dyeNONIkEpR22CD4uabzcoa3uUAAdfhE=; b=OJm7r57aSKMDNlCzqd+gY9faDgFzxLiXDDnNr4NMo0Az16seXrcgAh0H1OVKkHlHiI PqOFojWCevVbcYbuGD0P8zfyqfXtuLlRUF7cLkzu/1fme3iJTkli8dgAY6Llj7GO2AoK cN3FwJmQbFtSxGbVtcVqV4hpEa3LF+Tqxmo9ZMhcKacZyE6xu5huDDcl6+gkvlHaKEYi AMacKmCnBUJk/uVlgcdZHD5PTF0pQc/xdWWLjyH22MLFxiDpPXOU6DnEwp5/hjh134zC YtDF2zqdO9ocOcN7n6e7M6u0BkmUhzwuZU9iTh0n/XeZ5yAaJQWFEQNN8e6sZAT8VaOH uCwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jmgGuqVgxZ6dyeNONIkEpR22CD4uabzcoa3uUAAdfhE=; b=Y4/hAp39Km5S24ke4fTsVtEHI9DHPGKXT1+hLbKDl5PwUNolASzCuyzpCNc0NjEfOl etlhynOUB51zBlaO275tLoPLMD/J+PD71SILd8E6zksmyUNEYxFzuMrRUBLvMrSzVx77 zbcoAIaFcw/mq43HTSM69hhyuJZ2lza407PMsYgA1f7lACiVtvDo1wAeWgKX3BuGAl+z nPIDHoigaTqRcfzNeR46t9qwcj+MT+ioZI+EU1KNKvitZCnEX2LxhYLyqW3MORwtnFa2 nY8mmWl81LtIfBhGNYUfYqT9wYTqzzNY/AvTiZWMSrnTG3uYkXXpxFu8ZZtbXDC3LmcF WHzA== X-Gm-Message-State: AOAM533Yx2q7yAmlS0TNhppXx7/7ZIE3f3JjdDgPu/23GuhNN8WZi6Xe vJt9DKZZkIkwBvGN4vYQQYB2vMvj4bSX4TU9y4g= X-Google-Smtp-Source: ABdhPJwcXjsHRYFpaknqahe6I/8at3oGekOR3PDs0jZQwPnIumOLUZmvyjc0lqO0DWIQIt5Zhk+8SeYq0rhZ3ndT1Qc= X-Received: by 2002:a9d:2203:: with SMTP id o3mr3576600ota.149.1595506028153; Thu, 23 Jul 2020 05:07:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Thu, 23 Jul 2020 14:06:57 +0200 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42482-done Cc: 42482-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 23. Juli 2020 um 01:27 Uhr schrieb Milan Stanojevi=C4=87 : > > env-make_global_ref adds a reference to the underlying Lisp_Object > and allocates emacs_value from the global storage. env->free_global_ref > on the other hand will only remove a reference to the underlying > Lisp_Object and not free the emacs_value. > > Here is a simple recipe to reproduce the problem (I only tested this > on linux). I'm attaching the necessary files. > > $ gcc -shared -fpic -std=3Dc99 -I > create_global_refs.c -o create_global_refs.so > $ emacs --no-splash -q -l create_global_refs.so -l create_global_refs_tes= t.el > > If you look at the memory usage of emacs (for example in htop) you'll > see that with emacs-26 it is constant but with emacs-27 the resident > memory quickly grows. Thanks for the report. I've fixed this in commit 5c5eb9790898e4ab10bcbbdb6871947ed3018569; the fix is slightly different from what you proposed in that it stores the emacs_value object in the global references hashtable, but it should have the same effect. At least I can't reproduce the symptom any more after that commit. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 10:29:55 2020 Received: (at 42482-done) by debbugs.gnu.org; 23 Jul 2020 14:29:55 +0000 Received: from localhost ([127.0.0.1]:45763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycEN-0002mY-DX for submit@debbugs.gnu.org; Thu, 23 Jul 2020 10:29:55 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:48969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycEK-0002mI-JW for 42482-done@debbugs.gnu.org; Thu, 23 Jul 2020 10:29:54 -0400 X-JS-Received: from [30.40.81.8] (helo=tot-qpr-mailcore1) by mxout5.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94) (envelope-from ) id 1jycEE-0000pN-VS for 42482-done@debbugs.gnu.org; Thu, 23 Jul 2020 10:29:46 -0400 X-JS-Flow: external X-JS-Received: by tot-qpr-mailcore1 with ocaml/mailcore/main_production (a856a1269fd0) (envelope-from ) id BfGZ7a-tJ-cQA-ci; 2020-07-23 10:29:46.959719-04:00 X-JS-Scanner-attachment: No attachments X-JS-Scanner-esets: Not scanned (internal mail) Received: from mail-wm1-f72.google.com ([209.85.128.72]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94) id 1jycED-0000ig-HC for 42482-done@debbugs.gnu.org; Thu, 23 Jul 2020 10:29:45 -0400 Received: by mail-wm1-f72.google.com with SMTP id f74so2598938wmf.1 for <42482-done@debbugs.gnu.org>; Thu, 23 Jul 2020 07:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=45kIpnI6TklTvpaXiKA8pfBcnltb7Q6T064NledhvEs=; b=MX9KhpiXwwNC1B2q9apHIQarh9PCITdY4McNQ3ERxrGfi3fht76xKXDFB4YclONk5u /qf9nAx4hkjKtILQM/IviGoJ1WrL1huma9rl41c3ZkOjWshv1lGcl9SsWeMNm+XOrYA7 RVYqDgT0ZM95Q5BcCoFjW8aVKypb3FUKjTRCA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=45kIpnI6TklTvpaXiKA8pfBcnltb7Q6T064NledhvEs=; b=YKFLSDvT9G4tS7YYQ+luU31zp7cpQbUYoxOLyP/QUH6Q+JbQi8dD4y24JvjVN7Xp+4 JhcFut12B2X116mE8aJw3LG3S8+mRBBzZ4or+trCdNbvOcwh1ENkFsQoQamyFn+rlpzW pkjy3LesSBOttTn6hceKE40gsh/D3bR1BumOXAnC6IlZuzT1mmzUu3XyAvvCKrEVeeO/ IEG2J1kaamXHxIpQvgQswvzjbHbs7Misu73zgXjNM7Z4avjm7RM79NVAWf/BaWB5w7Bo p48hw9qlFNdvojFvvIwJyVmSiloU9adY7eGY/5LQHHdGvePd7Rn/80vWbg/ZkJAOW62e E7wQ== X-Gm-Message-State: AOAM532FHPbVlvcd1lgzpv/mfDzFGk3y5d0fuLhzxOyoHQICwD7ZEmBH 3RKId6UKyYWbK0+5TZem1xYmYKk8zhqAv2f2OqNeu3ah25NNZjPiZNd0fOkQvjOt52wE3Rt4ULL jPgnz7qyNnEYIcsD21FSpoFIcE2Q15S9WJjSZ X-Received: by 2002:adf:97dc:: with SMTP id t28mr4015466wrb.291.1595514584674; Thu, 23 Jul 2020 07:29:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVKnifs9z29KyeSdLz1O0ciYeeagn1TbrwXQrIC1uFfHfnNM8B3e83zUIcU++iMxTX10CyXgmoYpaEsgm47xc= X-Received: by 2002:adf:97dc:: with SMTP id t28mr4015449wrb.291.1595514584419; Thu, 23 Jul 2020 07:29:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Date: Thu, 23 Jul 2020 10:29:08 -0400 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Philipp Stephani Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-JS-Exim-Data-Received: 2020-07-23 10:29:45-0400 X-JS-Processed-by: mailcore X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482-done Cc: 42482-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thank you for the quick fix. Is there a chance this also goes to emacs-27 branch so it can be in the emacs 27.1 when it gets released? On Thu, Jul 23, 2020 at 8:07 AM Philipp Stephani wr= ote: > > Am Do., 23. Juli 2020 um 01:27 Uhr schrieb Milan Stanojevi=C4=87 > : > > > > env-make_global_ref adds a reference to the underlying Lisp_Object > > and allocates emacs_value from the global storage. env->free_global_ref > > on the other hand will only remove a reference to the underlying > > Lisp_Object and not free the emacs_value. > > > > Here is a simple recipe to reproduce the problem (I only tested this > > on linux). I'm attaching the necessary files. > > > > $ gcc -shared -fpic -std=3Dc99 -I > > create_global_refs.c -o create_global_refs.so > > $ emacs --no-splash -q -l create_global_refs.so -l create_global_refs_t= est.el > > > > If you look at the memory usage of emacs (for example in htop) you'll > > see that with emacs-26 it is constant but with emacs-27 the resident > > memory quickly grows. > > Thanks for the report. I've fixed this in commit > 5c5eb9790898e4ab10bcbbdb6871947ed3018569; the fix is slightly > different from what you proposed in that it stores the emacs_value > object in the global references hashtable, but it should have the same > effect. At least I can't reproduce the symptom any more after that > commit. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 10:33:31 2020 Received: (at 42482-done) by debbugs.gnu.org; 23 Jul 2020 14:33:31 +0000 Received: from localhost ([127.0.0.1]:45776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycHr-0002uJ-A0 for submit@debbugs.gnu.org; Thu, 23 Jul 2020 10:33:31 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:42490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jycHp-0002u7-MO for 42482-done@debbugs.gnu.org; Thu, 23 Jul 2020 10:33:30 -0400 Received: by mail-ot1-f53.google.com with SMTP id g37so4464659otb.9 for <42482-done@debbugs.gnu.org>; Thu, 23 Jul 2020 07:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bHkBrjjlL6QQijnp9x7HKyGQAlKN+PLoOr3zYbNs6Bk=; b=YTfHQ+I2qjPi2ym4GqS/QWxE0eEI1BYkeRl74ifODDZl8/5qWCNQXZqQad+oBW1YuM TO/eHdXmvrJZK4SOYGb8GHQZB5qcLqcbc6kClYAt42ZNJO5d8D2HUZ1k0VvqQVl857yy R36S98F0mCbBcoNEkfUgvmRzv8SAzcsuz0yL5m762pU2jCHpoiDni4EoNtNs0WbDgdQL 1UeqqxXA4lTrrNX9kc0M61J+z3vl7pUK6/7YHpp/dlW8ckJ8flUqYCv7tkue6tCKkVw5 eAb8fIKmX+ly4PsUUbln9kcnKY8N45g0KBCXi5JhYrgSp0LgkKN/FkLpXQFlfwANHL9M WRfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bHkBrjjlL6QQijnp9x7HKyGQAlKN+PLoOr3zYbNs6Bk=; b=dQYeNHrq3+DrMQGKE0sgFjHLf/mZqC4ui/Mn0EGnHS/XRBD58wI+SsDG82CVJ3Y5/D tYcNgvz5c4Qs7hqHzRKnx6adetSgW09f7heUu9FspyPvPflAmafSVFtgZ0UtL9bUH5nm f4L0YMZcsZtB1sOq1PPwD0WkamRQYQU3d1K9vWEy6wh2HVR7l+1Lr/L5xmgelRvcibyC bjMkfAGyKk+5tg1uSvKTazaWKY5da/AxOhlmyISSrKaFr4B/cMvuPGw8ICsKsIIaXDjK O0hivMu6sHIMJ1fI2j/wsvILkuCFMzRUhFCp4Dw+4XrbCeOI2FpZ1gqezWF59BQYtR5S bonQ== X-Gm-Message-State: AOAM531qGlLrQZRNa/kBy/J45/KNohgREi1mCbwW1oRvDEuytsSybLUt oUnZAKZQb0LA8pv9SWWPNNbjYq/KiSv9aUYbgO4= X-Google-Smtp-Source: ABdhPJy5y5REVpu1pzJD6nGNWyg4xcFAx3IRckoPr067AiQC4hdKKJOmI79iNRYAaNwhmdb7IrlSEcMMumxWkzsy8gc= X-Received: by 2002:a9d:7995:: with SMTP id h21mr4129635otm.174.1595514803904; Thu, 23 Jul 2020 07:33:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Thu, 23 Jul 2020 16:33:12 +0200 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42482-done Cc: 42482-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojevi=C4=87 : > > Thank you for the quick fix. > Is there a chance this also goes to emacs-27 branch so it can be in > the emacs 27.1 when it gets released? I think backporting the fix should be fine, as the fix is rather localized and fixes a regression. Eli? > > On Thu, Jul 23, 2020 at 8:07 AM Philipp Stephani = wrote: > > > > Am Do., 23. Juli 2020 um 01:27 Uhr schrieb Milan Stanojevi=C4=87 > > : > > > > > > env-make_global_ref adds a reference to the underlying Lisp_Object > > > and allocates emacs_value from the global storage. env->free_global_r= ef > > > on the other hand will only remove a reference to the underlying > > > Lisp_Object and not free the emacs_value. > > > > > > Here is a simple recipe to reproduce the problem (I only tested this > > > on linux). I'm attaching the necessary files. > > > > > > $ gcc -shared -fpic -std=3Dc99 -I > > > create_global_refs.c -o create_global_refs.so > > > $ emacs --no-splash -q -l create_global_refs.so -l create_global_refs= _test.el > > > > > > If you look at the memory usage of emacs (for example in htop) you'll > > > see that with emacs-26 it is constant but with emacs-27 the resident > > > memory quickly grows. > > > > Thanks for the report. I've fixed this in commit > > 5c5eb9790898e4ab10bcbbdb6871947ed3018569; the fix is slightly > > different from what you proposed in that it stores the emacs_value > > object in the global references hashtable, but it should have the same > > effect. At least I can't reproduce the symptom any more after that > > commit. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 13:45:54 2020 Received: (at 42482) by debbugs.gnu.org; 23 Jul 2020 17:45:54 +0000 Received: from localhost ([127.0.0.1]:45945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyfI2-0007W3-Fi for submit@debbugs.gnu.org; Thu, 23 Jul 2020 13:45:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyfI0-0007Vq-Da for 42482@debbugs.gnu.org; Thu, 23 Jul 2020 13:45:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45312) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyfHu-00042p-P6; Thu, 23 Jul 2020 13:45:46 -0400 Received: from [176.228.60.248] (port=4694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jyfHu-0007xi-2x; Thu, 23 Jul 2020 13:45:46 -0400 Date: Thu, 23 Jul 2020 20:45:28 +0300 Message-Id: <83365if7lz.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-Reply-To: (message from Philipp Stephani on Thu, 23 Jul 2020 16:33:12 +0200) Subject: Re: bug#42482: 27.0.91; emacs modules memory leak References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482 Cc: 42482@debbugs.gnu.org, mstanojevic@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Thu, 23 Jul 2020 16:33:12 +0200 > Cc: 42482-done@debbugs.gnu.org > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojević > : > > > > Thank you for the quick fix. > > Is there a chance this also goes to emacs-27 branch so it can be in > > the emacs 27.1 when it gets released? > > I think backporting the fix should be fine, as the fix is rather > localized and fixes a regression. Eli? How well was it tested? The change is not exactly trivial. But if you are satisfied with the testing enough to have this in emacs-27, I'm okay with that. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 23 15:12:17 2020 Received: (at 42482) by debbugs.gnu.org; 23 Jul 2020 19:12:18 +0000 Received: from localhost ([127.0.0.1]:46065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jygdd-0001E9-Mc for submit@debbugs.gnu.org; Thu, 23 Jul 2020 15:12:17 -0400 Received: from mxout1.mail.janestreet.com ([38.105.200.78]:59516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jygda-0001Dq-DU for 42482@debbugs.gnu.org; Thu, 23 Jul 2020 15:12:16 -0400 X-JS-Received: from [30.32.81.38] (helo=igm-qpr-mailcore1) by mxout1.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94) (envelope-from ) id 1jygdU-0003Ai-Q2 for 42482@debbugs.gnu.org; Thu, 23 Jul 2020 15:12:08 -0400 X-JS-Flow: external X-JS-Received: by igm-qpr-mailcore1 with ocaml/mailcore/main_production (a856a1269fd0) (envelope-from ) id BfGeEI-2vLtkA-Yz; 2020-07-23 15:12:08.799126-04:00 X-JS-Scanner-attachment: No attachments X-JS-Scanner-esets: Not scanned (internal mail) Received: from mail-wm1-f71.google.com ([209.85.128.71]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94) id 1jygdU-0007Zg-MQ for 42482@debbugs.gnu.org; Thu, 23 Jul 2020 15:12:08 -0400 Received: by mail-wm1-f71.google.com with SMTP id r2so2680664wmh.1 for <42482@debbugs.gnu.org>; Thu, 23 Jul 2020 12:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3J/YaYXEJRAh8jHViYmayuTrGDJYsb225op24nKRGu0=; b=FJq0thh0rOnbmRLnZ0qB5l8EKv3Yz/xAMh+LPP8ll4ijnQ55690KolDyMexZuprlQo /AwvlK4vBphI6qmIocSCtnvT6pD6F0X+634MNjkMplkPzmMroNi1GSoK+11ZA0eyIdeB B1h2S1tTIYpqxhusDHZfzEvGh4QXzpmNGE5xk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3J/YaYXEJRAh8jHViYmayuTrGDJYsb225op24nKRGu0=; b=RqhDXfAG5QF0JRtrCL4dKfDDAMgDPsWuHmuIhmajh/H4ncOvI4jf5ZRg9zPEe1jxh6 VtqF+Lt5Qzg9GBeyHf+KLJpeGT3MchpNgny03boaL6T8F7h0eU0ZN2gkTg7K3/RKOAhG K0o6b6jxULR8mdz0bbWdbKOm7sNWu0eaE+P1iEd9xS2hEVnQjh9vVTN3xfzURh8AJpMk mX7cA15m3SoiBJpnrZ2yidHPLRtjxQXTom8VuHvpLuDs5q5L3A9XCURiHx/2mVYlsW/a lp2H9mV9f81hFygc2RUVn9VoFXXK7vMbl+PuJcJqeH5QRIaLdfPBg9r0u4nWD8+qCVAu CTCQ== X-Gm-Message-State: AOAM532nh4TxTfvnYG8orBMBmzuIP2fgbkkAK3iQxHfQ1QZ6ssCAiefC t/8PGNoFdaoo/anuIphpFQqAdQLMChzFNm15AM8Xnj8SVfImZ3J+nvPnagQP98yYgvNpTDzAdVm qJKDCn8GToLWwgxWhapanMJR4TdH/ig== X-Received: by 2002:adf:97dc:: with SMTP id t28mr4928584wrb.291.1595531527820; Thu, 23 Jul 2020 12:12:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG4OzwvIvPLIBHqzv4NeZ5Z09Lv3GqD1aPYEEovYfuPwcV8AdKM3O0MYcz93TLwDY8n4j3PXsYFgb6aFp2krU= X-Received: by 2002:adf:97dc:: with SMTP id t28mr4928569wrb.291.1595531527552; Thu, 23 Jul 2020 12:12:07 -0700 (PDT) MIME-Version: 1.0 References: <83365if7lz.fsf@gnu.org> In-Reply-To: <83365if7lz.fsf@gnu.org> From: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Date: Thu, 23 Jul 2020 15:11:31 -0400 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-JS-Exim-Data-Received: 2020-07-23 15:12:08-0400 X-JS-Processed-by: mailcore X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482 Cc: Philipp Stephani , 42482@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I backported the change to emacs-27 branch locally and tried a simple test using our real-world emacs module against it and the change seems to fix the memory leak. Our module (and the test I tried) is written in ocaml (calls to/from emacs are via C bindings) and relies on interplay between ocaml and emacs gcs to not leak memory, so that working is a good sign. Compared to emacs-26, it uses a bit more memory, but I think that is expected. The main thing is that memory is stable. On Thu, Jul 23, 2020 at 1:45 PM Eli Zaretskii wrote: > > > From: Philipp Stephani > > Date: Thu, 23 Jul 2020 16:33:12 +0200 > > Cc: 42482-done@debbugs.gnu.org > > > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojevi=C4=87 > > : > > > > > > Thank you for the quick fix. > > > Is there a chance this also goes to emacs-27 branch so it can be in > > > the emacs 27.1 when it gets released? > > > > I think backporting the fix should be fine, as the fix is rather > > localized and fixes a regression. Eli? > > How well was it tested? The change is not exactly trivial. But if > you are satisfied with the testing enough to have this in emacs-27, > I'm okay with that. > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 25 17:43:31 2020 Received: (at 42482) by debbugs.gnu.org; 25 Jul 2020 21:43:32 +0000 Received: from localhost ([127.0.0.1]:51285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzRx5-0004Yd-MI for submit@debbugs.gnu.org; Sat, 25 Jul 2020 17:43:31 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:35353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzRx4-0004YP-0W for 42482@debbugs.gnu.org; Sat, 25 Jul 2020 17:43:30 -0400 Received: by mail-ot1-f52.google.com with SMTP id d4so9687186otk.2 for <42482@debbugs.gnu.org>; Sat, 25 Jul 2020 14:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aocz8Z6IHqDVCp2Reaglh9Vhf0ozN6i92QPsr85LD0I=; b=NCI/OJFkUqvFtpMIeGw6ZswIeu3/FnbkgK0OH4uz/DB5IVEZalbF9lHDCeL1Y4yIh0 AqiALC7whZCCq8EcJn8gcAy8e5JnPq9+aDat7/kHoNQjx5r8EUHZtL1oGSm7IKStK9ZY LTQWcf3AbrsousyNdpmlM/uBcjVzevkegEwJWMH7kwoQGeeao/poa/sPPMTlv+EB0ROA 4E8qCSrKUY3i9OCU2UMdEf9//+f2N473Nn+ZZra/+QuEX7bFJ3s1xIThQxDdgGdg0Co5 c1hHsXW5C10KQitmKcoB59EqxJS/rA+nKzxJIyJGNkKEnJPaGx5KhL8tR7XmmaWpIw4q mnDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aocz8Z6IHqDVCp2Reaglh9Vhf0ozN6i92QPsr85LD0I=; b=tBD+DzMGpbUGpyWdQaV9G9KrwK+LNpdf2r6xUndYYIIRj8MwPuxsSBB2gGJiELWGkg qkMfEPPfawCI5TawBEPgmyqL+j76M6gfyYWQklShiRYgCDslEFYFFPDejVmC8PN3glKk 4yyijiw+NEEhSRR8TpDraTMpNoOR+UOnHeQQNW07ENST64MJ+4pQiZqZxRTaVkMAT6vY OxhXetN2sf8cLHgm6tTpPp/Dw5VXwF0RzK4Xf3xQhfItTcy0hNLmSaUOsgHrcMKY4nyn RLiqaMeZzr/z/JQ/qXThv8LixsodBStKwqkrhOSHZ2EN7dJYe/CkRz3FI1YBbHoIoc07 anPA== X-Gm-Message-State: AOAM533PqvIymKnHZ99HJVurBYGmo+MuhnzqPwzLPmIpx2m/DuS8FlR0 c33ngrDIlmNPOaHLMMtscb9L0x+FOZx3wWQeiI9gig== X-Google-Smtp-Source: ABdhPJwViPj40g1xRJXPE1pSCc4ovTdT6gccMK1li010bXaAljVZp3qEaAhAWXUnc0kpUJ2b66TVmnUXqFEnXXO2QOk= X-Received: by 2002:a05:6830:1daa:: with SMTP id z10mr14489238oti.36.1595713404424; Sat, 25 Jul 2020 14:43:24 -0700 (PDT) MIME-Version: 1.0 References: <83365if7lz.fsf@gnu.org> In-Reply-To: <83365if7lz.fsf@gnu.org> From: Philipp Stephani Date: Sat, 25 Jul 2020 23:43:13 +0200 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42482 Cc: 42482@debbugs.gnu.org, =?UTF-8?Q?Milan_Stanojevi=C4=87?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 23. Juli 2020 um 19:45 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Thu, 23 Jul 2020 16:33:12 +0200 > > Cc: 42482-done@debbugs.gnu.org > > > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojevi=C4=87 > > : > > > > > > Thank you for the quick fix. > > > Is there a chance this also goes to emacs-27 branch so it can be in > > > the emacs 27.1 when it gets released? > > > > I think backporting the fix should be fine, as the fix is rather > > localized and fixes a regression. Eli? > > How well was it tested? The change is not exactly trivial. But if > you are satisfied with the testing enough to have this in emacs-27, > I'm okay with that. I'd like to have a few more test cases around global references in emacs-27, as the current test cases only test some simple/success cases, and we'd probably want to test at least a few more edge cases (e.g. freeing global references in a different order than allocating them). I've added two more test cases on master and will see that I can add a few more in the coming days. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 01 08:12:14 2020 Received: (at 42482) by debbugs.gnu.org; 1 Aug 2020 12:12:14 +0000 Received: from localhost ([127.0.0.1]:39814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1qN3-00084z-Rp for submit@debbugs.gnu.org; Sat, 01 Aug 2020 08:12:14 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:40838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1qN0-00084k-W9 for 42482@debbugs.gnu.org; Sat, 01 Aug 2020 08:12:12 -0400 Received: by mail-oi1-f178.google.com with SMTP id u24so19286327oiv.7 for <42482@debbugs.gnu.org>; Sat, 01 Aug 2020 05:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=j/dXFY0sUSg69nZ+pg+DZEXMK6W3Ni0XcLhdKPxAlYs=; b=SXv/eqnkw1d20wvjthxjVCGZCtIy+rT5f6qUCpIOz2zRmw86NYf6iWBbh5EGh73KRb O61/bqrMhNqiE84pxb3WjcscGVKS1dyPi4ZlXvY+h66F40qwmd1JPHkt8UWTIRdG7yt/ XOQZpModOyYMsS9EVHknrGN5yyQo8RjGWwYTJCnYYT/ywx5xRD3wp96Uc1/Mv8kC+fo9 XbNks1SKZP7OURCBoGynsme1qVklyzi1R35JhFMCOcuSIXYW7sJ4Ofhng7l/hfX6eTA5 N1lX60Mhd4Y2wZfGVLoiXHy9PxttiI4ul5Ny+T8IirdlWncO+1qRCjGtXLn1COjK7t8j RKvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=j/dXFY0sUSg69nZ+pg+DZEXMK6W3Ni0XcLhdKPxAlYs=; b=IJhfqYgY0+1YxnG8aJ27V4jcMToDH//6+rdR+ZHHTU4hBtxFlfeUgD2lbaGhzJ1tO3 nyJ4sx41TzDD7Jvn0sKqf0oduhoyYjm0mlL4qnd+ypY78EsLuw96tLuEckB4fWfeNuny oH4Ug6p3DSQSmuMNUFUVnysdgvwaJ1EYJRAGgo+7idvh9avSVUQBV+C6WCOKm4Oj0OUY 9vYG6TXBoy4w/zqXUGdsN2UTfkBKkCI2WYbWXdAmxNXXDrKz9uC5utN0b4ty/xVcb8Hj 7yEZXKZ6PMtvcPpyFsjqcWKBau/UtIICzHW009/vSDj0oiYrmrMvqy+Q9r5bN3thf5C6 Nf/A== X-Gm-Message-State: AOAM533VAf7BvRabRAhhw7NLb/JXzV7H1YjCel0WKATDo3VV1RIRFWcW F6VpMCn9AEzEDnGkykmzNYu1wVBKCSB04CXNXkg= X-Google-Smtp-Source: ABdhPJzhjj2Kp7WbpxO8WMNoSsBF3dRfMWR4T7n0gye3u82czasAD3NuoKkMVXtLes1pZKEScxa5KcSC3GixcPsSSz0= X-Received: by 2002:a05:6808:a8d:: with SMTP id q13mr6498601oij.9.1596283925185; Sat, 01 Aug 2020 05:12:05 -0700 (PDT) MIME-Version: 1.0 References: <83365if7lz.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Sat, 1 Aug 2020 14:11:54 +0200 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 42482 Cc: 42482@debbugs.gnu.org, =?UTF-8?Q?Milan_Stanojevi=C4=87?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Sa., 25. Juli 2020 um 23:43 Uhr schrieb Philipp Stephani : > > Am Do., 23. Juli 2020 um 19:45 Uhr schrieb Eli Zaretskii : > > > > > From: Philipp Stephani > > > Date: Thu, 23 Jul 2020 16:33:12 +0200 > > > Cc: 42482-done@debbugs.gnu.org > > > > > > Am Do., 23. Juli 2020 um 16:29 Uhr schrieb Milan Stanojevi=C4=87 > > > : > > > > > > > > Thank you for the quick fix. > > > > Is there a chance this also goes to emacs-27 branch so it can be in > > > > the emacs 27.1 when it gets released? > > > > > > I think backporting the fix should be fine, as the fix is rather > > > localized and fixes a regression. Eli? > > > > How well was it tested? The change is not exactly trivial. But if > > you are satisfied with the testing enough to have this in emacs-27, > > I'm okay with that. > > I'd like to have a few more test cases around global references in > emacs-27, as the current test cases only test some simple/success > cases, and we'd probably want to test at least a few more edge cases > (e.g. freeing global references in a different order than allocating > them). I've added two more test cases on master and will see that I > can add a few more in the coming days. I've now added a few more tests and backported the fix to the release branc= h. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 01 08:37:57 2020 Received: (at 42482) by debbugs.gnu.org; 1 Aug 2020 12:37:57 +0000 Received: from localhost ([127.0.0.1]:39913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1qlw-0000FY-Vt for submit@debbugs.gnu.org; Sat, 01 Aug 2020 08:37:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1qlu-0000FJ-AF for 42482@debbugs.gnu.org; Sat, 01 Aug 2020 08:37:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35494) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1qlo-0008Os-N9; Sat, 01 Aug 2020 08:37:48 -0400 Received: from [176.228.60.248] (port=2098 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k1qlo-0006ZX-4R; Sat, 01 Aug 2020 08:37:48 -0400 Date: Sat, 01 Aug 2020 15:37:40 +0300 Message-Id: <83zh7eczjf.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-Reply-To: (message from Philipp Stephani on Sat, 1 Aug 2020 14:11:54 +0200) Subject: Re: bug#42482: 27.0.91; emacs modules memory leak References: <83365if7lz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482 Cc: 42482@debbugs.gnu.org, mstanojevic@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Sat, 1 Aug 2020 14:11:54 +0200 > Cc: Milan Stanojević , > 42482@debbugs.gnu.org > > I've now added a few more tests and backported the fix to the release branch. I think it's too late for Emacs 27.1, sorry. The tarball is already made. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 01 10:47:38 2020 Received: (at 42482) by debbugs.gnu.org; 1 Aug 2020 14:47:38 +0000 Received: from localhost ([127.0.0.1]:40862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1snS-0003VX-7x for submit@debbugs.gnu.org; Sat, 01 Aug 2020 10:47:38 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:41639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1snP-0003VH-6p for 42482@debbugs.gnu.org; Sat, 01 Aug 2020 10:47:37 -0400 Received: by mail-ot1-f49.google.com with SMTP id a65so15642030otc.8 for <42482@debbugs.gnu.org>; Sat, 01 Aug 2020 07:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X4GWn6nfvRPl6ZNO2d7wkjPwYFpRp22MuXdwd1f+TF4=; b=LPLRxHYss6i06jyZaUhFZNfhKhfShOCXw9lvpoBkOtHo1jKF3Zt5prgC7wkSSHl/HW VR3GJlu5fGEQU9lrQ8s7riw6Oz4OlNa6ggw19ogDYo2cHGU3iG8oRY2kTLDe95ojm0Ri xtfmAOjxrh1AAojLNEeEMmhtcb0z8ecVyJKsgqYLADuZYIvQIuN7OEBVLWaXOkRlXpMh LO+vHrOaqxCNUW7Vcb4f0l19CVCyJxvzrwnrN9ApMPNNZn6DYIg2MkPb8/wGhgxdq9qJ PfPITbJ844WzlyjerlbPH3uT2g/AdTmX6kHoUl7dXJeLkgVfed8IDQDvELovwjZqK5Hq Ut1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X4GWn6nfvRPl6ZNO2d7wkjPwYFpRp22MuXdwd1f+TF4=; b=El7kpfHqx9iWQz0zcTBF/Rfq2z4OfYcrQP9q+twT179Jm63d0IM2U+DvXWOHSVTYTn O+sDj3WL2bnyvvnbJke80ziV0wP5PVq5/XoPdCdZxy9XcSOWsH0TpktyXYmXzuBR/HH/ 5lPLxnxvKmAG9d9he+gh49f3wg9LYwv71llEwgpi4BWD9dBNg9opERQSsUQrgNChh5u6 tWAhgjE23vCtkWL4liAM9g38+I7iwFH/wdhhg44rZ+6LYBEOwUxJq386uvUHIykTpVWp ZCrGwl9UYVlRmfRe8P80kVxIuZiEq31UYMk/u2nxnXjJ4VbbVRi35zJzNpllp3jQfkgh neTw== X-Gm-Message-State: AOAM532LLhi37f1LB6lMoJCgHfHmuvg1mXmyLjn6hm3IJi/sUyr7CMTi YwIWbVsRYhjXIDONdO80pJYQ3agujrDy/P7QRz0= X-Google-Smtp-Source: ABdhPJy7Bl1auE2RrBwiN0om9BnRoSZaE2+hxWIPT0usrIqrKMzeqvbMQ3W6sJgIKhWwQTAe4iKqNga07BcoaBAv7u4= X-Received: by 2002:a9d:2203:: with SMTP id o3mr6699458ota.149.1596293249228; Sat, 01 Aug 2020 07:47:29 -0700 (PDT) MIME-Version: 1.0 References: <83365if7lz.fsf@gnu.org> <83zh7eczjf.fsf@gnu.org> <87zh7er0e2.fsf@petton.fr> In-Reply-To: <87zh7er0e2.fsf@petton.fr> From: Philipp Stephani Date: Sat, 1 Aug 2020 16:47:18 +0200 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Nicolas Petton Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42482 Cc: Eli Zaretskii , 42482@debbugs.gnu.org, =?UTF-8?Q?Milan_Stanojevi=C4=87?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Sa., 1. Aug. 2020 um 14:55 Uhr schrieb Nicolas Petton : > > Eli Zaretskii writes: > > >> I've now added a few more tests and backported the fix to the release branch. > > > > I think it's too late for Emacs 27.1, sorry. The tarball is already > > made. > > If the bugfix is important enough, I can build a new RC tomorrow and set > the release date to the 8th of Aug. I don't feel strongly either way. My expectation for global references is that they should mainly be used for the module equivalent of defvar and friends, in which case the bug isn't that severe because nobody needs millions of defvars. OTOH, people might use global references for other means, including allocating them dynamically, in which case leaking them can become annoying. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 01 12:26:48 2020 Received: (at 42482) by debbugs.gnu.org; 1 Aug 2020 16:26:48 +0000 Received: from localhost ([127.0.0.1]:40963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1uLQ-0005tV-75 for submit@debbugs.gnu.org; Sat, 01 Aug 2020 12:26:48 -0400 Received: from petton.fr ([89.234.186.68]:44686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1r3G-0000eX-G5 for 42482@debbugs.gnu.org; Sat, 01 Aug 2020 08:55:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=petton.fr; s=email; t=1596286536; bh=OGKPnR21qE9jbTjAYikZeg8tGIcnTY5O3GBjZkf+vmI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OwVAEFHNv9KpOmhLIVZKVt8KFVS/eTy6jujdrIMgQQmYDQkL2gLZLJvKWcFRNi2+0 DmID37tF5g5GjCu1CzIMmxPCBqAhLPRt7da+EAJYJkaBoEXRn8EAd0+EXrvo3xn+P+ 1mPV4pihEhjPhblDQ6NhM0vkxlU4ZBpc24l1HBu4= From: Nicolas Petton To: Eli Zaretskii , Philipp Stephani Subject: Re: bug#42482: 27.0.91; emacs modules memory leak In-Reply-To: <83zh7eczjf.fsf@gnu.org> References: <83365if7lz.fsf@gnu.org> <83zh7eczjf.fsf@gnu.org> Date: Sat, 01 Aug 2020 14:55:33 +0200 Message-ID: <87zh7er0e2.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42482 X-Mailman-Approved-At: Sat, 01 Aug 2020 12:26:47 -0400 Cc: 42482@debbugs.gnu.org, mstanojevic@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> I've now added a few more tests and backported the fix to the release branch. > > I think it's too late for Emacs 27.1, sorry. The tarball is already > made. If the bugfix is important enough, I can build a new RC tomorrow and set the release date to the 8th of Aug. Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE1AWqLIYsVPF+7mvg6LzXhmr8+XgFAl8lZkUACgkQ6LzXhmr8 +Xh0dwgAgf/LWNHhStKVHi0B01XniNjVftB4PxjnJeSJ9uXwRH/CM93QmqU+EuhF y8J5xzgLe+OqRQb+XtxpgxG7pLH2Q7xwK0QG3buaObbTP9iX+xzNkg9CVF3P+dpi V78I6oTW3l/FbTavcDhkI1ciPv+t6roabNjiXXcQwSdpdx+qC/uSAvUbtM+y32lI uTuSPPFfb4a6HERIcoiBChYq+7NGuwmbqLp4l+acsgZS0N6kGIWOo6EJ6R18RD4O rgrp5OFwb9H6TAEK60/5jMxuF8PSiOhiMc5Zqe6kYv4rOkeUEBBwJdt6rhlDvoIM D7OX5lAuld4uFoiWxkvyhXQnCfc29Q== =so0x -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 02 13:26:12 2020 Received: (at 42482) by debbugs.gnu.org; 2 Aug 2020 17:26:12 +0000 Received: from localhost ([127.0.0.1]:43340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2HkS-0007zX-0Y for submit@debbugs.gnu.org; Sun, 02 Aug 2020 13:26:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2HkQ-0007zJ-9a for 42482@debbugs.gnu.org; Sun, 02 Aug 2020 13:26:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53544) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2HkK-0004mm-Ho; Sun, 02 Aug 2020 13:26:04 -0400 Received: from [176.228.60.248] (port=4865 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k2HkJ-0002fV-O7; Sun, 02 Aug 2020 13:26:04 -0400 Date: Sun, 02 Aug 2020 20:25:49 +0300 Message-Id: <83k0yharj6.fsf@gnu.org> From: Eli Zaretskii To: Nicolas Petton In-Reply-To: <87zh7er0e2.fsf@petton.fr> (message from Nicolas Petton on Sat, 01 Aug 2020 14:55:33 +0200) Subject: Re: bug#42482: 27.0.91; emacs modules memory leak References: <83365if7lz.fsf@gnu.org> <83zh7eczjf.fsf@gnu.org> <87zh7er0e2.fsf@petton.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482 Cc: p.stephani2@gmail.com, 42482@debbugs.gnu.org, mstanojevic@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicolas Petton > Cc: 42482@debbugs.gnu.org, mstanojevic@janestreet.com > Date: Sat, 01 Aug 2020 14:55:33 +0200 > > > I think it's too late for Emacs 27.1, sorry. The tarball is already > > made. > > If the bugfix is important enough, I can build a new RC tomorrow and set > the release date to the 8th of Aug. Unfortunately, a much more serious bug was reported and fixed today, so we will need a new RC from the latest emacs-27 branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 03 19:02:50 2020 Received: (at 42482) by debbugs.gnu.org; 3 Aug 2020 23:02:50 +0000 Received: from localhost ([127.0.0.1]:46266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2jTm-0000sT-3q for submit@debbugs.gnu.org; Mon, 03 Aug 2020 19:02:50 -0400 Received: from mxout1.mail.janestreet.com ([38.105.200.78]:33014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2jTh-0000sD-MR for 42482@debbugs.gnu.org; Mon, 03 Aug 2020 19:02:49 -0400 X-JS-Received: from [30.32.81.38] (helo=igm-qpr-mailcore1) by mxout1.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94) (envelope-from ) id 1k2jTb-0002PU-2k for 42482@debbugs.gnu.org; Mon, 03 Aug 2020 19:02:39 -0400 X-JS-Flow: external X-JS-Received: by igm-qpr-mailcore1 with ocaml/mailcore/main_production (76b1560308f1) (envelope-from ) id BfKJeP-lZutoA-B5; 2020-08-03 19:02:39.068475-04:00 X-JS-Scanner-attachment: No attachments X-JS-Scanner-esets: Not scanned (internal mail) Received: from mail-wr1-f70.google.com ([209.85.221.70]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94) id 1k2jTa-0004QR-JQ for 42482@debbugs.gnu.org; Mon, 03 Aug 2020 19:02:38 -0400 Received: by mail-wr1-f70.google.com with SMTP id j2so9445135wrr.14 for <42482@debbugs.gnu.org>; Mon, 03 Aug 2020 16:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CdGvmDuDoHvzkAyz6NT6KgZZM/1zGhqoX4f1my2P4uQ=; b=N3jIBgvPNGehXdtHAJTccyAYW511LQoImH/0EIm0jI2ZHcBpdQTafhjsXitoTwqjaK Ut3bUrGHnULgVd6CQeeSqxKT8ctA3tPGWCeTFpT1IkqgGXhzzNxPZsAjLfHTnRiNcvGG v4T6MH8IzZeTx0BxxqSQDtqjGJTqmEI0LLKq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CdGvmDuDoHvzkAyz6NT6KgZZM/1zGhqoX4f1my2P4uQ=; b=N5w70yswKCHqgMm9QCzuiAG2PYB1CMnnlcKQ5TEmVR14eozR1cfkXFttxfDCcsICWu XE0jo5+Mp1Rxy+urUKdvOkF/SRfDIrgpeGZfc6DyMF5pm00zTipNlJYDsQFaJu03JjqA ZBlfMQkjXyWu3W6JzXxB4qm40lN30RI8IOx/aoUImVv3dkV2TveCiEmsNWsQ6fw+cA1h 5wupCHWmxCTP8dkHP5TXm7bZFRczTE/hN/ryitg2Rxx2k7RYbb0K34DlDbjoZHuy/kSg I7AxIwOa4P5/n/3JideR0nhVnwHIE8gUnCtCiS+q78+JAGhIGFRSrhPalDdgzUaDBLb5 guzA== X-Gm-Message-State: AOAM532TFmEqfYMdS9Eh1r7TLKFxVdvbR2OoOkqOMeSz4tWEZyrNHU9U ihJ1oQFVpUC7K5nIfCWU9PrD4BEwdKIcNgV+D21pbrz+T28Pc59g9LzufOEJdjmG3ym+hFVcVJ9 XdBCSp6p+y40f5tQCdXlqWa+0MuoJ7Q== X-Received: by 2002:a7b:c4d3:: with SMTP id g19mr1180098wmk.29.1596495757847; Mon, 03 Aug 2020 16:02:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfEDnuYO0jVwfjc9Z/CBpdGNenV7uM0J7m+PvJWG2931LThNsy3ZXL6NTXAQEGrDe8se3/tpYzXqXWx7MfFyY= X-Received: by 2002:a7b:c4d3:: with SMTP id g19mr1180088wmk.29.1596495757594; Mon, 03 Aug 2020 16:02:37 -0700 (PDT) MIME-Version: 1.0 References: <83365if7lz.fsf@gnu.org> <83zh7eczjf.fsf@gnu.org> <87zh7er0e2.fsf@petton.fr> <83k0yharj6.fsf@gnu.org> In-Reply-To: <83k0yharj6.fsf@gnu.org> From: =?UTF-8?Q?Milan_Stanojevi=C4=87?= Date: Mon, 3 Aug 2020 19:02:01 -0400 Message-ID: Subject: Re: bug#42482: 27.0.91; emacs modules memory leak To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-JS-Exim-Data-Received: 2020-08-03 19:02:38-0400 X-JS-Processed-by: mailcore X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42482 Cc: Philipp Stephani , 42482@debbugs.gnu.org, Nicolas Petton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I guess this fix will be included now in 27.1 but I just wanted to say that OCaml emacs module library (https://github.com/janestreet/ecaml) uses global refs everywhere so the leak would be very noticeable (that is how we found out in the first place). I'm not sure this would have been enough to postpone the release date since I don't think ecaml has that many users (We do have 500+ devs using and relying on ecaml but it is really a single emacs+ecaml installation and we can patch emacs sources or just wait for 27.2) On Sun, Aug 2, 2020 at 1:26 PM Eli Zaretskii wrote: > > > From: Nicolas Petton > > Cc: 42482@debbugs.gnu.org, mstanojevic@janestreet.com > > Date: Sat, 01 Aug 2020 14:55:33 +0200 > > > > > I think it's too late for Emacs 27.1, sorry. The tarball is already > > > made. > > > > If the bugfix is important enough, I can build a new RC tomorrow and set > > the release date to the 8th of Aug. > > Unfortunately, a much more serious bug was reported and fixed today, > so we will need a new RC from the latest emacs-27 branch. > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 04 04:05:51 2020 Received: (at 42482) by debbugs.gnu.org; 4 Aug 2020 08:05:51 +0000 Received: from localhost ([127.0.0.1]:46706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2rxG-0005mv-RW for submit@debbugs.gnu.org; Tue, 04 Aug 2020 04:05:51 -0400 Received: from petton.fr ([89.234.186.68]:33772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2rxE-0005mi-Kj for 42482@debbugs.gnu.org; Tue, 04 Aug 2020 04:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=petton.fr; s=email; t=1596528341; bh=jF4gk0KEA+0XOG3oT/5i9yyNNISlOCaof0tGO/k9gt4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NuhhGDCn8xgKN0+EOKBiL8YPMHcuSzRfW5z8nltgu2GZWqXPnr5MVc0/1ilq9gGkg G+Wle5sRwHyQaAt3xhyo2eHApcxEwigl0Rf/PEZgnrJ/tyC55gbA//DQ63twcC73ww ISHxMVeulSACUm6iG11TdtCK3i4QM+m/NvhL9lpo= From: Nicolas Petton To: Eli Zaretskii , Nicolas Petton Subject: Re: bug#42482: 27.0.91; emacs modules memory leak In-Reply-To: <83k0yharj6.fsf@gnu.org> References: <83365if7lz.fsf@gnu.org> <83zh7eczjf.fsf@gnu.org> <87zh7er0e2.fsf@petton.fr> <83k0yharj6.fsf@gnu.org> Date: Tue, 04 Aug 2020 10:05:38 +0200 Message-ID: <87lfiurg31.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42482 Cc: p.stephani2@gmail.com, 42482@debbugs.gnu.org, mstanojevic@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> If the bugfix is important enough, I can build a new RC tomorrow and set >> the release date to the 8th of Aug. > > Unfortunately, a much more serious bug was reported and fixed today, > so we will need a new RC from the latest emacs-27 branch. That's ok :) I'll make a new one this evening. Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE1AWqLIYsVPF+7mvg6LzXhmr8+XgFAl8pFtIACgkQ6LzXhmr8 +XjQNggAoD+EMSXVRwp4YqV0oyldfX3xCzVZUkJlNNwK6Z2dyha30W0b5isrQuCK bO5UyKUKc+Hp371MDzPMErD+HoQAI76iFMMMsFNwkbrXEJKrtzLly+2E1R5faThH xjFXQ1g4Isi4OEYcZY0vlMXKlevYvfb9002wfan8Czo5Mz6oWN+5uI8f26nXoUfW yzPmNHMEEWzg1UbkkrpdXnGyq4HVet4nz2Tr/magTWnl3PUxUtdGjyjlMoD1pgbT ndkGATo4P9Gkph+p8bBauu0W0f3VfgSbzCIiw+rN6JNr232ypwdfuvUIv6FRSCFS 0FIIWe4A2L02oPRYHTvi+bVxRGQdKQ== =6I1R -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:21:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator