From unknown Sat Aug 16 16:17:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42467: 26.3; mark-defun in f90-mode Resent-From: Vangelis Evangelou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jul 2020 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42467 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 42467@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159535209515136 (code B ref -1); Tue, 21 Jul 2020 17:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jul 2020 17:21:35 +0000 Received: from localhost ([127.0.0.1]:40271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxvxO-0003w4-TR for submit@debbugs.gnu.org; Tue, 21 Jul 2020 13:21:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:53958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxvo0-0003h3-Vp for submit@debbugs.gnu.org; Tue, 21 Jul 2020 13:11:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxvo0-0001KP-QI for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2020 13:11:52 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:41239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxvny-0005Fz-Q4 for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2020 13:11:52 -0400 Received: by mail-ej1-x62d.google.com with SMTP id w9so8267269ejc.8 for ; Tue, 21 Jul 2020 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=1N0LDdiGt7MF85HJOSgXkay698w/DIUN09tjwAZn7bo=; b=NqnZ0sZUHASV4e78DMCK3Nvh7JB9i8Cbzvce8V3H9s6kBmU1DXlfFrLnNvmtW9b98U GvrTrfnhpzYDOrOrnrmLbx+w5mMg/CHKIP4c9hH3XzyBVMw9Va13cgkbtkO/6rWjJaqH gsNzSxIPQ2liIppByyPVJ+lotqEon/Ir/FbSt9cYe9gQESMmJbM0WPpSyDgh3xezpNLk EjCkzHibRlEZ5CHRm3Dl5rRGkzCjR2WmBu5MbPrbQwP1FPfHH/aVMAGLcHI03X/nb9ql uhyvqgDBHvqGrjJXHMfHtHxj/npI5i56dlIuJXAIRCXDFFcA+M019PlLRB17WMZJQELQ aRog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=1N0LDdiGt7MF85HJOSgXkay698w/DIUN09tjwAZn7bo=; b=DECYs5BNyN48d1M2pc5mlYw4+RqznowBvPM3ETTFgAoKBXF/fVdyjmvGtaF8BSz9t+ /H7iS3SMwTjzqCG0qsabcIrsesXCPeJImvY1LtLwRdYXPbiGD2aslDCQ1fk9jsbQO6xg mCCRi1lkBtRuPdDspMu/a5yOBBzZ9YbkA7jtH01AMlm2CYUv/idddcic/jDBU0CvDkQF TpHUf8wJGNXh1XTOPp6m7A3l+AtoMz/RoNMlNZ7H2kLF2V/fG8/22asHVLPDCNgG8Y71 Y7I1iVBCF6bezIGC9g3OzYdyZW4DbB/+WfL8hdDHVV/XSoPfeFDjBXofKhVzORlFll/y WddA== X-Gm-Message-State: AOAM533yDHJwe0/5FqDnvMXkmD0Kz5ZbA4H8rpoWqPuhFRi8G49gv6Yc 0WpnamChpcF8VnuqxReF+T0dEJp6ovhARSBRLadvoknrhC8= X-Google-Smtp-Source: ABdhPJydPmc20ZPwQNKSRmxXHQITcqzXcUizoIgRzsHICCywUYL34pUW6fI0DxElM+ZcXc0PhPVkhhyywvZ3uj8pKoA= X-Received: by 2002:a17:906:c0d9:: with SMTP id bn25mr25803432ejb.176.1595351508173; Tue, 21 Jul 2020 10:11:48 -0700 (PDT) MIME-Version: 1.0 From: Vangelis Evangelou Date: Tue, 21 Jul 2020 18:11:36 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000efd78805aaf6b7ae" Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=evangelou@gmail.com; helo=mail-ej1-x62d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Mailman-Approved-At: Tue, 21 Jul 2020 13:21:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000efd78805aaf6b7ae Content-Type: text/plain; charset="UTF-8" The `mark-defun` function does not work as expected in f90-mode. Test using the following file: ------- test.f90 ---------------------------------------------- subroutine a end subroutine a subroutine b end subroutine b subroutine c end subroutine c ---------------------------------------------------------------- Note: subroutine a must be on line 1 of the text file. Place the cursor inside subroutine a and execute `mark-defun`. The subroutine is correctly marked. Now place the cursor inside subroutine b and execute `mark-defun`. In this case subroutine b and subroutine c are both marked instead of subroutine b only. Now add a new empty line above subroutine a, place the cursor inside subroutine a and execute `mark-defun`. In this case the whole buffer is marked instead of subroutine a only. In GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-12-04 built on vangelis-ThinkPad-T410 Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux Mint 20 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set [2 times] Quit Mark set [2 times] Quit Configured using: 'configure --without-pop --with-x-toolkit=lucid --with-file-notification=inotify --with-x --with-modules' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2 Important settings: value of $LC_MONETARY: en_GB.UTF-8 value of $LC_NUMERIC: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: F90 Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils f90 cus-edit easymenu cus-start cus-load wid-edit cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 116755 7641) (symbols 48 22249 1) (miscs 40 62 129) (strings 32 33508 1367) (string-bytes 1 874511) (vectors 16 15687) (vector-slots 8 518839 13116) (floats 8 58 79) (intervals 56 288 0) (buffers 992 13)) --000000000000efd78805aaf6b7ae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

The `mark-defun` function does not work as expected in=
f90-mode. Test using the following file:
------- test.f90 ----------= ------------------------------------
subroutine a

end subroutine = a

subroutine b

end subroutine b

subroutine c

en= d subroutine c

-----------------------------------------------------= -----------

Note: subroutine a must be on line 1 of the text file. P= lace the cursor
inside subroutine a and execute `mark-defun`. The subrou= tine is
correctly marked. Now place the cursor inside subroutine b and e= xecute
`mark-defun`. In this case subroutine b and subroutine c are both=
marked instead of subroutine b only. Now add a new empty line abov= e
subroutine a, place the cursor inside subroutine a and exe= cute `mark-defun`.
In this case the whole buffer is marked i= nstead of subroutine a only.


In GNU Emacs 26.3 (build 1, x= 86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
=C2=A0of 2019-12-04 bu= ilt on vangelis-ThinkPad-T410
Windowing system distributor 'The X.Or= g Foundation', version 11.0.12008000
System Description: Linux Mint = 20

Recent messages:
For information about GNU Emacs and the GNU s= ystem, type C-h C-a.
Mark set [2 times]
Quit
Mark set [2 times]Quit
Configured using:
=C2=A0'configure --without-pop --with-x-t= oolkit=3Dlucid
=C2=A0--with-file-notification=3Dinotify --with-x --with-= modules'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSV= G IMAGEMAGICK SOUND GPM DBUS GSETTINGS
GLIB NOTIFY ACL LIBSELINUX GNUTLS= LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS LUCID X11= XDBE XIM MODULES THREADS LIBSYSTEMD
LCMS2

Important settings:=C2=A0 value of $LC_MONETARY: en_GB.UTF-8
=C2=A0 value of $LC_NUMERIC: = en_GB.UTF-8
=C2=A0 value of $LC_TIME: en_GB.UTF-8
=C2=A0 value of $LA= NG: en_US.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mod= e: F90

Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 gl= obal-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-= mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 fil= e-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-loc= k-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: t=
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
= =C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

Load-pat= h shadows:
None found.

Features:
(shadow sort mail-extr emacsb= ug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv dired di= red-loaddefs format-spec rfc822 mml
mml-sec password-cache epa derived e= pg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-enco= de mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 r= fc2045 ietf-drums
mm-util mail-prsvr mail-utils f90 cus-edit easymenu cu= s-start cus-load
wid-edit cl-loaddefs cl-lib elec-pair time-date mule-ut= il tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type m= wheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image = regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode= lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer se= lect
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
te= rm/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietna= mese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew g= reek romanian slovak czech european ethiopic indian cyrillic
chinese com= posite charscript charprop case-table epa-hook jka-cmpr-hook
help simple= abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cu= s-face macroexp files text-properties overlay sha1 md5
base64 format env= code-pages mule custom widget hashtable-print-readable
backquote thread= s dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render= -setting x-toolkit x multi-tty
make-network-process emacs)

Memory= information:
((conses 16 116755 7641)
=C2=A0(symbols 48 22249 1)
= =C2=A0(miscs 40 62 129)
=C2=A0(strings 32 33508 1367)
=C2=A0(string-b= ytes 1 874511)
=C2=A0(vectors 16 15687)
=C2=A0(vector-slots 8 518839 = 13116)
=C2=A0(floats 8 58 79)
=C2=A0(intervals 56 288 0)
=C2=A0(bu= ffers 992 13))
--000000000000efd78805aaf6b7ae-- From unknown Sat Aug 16 16:17:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42467: 26.3; mark-defun in f90-mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Oct 2020 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42467 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Vangelis Evangelou Cc: 42467@debbugs.gnu.org Received: via spool by 42467-submit@debbugs.gnu.org id=B42467.160292081021515 (code B ref 42467); Sat, 17 Oct 2020 07:47:01 +0000 Received: (at 42467) by debbugs.gnu.org; 17 Oct 2020 07:46:50 +0000 Received: from localhost ([127.0.0.1]:33179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgvS-0005aw-Ek for submit@debbugs.gnu.org; Sat, 17 Oct 2020 03:46:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgvQ-0005ah-Bq for 42467@debbugs.gnu.org; Sat, 17 Oct 2020 03:46:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/pJNUi8oDnehuzZiQqGhuoSmqMfcUrV/75Bc/hb4NXg=; b=sdLy+NqTKh8/lbUyzKIhs1DwGd 5gFZFSo3A9Ew/hAxExohYk0KqM6ah5o0jyhj+8KmAJ+TslaymUAAwveM+4CJMrWUJKN22w/WKjtrR CS1jJ9zLbL19R7CrAOdqWG5KNOljJzzYqL0d07qnh1V5zUi+QGl+zYIyeuh+UkvCe22g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTgvI-0000t2-2V; Sat, 17 Oct 2020 09:46:42 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Thomas Mery's _Les couleurs, les ombres_: "Aux =?UTF-8?Q?fen=C3=AAtre?= immenses" Date: Sat, 17 Oct 2020 09:46:38 +0200 In-Reply-To: (Vangelis Evangelou's message of "Tue, 21 Jul 2020 18:11:36 +0100") Message-ID: <87r1pxwazl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Vangelis Evangelou writes: > The `mark-defun` function does not work as expected in > f90-mode. Test using the following file: This should now be fixed in Emacs 28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Vangelis Evangelou writes: > The `mark-defun` function does not work as expected in > f90-mode. Test using the following file: This should now be fixed in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 17 03:46:55 2020 Received: (at control) by debbugs.gnu.org; 17 Oct 2020 07:46:56 +0000 Received: from localhost ([127.0.0.1]:33182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgvX-0005bG-Mw for submit@debbugs.gnu.org; Sat, 17 Oct 2020 03:46:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTgvW-0005au-9f for control@debbugs.gnu.org; Sat, 17 Oct 2020 03:46:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4WdtuvB8cV7JukAz66DvwIi9tqULXVIAP8frha15l0k=; b=tbIFvGU+4iL2Y4PiHg0bjQdiHL WObdMC4KxrsLZRrR1/fn8+yv5kB6XRIVD1GafNrZMCwRFd4p3VB0c7teR1Dunyj02AjJSUWeRGgKi MLnlYxawdrKOYQmieYcSzQEdDmbNGwOTVd63voCOMMlcd4myNdCsOHiCvnzLULaTnoSs=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTgvO-0000t8-Dn for control@debbugs.gnu.org; Sat, 17 Oct 2020 09:46:48 +0200 Date: Sat, 17 Oct 2020 09:46:45 +0200 Message-Id: <87pn5hwaze.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #42467 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 42467 fixed close 42467 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 42467 fixed close 42467 28.1 quit