Subject: bug#42457: closed (Re: [bug#42457] [PATCH] gnu: knights: Fix build.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 28 Jul 2020 18:14:02 +0000

Your bug report

#42457: [PATCH] gnu: knights: Fix build.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
42457: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42457
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#42457] [PATCH] gnu: knights: Fix build.
From: Oleg Pykhalov <[email-masked]>
To: Jesse Gibbons <[email-masked]>
Cc: [email-masked]
Date: Tue, 28 Jul 2020 21:13:17 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

[…]

> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"

Rather:
* gnu/packages/games.scm (knights)[arguments]<#:make-flags>: Add
"CXXFLAGS=-lpthread".

> ---
>  gnu/packages/games.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:make-flags
> -       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> +       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +	     "CXXFLAGS=-lpthread")

^
Please, use spaces instead of tabs. ;-)

>         #:phases
>         (modify-phases %standard-phases
>           ;; No configure script.

Pushed to master with mentioned changes.

Oleg.

Subject: [PATCH] gnu: knights: Fix build.
From: Jesse Gibbons <[email-masked]>
To: Guix Patches <[email-masked]>
Date: Tue, 21 Jul 2020 00:11:05 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/games.scm (knights):
[make-flags] add "CXXFLAGS=-lpthread"
---
gnu/packages/games.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index cff1c0af99..dc0511e55a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1366,7 +1366,8 @@ built-in level editor.")
(build-system gnu-build-system)
(arguments
'(#:make-flags
- (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+ "CXXFLAGS=-lpthread")
#:phases
(modify-phases %standard-phases
;; No configure script.