GNU bug report logs - #42455
[PATCH 1/1] gnu: ffmpeg: Add support for libgme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 42455 in the body.
You can then email your comments to 42455 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
Date: Tue, 21 Jul 2020 00:08:46 -0600

* gnu/packages/video.scm (ffmpeg):
[inputs]: Add libgme.
[arguments]: Pass "--enable-libgme" to configure.
---
gnu/packages/video.scm | 2 ++
1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6b57d384e1..cbb8e76949 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -963,6 +963,7 @@ operate properly.")
("libcaca" ,libcaca)
("libcdio-paranoia" ,libcdio-paranoia)
("libdrm" ,libdrm)
+ ("libgme" ,libgme)
("libtheora" ,libtheora)
("libva" ,libva)
("libvdpau" ,libvdpau)
@@ -1057,6 +1058,7 @@ operate properly.")
"--enable-libcdio"
"--enable-libdav1d"
"--enable-libfreetype"
+ "--enable-libgme"
"--enable-libmp3lame"
"--enable-libopus"
"--enable-libpulse"

Message #8 received at 42455 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 42455 <at> debbugs.gnu.org
Subject: Re: [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
Date: Sat, 25 Jul 2020 17:28:35 +0200

[Message part 1 (text/plain, inline)]

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> * gnu/packages/video.scm (ffmpeg):
> [inputs]: Add libgme.
> [arguments]: Pass "--enable-libgme" to configure.

'libgme' appears to keep a reference to 'gcc':

$ guix size libgme 
store item                          total    self
/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0              178.5   107.3  59.1%    <--- this should not be here
/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31              38.4    36.7  20.2%
/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib           71.0    32.6  18.0%
/gnu/store/483hgxdmnhh2jh471d0x3aywqrpfp36k-libgme-0.6.3           181.6     3.1   1.7%
/gnu/store/mmhimfwmmidf09jw1plw3aw1g1zn2nkh-bash-static-5.0.16       1.6     1.6   0.9%
/gnu/store/g2s5jfkfd4k973wb58476b1bbv9zpm6m-zlib-1.2.11             38.6     0.2   0.1%
total: 181.6 MiB

Thus adding it to ffmpeg would increase the closure size of ffmpeg by
more than 100MiB (compare 'guix size ffmpeg' and
'guix size libgme ffmpeg').

We should sort out that GCC reference first.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 42455 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim <at> guixotic.coop>
To: Marius Bakke <marius <at> gnu.org>
Cc: Jesse Gibbons <jgibbons2357 <at> gmail.com>, 42455 <at> debbugs.gnu.org
Subject: Re: [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
Date: Sun, 13 Jul 2025 09:37:03 +0900

Hi,

Marius Bakke <marius <at> gnu.org> writes:

> Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:
>
>> * gnu/packages/video.scm (ffmpeg):
>> [inputs]: Add libgme.
>> [arguments]: Pass "--enable-libgme" to configure.
>
> 'libgme' appears to keep a reference to 'gcc':
>
> $ guix size libgme 
> store item                          total    self
> /gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0 178.5 107.3
> 59.1% <--- this should not be here
> /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31              38.4    36.7  20.2%
> /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib           71.0    32.6  18.0%
> /gnu/store/483hgxdmnhh2jh471d0x3aywqrpfp36k-libgme-0.6.3           181.6     3.1   1.7%
> /gnu/store/mmhimfwmmidf09jw1plw3aw1g1zn2nkh-bash-static-5.0.16       1.6     1.6   0.9%
> /gnu/store/g2s5jfkfd4k973wb58476b1bbv9zpm6m-zlib-1.2.11             38.6     0.2   0.1%
> total: 181.6 MiB
>
> Thus adding it to ffmpeg would increase the closure size of ffmpeg by
> more than 100MiB (compare 'guix size ffmpeg' and
> 'guix size libgme ffmpeg').
>
> We should sort out that GCC reference first.

This concern appears to have been resolved:

--8<---------------cut here---------------start------------->8---
$ guix size /gnu/store/lgxx93sfzx6k93pcvdy2vxypham5a8ky-libgme-0.6.3
élément du dépôt                                                 total    self
/gnu/store/hw6g2kjayxnqi8rwpnmpraalxi0djkxc-glibc-2.39              40.5    38.8  51.2%
/gnu/store/d69awcc5wahh71amx0dmgaimsdvvp2bg-gcc-11.4.0-lib          75.6    35.0  46.2%
/gnu/store/87z5k84hxbqs87plgwsl2v6a4j7m3k7h-bash-static-5.1.16       1.7     1.7   2.2%
/gnu/store/lgxx93sfzx6k93pcvdy2vxypham5a8ky-libgme-0.6.3            75.9     0.3   0.5%
total : 75.9 Mio
--8<---------------cut here---------------end--------------->8---

I'll line up this change on an ffmpeg topic branch or similar.

-- 
Thanks,
Maxim

Message #16 received at 42455-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim <at> guixotic.coop>
To: Marius Bakke <marius <at> gnu.org>
Cc: 42455-done <at> debbugs.gnu.org, Jesse Gibbons <jgibbons2357 <at> gmail.com>
Subject: Re: [bug#42455] [PATCH 1/1] gnu: ffmpeg: Add support for libgme.
Date: Fri, 18 Jul 2025 12:57:16 +0900

Hi,

I'm closing this, it's been integrated in this series:
https://codeberg.org/guix/guix/pulls/1288

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.