GNU bug report logs - #42431
28.0.50; browse-url-of-dired-file confusing messaging

Previous Next

Full log

Message #59 received at 42431 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: larsi <at> gnus.org, michael.albinus <at> gmx.de, 42431 <at> debbugs.gnu.org
Subject: Re: bug#42431: 28.0.50; browse-url-of-dired-file confusing messaging
Date: Thu, 13 Oct 2022 13:35:44 +0300

> Date: Thu, 13 Oct 2022 01:51:00 -0700
> Cc: michael.albinus <at> gmx.de, 42431 <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -5000,7 +5000,7 @@ because (1) it preserves some marker positions (in unchanged portions
>        unbind_to (count1, Qnil);
>      }
>  
> -  if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0)
> +  if (save_errno != 0)
>      {
>        /* Signal an error if visiting a file that could not be opened.  */
>        report_file_errno ("Opening input file", orig_filename, save_errno);

Why would we want to signal an error when VISIT is nil?  We didn't
before.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.