From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 18 18:19:39 2020 Received: (at submit) by debbugs.gnu.org; 18 Jul 2020 22:19:39 +0000 Received: from localhost ([127.0.0.1]:59416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwvBD-0000cE-FF for submit@debbugs.gnu.org; Sat, 18 Jul 2020 18:19:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:54050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwvB9-0000c4-4s for submit@debbugs.gnu.org; Sat, 18 Jul 2020 18:19:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwvB8-0007L7-VO for bug-guix@gnu.org; Sat, 18 Jul 2020 18:19:34 -0400 Received: from aibo.runbox.com ([91.220.196.211]:46146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwvB3-0004nH-VY for bug-guix@gnu.org; Sat, 18 Jul 2020 18:19:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Subject:To:From:Date; bh=2EZ62Dc1QaREnPeh+QuQeA5eHTpmqafdqyfhK+vqJEg=; b=L13CFaveCUyF8cD6IFQMAnYZdd km32R02hKI5457sMmt3I8LLnaOGyeh/iKfd+Wm738fFLvWVq0OmE2qBCPj1bDHzLoTcThTkEgiCsX 0V+B1AQbNIziH03nWIVhXIELzmovi2lEhxPJs3CMJklr83MGufkKaRgDJ1XXOoCsEYsf59h+JrlrT WmmTWTuU4XiTvcusJIdbUwJdJK8RUzWvkLu0qTUqS6NaP5LsQ76cZcn6BIutbuIsdIQYcNvagLFoF 9j7PIxJw8irxmRy+kXcfpqdYKJu/S5XfJjs2su32Xn2ohUFe/1uOp3tHqu+mU6GW7uZbeh441EGav LSUn+TTg==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jwvAx-00018d-Cs for bug-guix@gnu.org; Sun, 19 Jul 2020 00:19:23 +0200 Received: by submission03.runbox with esmtpsa [Authenticated alias (780724)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jwvAl-0001D1-U5 for bug-guix@gnu.org; Sun, 19 Jul 2020 00:19:12 +0200 Date: Sat, 18 Jul 2020 23:19:09 +0100 From: pkill9 To: bug-guix@gnu.org Subject: git-fetch origins produce same store output when set recursive is set to true or false Message-ID: <20200718231909.646cbf7d@runbox.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=91.220.196.211; envelope-from=pkill9@runbox.com; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/18 18:19:23 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I built a source that uses git-fetch - by default (recursive? #f) - and the package failed to build, then I remembered it uses submodules, so I set (recursive? #t) but it failed with the same error. The problem is that the store path of the source is the same for both, so it didn't try to rebuild the git checkout with submodules checked out. After garbage collecting the source so it rebuilds it, I can build the package. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 25 11:23:49 2020 Received: (at 42420) by debbugs.gnu.org; 25 Jul 2020 15:23:49 +0000 Received: from localhost ([127.0.0.1]:50837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzM1c-0003ip-St for submit@debbugs.gnu.org; Sat, 25 Jul 2020 11:23:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzM1Z-0003iX-14 for 42420@debbugs.gnu.org; Sat, 25 Jul 2020 11:23:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45438) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzM1T-0002w5-1J; Sat, 25 Jul 2020 11:23:39 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:39556 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzM1S-0007Nw-KJ; Sat, 25 Jul 2020 11:23:38 -0400 From: Marius Bakke To: pkill9 , 42420@debbugs.gnu.org Subject: Re: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false In-Reply-To: <20200718231909.646cbf7d@runbox.com> References: <20200718231909.646cbf7d@runbox.com> Date: Sat, 25 Jul 2020 17:23:21 +0200 Message-ID: <878sf7vct2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42420 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain pkill9 writes: > I built a source that uses git-fetch - by default (recursive? #f) - and > the package failed to build, then I remembered it uses submodules, so I > set (recursive? #t) but it failed with the same error. The problem is > that the store path of the source is the same for both, so it didn't > try to rebuild the git checkout with submodules checked out. > > After garbage collecting the source so it rebuilds it, I can build the > package. Could it be that you did not update the sha256 checksum of the package after setting (recursive? #t), so Guix thought it already had the complete checkout in the store? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cTmkACgkQoqBt8qM6 VPqChQgAmEo3rfiBVE4cGo0Kr//D8l+o6OYWMbaL8zZ+0N2UCcma1F4sMxjmJYNM qOG4kpGZlnfRD1aLA82OJd86rFe1msnx/FkFhW46Bc7qyJWmMLVkgQgdZxkmwQFi sETM4ldpMiC4i9TmjCX3R2NoJad54b1/1uZgEQLxHiHeWmvxC39dDzP9BSgRakQg Let19IwDk9nvlhDnKTppIAUdWebpVeNNng3wjOkZTJndD7KaMmQlz6nUh+syUC2O 1HL8tcsctoOJ5RPhXGiD7JcUxyPCx+Tdfo4xoCFh+dUA7GJuB74WlQaTlcDK0+aN 20tfSw97iJGWektO7qDkBWBtR66P8Q== =hujc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 28 00:23:39 2020 Received: (at 42420) by debbugs.gnu.org; 28 Nov 2020 05:23:39 +0000 Received: from localhost ([127.0.0.1]:46828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kishv-0003bm-40 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 00:23:39 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:33241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kisht-0003bW-BF for 42420@debbugs.gnu.org; Sat, 28 Nov 2020 00:23:37 -0500 Received: by mail-qk1-f179.google.com with SMTP id 1so4868937qka.0 for <42420@debbugs.gnu.org>; Fri, 27 Nov 2020 21:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PSaBAfE98mAGgvdM/32M7QYMpqSwB8hvjrYZ/8Wv070=; b=u76okleF8vmtlgnpeNa8QgfGZLKLPjZUSBoyXr/EGnalJnbNwyodNrVivSLZytC6n1 BgiVkLzw50aXKOnFde6BKYWVtfBNWKWzRjdsUGZoITxCLn3BbHsZ2q9pthcdp10s9r3q Rwx2ajnxQVYBPUP3J3mjLWghK6oCRsvvfiLtx6AGvIQDqyyzgKBmw04E0EVqSj/k3m4f wr9NL13B7gsGT/RnqX9Ho7c4KHqO1uFq0/YT8bevjv2kPv/hKBHk/NvfsJkEtq//8ltT +o7S5nv9KAAmFoG0gCMmBJkAfR8TZ+cxxw8WfS7iHZdgmm10f/LecrGEtYSbjGyOoE9b qKhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PSaBAfE98mAGgvdM/32M7QYMpqSwB8hvjrYZ/8Wv070=; b=Z0nDG1gPLZ3dvNl8oCNxFh3FCSfyo7sK1P++A3LFAYih3hjaoYIv3ggJM7y4xYqsuT hyKZ5Ri/rRN2y7+Mx9UOxPJrKQZ0udGNIy3C0pKcx/Cnkgb1q698lRaTCa4LG6aThCyi OSde0qB1rJrbf3+hH5+AsRZ5BDspdWnlmCuBE0hrNXMBGSFp56nf1dVwOg+JvP/XAMM/ mOab1rYaEnnn60V2VNxGDRMxKmnAayoSaYfjHotdJ56yovp8gbdtHYsJGWh9KJnh0kXn Igfe+ROqvqXTBGZem/V5sJLjh2m1LJgSluwJowFymHC4RR+eXNtX2WMZOimSkARh79DN t/7A== X-Gm-Message-State: AOAM531qNnT+F6vsm5GukC+m2WpTQAJxcvu/JGyuQPUV4mKhTdZxbuKi BXoi72jc5vSxbcJ/pIX04jnzlo0atcSj1A== X-Google-Smtp-Source: ABdhPJzJbvYarmxT3dqcFrvDu1Jud8rC0DrsazVym8H5nhyFHSlJ9lk902+svTMthTWUq+dTAIxNWA== X-Received: by 2002:a37:ac19:: with SMTP id e25mr11649889qkm.344.1606541010636; Fri, 27 Nov 2020 21:23:30 -0800 (PST) Received: from hurd (dsl-205-151-56-74.b2b2c.ca. [205.151.56.74]) by smtp.gmail.com with ESMTPSA id l79sm8701335qke.1.2020.11.27.21.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 21:23:29 -0800 (PST) From: Maxim Cournoyer To: Marius Bakke Subject: Re: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false References: <20200718231909.646cbf7d@runbox.com> <878sf7vct2.fsf@gnu.org> Date: Sat, 28 Nov 2020 00:23:28 -0500 In-Reply-To: <878sf7vct2.fsf@gnu.org> (Marius Bakke's message of "Sat, 25 Jul 2020 17:23:21 +0200") Message-ID: <87czzynjfz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42420 Cc: pkill9 , 42420@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Marius Bakke writes: > pkill9 writes: > >> I built a source that uses git-fetch - by default (recursive? #f) - and >> the package failed to build, then I remembered it uses submodules, so I >> set (recursive? #t) but it failed with the same error. The problem is >> that the store path of the source is the same for both, so it didn't >> try to rebuild the git checkout with submodules checked out. >> >> After garbage collecting the source so it rebuilds it, I can build the >> package. > > Could it be that you did not update the sha256 checksum of the package > after setting (recursive? #t), so Guix thought it already had the > complete checkout in the store? Yes, that just happened to me. It's confusing, but I don't see how we can improve on that. pkill, next time this happens, you might want to force a check on the cached source via 'guix build --source --check'. I believe this would flag the discrepancy. Is there an action to do here, or should we simply close it? Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 28 12:04:28 2020 Received: (at 42420-done) by debbugs.gnu.org; 28 Nov 2020 17:04:28 +0000 Received: from localhost ([127.0.0.1]:48955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj3e7-0004LD-Oh for submit@debbugs.gnu.org; Sat, 28 Nov 2020 12:04:27 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj3e4-0004Kx-OY for 42420-done@debbugs.gnu.org; Sat, 28 Nov 2020 12:04:25 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AFD435C00AD; Sat, 28 Nov 2020 12:04:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 28 Nov 2020 12:04:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Drt60CrNHeBqQ9Lp6++vd6pG agWF/g/8//TEQjqsIQo=; b=LBweIyvj2BCjjdxxqZvVHvrsmy6udpI6fISQQOKV B/ThHC687XjHEs9jWGaQ565QMLj/hzcS34iscPdQw1zO7iX+8eqcYdhYzuhJtYnB YFq19pfAQvvchtq0B1fIvnsTyHWHpQJYst9jChEF5JjF8+l8oKZa773yxg/UazFP kWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Drt60C rNHeBqQ9Lp6++vd6pGagWF/g/8//TEQjqsIQo=; b=SvPoAKhbNF8mrkFPGJIivZ 31us2+calcHMWTjSnvPGWRrfvRR+rm8UddWNXaAemGzAyeTEIfhcyA5UPRg3uQr8 zWELymPVpSkeoS5IVLQ6i0VnEUT92okXb0jgWmpdhpRWhOKn0QQjq/EZHk690y/N Wd6t5KZZUDQ7XmsVLHFWrMj1C2B9EIGtj5URpFSgD/b3qZILdLITH1p8c0zSpyzC nVRTwAXPnxuZnccg5sGb4LX/JAxDN5+k/kDHFuy5DsIdGN352x2dfp8jR/ascM0f z1aMSbeX1SzDqrvfOIKW0sDph/fAin1Ka67Ttl7zgZtVMwh/jo9sf+ykyUz69cMA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehiedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 58EFF3064AB0; Sat, 28 Nov 2020 12:04:18 -0500 (EST) Date: Sat, 28 Nov 2020 12:04:16 -0500 From: Leo Famulari To: Maxim Cournoyer Subject: Re: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false Message-ID: References: <20200718231909.646cbf7d@runbox.com> <878sf7vct2.fsf@gnu.org> <87czzynjfz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87czzynjfz.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42420-done Cc: 42420-done@debbugs.gnu.org, pkill9 , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Nov 28, 2020 at 12:23:28AM -0500, Maxim Cournoyer wrote: > Is there an action to do here, or should we simply close it? If we have a good idea for how to improve the situation, we should use it. Otherwise, we can close the bug. It's something that confuses a lot of people the first time but, once you learn what's happening, it's easy to avoid in the future. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 29 23:06:17 2020 Received: (at 42420-done) by debbugs.gnu.org; 30 Nov 2020 04:06:17 +0000 Received: from localhost ([127.0.0.1]:53140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjaS9-000442-5u for submit@debbugs.gnu.org; Sun, 29 Nov 2020 23:06:17 -0500 Received: from mail-qk1-f176.google.com ([209.85.222.176]:34961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjaS8-00043r-5T for 42420-done@debbugs.gnu.org; Sun, 29 Nov 2020 23:06:16 -0500 Received: by mail-qk1-f176.google.com with SMTP id v143so9764946qkb.2 for <42420-done@debbugs.gnu.org>; Sun, 29 Nov 2020 20:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ta1wv3iQHA1JHziZvsm0NfHS3J/C2rrJQJpylJO5c1k=; b=an9rOGmNbeavHQgnmszoKguHphfSzg/cKMR1AUi7pwdtQ/XLn3unhRa8vF7JiKFkNI 92VmmuFfU1cOqGIeKPvi5odh/HbEobrucZuiHKeZK7pmggQIoIexf0Zf5tv3phLkIuyQ N4J8I9nWxJNEbkG1lEmfRPTOR35w/bTcNEcdSfpncbrLYgaEPurHM/NncwaNI2KHViUL KPN1FBDNT9q5HAM/t/kOFcOeV1pW5qchYkx90OxzcB9xztAU8f+40s88iNbHu10q7CnD Z/n3eFZNCI4nqLdC3OgMh5tPXc2chnXCQ+wdQBPEtXIC5yIJvxryPWSVfh3S/PddSf+i uXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ta1wv3iQHA1JHziZvsm0NfHS3J/C2rrJQJpylJO5c1k=; b=XX3XAm9XW5OHfJARxGOYH5WDlsK6WCA0lTfSAIrmK8fRF0H6Sj+yIwIFXV0kwRteyH ULsFENBZzkqDAENxeP7rtsWDRHY9gFq7LRakzXwkhEQo+VTXEfXFsgkTA6f3C9X7Tz2o vf3MYGPMLFsCG8HZsX01E//6LNv5QyGLetCubzfG5Bu1l9EfbA4aoGFafpjnGgm76S3q TT4OnpF7WS3JOPa3kiqtUTGxs5WXWTqzbIhYbmm0s5MI41x37UCEroQjJfbu6wZw71QO 4nkd1Ve28WfYrbx/QS8FWgSEtLNCZi+BHhltATc0qAOE9MP0HDyMHZHaYlqBOaAt4NZ/ H2Tg== X-Gm-Message-State: AOAM53135tNOV+Y3pzw/clEe90yh2h/hl0oLEDD8HYmZcOlRTPOn0WSh g+vyg9eGmtnIENukluvy7JlVX0UCHRxZr+tq X-Google-Smtp-Source: ABdhPJwX6yrj7r/DoeI1p/FFhAahNrXNUH/+SMwMWozOSKwPd+5pQV12v0FxssYSG76UHo7K3ZloRQ== X-Received: by 2002:a37:6f07:: with SMTP id k7mr20210427qkc.423.1606709170620; Sun, 29 Nov 2020 20:06:10 -0800 (PST) Received: from hurd (dsl-150-82.b2b2c.ca. [66.158.150.82]) by smtp.gmail.com with ESMTPSA id i12sm13907780qtr.56.2020.11.29.20.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 20:06:09 -0800 (PST) From: Maxim Cournoyer To: Leo Famulari Subject: Re: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false References: <20200718231909.646cbf7d@runbox.com> <878sf7vct2.fsf@gnu.org> <87czzynjfz.fsf@gmail.com> Date: Sun, 29 Nov 2020 23:06:09 -0500 In-Reply-To: (Leo Famulari's message of "Sat, 28 Nov 2020 12:04:16 -0500") Message-ID: <87czzvmqtq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42420-done Cc: 42420-done@debbugs.gnu.org, pkill9 , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Leo Famulari writes: > On Sat, Nov 28, 2020 at 12:23:28AM -0500, Maxim Cournoyer wrote: >> Is there an action to do here, or should we simply close it? > > If we have a good idea for how to improve the situation, we should use > it. Otherwise, we can close the bug. It's something that confuses a lot > of people the first time but, once you learn what's happening, it's easy > to avoid in the future. I don't; it'd involve changing the way fixed-output derivations are cached, such as keeping metadata about the sources for fixed hash derivations (e.g., "There's a hash in the store matching what the sources tells me, but was it produced from the same origin source?"), and I don't see how that'd be a good thing. Note that 'guix build --source --check' can be used when in doubt that the origin really computes to the in-store item matching its declared hash. I've just documented so in the hope users will find it in the manual when they stumble on such a situation; see commit 3462678bc346c2f6ea81245d6842264b6dccd945. I'm closing the issue for now. We can try to do more if it comes back too often. Thank you, Maxim From unknown Fri Jun 20 20:13:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 28 Dec 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator