GNU bug report logs - #42406
Mouse-wheel scrolling can be flickering

Previous Next

Full log

Message #294 received at 42406 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: alan <at> idiocy.org, konrad.podczeck <at> univie.ac.at, 42406 <at> debbugs.gnu.org
Subject: Re: bug#42406: Mouse-wheel scrolling can be flickering
Date: Fri, 18 Dec 2020 18:12:45 -0500

>> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
>> Cc: alan <at> idiocy.org,  konrad.podczeck <at> univie.ac.at,  42406 <at> debbugs.gnu.org
>> Date: Fri, 18 Dec 2020 11:22:40 -0500
>> 
>> To be clear: I have no intention to push this to `emacs-27`, but
>> I can't see any good reason not to push it to master (after fixing its
>> FIXME, obviously).
>
> I thought I already explained why I'm not interested in such "fixes".

I resent the way you used scare-quotes around this word.
This *is* a fix and it only touches "flags" whose semantics we
understand well.

Any change to the redisplay will risk introducing regressions because of
the previous code's intricate workings so if you reject this simple
change, I can't see why you wouldn't reject similarly any other change
to the redisplay (including your advocated big redesign).

After all, my `redisplay` bits did pretty much exactly what you suggest
we do, except that they did not try to use a finer distinction between
frametitles, headerlines, modelines, ...

I really just don't understand your stance here.

> Oh, and your question about where the change in mode-line dimensions
> is handled? it's here:
>
>       display_mode_lines (w);
>
>       /* If mode line height has changed, arrange for a thorough
> 	 immediate redisplay using the correct mode line height.  */
>       if (window_wants_mode_line (w)
> 	  && CURRENT_MODE_LINE_HEIGHT (w) != DESIRED_MODE_LINE_HEIGHT (w))
> 	{
> 	  f->fonts_changed = true;
> 	  w->mode_line_height = -1;
> 	  MATRIX_MODE_LINE_ROW (w->current_matrix)->height
> 	    = DESIRED_MODE_LINE_HEIGHT (w);
> 	}
>       [...]
>       if (f->fonts_changed)
> 	goto need_larger_matrices;

Ah, right, thanks, that makes sense.  And it shows that the division
between "mode-lines" and "window contents" was a good idea, since in
most cases they can be handled separately and in the few cases where
they can't, we can easily arrange to augment the amount that's actually
redisplayed once we discover that more needs to be done.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.