GNU bug report logs - #42397
[PATCH 00/14] Use outline headings and some cosmetics

Previous Next

Package: emacs;

Reported by: Jonas Bernoulli <jonas <at> bernoul.li>

Date: Thu, 16 Jul 2020 14:48:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 42397 <at> debbugs.gnu.org
Subject: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation.
Date: Fri, 17 Jul 2020 20:23:37 +0200

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Jonas Bernoulli <jonas <at> bernoul.li> writes:

>> +	  (when mode-line-format
>> +	    (unless (and (listp mode-line-format)
>> +			 (assq 'eldoc-mode-line-string mode-line-format))
>> +	      (setq mode-line-format ...)))
>
> You can avoid reindenting this whole block by merging the conditions of
> the redundantly nested when and unless:
>
>   (unless (if (consp mode-line-format)
>               (assq 'eldoc-mode-line-string mode-line-format)
>             (not mode-line-format))
>     (setq mode-line-format ...))

I suppose; but IMO this variant is trying to hard to be smart.

> or similar.

I think I will go with:

  (when (and mode-line-format
             (not (and (listp mode-line-format)
                       (assq 'eldoc-mode-line-string mode-line-format))))
    (setq mode-line-format ...))
This bug report was last modified 4 years and 342 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.