From unknown Thu Aug 21 23:00:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#42397 <42397@debbugs.gnu.org> To: bug#42397 <42397@debbugs.gnu.org> Subject: Status: [PATCH 00/14] Use outline headings and some cosmetics Reply-To: bug#42397 <42397@debbugs.gnu.org> Date: Fri, 22 Aug 2025 06:00:29 +0000 retitle 42397 [PATCH 00/14] Use outline headings and some cosmetics reassign 42397 emacs submitter 42397 Jonas Bernoulli severity 42397 normal tag 42397 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:47:29 2020 Received: (at submit) by debbugs.gnu.org; 16 Jul 2020 14:47:29 +0000 Received: from localhost ([127.0.0.1]:55659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5AX-0007OX-Fw for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:47:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:46476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5AW-0007OP-6A for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw5AV-0000bZ-Rr for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 10:47:27 -0400 Received: from mail.hostpark.net ([212.243.197.30]:58900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw5AU-0000fl-2I for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 10:47:27 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 416DB16B57; Thu, 16 Jul 2020 16:47:21 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id VXZa3K-8DQd8; Thu, 16 Jul 2020 16:47:08 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2E56D1615D; Thu, 16 Jul 2020 16:47:08 +0200 (CEST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: [PATCH 00/14] Use outline headings and some cosmetics Date: Thu, 16 Jul 2020 16:47:07 +0200 Message-Id: <20200716144707.16857-1-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 10:47:21 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This patch series adds outline-minor-mode compatible headers to some libraries. In some cases that is done by increasing the number of semicolons from two to the necessary three. In other cases completely new headings had to be added. Also included are some cleanup commits. [Note that this patch series was created using git-format-patch. The subjects are the commit summaries. I am the author of these changes.] Jonas Bernoulli (14): ; * lisp/epg.el (epg-signature-to-string): Use cl-case. ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias. Split EasyPG libraries into outline sections * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. * lisp/progmodes/compile.el: Remove unnecessary comments. ; * lisp/whitespace.el: Capitalize "Code" section heading. * lisp/mail/smtpmail.el: Use outline headings. * test/src/emacs-module-tests.el: Use proper outline headings. * lisp/obsolete/longlines.el: Use proper outline headings. * lisp/net/imap.el: Use proper outline headings * lisp/font-lock.el: Split the Commentary into subsections. * lisp/font-lock.el: No longer mark each end of a section explicitly. lisp/emacs-lisp/eldoc.el | 14 +++--- lisp/epa-dired.el | 1 + lisp/epa-file.el | 9 ++++ lisp/epa-hook.el | 1 + lisp/epa-mail.el | 9 ++++ lisp/epa.el | 37 ++++++++++------ lisp/epg-config.el | 6 +++ lisp/epg.el | 79 ++++++++++++++++++++-------------- lisp/font-lock.el | 22 +++------- lisp/mail/smtpmail.el | 9 ++-- lisp/net/imap.el | 29 +++++++------ lisp/obsolete/longlines.el | 18 ++++---- lisp/progmodes/compile.el | 2 - lisp/whitespace.el | 2 +- test/src/emacs-module-tests.el | 20 +++------ 15 files changed, 149 insertions(+), 109 deletions(-) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:02 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:02 +0000 Received: from localhost ([127.0.0.1]:55672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hp-0007Zx-Qr for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:02 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hn-0007Zh-6E for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:00 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 6276E160BA; Thu, 16 Jul 2020 16:54:57 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id Ir_xyqrOcvjy; Thu, 16 Jul 2020 16:54:57 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 31005160AE; Thu, 16 Jul 2020 16:54:57 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. Date: Thu, 16 Jul 2020 16:54:43 +0200 Message-Id: <20200716145456.17531-1-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) In this case we can greatly increase readability by using `cl-case' instead of `cond'. --- lisp/epg.el | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lisp/epg.el b/lisp/epg.el index 222fd913e1..e97db65b60 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -404,18 +404,13 @@ epg-signature-to-string (pubkey-algorithm (epg-signature-pubkey-algorithm signature)) (key-id (epg-signature-key-id signature))) (concat - (cond ((eq (epg-signature-status signature) 'good) - "Good signature from ") - ((eq (epg-signature-status signature) 'bad) - "Bad signature from ") - ((eq (epg-signature-status signature) 'expired) - "Expired signature from ") - ((eq (epg-signature-status signature) 'expired-key) - "Signature made by expired key ") - ((eq (epg-signature-status signature) 'revoked-key) - "Signature made by revoked key ") - ((eq (epg-signature-status signature) 'no-pubkey) - "No public key for ")) + (cl-case signature + (good "Good signature from ") + (bad "Bad signature from ") + (expired "Expired signature from ") + (expired-key "Signature made by expired key ") + (revoked-key "Signature made by revoked key ") + (no-pubkey "No public key for ")) key-id (if user-id (concat " " -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:04 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:04 +0000 Received: from localhost ([127.0.0.1]:55675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hs-0007aV-JE for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:04 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hr-0007aK-BJ for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:03 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id A30A6160BA; Thu, 16 Jul 2020 16:55:02 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id GlL3fWWNS180; Thu, 16 Jul 2020 16:55:02 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 752A8160AE; Thu, 16 Jul 2020 16:55:02 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 02/14] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. Date: Thu, 16 Jul 2020 16:54:44 +0200 Message-Id: <20200716145456.17531-2-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-1-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) `concat' treats arguments that are nil as if they were empty strings. We therefore do not have to write (if TEST THEN "") and can just use (and TEST THEN). --- lisp/epg.el | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/lisp/epg.el b/lisp/epg.el index e97db65b60..c10eb4f06c 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -412,24 +412,20 @@ epg-signature-to-string (revoked-key "Signature made by revoked key ") (no-pubkey "No public key for ")) key-id - (if user-id - (concat " " - (if (stringp user-id) - (epg--decode-percent-escape-as-utf-8 user-id) - (epg-decode-dn user-id))) - "") - (if (epg-signature-validity signature) - (format " (trust %s)" (epg-signature-validity signature)) - "") - (if (epg-signature-creation-time signature) - (format-time-string " created at %Y-%m-%dT%T%z" - (epg-signature-creation-time signature)) - "") - (if pubkey-algorithm - (concat " using " - (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist)) - (format "(unknown algorithm %d)" pubkey-algorithm))) - "")))) + (and user-id + (concat " " + (if (stringp user-id) + (epg--decode-percent-escape-as-utf-8 user-id) + (epg-decode-dn user-id)))) + (and (epg-signature-validity signature) + (format " (trust %s)" (epg-signature-validity signature))) + (and (epg-signature-creation-time signature) + (format-time-string " created at %Y-%m-%dT%T%z" + (epg-signature-creation-time signature))) + (and pubkey-algorithm + (concat " using " + (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist)) + (format "(unknown algorithm %d)" pubkey-algorithm))))))) (defun epg-verify-result-to-string (verify-result) "Convert VERIFY-RESULT to a human readable string." -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:10 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:10 +0000 Received: from localhost ([127.0.0.1]:55678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hx-0007ap-Pb for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:10 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Hw-0007ah-JR for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:08 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DF6F1160BA; Thu, 16 Jul 2020 16:55:07 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id AIbyxWGpkwn5; Thu, 16 Jul 2020 16:55:07 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id AD9DE160AE; Thu, 16 Jul 2020 16:55:07 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 03/14] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. Date: Thu, 16 Jul 2020 16:54:45 +0200 Message-Id: <20200716145456.17531-3-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-2-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/epg.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/epg.el b/lisp/epg.el index c10eb4f06c..2e092acc6a 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -123,7 +123,7 @@ epg-import-problem-reason-alist (defconst epg-no-data-reason-alist '((1 . "No armored data") - (2 . "Expected a packet but did not found one") + (2 . "Expected a packet but did not find one") (3 . "Invalid packet found, this may indicate a non OpenPGP message") (4 . "Signature expected but not found"))) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:15 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:15 +0000 Received: from localhost ([127.0.0.1]:55681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5I3-0007bA-1p for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:15 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5I1-0007b0-Rw for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:14 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 2CA20160BA; Thu, 16 Jul 2020 16:55:13 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id NhuJVlSjoanA; Thu, 16 Jul 2020 16:55:13 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id F00E4160AE; Thu, 16 Jul 2020 16:55:12 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 04/14] * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias. Date: Thu, 16 Jul 2020 16:54:46 +0200 Message-Id: <20200716145456.17531-4-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-3-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) `derived-mode-p' was added twenty years ago in 6ad501012b9a9ddc26dd8ce1cef8332ee16d87df and by now we can just assume that it exists. --- lisp/epa.el | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lisp/epa.el b/lisp/epa.el index 3c7dd8309a..fc7ad5efab 100644 --- a/lisp/epa.el +++ b/lisp/epa.el @@ -1105,17 +1105,6 @@ epa-sign-region 'start-open t 'end-open t))))) -(defalias 'epa--derived-mode-p - (if (fboundp 'derived-mode-p) - #'derived-mode-p - (lambda (&rest modes) - "Non-nil if the current major mode is derived from one of MODES. -Uses the `derived-mode-parent' property of the symbol to trace backwards." - (let ((parent major-mode)) - (while (and (not (memq parent modes)) - (setq parent (get parent 'derived-mode-parent)))) - parent)))) - ;;;###autoload (defun epa-encrypt-region (start end recipients sign signers) "Encrypt the current region between START and END for RECIPIENTS. @@ -1227,8 +1216,7 @@ epa-import-keys (if (epg-context-result-for context 'import) (epa-display-info (epg-import-result-to-string (epg-context-result-for context 'import)))) - ;; FIXME: Why not use the (otherwise unused) epa--derived-mode-p? - (if (eq major-mode 'epa-key-list-mode) + (if (derived-mode-p 'epa-key-list-mode) (apply #'epa--list-keys epa-list-keys-arguments)))) ;;;###autoload -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:21 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:21 +0000 Received: from localhost ([127.0.0.1]:55684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5I9-0007bW-Aj for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:21 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5I7-0007bM-61 for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:19 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 76E9F160BA; Thu, 16 Jul 2020 16:55:18 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id oTCREEyqSFlk; Thu, 16 Jul 2020 16:55:18 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 36619160AE; Thu, 16 Jul 2020 16:55:18 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 05/14] Split EasyPG libraries into outline sections Date: Thu, 16 Jul 2020 16:54:47 +0200 Message-Id: <20200716145456.17531-5-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-4-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * lisp/epa-dired.el: lisp/epa-file.el: lisp/epa-hook.el: lisp/epa-mail.el: lisp/epa.el: lisp/epg-config.el: lisp/epg.el: Split into outline sections. * lisp/epg.el (epg-error): Move definition. --- lisp/epa-dired.el | 1 + lisp/epa-file.el | 9 +++++++++ lisp/epa-hook.el | 1 + lisp/epa-mail.el | 9 +++++++++ lisp/epa.el | 23 +++++++++++++++++++++++ lisp/epg-config.el | 6 ++++++ lisp/epg.el | 26 +++++++++++++++++++++++++- 7 files changed, 74 insertions(+), 1 deletion(-) diff --git a/lisp/epa-dired.el b/lisp/epa-dired.el index 9269ea9707..4ff1ba3394 100644 --- a/lisp/epa-dired.el +++ b/lisp/epa-dired.el @@ -1,4 +1,5 @@ ;;; epa-dired.el --- the EasyPG Assistant, dired extension -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno diff --git a/lisp/epa-file.el b/lisp/epa-file.el index 20043a9eae..de51c59c34 100644 --- a/lisp/epa-file.el +++ b/lisp/epa-file.el @@ -1,4 +1,5 @@ ;;; epa-file.el --- the EasyPG Assistant, transparent file encryption -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -25,6 +26,8 @@ (require 'epa) (require 'epa-hook) +;;; Options + (defcustom epa-file-cache-passphrase-for-symmetric-encryption nil "If non-nil, cache passphrase for symmetric encryption. @@ -49,6 +52,8 @@ epa-file-select-keys (const :tag "Don't ask" silent)) :group 'epa-file) +;;; Other + (defvar epa-file-passphrase-alist nil) (defun epa-file-passphrase-callback-function (context key-id file) @@ -72,6 +77,8 @@ epa-file-passphrase-callback-function passphrase)))) (epa-passphrase-callback-function context key-id file))) +;;; File Handler + (defvar epa-inhibit nil "Non-nil means don't try to decrypt .gpg files when operating on them.") @@ -303,6 +310,8 @@ epa-file-write-region (message "Wrote %s" buffer-file-name)))) (put 'write-region 'epa-file 'epa-file-write-region) +;;; Commands + (defun epa-file-select-keys () "Select recipients for encryption." (interactive) diff --git a/lisp/epa-hook.el b/lisp/epa-hook.el index a86f23eb68..6f12f8a6bf 100644 --- a/lisp/epa-hook.el +++ b/lisp/epa-hook.el @@ -1,4 +1,5 @@ ;;; epa-hook.el --- preloaded code to enable epa-file.el -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno diff --git a/lisp/epa-mail.el b/lisp/epa-mail.el index 00f560af0b..4c57235394 100644 --- a/lisp/epa-mail.el +++ b/lisp/epa-mail.el @@ -1,4 +1,5 @@ ;;; epa-mail.el --- the EasyPG Assistant, minor-mode for mail composer -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -25,6 +26,8 @@ (require 'epa) (require 'mail-utils) +;;; Local Mode + (defvar epa-mail-mode-map (let ((keymap (make-sparse-keymap))) (define-key keymap "\C-c\C-ed" 'epa-mail-decrypt) @@ -50,6 +53,8 @@ epa-mail-mode "A minor-mode for composing encrypted/clearsigned mails." nil " epa-mail" epa-mail-mode-map) +;;; Utilities + (defun epa-mail--find-usable-key (keys usage) "Find a usable key from KEYS for USAGE. USAGE would be `sign' or `encrypt'." @@ -64,6 +69,8 @@ epa-mail--find-usable-key (setq pointer (cdr pointer)))) (setq keys (cdr keys))))) +;;; Commands + ;;;###autoload (defun epa-mail-decrypt () "Decrypt OpenPGP armors in the current buffer. @@ -238,6 +245,8 @@ epa-mail-import-keys (interactive) (epa-import-armor-in-region (point-min) (point-max))) +;;; Global Mode + ;;;###autoload (define-minor-mode epa-global-mail-mode "Minor mode to hook EasyPG into Mail mode." diff --git a/lisp/epa.el b/lisp/epa.el index fc7ad5efab..a63dc18fdb 100644 --- a/lisp/epa.el +++ b/lisp/epa.el @@ -30,6 +30,8 @@ (require 'wid-edit)) (require 'derived) +;;; Options + (defgroup epa nil "The EasyPG Assistant" :version "23.1" @@ -73,6 +75,8 @@ epa-mail-aliases :group 'epa :version "24.4") +;;; Faces + (defgroup epa-faces nil "Faces for epa-mode." :version "23.1" @@ -146,6 +150,8 @@ epa-validity-face-alist :type '(repeat (cons symbol face)) :group 'epa-faces) +;;; Variables + (defvar epa-font-lock-keywords '(("^\\*" (0 'epa-mark)) @@ -252,6 +258,8 @@ epa-info-mode-map (defvar epa-exit-buffer-function #'quit-window) +;;; Key Widget + (define-widget 'epa-key 'push-button "Button for representing an epg-key object." :format "%[%v%]" @@ -293,6 +301,8 @@ epa--key-widget-help-echo (epg-sub-key-id (car (epg-key-sub-key-list (widget-get widget :value)))))) +;;; Modes + (define-derived-mode epa-key-list-mode special-mode "EPA Keys" "Major mode for `epa-list-keys'." (buffer-disable-undo) @@ -316,6 +326,9 @@ epa-info-mode (setq truncate-lines t buffer-read-only t)) +;;; Commands +;;;; Marking + (defun epa-mark-key (&optional arg) "Mark a key on the current line. If ARG is non-nil, unmark the key." @@ -338,11 +351,15 @@ epa-unmark-key (interactive "P") (epa-mark-key (not arg))) +;;;; Quitting + (defun epa-exit-buffer () "Exit the current buffer using `epa-exit-buffer-function'." (interactive) (funcall epa-exit-buffer-function)) +;;;; Listing and Selecting + (defun epa--insert-keys (keys) (save-excursion (save-restriction @@ -505,6 +522,8 @@ epa-select-keys (let ((keys (epg-list-keys context names secret))) (epa--select-keys prompt keys))) +;;;; Key Details + (defun epa-show-key () "Show a key on the current line." (interactive) @@ -591,6 +610,8 @@ epa--show-key (goto-char (point-min)) (pop-to-buffer (current-buffer)))) +;;;; Encryption and Signatures + (defun epa-display-info (info) (if epa-popup-info-window (save-selected-window @@ -1180,6 +1201,8 @@ epa-encrypt-region 'start-open t 'end-open t))))) +;;;; Key Management + ;;;###autoload (defun epa-delete-keys (keys &optional allow-secret) "Delete selected KEYS." diff --git a/lisp/epg-config.el b/lisp/epg-config.el index 1c42924652..e7f9d303ad 100644 --- a/lisp/epg-config.el +++ b/lisp/epg-config.el @@ -34,6 +34,8 @@ epg-version-number (define-obsolete-variable-alias 'epg-bug-report-address 'report-emacs-bug-address "27.1") +;;; Options + (defgroup epg () "Interface to the GNU Privacy Guard (GnuPG)." :tag "EasyPG" @@ -106,6 +108,8 @@ epg-debug Note that the buffer name starts with a space." :type 'boolean) +;;; Constants + (defconst epg-gpg-minimum-version "1.4.3") (defconst epg-gpg2-minimum-version "2.1.6") @@ -133,6 +137,8 @@ epg-config--configuration-constructor-alist either `OpenPGP' or `CMS'. The second element is a function which constructs a configuration object (actually a plist).") +;;; "Configuration" + (defvar epg--configurations nil) ;;;###autoload diff --git a/lisp/epg.el b/lisp/epg.el index 2e092acc6a..9909b819e4 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -1,4 +1,5 @@ ;;; epg.el --- the EasyPG Library -*- lexical-binding: t -*- + ;; Copyright (C) 1999-2000, 2002-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -25,6 +26,10 @@ (require 'epg-config) (eval-when-compile (require 'cl-lib)) +(define-error 'epg-error "GPG error") + +;;; Variables + (defvar epg-user-id nil "GnuPG ID of your default identity.") @@ -41,6 +46,8 @@ epg-debug-buffer (defvar epg-agent-file nil) (defvar epg-agent-mtime nil) +;;; Enums + ;; from gnupg/common/openpgpdefs.h (defconst epg-cipher-algorithm-alist '((0 . "NONE") @@ -169,7 +176,8 @@ epg-dn-type-alist (defvar epg-prompt-alist nil) -(define-error 'epg-error "GPG error") +;;; Structs +;;;; Data Struct (cl-defstruct (epg-data (:constructor nil) @@ -180,6 +188,8 @@ 'epg-error (file nil :read-only t) (string nil :read-only t)) +;;;; Context Struct + (cl-defstruct (epg-context (:constructor nil) (:constructor epg-context--make @@ -218,6 +228,8 @@ 'epg-error (error-output "") error-buffer) +;;;; Context Methods + ;; This is not an alias, just so we can mark it as autoloaded. ;;;###autoload (defun epg-make-context (&optional protocol armor textmode include-certs @@ -281,6 +293,8 @@ epg-context-set-signers (declare (obsolete setf "25.1")) (setf (epg-context-signers context) signers)) +;;;; Other Structs + (cl-defstruct (epg-signature (:constructor nil) (:constructor epg-make-signature @@ -385,6 +399,8 @@ epg-context-set-signers secret-unchanged not-imported imports) +;;; Functions + (defun epg-context-result-for (context name) "Return the result of CONTEXT associated with NAME." (cdr (assq name (epg-context-result context)))) @@ -850,6 +866,8 @@ epg--prompt-GET_BOOL-untrusted_key.override (format "Untrusted key %s %s. Use anyway? " key-id user-id)) "Use untrusted key anyway? "))) +;;; Status Functions + (defun epg--status-GET_BOOL (context string) (let (inhibit-quit) (condition-case nil @@ -1225,6 +1243,8 @@ epg--status-IMPORT_RES (epg-context-result-for context 'import-status))) (epg-context-set-result-for context 'import-status nil))) +;;; Functions + (defun epg-passphrase-callback-function (context key-id _handback) (declare (obsolete epa-passphrase-callback-function "23.1")) (if (eq key-id 'SYM) @@ -1294,6 +1314,8 @@ epg--make-sub-key-1 (if (aref line 6) (epg--time-from-seconds (aref line 6))))) +;;; Public Functions + (defun epg-list-keys (context &optional name mode) "Return a list of epg-key objects matched with NAME. If MODE is nil or `public', only public keyring should be searched. @@ -2022,6 +2044,8 @@ epg-edit-key (epg-errors-to-string errors)))))) (epg-reset context))) +;;; Decode Functions + (defun epg--decode-percent-escape (string) (setq string (encode-coding-string string 'raw-text)) (let ((index 0)) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:30 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:30 +0000 Received: from localhost ([127.0.0.1]:55688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IH-0007bu-RW for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:30 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IC-0007bg-AC for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 9A236160BA; Thu, 16 Jul 2020 16:55:23 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id rWGmb_QL3BtD; Thu, 16 Jul 2020 16:55:23 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 6FE66160AE; Thu, 16 Jul 2020 16:55:23 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. Date: Thu, 16 Jul 2020 16:54:48 +0200 Message-Id: <20200716145456.17531-6-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-5-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/emacs-lisp/eldoc.el | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 510dff9ed0..90dce4a317 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -285,13 +285,13 @@ eldoc-minibuffer-message (or (window-in-direction 'above (minibuffer-window)) (minibuffer-selected-window) (get-largest-window))) - (when mode-line-format - (unless (and (listp mode-line-format) - (assq 'eldoc-mode-line-string mode-line-format)) - (setq mode-line-format - (list "" '(eldoc-mode-line-string - (" " eldoc-mode-line-string " ")) - mode-line-format)))) + (when mode-line-format + (unless (and (listp mode-line-format) + (assq 'eldoc-mode-line-string mode-line-format)) + (setq mode-line-format + (list "" '(eldoc-mode-line-string + (" " eldoc-mode-line-string " ")) + mode-line-format)))) (setq eldoc-mode-line-string (when (stringp format-string) (apply #'format-message format-string args))) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:33 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:33 +0000 Received: from localhost ([127.0.0.1]:55690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IL-0007c9-3e for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:33 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IH-0007bs-IO for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id D728B160DE; Thu, 16 Jul 2020 16:55:28 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id G6X78IHjWvLJ; Thu, 16 Jul 2020 16:55:28 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id AB63B160AE; Thu, 16 Jul 2020 16:55:28 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 07/14] * lisp/progmodes/compile.el: Remove unnecessary comments. Date: Thu, 16 Jul 2020 16:54:49 +0200 Message-Id: <20200716145456.17531-7-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-6-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) These comments are unnecessary because the doc-strings that follow already cover the same ground, while being more concise. These comments were also prefixed with too many semicolons, causing them to be treated as outline headings. --- lisp/progmodes/compile.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index a76a3c44a3..0b9f417845 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2373,12 +2373,10 @@ compilation-filter (set-marker min nil) (set-marker max nil)))))) -;;; test if a buffer is a compilation buffer, assuming we're in the buffer (defsubst compilation-buffer-internal-p () "Test if inside a compilation buffer." (local-variable-p 'compilation-locs)) -;;; test if a buffer is a compilation buffer, using compilation-buffer-internal-p (defsubst compilation-buffer-p (buffer) "Test if BUFFER is a compilation buffer." (with-current-buffer buffer -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:36 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:36 +0000 Received: from localhost ([127.0.0.1]:55693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IO-0007cP-Aw for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:36 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IM-0007cH-Qe for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:35 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 21A22160BA; Thu, 16 Jul 2020 16:55:34 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id OssSWHuqooCv; Thu, 16 Jul 2020 16:55:34 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id E27BA160AE; Thu, 16 Jul 2020 16:55:33 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 08/14] ; * lisp/whitespace.el: Capitalize "Code" section heading. Date: Thu, 16 Jul 2020 16:54:50 +0200 Message-Id: <20200716145456.17531-8-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-7-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/whitespace.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/whitespace.el b/lisp/whitespace.el index 47434bf3d2..0f5901b0cf 100644 --- a/lisp/whitespace.el +++ b/lisp/whitespace.el @@ -262,7 +262,7 @@ ;; ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -;;; code: +;;; Code: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:41 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:41 +0000 Received: from localhost ([127.0.0.1]:55696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IT-0007cj-Jt for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:41 -0400 Received: from mail.hostpark.net ([212.243.197.30]:59994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IS-0007ca-1f for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:40 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 5ABE1160BA; Thu, 16 Jul 2020 16:55:39 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id mUhHJ2LyHPi4; Thu, 16 Jul 2020 16:55:39 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2E279160AE; Thu, 16 Jul 2020 16:55:39 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 09/14] * lisp/mail/smtpmail.el: Use outline headings. Date: Thu, 16 Jul 2020 16:54:51 +0200 Message-Id: <20200716145456.17531-9-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-8-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/mail/smtpmail.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/mail/smtpmail.el b/lisp/mail/smtpmail.el index f5c9432879..cf08bd742f 100644 --- a/lisp/mail/smtpmail.el +++ b/lisp/mail/smtpmail.el @@ -61,12 +61,12 @@ (autoload 'message-make-message-id "message") (autoload 'rfc2104-hash "rfc2104") -;;; +;;; Options + (defgroup smtpmail nil "SMTP protocol for sending mail." :group 'mail) - (defcustom smtpmail-default-smtp-server nil "Specify default SMTP server. This only has effect if you specify it before loading the smtpmail library." @@ -172,8 +172,7 @@ smtpmail-retries :type 'integer :version "27.1") -;; End of customizable variables. - +;;; Variables (defvar smtpmail-address-buffer) (defvar smtpmail-recipient-address-list) @@ -192,6 +191,8 @@ smtpmail-auth-supported (defvar smtpmail-mail-address nil "Value to use for envelope-from address for mail from ambient buffer.") +;;; Functions + ;;;###autoload (defun smtpmail-send-it () (let ((errbuf (if mail-interactive -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:47 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:47 +0000 Received: from localhost ([127.0.0.1]:55699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IY-0007d1-Sg for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:47 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5IX-0007ct-9b for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 949F5160DE; Thu, 16 Jul 2020 16:55:44 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id aZUtGbIinPAq; Thu, 16 Jul 2020 16:55:44 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 686B6160AE; Thu, 16 Jul 2020 16:55:44 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 10/14] * test/src/emacs-module-tests.el: Use proper outline headings. Date: Thu, 16 Jul 2020 16:54:52 +0200 Message-Id: <20200716145456.17531-10-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-9-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. --- test/src/emacs-module-tests.el | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el index 411b4505da..905a0ae546 100644 --- a/test/src/emacs-module-tests.el +++ b/test/src/emacs-module-tests.el @@ -48,9 +48,7 @@ emacs-module-tests--generic (cl-defmethod emacs-module-tests--generic ((_ user-ptr)) 'user-ptr) -;; -;; Basic tests. -;; +;;; Basic tests. (ert-deftest mod-test-sum-test () (should (= (mod-test-sum 1 2) 3)) @@ -103,9 +101,7 @@ module-function-object ">" eos) (prin1-to-string func))))) -;; -;; Non-local exists (throw, signal). -;; +;;; Non-local exists (throw, signal). (ert-deftest mod-test-non-local-exit-signal-test () (should-error (mod-test-signal)) @@ -142,9 +138,7 @@ mod-test-non-local-exit-funcall-throw (should (equal (mod-test-non-local-exit-funcall (lambda () (throw 'tag 32))) '(throw tag 32)))) -;; -;; String tests. -;; +;;; String tests. (defun multiply-string (s n) "Return N copies of S concatenated together." @@ -165,9 +159,7 @@ mod-test-globref-free-test (ert-deftest mod-test-string-a-to-b-test () (should (string= (mod-test-string-a-to-b "aaa") "bbb"))) -;; -;; User-pointer tests. -;; +;;; User-pointer tests. (ert-deftest mod-test-userptr-fun-test () (let* ((n 42) @@ -181,9 +173,7 @@ mod-test-userptr-fun-test ;; TODO: try to test finalizer -;; -;; Vector tests. -;; +;;; Vector tests. (ert-deftest mod-test-vector-test () (dolist (s '(2 10 100 1000)) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:52 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:52 +0000 Received: from localhost ([127.0.0.1]:55702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Ie-0007dK-2k for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:52 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Ic-0007dC-Hl for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:50 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id D307F160DE; Thu, 16 Jul 2020 16:55:49 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id WVJZ155U72G1; Thu, 16 Jul 2020 16:55:49 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A2468160AE; Thu, 16 Jul 2020 16:55:49 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 11/14] * lisp/obsolete/longlines.el: Use proper outline headings. Date: Thu, 16 Jul 2020 16:54:53 +0200 Message-Id: <20200716145456.17531-11-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-10-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> <20200716145456.17531-10-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. One heading is new. --- lisp/obsolete/longlines.el | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lisp/obsolete/longlines.el b/lisp/obsolete/longlines.el index 2fba49f402..11e167aa18 100644 --- a/lisp/obsolete/longlines.el +++ b/lisp/obsolete/longlines.el @@ -38,6 +38,8 @@ ;;; Code: +;;; Options + (defgroup longlines nil "Automatic wrapping of long lines when loading files." :group 'fill) @@ -76,7 +78,7 @@ longlines-show-effect :group 'longlines :type 'string) -;; Internal variables +;;; Internal variables (defvar longlines-wrap-beg nil) (defvar longlines-wrap-end nil) @@ -90,7 +92,7 @@ longlines-decoded (make-variable-buffer-local 'longlines-showing) (make-variable-buffer-local 'longlines-decoded) -;; Mode +;;; Mode (defvar message-indent-citation-function) @@ -210,7 +212,7 @@ longlines-mode-off major mode changes." (longlines-mode 0)) -;; Showing the effect of hard newlines in the buffer +;;; Showing the effect of hard newlines in the buffer (defun longlines-show-hard-newlines (&optional arg) "Make hard newlines visible by adding a face. @@ -252,7 +254,7 @@ longlines-unshow-hard-newlines (setq pos (text-property-not-all (1+ pos) (point-max) 'hard nil))) (restore-buffer-modified-p mod))) -;; Wrapping the paragraphs. +;;; Wrapping the paragraphs (defun longlines-wrap-region (beg end) "Wrap each successive line, starting with the line before BEG. @@ -402,7 +404,7 @@ longlines-encode-string (setq pos (string-match "\n" str (1+ pos)))) str)) -;; Auto wrap +;;; Auto wrap (defun longlines-auto-wrap (&optional arg) "Toggle automatic line wrapping. @@ -457,7 +459,7 @@ longlines-window-change-function (setq fill-column (- (window-width) dw)) (longlines-wrap-region (point-min) (point-max))))) -;; Isearch +;;; Isearch (defun longlines-search-function () (cond @@ -477,7 +479,7 @@ longlines-re-search-forward (let ((search-spaces-regexp " *[ \n]")) (re-search-forward string bound noerror count))) -;; Loading and saving +;;; Loading and saving (defun longlines-before-revert-hook () (add-hook 'after-revert-hook 'longlines-after-revert-hook nil t) @@ -492,7 +494,7 @@ longlines-after-revert-hook (list 'longlines "Automatically wrap long lines." nil nil 'longlines-encode-region t nil)) -;; Unloading +;;; Unloading (defun longlines-unload-function () "Unload the longlines library." -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:55:57 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:55:57 +0000 Received: from localhost ([127.0.0.1]:55705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Ij-0007dc-BF for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:57 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Ih-0007dU-Pk for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:55:56 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 1ABD6160FB; Thu, 16 Jul 2020 16:55:55 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id c8uMs-l0Umgi; Thu, 16 Jul 2020 16:55:54 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id D9FFE160AE; Thu, 16 Jul 2020 16:55:54 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 12/14] * lisp/net/imap.el: Use proper outline headings Date: Thu, 16 Jul 2020 16:54:54 +0200 Message-Id: <20200716145456.17531-12-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-11-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> <20200716145456.17531-10-jonas@bernoul.li> <20200716145456.17531-11-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. One heading is new. --- lisp/net/imap.el | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/lisp/net/imap.el b/lisp/net/imap.el index a492dc8c79..6e6c2e4aeb 100644 --- a/lisp/net/imap.el +++ b/lisp/net/imap.el @@ -145,7 +145,7 @@ (declare-function digest-md5-digest-uri "ext:digest-md5") (declare-function digest-md5-challenge "ext:digest-md5") -;; User variables. +;;; User variables. (defgroup imap nil "Low-level IMAP issues." @@ -257,7 +257,7 @@ imap-store-password :group 'imap :type 'boolean) -;; Various variables. +;;; Various variables. (defvar imap-fetch-data-hook nil "Hooks called after receiving each FETCH response.") @@ -316,7 +316,9 @@ imap-logout-timeout an application program that uses this module specifies on a per-server basis.") -;; Internal constants. Change these and die. +;;; Internal constants + +;; Change these and die. (defconst imap-default-port 143) (defconst imap-default-ssl-port 993) @@ -348,7 +350,7 @@ imap-local-variables (defconst imap-log-buffer "*imap-log*") (defconst imap-debug-buffer "*imap-debug*") -;; Internal variables. +;;; Internal variables. (defvar imap-stream nil) (defvar imap-auth nil) @@ -437,7 +439,7 @@ imap-enable-exchange-bug-workaround canonical form fails.") -;; Utility functions: +;;; Utility functions (defun imap-remassoc (key alist) "Delete by side effect any elements of ALIST whose car is `equal' to KEY. @@ -489,7 +491,8 @@ imap-error-text (nth 3 (car imap-failed-tags)))) -;; Server functions; stream stuff: +;;; Server functions +;;;; Stream functions (defun imap-log (string-or-buffer) (when imap-log @@ -747,7 +750,7 @@ imap-starttls-open (message "imap: Connecting with STARTTLS...%s" (if done "done" "failed")) done)) -;; Server functions; authenticator stuff: +;;;; Authenticator functions (defun imap-interactive-login (buffer loginfunc) "Login to server in BUFFER. @@ -969,7 +972,7 @@ imap-digest-md5-auth (imap-send-command-1 "") (imap-ok-p (imap-wait-for-tag tag))))))) -;; Server functions: +;;; Server functions (defun imap-open-1 (buffer) (with-current-buffer buffer @@ -1228,7 +1231,7 @@ imap-logout-wait (imap-send-command-wait "LOGOUT" buffer))) -;; Mailbox functions: +;;; Mailbox functions (defun imap-mailbox-put (propname value &optional mailbox buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1520,7 +1523,7 @@ imap-mailbox-acl-delete identifier)))))) -;; Message functions: +;;; Message functions (defun imap-current-message (&optional buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1832,7 +1835,7 @@ imap-envelope-from (if (aref from 0) ">")))) -;; Internal functions. +;;; Internal functions. (defun imap-add-callback (tag func) (setq imap-callbacks (append (list (cons tag func)) imap-callbacks))) @@ -1969,7 +1972,7 @@ imap-arrival-filter (delete-region (point-min) (point-max))))))))) -;; Imap parser. +;;; Imap parser. (defsubst imap-forward () (or (eobp) (forward-char))) @@ -2850,6 +2853,8 @@ imap-parse-body (imap-forward) (nreverse body))))) +;;; Debug + (when imap-debug ; (untrace-all) (require 'trace) (buffer-disable-undo (get-buffer-create imap-debug-buffer)) -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:56:03 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:56:03 +0000 Received: from localhost ([127.0.0.1]:55709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Io-0007e9-Kn for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:56:03 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5In-0007dm-1S for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:56:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 583A3160DE; Thu, 16 Jul 2020 16:56:00 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 5nJT8G9Pxfe8; Thu, 16 Jul 2020 16:56:00 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 25ACB160AE; Thu, 16 Jul 2020 16:56:00 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 13/14] * lisp/font-lock.el: Split the Commentary into subsections. Date: Thu, 16 Jul 2020 16:54:55 +0200 Message-Id: <20200716145456.17531-13-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-12-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> <20200716145456.17531-10-jonas@bernoul.li> <20200716145456.17531-11-jonas@bernoul.li> <20200716145456.17531-12-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The "Commentary" was already split into multiple sections, but these sections where on the same level as "Commentary" itself, which is less convenient for users of `outline-minor-mode'. --- lisp/font-lock.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/font-lock.el b/lisp/font-lock.el index 5cda4a693d..cf88100ab5 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -51,7 +51,7 @@ ;; also the variable `font-lock-maximum-size'. Support modes for Font Lock ;; mode can be used to speed up Font Lock mode. See `font-lock-support-mode'. -;;; How Font Lock mode fontifies: +;;;; How Font Lock mode fontifies: ;; When Font Lock mode is turned on in a buffer, it (a) fontifies the entire ;; buffer and (b) installs one of its fontification functions on one of the @@ -96,7 +96,7 @@ ;; some syntactic parsers for common languages and a son-of-font-lock.el could ;; use them rather then relying so heavily on the keyword (regexp) pass. -;;; How Font Lock mode supports modes or is supported by modes: +;;;; How Font Lock mode supports modes or is supported by modes: ;; Modes that support Font Lock mode do so by defining one or more variables ;; whose values specify the fontification. Font Lock mode knows of these @@ -112,7 +112,7 @@ ;; Font Lock mode fontification behavior can be modified in a number of ways. ;; See the below comments and the comments distributed throughout this file. -;;; Constructing patterns: +;;;; Constructing patterns: ;; See the documentation for the variable `font-lock-keywords'. ;; @@ -120,7 +120,7 @@ ;; `font-lock-syntactic-keywords' can be generated via the function ;; `regexp-opt'. -;;; Adding patterns for modes that already support Font Lock: +;;;; Adding patterns for modes that already support Font Lock: ;; Though Font Lock highlighting patterns already exist for many modes, it's ;; likely there's something that you want fontified that currently isn't, even @@ -135,7 +135,7 @@ ;; other variables. For example, additional C types can be specified via the ;; variable `c-font-lock-extra-types'. -;;; Adding patterns for modes that do not support Font Lock: +;;;; Adding patterns for modes that do not support Font Lock: ;; Not all modes support Font Lock mode. If you (as a user of the mode) add ;; patterns for a new mode, you must define in your ~/.emacs a variable or @@ -155,7 +155,7 @@ ;; (set (make-local-variable 'font-lock-defaults) ;; '(foo-font-lock-keywords t)))) -;;; Adding Font Lock support for modes: +;;;; Adding Font Lock support for modes: ;; Of course, it would be better that the mode already supports Font Lock mode. ;; The package author would do something similar to above. The mode must -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 10:56:08 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 14:56:08 +0000 Received: from localhost ([127.0.0.1]:55724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Iu-0007fy-21 for submit@debbugs.gnu.org; Thu, 16 Jul 2020 10:56:08 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Is-0007f7-8c for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 10:56:06 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 8E4E5160DE; Thu, 16 Jul 2020 16:56:05 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id AlNq4O_G5h5r; Thu, 16 Jul 2020 16:56:05 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 5C617160AE; Thu, 16 Jul 2020 16:56:05 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH 14/14] * lisp/font-lock.el: No longer mark each end of a section explicitly. Date: Thu, 16 Jul 2020 16:54:56 +0200 Message-Id: <20200716145456.17531-14-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716145456.17531-13-jonas@bernoul.li> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> <20200716145456.17531-10-jonas@bernoul.li> <20200716145456.17531-11-jonas@bernoul.li> <20200716145456.17531-12-jonas@bernoul.li> <20200716145456.17531-13-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Each section ends right before the following section begins. It is therefore unnecessary to mark the end of sections. The end of section headings made the result of invoking `outline-hide-sublevels' much less readable than what we get after this change. --- lisp/font-lock.el | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lisp/font-lock.el b/lisp/font-lock.el index cf88100ab5..2d2a7e0f7b 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -986,7 +986,6 @@ font-lock-after-unfontify-buffer ((bound-and-true-p lazy-lock-mode) (lazy-lock-after-unfontify-buffer)))) -;;; End of Font Lock Support mode. ;;; Fontification functions. @@ -1393,7 +1392,6 @@ font-lock-fontify-block (font-lock-fontify-region (point) (mark))) ((error quit) (message "Fontifying block...%s" error-data))))))) -;;; End of Fontification functions. ;;; Additional text property functions. @@ -1485,7 +1483,6 @@ font-lock--remove-face-from-text-property (put-text-property start next prop new object)))))) (setq start (text-property-not-all next end prop nil object))))) -;;; End of Additional text property functions. ;;; Syntactic regexp fontification functions. @@ -1591,7 +1588,6 @@ font-lock-fontify-syntactic-keywords-region (setq highlights (cdr highlights)))) (setq keywords (cdr keywords))))) -;;; End of Syntactic regexp fontification functions. ;;; Syntactic fontification functions. @@ -1650,7 +1646,6 @@ font-lock-fontify-syntactically-region (setq state (parse-partial-sexp (point) end nil nil state 'syntax-table)))))) -;;; End of Syntactic fontification functions. ;;; Keyword regexp fontification functions. @@ -1784,9 +1779,8 @@ font-lock-fontify-keywords-region (setq keywords (cdr keywords))) (set-marker pos nil))) -;;; End of Keyword regexp fontification functions. -;; Various functions. +;;; Various functions. (defun font-lock-compile-keywords (keywords &optional syntactic-keywords) "Compile KEYWORDS into the form (t KEYWORDS COMPILED...) @@ -2102,7 +2096,6 @@ font-lock-regexp-grouping-construct "Font Lock mode face used to highlight grouping constructs in Lisp regexps." :group 'font-lock-faces) -;;; End of Color etc. support. ;;; Menu support. @@ -2204,7 +2197,6 @@ font-lock-regexp-grouping-construct ;; ;; Deactivate less/more fontification entries. ;; (setq font-lock-fontify-level nil)) -;;; End of Menu support. ;;; Various regexp information shared by several modes. ;; ;; Information specific to a single mode should go in its load library. -- 2.26.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:10:02 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:10:02 +0000 Received: from localhost ([127.0.0.1]:55740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5WL-00080v-OX for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:10:01 -0400 Received: from mail.hostpark.net ([212.243.197.30]:37366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5WJ-00080c-Hx for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:10:00 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C59CC16A7F; Thu, 16 Jul 2020 17:09:57 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 9fS8AoIqZg_6; Thu, 16 Jul 2020 17:09:57 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 906E316A7E; Thu, 16 Jul 2020 17:09:57 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: This message is a test Date: Thu, 16 Jul 2020 17:09:57 +0200 Message-Id: <20200716150957.18363-1-jonas@bernoul.li> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200716144707.16857-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) [Ignore this particular message (only). I am testing something.] From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:12:40 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:12:40 +0000 Received: from localhost ([127.0.0.1]:55745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Yu-00084z-6B for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:12:40 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:41606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5Yr-00084m-42 for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:12:38 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06GFBvOp017079; Thu, 16 Jul 2020 15:12:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=pNY4QJYv9yFHBOtVZ5NHUdM4Rdv6YFNc75nt7TTZoqI=; b=I4qLFbnlfVwVfJ/2xtBkdd7pgnsRlI/8W97acu2SaZfgMzItbC4ATywsSkLpyQ04qqGA /uoVIcWAHCP5bajUPq2TnbvCU0RqqPxhvVjXG6G71Ady2VjC+Jfj2Ocx344A3TAda7lw g/MTqU7V/fG4s0An/9ShtEQdQqsT0eTOwCp0xqjqmgtqcDiZ4lK86S6geBMnmh4KV9pv OZb9UUhcrWNaimy1nDr+30EQvi0Z+Atmj8ERMKoKE+S54/1L7fV2uNbFiEb3yfCVO6vx 0LpeNrCjycKt1GJT+/RFvhrhJMtXnwLu63tE4zqjcdCY5b70xmQFK5fobVn1nVLNOEFk Gw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 327s65ramn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Jul 2020 15:12:28 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06GEqkr7073071; Thu, 16 Jul 2020 15:12:27 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 327qc3khjf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Jul 2020 15:12:27 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06GFCO2J010612; Thu, 16 Jul 2020 15:12:25 GMT MIME-Version: 1.0 Message-ID: <4c040cd2-8df0-4761-822f-8cd318ee629e@default> Date: Thu, 16 Jul 2020 08:12:24 -0700 (PDT) From: Drew Adams To: Jonas Bernoulli , 42397@debbugs.gnu.org Subject: RE: bug#42397: [PATCH 00/14] Use outline headings and some cosmetics References: <20200716144707.16857-1-jonas@bernoul.li> In-Reply-To: <20200716144707.16857-1-jonas@bernoul.li> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxlogscore=964 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007160114 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 phishscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1011 bulkscore=0 mlxlogscore=969 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007160115 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I thought we had a pretty standard header format. I've been respecting that for decades in my own libraries. Now it's changed? My understanding has been: 3 ; for the first header line. 3 ; for a ;;; Commentary: line. 3 ; for a ;;; Change Log: line. (Used to be Chang log.) 3 ; for a ;;; Code: line. More than 3 ; for any "separator" line. 2 ; for all other header lines. ____ And 3 ; for the file footer. E.g.: ;;; foo-lib.el ends here ____ And within the code, whatever you want, per convention (3 for major, 2 for minor, 1 at eol). ____ Further, I thought the convention called for 2 SPC after the initial 3 ; or 2 ;, except for 4 SPC before the first Commentary text, i.e., the file description. E.g.: ;;; Commentary: ;; ;; Here is a one-line library description. ;; ;; Here are any commentary details that might ;; be present - anything at all. ____ Dunno whether such a convention is still stated somewhere, but I'm pretty sure it was in place in the past. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:21:40 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:21:40 +0000 Received: from localhost ([127.0.0.1]:55758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5hb-0008It-Ot for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:21:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5hZ-0008If-VY for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:21:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49818) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5hT-0001pk-Qa; Thu, 16 Jul 2020 11:21:31 -0400 Received: from [176.228.60.248] (port=2355 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw5hT-0003iL-B6; Thu, 16 Jul 2020 11:21:31 -0400 Date: Thu, 16 Jul 2020 18:21:18 +0300 Message-Id: <83ft9rlc41.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <20200716145456.17531-3-jonas@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 16:54:45 +0200) Subject: Re: bug#42397: [PATCH 03/14] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Date: Thu, 16 Jul 2020 16:54:45 +0200 > Cc: jonas@bernoul.li > > --- > lisp/epg.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/epg.el b/lisp/epg.el > index c10eb4f06c..2e092acc6a 100644 > --- a/lisp/epg.el > +++ b/lisp/epg.el > @@ -123,7 +123,7 @@ epg-import-problem-reason-alist > > (defconst epg-no-data-reason-alist > '((1 . "No armored data") > - (2 . "Expected a packet but did not found one") > + (2 . "Expected a packet but did not find one") > (3 . "Invalid packet found, this may indicate a non OpenPGP message") > (4 . "Signature expected but not found"))) Thanks. There's no need to post typo corrections for review, you can simply go ahead and push. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:24:45 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:24:45 +0000 Received: from localhost ([127.0.0.1]:55762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5kb-0008NH-7l for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:24:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5kX-0008N1-9W for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:24:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49873) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5kR-0002W3-K0; Thu, 16 Jul 2020 11:24:35 -0400 Received: from [176.228.60.248] (port=2540 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw5kQ-0003we-Ik; Thu, 16 Jul 2020 11:24:35 -0400 Date: Thu, 16 Jul 2020 18:24:20 +0300 Message-Id: <83eepblbyz.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <20200716145456.17531-14-jonas@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 16:54:56 +0200) Subject: Re: bug#42397: [PATCH 14/14] * lisp/font-lock.el: No longer mark each end of a section explicitly. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <20200716145456.17531-7-jonas@bernoul.li> <20200716145456.17531-8-jonas@bernoul.li> <20200716145456.17531-9-jonas@bernoul.li> <20200716145456.17531-10-jonas@bernoul.li> <20200716145456.17531-11-jonas@bernoul.li> <20200716145456.17531-12-jonas@bernoul.li> <20200716145456.17531-13-jonas@bernoul.li> <20200716145456.17531-14-jonas@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 16 Jul 2020 16:54:56 +0200 > Cc: jonas@bernoul.li > > Each section ends right before the following section begins. It is > therefore unnecessary to mark the end of sections. The end of section > headings made the result of invoking `outline-hide-sublevels' much > less readable than what we get after this change. It might sometimes be useful if a section is very long, and the file isn't placed under Outline. If we are going to remove these as a matter of policy, I think we should first discuss that on emacs-devel, to see if there are people who might want those "end" markers. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:27:45 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:27:45 +0000 Received: from localhost ([127.0.0.1]:55772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5nV-0008SM-12 for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:27:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5nT-0008SA-Fc for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:27:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49927) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5nO-0003M6-4w; Thu, 16 Jul 2020 11:27:38 -0400 Received: from [176.228.60.248] (port=2712 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw5nB-00051A-Kw; Thu, 16 Jul 2020 11:27:31 -0400 Date: Thu, 16 Jul 2020 18:27:11 +0300 Message-Id: <83d04vlbu8.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <20200716145456.17531-6-jonas@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 16:54:48 +0200) Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li, 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Date: Thu, 16 Jul 2020 16:54:48 +0200 > Cc: jonas@bernoul.li > > --- > lisp/emacs-lisp/eldoc.el | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) When you fix indentation, make sure to use our .dir-locals.el settings, to produce canonical whitespace. In this case, we use only spaces in Lisp files, not TABs and spaces. Thanks. P.S. Why do you CC yourself on every message? It causes the Reply to name you twice, so you will get 2 copies of them. Is this what you want? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 11:31:08 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 15:31:08 +0000 Received: from localhost ([127.0.0.1]:55777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5qm-00007X-IQ for submit@debbugs.gnu.org; Thu, 16 Jul 2020 11:31:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw5qk-00007K-Ps for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 11:31:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49982) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw5qe-0004Mw-0C; Thu, 16 Jul 2020 11:31:00 -0400 Received: from [176.228.60.248] (port=2931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw5qa-0007f0-TB; Thu, 16 Jul 2020 11:30:58 -0400 Date: Thu, 16 Jul 2020 18:30:43 +0300 Message-Id: <83blkflboc.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: <4c040cd2-8df0-4761-822f-8cd318ee629e@default> (message from Drew Adams on Thu, 16 Jul 2020 08:12:24 -0700 (PDT)) Subject: Re: bug#42397: [PATCH 00/14] Use outline headings and some cosmetics References: <20200716144707.16857-1-jonas@bernoul.li> <4c040cd2-8df0-4761-822f-8cd318ee629e@default> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: jonas@bernoul.li, 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 16 Jul 2020 08:12:24 -0700 (PDT) > From: Drew Adams > > I thought we had a pretty standard header format. > I've been respecting that for decades in my own > libraries. Now it's changed? You have a point there. Jonas, please compare what you propose with the tips we have in the "Comment Tips" node of the ELisp manual, and seed if there's any discrepancies. If there are, I think we should discuss first (on emacs-devel). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 12:56:27 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 16:56:28 +0000 Received: from localhost ([127.0.0.1]:55860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7BL-0002Be-Kw for submit@debbugs.gnu.org; Thu, 16 Jul 2020 12:56:27 -0400 Received: from mail.hostpark.net ([212.243.197.30]:44992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7BG-0002BP-Hx for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 12:56:25 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 0E585165C3; Thu, 16 Jul 2020 18:56:21 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id KAltXTCvGOCJ; Thu, 16 Jul 2020 18:56:20 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id CE554165C9; Thu, 16 Jul 2020 18:56:20 +0200 (CEST) From: Jonas Bernoulli To: Eli Zaretskii Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: <83d04vlbu8.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> Date: Thu, 16 Jul 2020 18:56:20 +0200 Message-ID: <87mu3zpfez.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Jonas Bernoulli >> Date: Thu, 16 Jul 2020 16:54:48 +0200 >> Cc: jonas@bernoul.li >> >> --- >> lisp/emacs-lisp/eldoc.el | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > When you fix indentation, make sure to use our .dir-locals.el > settings, to produce canonical whitespace. In this case, we use only > spaces in Lisp files, not TABs and spaces. Gladly! In fact while I was just taking a bath, I was drafting a message in my head explaining why such a file should be added! The reason that I was not aware that the local value is explicitly set now, is (aside from simply not having checked) that the indentation in Emacs is so inconsistent that I did occur to me that it might be set after all. I did just dig a bit and found bug#20323. So it turns out we did eventually set the variable, but we did not adjust existing code to conform to that setting. I do care a lot about consistency so I did in fact look at the surrounding code to determine what style to use. It was not an easy decision in this case because both styles are being within this one function! I went with tabs because more existing lines did that. ;D I'll change that before pushing obviously. And since this commit is already about *fixing* whitespace, I will also *adjust* the remaining lines to use the preferred style. It might be time to revisit the decision to not fix indentation in bulk. Since version Git 2.23 "git blame" can ignore the effect and presence of certain commits. We could make the whitespace change in one huge commit and then ignore that commit using the Git variable "blame.ignoreRevsFile". > P.S. Why do you CC yourself on every message? It causes the Reply to > name you twice, so you will get 2 copies of them. Is this what you > want? Hmmm. Because that's not the behavior I experience. Without that explicit CC I get the message zero times (git send-email does not put them into the local maildir and debbugs does not appear to be echoing my own messages back to me). With that CC I get the messages exactly once. Maybe you experience something else because debbugs sends *all* message to you, not just your own? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 12:57:25 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 16:57:25 +0000 Received: from localhost ([127.0.0.1]:55864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7CH-0002DC-05 for submit@debbugs.gnu.org; Thu, 16 Jul 2020 12:57:25 -0400 Received: from mail.hostpark.net ([212.243.197.30]:45028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7C0-0002Cp-1k for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 12:57:23 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 59F4A165C9; Thu, 16 Jul 2020 18:57:07 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id rWd5a7e3IUaN; Thu, 16 Jul 2020 18:57:07 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2E944165C3; Thu, 16 Jul 2020 18:57:07 +0200 (CEST) From: Jonas Bernoulli To: Eli Zaretskii Subject: Re: bug#42397: [PATCH 03/14] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. In-Reply-To: <83ft9rlc41.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <83ft9rlc41.fsf@gnu.org> Date: Thu, 16 Jul 2020 18:57:07 +0200 Message-ID: <87k0z3pfdo.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > There's no need to post typo corrections for review, you can simply go > ahead and push. Okay, will do. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 13:17:37 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:17:37 +0000 Received: from localhost ([127.0.0.1]:55881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7Vo-0002hG-Q3 for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:17:36 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:54162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7Vj-0002gy-CT for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:17:34 -0400 Received: by mail-wm1-f41.google.com with SMTP id j18so10987223wmi.3 for <42397@debbugs.gnu.org>; Thu, 16 Jul 2020 10:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=9WTtp8BkVvzYf2kL7Zu/ZIi4eiZ/4FtRGBlhEFCsUJk=; b=mXPcbujPIZsr/Mluoic66W2S9UMsPm4Gqnqa+ZuueeAHk8btyYQ7lPAZX/iTD2Is35 5eDrCD/0vM8MAXRea77gfPmXTYnO6swrvg8XtWNy3zdE4ggLvVIgbVy7GgIcGIcqOeAz EO8peb2lRd8LRWZLkfU6IBAn4SbTu9g05/xdUYG1CgasgZDpoPIQWZ3oIpBkVBG84zRn v6s03ExDVAHZM4s73bDE8pHhkKNUf9OV//zAyZMql1JfQg2a61ESTA4LW2eEac1L/gLC PDoaNWsbvtG9hRBTH+jycKSblYjTHzmcZcv637xYoC8FVvUbSzsKxnqW9uLxxJdAZPg9 6F1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=9WTtp8BkVvzYf2kL7Zu/ZIi4eiZ/4FtRGBlhEFCsUJk=; b=EUgUXQL9Ko3EMHzRKnEZDylz05f4j4OzW1pbnioUiI5xY65G1/H1nlQR8vgLSKr8jJ mvoBMVZd5GXOn25pnM5jLYOjhRiuc05Mqr9iG/lH0NNUmjmqBa42zY4YEe3YD52ud1um Y1AsNOIiY0IoA1TrPwo4G48XPxWwnFCppiLq/JcxEm8/Q6nBJrjyM6ej2wGqaP5oYU0F NlHcyWBrSxDuBg5OOm1MR3l0OtHx605hCW5Ntn9z7cqoeAOFtEqy+G+IQeo0JW+qA5BS v1ghAVMyT7iEnCy8I+UgZJ1VuqekSEsUhDVh4Gd8OOtnAGJqWCRE98HEvwaMXAZlnZQU X5Bg== X-Gm-Message-State: AOAM532kP4Lbq3s+cVIiyNPop51SnzeJE/iI0GG6lta1I/y3lc6ve2Xp onexhG/R/CHY2XOo9ZG2ExJZoNRZIdA= X-Google-Smtp-Source: ABdhPJzLXN3alje/hHnXBrYuTNxa2J1zFVqTvIlwmGoboqxvMrRaAT6Fqw3DTKoqDmyiVzlrYhWbtg== X-Received: by 2002:a05:600c:282:: with SMTP id 2mr5619126wmk.168.1594919844843; Thu, 16 Jul 2020 10:17:24 -0700 (PDT) Received: from rpluim-mac (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id b10sm8877049wmj.30.2020.07.16.10.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 10:17:24 -0700 (PDT) From: Robert Pluim To: Jonas Bernoulli Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> Date: Thu, 16 Jul 2020 19:17:22 +0200 In-Reply-To: <87mu3zpfez.fsf@bernoul.li> (Jonas Bernoulli's message of "Thu, 16 Jul 2020 18:56:20 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: Eli Zaretskii , 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 16 Jul 2020 18:56:20 +0200, Jonas Bernoulli said: >> P.S. Why do you CC yourself on every message? It causes the Reply to >> name you twice, so you will get 2 copies of them. Is this what you >> want? Jonas> Hmmm. Because that's not the behavior I experience. Without th= at Jonas> explicit CC I get the message zero times (git send-email does no= t put Jonas> them into the local maildir and debbugs does not appear to be ec= hoing my Jonas> own messages back to me). With that CC I get the messages exact= ly once. Jonas> Maybe you experience something else because debbugs sends *all* = message Jonas> to you, not just your own? On a related note: would you consider using '--no-chain-reply-to' [1]? Your patch series march off the right edge of my screen :-) Robert Footnotes: [1] I think that=CA=BCs the right one; the git documentation of that option makes my head hurt. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 13:22:23 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:22:23 +0000 Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7aR-0002oX-Ca for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:22:23 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:38839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7aP-0002oI-JE for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:22:22 -0400 Received: by mail-wm1-f43.google.com with SMTP id f18so12320026wml.3 for <42397@debbugs.gnu.org>; Thu, 16 Jul 2020 10:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=2wDvI6X3RVfEc9Yu5fOLxc3r+iH8K59p9rV104M1H1k=; b=JA1QJ0vOBu0q6YLTUHozwiLfjr+X7JeO8okIJW5+6e+cYUEXG495TjrJURefSUlhzs /n02MHP2nw62+ZHOxKwe8qRemO9GtmuwYoT0skaljdVwTtw+L/aToTou+Dt64Gpz1+7Q K+IqKjndwYltgEo93toQ36kmKDl2BDZfSmqaECzif96s9wlOkEXwezqCHFnt4F1t42Vp ASq+EctJhto2mrRMhtdimmXR1C+VdIeHrBNYSVPtCbYMOwfWnlBQZNMuuU+rgn7lfka+ 3JWOdTzWAWW/rmO9mWtx6WHUd9EfvjO1RTxKSFaRkxqHHcBnnrxJq1MBeOmqy0DUNvih waeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=2wDvI6X3RVfEc9Yu5fOLxc3r+iH8K59p9rV104M1H1k=; b=XNUA3eO3nqMUgyxvjwUbHu9VqjWDG1nOPLXPJWwTqaRd+B0dbVe9m9zPqShhqBK0sB U+ZIK6Gby6fYLFHvkOKou9j9IPpGsFpt+2HNnZ+T4lEOSkmfxFItwLISppZ+qo8Xx1e0 vIX24W/3xf0V0oSENrhPpIkc72CMbpifdM2qmAcVP9O8CuePZpu7j4o7/HTEHKsvNnJK RFmxfHLfNydQBlqwfAxekVmM7qCKLyGPS3NCSiEPWhDP5e9vE1nFihwjNAxahVeEVMl2 PHXssIL+I2ZpAyBlF/Gb37QYfLeOgHPh6Q3UpRsUHdLfgX4PdDy4RwtHZSeg97INvC18 MW+g== X-Gm-Message-State: AOAM533v+sw4k9PpdNPOVBVH2esBp3V8GZQn0TIWz8dpSdo/2hcvPbvG LYwD62EdNbjHbycMQydZRG4FroppcHhXTQ== X-Google-Smtp-Source: ABdhPJzTi3mZ6rwZT23jRHjRlhcTTY8jOwfQgwnA51FQEaTLJ6D7Zq4328uYXtyBNj4OknuQWAuF4g== X-Received: by 2002:a1c:ed01:: with SMTP id l1mr5352444wmh.33.1594920135121; Thu, 16 Jul 2020 10:22:15 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:6c9b:b312:5489:40ad]) by smtp.gmail.com with ESMTPSA id j4sm10539543wrp.51.2020.07.16.10.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 10:22:14 -0700 (PDT) From: Robert Pluim To: Jonas Bernoulli Subject: Re: bug#42397: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. References: <20200716144707.16857-1-jonas@bernoul.li> <20200716145456.17531-1-jonas@bernoul.li> Date: Thu, 16 Jul 2020 19:22:13 +0200 In-Reply-To: <20200716145456.17531-1-jonas@bernoul.li> (Jonas Bernoulli's message of "Thu, 16 Jul 2020 16:54:43 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 16 Jul 2020 16:54:43 +0200, Jonas Bernoulli said: Jonas> In this case we can greatly increase readability by using `cl-case' Jonas> instead of `cond'. Jonas> --- Jonas> lisp/epg.el | 19 +++++++------------ Jonas> 1 file changed, 7 insertions(+), 12 deletions(-) Jonas> diff --git a/lisp/epg.el b/lisp/epg.el Jonas> index 222fd913e1..e97db65b60 100644 Jonas> --- a/lisp/epg.el Jonas> +++ b/lisp/epg.el Jonas> @@ -404,18 +404,13 @@ epg-signature-to-string Jonas> (pubkey-algorithm (epg-signature-pubkey-algorithm signature)) Jonas> (key-id (epg-signature-key-id signature))) Jonas> (concat Jonas> - (cond ((eq (epg-signature-status signature) 'good) Jonas> - "Good signature from ") Jonas> - ((eq (epg-signature-status signature) 'bad) Jonas> - "Bad signature from ") Jonas> - ((eq (epg-signature-status signature) 'expired) Jonas> - "Expired signature from ") Jonas> - ((eq (epg-signature-status signature) 'expired-key) Jonas> - "Signature made by expired key ") Jonas> - ((eq (epg-signature-status signature) 'revoked-key) Jonas> - "Signature made by revoked key ") Jonas> - ((eq (epg-signature-status signature) 'no-pubkey) Jonas> - "No public key for ")) Jonas> + (cl-case signature Jonas> + (good "Good signature from ") Jonas> + (bad "Bad signature from ") Jonas> + (expired "Expired signature from ") Jonas> + (expired-key "Signature made by expired key ") Jonas> + (revoked-key "Signature made by revoked key ") Jonas> + (no-pubkey "No public key for ")) Did you drop the `epg-signature-status' accessor on purpose here? Robert From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 13:25:00 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:25:00 +0000 Received: from localhost ([127.0.0.1]:55889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7cx-0002sN-Vl for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:25:00 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:34884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw7cv-0002s8-Er for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:24:58 -0400 Received: by mail-wr1-f53.google.com with SMTP id z2so7938660wrp.2 for <42397@debbugs.gnu.org>; Thu, 16 Jul 2020 10:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=U3YKkToO9JgERyvetj5pTm6EtKHpD7WJcgDk8s+X9ko=; b=tdRRXHibC4kjZLAlHW0iTlH/d4zuYkvIcSCSyFtNyALDuyHEJLvdF2NXNzO794CsAS VNua/Xag23RqAJ7NS0fvq2lf+Sx5on+iwVMeZ8Rf7BKPn1f8Pu4diHz0WbwVEW53GPnl X9lVUNkzeBgNVwK1D47UkPgkGsJV3q2AWIN2o82wDLNLhtnBd1u7rYAqNFNcYl3uOtys sitaFzJA+fB0Vfzpz9yEgHORrl/Ju0MDCVIVks3EL0UpxNbZRb2bDoHhW3QmfqYupQDC audPN2y9dvV/0dNE6bKYCaCGd7UhxICFmIE3S3afPI7pdfPpoMwpgk6t12fPuu3aXwOe kVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=U3YKkToO9JgERyvetj5pTm6EtKHpD7WJcgDk8s+X9ko=; b=MD+TGSuyxKUP2RR8IQgb3cYZjoPQ6WFe54THMgp3U1OmsPnXYzvgJtpGpErj8lqCHq yIn/Zlx843cM5vwrmU6u/1b74Nl97kX9Wmky+Jku6CBbKwBBdlVjJ7KzdwfoKMPzZyYb tvK1GFgDG4YUfNG2y9ysQRsaZN2zQ7uRylE6pX+gff0IpFyiN/6YvrvRD1L83qjizhMX +EIw6Ifzetlu6pflnHZHM25VFxz3EBWEEddiYkuUrlFp8/wACxyjwsFTyeRnHLvXXDCa zqI8zrFud/xRLKPXiSkFF5tvjia3YtAL8H8pOPxAUNfhupje5HOFMsx/LmRfR88eXUxs Ot5w== X-Gm-Message-State: AOAM5302gQMsMmv3Xa5E0R+LWpVY7tIW+jh+V+O+xE5t0R2Hbq9PkFP+ MDDKhlSTcRzv0TO9TtFtYfh7NACHp+Y= X-Google-Smtp-Source: ABdhPJwbNO386BY1rBLvnmpMpJT/XnoqhfZBgMlO7jr7N3QHL/H7/kkk/ozv0Zrp27Ah2sD0RDP36g== X-Received: by 2002:a5d:664e:: with SMTP id f14mr6067684wrw.6.1594920290996; Thu, 16 Jul 2020 10:24:50 -0700 (PDT) Received: from rpluim-mac (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id k11sm11060007wrd.23.2020.07.16.10.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 10:24:50 -0700 (PDT) From: Robert Pluim To: Jonas Bernoulli Subject: Re: bug#42397: [PATCH 02/14] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> Date: Thu, 16 Jul 2020 19:24:48 +0200 In-Reply-To: <20200716145456.17531-2-jonas@bernoul.li> (Jonas Bernoulli's message of "Thu, 16 Jul 2020 16:54:44 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 16 Jul 2020 16:54:44 +0200, Jonas Bernoulli said: Jonas> `concat' treats arguments that are nil as if they were empty str= ings. Jonas> We therefore do not have to write (if TEST THEN "") and can just= use Jonas> (and TEST THEN). Or (if TEST THEN), but I guess that=CA=BCs just a matter of preferred style. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 13:54:54 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:54:54 +0000 Received: from localhost ([127.0.0.1]:55904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw85t-0003aX-Ca for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:54:54 -0400 Received: from mail.hostpark.net ([212.243.197.30]:47538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw85o-0003aM-PX for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:54:52 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id CA07E165C9; Thu, 16 Jul 2020 19:54:46 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id pWlQFdIP7MDQ; Thu, 16 Jul 2020 19:54:46 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8F2F1165C3; Thu, 16 Jul 2020 19:54:46 +0200 (CEST) From: Jonas Bernoulli To: Robert Pluim Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> Date: Thu, 16 Jul 2020 19:54:46 +0200 Message-ID: <87ft9rpcpl.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: Eli Zaretskii , 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: > On a related note: would you consider using '--no-chain-reply-to' [1]? > Your patch series march off the right edge of my screen :-) And again, that was intentional. I actually used "--chain-reply-to" explicitly because when I didn't then mails were displayed in the wrong order in the web interface. Though thinking about that again, I now think that wasn't actually the reason. Maybe. The next patch series I am going to send without that argument. Since I don't have my own private debbugs instance, I have to do these experiments in public. On the plus side, once I have arrived at a suitable incarnation will blog about it and/or teach Magit about it. For this series I used: ,---- | git send-email 0000-cover-letter.patch \ | --to=3Dbug-gnu-emacs@gnu.org \ | --suppress-cc=3Dall --cc=3Djonas@bernoul.li && | rm 0000-cover-letter.patch |=20 | BUG_ID=3D42397 # Check inbox to determine that value |=20 | git send-email 00* \ | --to=3D$BUG_ID@debbugs.gnu.org \ | --suppress-cc=3Dall --cc=3Djonas@bernoul.li \ | --thread \ | --chain-reply-to \ # make sure order is correct | --batch-size=3D1 --relogin-delay=3D5 # make sure some other way `---- Unfortunately I did not use: ,---- | # Check inbox to determine this value as well: | FIRST_MSG_ID=3D"<20200716144707.16857-1-jonas@bernoul.li>" |=20 | git ... --in-reply-to=3D$FIRST_MSG_ID `---- I used the "This message is a test" mail to try whether using that argument helps. It does. > Robert > > Footnotes: > [1] I think that=CA=BCs the right one; the git documentation of that > option makes my head hurt. It's a bit weird. So far I am not a fan of debbugs and its documentation either. ;D Anyway... I am afraid I'll have to keep experimenting publicly for a while, but please feel free to point out any observations; they might speed up things. Jonas From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 13:57:28 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 17:57:28 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw88O-0003eQ-0N for submit@debbugs.gnu.org; Thu, 16 Jul 2020 13:57:28 -0400 Received: from mail.hostpark.net ([212.243.197.30]:47608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw88L-0003eH-Q9 for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 13:57:26 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 4E18B165C9; Thu, 16 Jul 2020 19:57:24 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id kXEqC7ZhmN-M; Thu, 16 Jul 2020 19:57:24 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 18F7E165C3; Thu, 16 Jul 2020 19:57:24 +0200 (CEST) From: Jonas Bernoulli To: Robert Pluim Subject: Re: bug#42397: [PATCH 01/14] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. In-Reply-To: References: <20200716144707.16857-1-jonas@bernoul.li> <20200716145456.17531-1-jonas@bernoul.li> Date: Thu, 16 Jul 2020 19:57:23 +0200 Message-ID: <87d04vpcl8.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Did you drop the `epg-signature-status' accessor on purpose here? Eeeep! No. Thanks for review! From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 14:03:39 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 18:03:39 +0000 Received: from localhost ([127.0.0.1]:55935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8EN-0003pB-3o for submit@debbugs.gnu.org; Thu, 16 Jul 2020 14:03:39 -0400 Received: from mail.hostpark.net ([212.243.197.30]:47824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8EK-0003p2-U0 for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 14:03:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 13585165C9; Thu, 16 Jul 2020 20:03:35 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id JaQWoLWwlQKU; Thu, 16 Jul 2020 20:03:33 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id D62EA165C3; Thu, 16 Jul 2020 20:03:33 +0200 (CEST) From: Jonas Bernoulli To: Robert Pluim Subject: Re: bug#42397: [PATCH 02/14] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. In-Reply-To: References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> Date: Thu, 16 Jul 2020 20:03:33 +0200 Message-ID: <87a6zzpcay.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: >>>>>> On Thu, 16 Jul 2020 16:54:44 +0200, Jonas Bernoulli said: > > Jonas> `concat' treats arguments that are nil as if they were empty s= trings. > Jonas> We therefore do not have to write (if TEST THEN "") and can ju= st use > Jonas> (and TEST THEN). > > Or (if TEST THEN), but I guess that=CA=BCs just a matter of preferred sty= le. Indeed. I am aware that at least some of Emacs' developers prefer to use `if' always, but I always use "when" when there is no else and "and" (instead of "when") when the returned value is used. I can live with other people doing it differently, but I don't like it. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 14:23:25 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 18:23:25 +0000 Received: from localhost ([127.0.0.1]:55990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8XU-0004K1-Ty for submit@debbugs.gnu.org; Thu, 16 Jul 2020 14:23:25 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8XT-0004Jo-Ig for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 14:23:24 -0400 Received: by mail-ot1-f67.google.com with SMTP id 95so4970499otw.10 for <42397@debbugs.gnu.org>; Thu, 16 Jul 2020 11:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6yTKXbv2Gj+3Z2nz3eco5c2ybvQY39ZBXtFRvNl1kN8=; b=Knd3nq+LDJr4N0eiJI2LsEh6DxWqMmewOV3q4rlnj5Q/3eLFNbWdZHHK4z7dWy4Q/o /gvqrKSoHBJTHDSCVYKSv5xAWSUDJX4CGsuPHQzJctH1TSRYViaw9++9bHp02E8qfAGw kCb3yvZLxWVF48xbCu/O6/pVtyuUjJtANuwn1WW8slN0P35GZjcJkwHoOkaHUkUEdOQd UIPzlypoerslHsMVhN9MTFlm9uLbaVH9fYNvQIixVld1Ap3Ek2/2G1E1WMpMLR56vf8D IIcVlgA+khwFkmNaV8TTy9Uc5tv9m71Ivei6OuVtaa+Mo9h9GMwqnpj/s6SpZV2r6j+/ EUOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6yTKXbv2Gj+3Z2nz3eco5c2ybvQY39ZBXtFRvNl1kN8=; b=BBQ7+h+Mb2Z2JB2Yx6FS73HGK935v6McbRjB6j+GqtNHjfjskgBGb36hJ0qYNDY5dp 04tM+wmw0XakPASSFMNC0Hnke8JjM6fTMgHpl5Is6hxypQ/Gg5WNYPrW3mzuRwwnj8Kw WHG0fsIWEQqsc/FVyHeumjQrvFEKxCAaLCe/JXBVG0mhgWQT4P1OVpJitkCQcpoZv2Hk oI5AFnUNnlqgBN60sg/fbPIF4KkRR0F1vjRgcnyDPX1rLi1X2YTsJyXUWs5G7hFsicGn GeQx0szGoRj3V2ALM55tRCx9DL5lDzL3z8N377Bfi1oIY5m4Go4fVNCvlVJHzzMHza6S LFEg== X-Gm-Message-State: AOAM532oF/nUcVQKJHSzyqQrLckbrP2/Dd0Y1mlMuaqbvCaHhcqT6+U6 qtsxXofc1XDGHCj4y3QEkq/jRvV34UJ5stLn+4k= X-Google-Smtp-Source: ABdhPJzv2jG/MUn+bCXOF8jsPb59P4AAh6lR0+/fCvITx+czkng4njfa2aOBkJG62PNg/K1yvpxPE7KZtf207n651S8= X-Received: by 2002:a05:6830:1d43:: with SMTP id p3mr5897140oth.369.1594923797912; Thu, 16 Jul 2020 11:23:17 -0700 (PDT) MIME-Version: 1.0 References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <87ft9rpcpl.fsf@bernoul.li> In-Reply-To: <87ft9rpcpl.fsf@bernoul.li> From: Noam Postavsky Date: Thu, 16 Jul 2020 14:23:01 -0400 Message-ID: Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. To: Jonas Bernoulli Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: Robert Pluim , 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 16 Jul 2020 at 13:55, Jonas Bernoulli wrote: > > Robert Pluim writes: > > > On a related note: would you consider using '--no-chain-reply-to' [1]? > > Your patch series march off the right edge of my screen :-) > > And again, that was intentional. I actually used "--chain-reply-to" > explicitly because when I didn't then mails were displayed in the wrong > order in the web interface. Though thinking about that again, I now > think that wasn't actually the reason. Maybe. As far as I know, the order of display in the web interface is based solely on the order of arrival, not the headers (chaining does help for the debbugs.el interface, which shows things properly threaded. Except it can also hurt, as Robert points out). From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 14:34:56 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 18:34:56 +0000 Received: from localhost ([127.0.0.1]:56000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8ie-0004ax-AE for submit@debbugs.gnu.org; Thu, 16 Jul 2020 14:34:56 -0400 Received: from mail.hostpark.net ([212.243.197.30]:50320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8ib-0004am-CN for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 14:34:54 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id F1022160BA; Thu, 16 Jul 2020 20:34:51 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ogZbCSGHY9wB; Thu, 16 Jul 2020 20:34:51 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B36F2160AE; Thu, 16 Jul 2020 20:34:51 +0200 (CEST) From: Jonas Bernoulli To: Eli Zaretskii , Drew Adams Subject: Re: bug#42397: [PATCH 00/14] Use outline headings and some cosmetics In-Reply-To: <83blkflboc.fsf@gnu.org> References: <20200716144707.16857-1-jonas@bernoul.li> <4c040cd2-8df0-4761-822f-8cd318ee629e@default> <83blkflboc.fsf@gnu.org> Date: Thu, 16 Jul 2020 20:34:51 +0200 Message-ID: <878sfjpaus.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> Date: Thu, 16 Jul 2020 08:12:24 -0700 (PDT) >> From: Drew Adams >>=20 >> I thought we had a pretty standard header format. I thought so too... and that I was following them. Maybe it is just that our respective selective memory focuses on a different aspect? >> I've been respecting that for decades in my own >> libraries. Now it's changed? > > You have a point there. > > Jonas, please compare what you propose with the tips we have in the > "Comment Tips" node of the ELisp manual, and seed if there's any > discrepancies. If there are, I think we should discuss first (on > emacs-devel). After reading (info "(elisp) Comment Tips") again, I think I remembered correctly. Quoting the ;;; entry in full: > =E2=80=98;;;=E2=80=99 > Comments that start with three semicolons, =E2=80=98;;;=E2=80=99, sh= ould start at > the left margin. We use them for comments which should be > considered a heading by Outline minor mode. By default, comments > starting with at least three semicolons (followed by a single space > and a non-whitespace character) are considered headings, comments > starting with two or fewer are not. Historically, triple-semicolon > comments have also been used for commenting out lines within a > function, but this use is discouraged. >=20 > When commenting out entire functions, use two semicolons. This says that three semicolons are for "headings". There is no mention of "separators". And the only node to older conventions is about using three semicolons to comment out parts of functions. It seems pretty clear to me that the use of three or more semicolons is now reserved for (outline) headings. Of course there are also autoload coolies but those don't have a space after the semicolons. Do you still think this has to be discussed on emacs-devel? Normally I don't divide the ";;; Commentary:" section into multiple sub-sections. In this particular case I have done so because (a) it is long (b) splitting into sibling sections, as was done before, seems wrong to me. Also note that I don't turn all the sections that contain code and follow the ";;; Code:" heading into sub-sections of that section. I don't think the "Comment Tips" are clear on that matter but it seems to me that they imply that I should do so. If so, then I disagree based on my experience. Seeing this ,---- | ;;; foo.el --- Foo bar baz | ;;; Commentary:... | ;;; Code:... | ;;; foo.el ends here `---- is almost entirely useless (because almost the same for all libraries that do it like this), whereas ,---- | ;;; foo.el --- Foo bar baz | ;;; Commentary:... | ;;; Code:... | ;;; Options... | ;;; List Mode... | ;;; List Commands... | ;;; Integrations | ;;; foo.el ends here `---- is very useful in my experience as it instantly gives a quick overview of how the code is structured etc. Ps: I have written a few packages to make `outline-minor-mode' a bit nicer: mainly `bicycle', but also `outline-minor-faces' and `backline'. https://github.com/tarsius/bicycle https://github.com/tarsius/outline-minor-faces https://github.com/tarsius/backline From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 14:40:07 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 18:40:07 +0000 Received: from localhost ([127.0.0.1]:56005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8ne-0004iN-VN for submit@debbugs.gnu.org; Thu, 16 Jul 2020 14:40:07 -0400 Received: from mail.hostpark.net ([212.243.197.30]:50540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw8nd-0004iB-AV for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 14:40:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id D9A7A160BA; Thu, 16 Jul 2020 20:40:03 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id zxrxarCLQguS; Thu, 16 Jul 2020 20:40:03 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A107F160AE; Thu, 16 Jul 2020 20:40:03 +0200 (CEST) From: Jonas Bernoulli To: Noam Postavsky Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <87ft9rpcpl.fsf@bernoul.li> Date: Thu, 16 Jul 2020 20:40:03 +0200 Message-ID: <875zanpam4.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: Robert Pluim , 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: > On Thu, 16 Jul 2020 at 13:55, Jonas Bernoulli wrote: >> >> Robert Pluim writes: >> >> > On a related note: would you consider using '--no-chain-reply-to' [1]? >> > Your patch series march off the right edge of my screen :-) >> >> And again, that was intentional. I actually used "--chain-reply-to" >> explicitly because when I didn't then mails were displayed in the wrong >> order in the web interface. Though thinking about that again, I now >> think that wasn't actually the reason. Maybe. > > As far as I know, the order of display in the web interface is based > solely on the order of arrival, My limited experience seems to confirm that. That's pretty nasty IMO. > not the headers (chaining does help > for the debbugs.el interface, which shows things properly threaded. > Except it can also hurt, as Robert points out). Unfortunately my experiments so far have not been very scientific and I will have to repeat some of them. Next thing I will try is to use only 1) --batch-size=1 --relogin-delay=5 but not 2) --chain-reply-to If it turns out that (1) by itself works reliable, then I will gladly drop (2). From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 15:25:41 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 19:25:42 +0000 Received: from localhost ([127.0.0.1]:56035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9Vl-0005l4-NX for submit@debbugs.gnu.org; Thu, 16 Jul 2020 15:25:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9Vi-0005kq-TD for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 15:25:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54084) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw9Vc-00089o-SP; Thu, 16 Jul 2020 15:25:32 -0400 Received: from [176.228.60.248] (port=1414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw9Vc-0006dj-07; Thu, 16 Jul 2020 15:25:32 -0400 Date: Thu, 16 Jul 2020 22:25:19 +0300 Message-Id: <83zh7zjm8w.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <87mu3zpfez.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 18:56:20 +0200) Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Cc: 42397@debbugs.gnu.org > Date: Thu, 16 Jul 2020 18:56:20 +0200 > > I did just dig a bit and found bug#20323. So it turns out we did > eventually set the variable, but we did not adjust existing code to > conform to that setting. Yes, because doing that would just cause a lot of "no-op" changes, which affect the output of 'annotate', but otherwise have no real gains. Instead, we tell people to modify the whitespace as part of changes to the code they do anyway. This way, the attribution stays significant, and we eventually will get to our goal, albeit slower. > I'll change that before pushing obviously. And since this commit is > already about *fixing* whitespace, I will also *adjust* the remaining > lines to use the preferred style. Please only change the whitespace where you do make changes, for the reasons mentioned above. > It might be time to revisit the decision to not fix indentation in > bulk. Since version Git 2.23 "git blame" can ignore the effect and > presence of certain commits. I don't think we want to assume 2.23 yet. I still use 2.10 on one of my machines, and fencepost.gnu.org has 2.3.5(!). > > P.S. Why do you CC yourself on every message? It causes the Reply to > > name you twice, so you will get 2 copies of them. Is this what you > > want? > > Hmmm. Because that's not the behavior I experience. Without that > explicit CC I get the message zero times (git send-email does not put > them into the local maildir and debbugs does not appear to be echoing my > own messages back to me). With that CC I get the messages exactly once. > Maybe you experience something else because debbugs sends *all* message > to you, not just your own? I was talking about the responses. The response goes to the address in From and also to those in CC. Thus, responding to messages sent by you will always send you a copy, because you appear in From. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 17:53:04 2020 Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 21:53:04 +0000 Received: from localhost ([127.0.0.1]:56107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwBoO-0000n9-Ix for submit@debbugs.gnu.org; Thu, 16 Jul 2020 17:53:04 -0400 Received: from mail.hostpark.net ([212.243.197.30]:54770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwBoL-0000mj-ON for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 17:53:03 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 231AE165C8; Thu, 16 Jul 2020 23:53:00 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id idzGczXiLW7l; Thu, 16 Jul 2020 23:52:59 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id E0FA3165C3; Thu, 16 Jul 2020 23:52:59 +0200 (CEST) From: Jonas Bernoulli To: Eli Zaretskii Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: <83zh7zjm8w.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <83zh7zjm8w.fsf@gnu.org> Date: Thu, 16 Jul 2020 23:52:44 +0200 Message-ID: <87tuy786vn.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Instead, we tell people to modify the whitespace as part of changes to > the code they do anyway. This way, the attribution stays significant, > and we eventually will get to our goal, albeit slower. > >> I'll change that before pushing obviously. And since this commit is >> already about *fixing* whitespace, I will also *adjust* the remaining >> lines to use the preferred style. > > Please only change the whitespace where you do make changes, for the > reasons mentioned above. Just to make sure: I was talking about potentially changing other lines *within the same function* that I am already touching, and that is what I am not supposed to do, right? Okay I will commit that rule to memory. >> It might be time to revisit the decision to not fix indentation in >> bulk. Since version Git 2.23 "git blame" can ignore the effect and >> presence of certain commits. > > I don't think we want to assume 2.23 yet. I still use 2.10 on one of > my machines, and fencepost.gnu.org has 2.3.5(!). One day, one day. >> > P.S. Why do you CC yourself on every message? It causes the Reply to >> > name you twice, so you will get 2 copies of them. Is this what you >> > want? >> >> Hmmm. Because that's not the behavior I experience. Without that >> explicit CC I get the message zero times (git send-email does not put >> them into the local maildir and debbugs does not appear to be echoing my >> own messages back to me). With that CC I get the messages exactly once. >> Maybe you experience something else because debbugs sends *all* message >> to you, not just your own? > > I was talking about the responses. The response goes to the address > in From and also to those in CC. Thus, responding to messages sent by > you will always send you a copy, because you appear in From. Are you talking about the responses that other humans write? E.g when you reply to From: Jonas, Cc: Jonas and you do a "reply all", then that results in To: Jonas, Cc: Jonas Since I cannot find such a message, I assume you manually modified those messages before sending. Otherwise please give me an example of such a message, so that I can inspect it. My current understanding is that even if this is the case I don't really have a choice. I need the messages that I send using "git send-email" to appear in my email client. That only happens if I CC the message to me. If that results in the replies to those messages arriving twice in my inbox, then that is unfortunate but the lesser evil. (But please enlighten me if I still get something wrong.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 16 23:40:56 2020 Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 03:40:56 +0000 Received: from localhost ([127.0.0.1]:56382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwHF2-00078R-5A for submit@debbugs.gnu.org; Thu, 16 Jul 2020 23:40:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwHEy-00078B-SW for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 23:40:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34371) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwHEs-0007wk-GS; Thu, 16 Jul 2020 23:40:46 -0400 Received: from [176.228.60.248] (port=3773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jwHEr-0007f5-Tv; Thu, 16 Jul 2020 23:40:46 -0400 Date: Fri, 17 Jul 2020 06:40:32 +0300 Message-Id: <83pn8ukdvz.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <87tuy786vn.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 23:52:44 +0200) Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <83zh7zjm8w.fsf@gnu.org> <87tuy786vn.fsf@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Cc: 42397@debbugs.gnu.org > Date: Thu, 16 Jul 2020 23:52:44 +0200 > > >> I'll change that before pushing obviously. And since this commit is > >> already about *fixing* whitespace, I will also *adjust* the remaining > >> lines to use the preferred style. > > > > Please only change the whitespace where you do make changes, for the > > reasons mentioned above. > > Just to make sure: I was talking about potentially changing other lines > *within the same function* that I am already touching, and that is what > I am not supposed to do, right? Well, if those other lines are close to the ones you modify (i.e. the function is small enough), perhaps you can do that as well. It's a judgment call: the important thing is not to make too many changes that are outside of the main change's locus and only change the whitespace. > >> It might be time to revisit the decision to not fix indentation in > >> bulk. Since version Git 2.23 "git blame" can ignore the effect and > >> presence of certain commits. > > > > I don't think we want to assume 2.23 yet. I still use 2.10 on one of > > my machines, and fencepost.gnu.org has 2.3.5(!). > > One day, one day. Yes, definitely. > > I was talking about the responses. The response goes to the address > > in From and also to those in CC. Thus, responding to messages sent by > > you will always send you a copy, because you appear in From. > > Are you talking about the responses that other humans write? E.g when > you reply to > > From: Jonas, Cc: Jonas > > and you do a "reply all", then that results in > > To: Jonas, Cc: Jonas Yes. > Since I cannot find such a message, I assume you manually modified those > messages before sending. Right. And that is a mild annoyance, because it makes responding slower, and I need to pay attention to the address headers, something I'd rather not do. > My current understanding is that even if this is the case I don't really > have a choice. I need the messages that I send using "git send-email" > to appear in my email client. That only happens if I CC the message to > me. If that results in the replies to those messages arriving twice in > my inbox, then that is unfortunate but the lesser evil. (But please > enlighten me if I still get something wrong.) Can't you use BCC for that? (I'm not familiar with "git send-email" enough to tell if this is possible.) From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 17 02:30:09 2020 Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 06:30:09 +0000 Received: from localhost ([127.0.0.1]:56529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwJsn-0002ys-49 for submit@debbugs.gnu.org; Fri, 17 Jul 2020 02:30:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwJsj-0002wr-53 for 42397@debbugs.gnu.org; Fri, 17 Jul 2020 02:30:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36498) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwJsc-00033x-Q9; Fri, 17 Jul 2020 02:29:58 -0400 Received: from [176.228.60.248] (port=2162 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jwJsa-0001Z9-P4; Fri, 17 Jul 2020 02:29:58 -0400 Date: Fri, 17 Jul 2020 09:29:42 +0300 Message-Id: <83eepak621.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <878sfjpaus.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 20:34:51 +0200) Subject: Re: bug#42397: [PATCH 00/14] Use outline headings and some cosmetics References: <20200716144707.16857-1-jonas@bernoul.li> <4c040cd2-8df0-4761-822f-8cd318ee629e@default> <83blkflboc.fsf@gnu.org> <878sfjpaus.fsf@bernoul.li> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Cc: 42397@debbugs.gnu.org > Date: Thu, 16 Jul 2020 20:34:51 +0200 > > > ‘;;;’ > > Comments that start with three semicolons, ‘;;;’, should start at > > the left margin. We use them for comments which should be > > considered a heading by Outline minor mode. By default, comments > > starting with at least three semicolons (followed by a single space > > and a non-whitespace character) are considered headings, comments > > starting with two or fewer are not. Historically, triple-semicolon > > comments have also been used for commenting out lines within a > > function, but this use is discouraged. > > > > When commenting out entire functions, use two semicolons. > > This says that three semicolons are for "headings". > There is no mention of "separators". Right. Unless by "separators" we allude to headings of what the manual calls "major sections of a program", see below. > It seems pretty clear to me that the use of three or more semicolons is > now reserved for (outline) headings. Of course there are also autoload > coolies but those don't have a space after the semicolons. > > Do you still think this has to be discussed on emacs-devel? Not the 3 semicolon issue, no. However, this part might need discussing: > Also note that I don't turn all the sections that contain code and > follow the ";;; Code:" heading into sub-sections of that section. I > don't think the "Comment Tips" are clear on that matter but it seems > to me that they imply that I should do so. Yes, I think that's what the manual says. > If so, then I disagree based on my experience. I don't have a strong opinion on this, but if we agree to do it your way, we should amend the manual. > Seeing this > > ,---- > | ;;; foo.el --- Foo bar baz > | ;;; Commentary:... > | ;;; Code:... > | ;;; foo.el ends here > `---- > > is almost entirely useless (because almost the same for all libraries > that do it like this), whereas > > ,---- > | ;;; foo.el --- Foo bar baz > | ;;; Commentary:... > | ;;; Code:... > | ;;; Options... > | ;;; List Mode... > | ;;; List Commands... > | ;;; Integrations > | ;;; foo.el ends here > `---- > > is very useful in my experience as it instantly gives a quick overview > of how the code is structured etc. But the above seems to say that Options, List Mode, List Commands etc. are on the same level as Code, whereas in reality they are subsections of Code, no? Anyway, like I said: we should make the manual describe our practices. Are you saying that the subsections with 4 semicolons are never actually used in Emacs? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 17 06:49:51 2020 Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 10:49:51 +0000 Received: from localhost ([127.0.0.1]:56774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwNw6-00013U-S0 for submit@debbugs.gnu.org; Fri, 17 Jul 2020 06:49:51 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:39428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwNw4-00013F-2v for 42397@debbugs.gnu.org; Fri, 17 Jul 2020 06:49:50 -0400 Received: by mail-wr1-f41.google.com with SMTP id q5so10489499wru.6 for <42397@debbugs.gnu.org>; Fri, 17 Jul 2020 03:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7r5zqFCOp5/gkupaMJinkeVrg0262gt0IebxEQ8os30=; b=1jFAmOoqULahp8x4QaSd5HrC3UT9oPeD7PBaun7HkCeK71+qvzMIgAM+OwfQoJcMXU 1X1Kdo6wzCWIREQTRO1vKDQo5P3BLsYZ3J3KKzZ6JXSaKf6mta5TNHmMyXtFicmBMWRw p0gNTG3z6h82/9BG99QzBMW3Z+xQQscKCyKuN1KWR8bLR1yGf9gFkc3i/LzmuiRGGHkC bD4DrxYf1/Ut3ZPWOQJ5nG+KpfhcdwBbYZR6Vf5133IIjxoiCBgLcSlqHWNisnFKmAym cbAqgnkIHcky5T2n737xrvl5KsZNrrWIPrZrmJYPnPfBc5xvcK6rr7exu9Myutv9nHy/ QtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7r5zqFCOp5/gkupaMJinkeVrg0262gt0IebxEQ8os30=; b=s/RqTvSqjhLSAHmRoc+6Os9qL2US/smhuMhpaghckqJPrlJuXwLiZt1ERSNRVuKIBy q+7ioxWtd6jscCR9+zgn+8pGLbrrcOVsYGg5rRZXxin3rgdH6ERw+4Y8LXvKh/KeXiwK WHF7ilifUgQ2k0OSIq4Wj4NjPdCvnR7KXZnj11LuVjMektrIZlUkC89l5O1OWwMDXxC8 sG1YMyE2Wce2ZSlTv95ZklOG2AZUXxp7fStmOnMF4sjgomVnLXSUMQOpL+JaHrxP+0mA ELRqxTMMim5dfnFdqNYC1PcK/Y1m/CsQTHWFJHlfOrWnR4J9QKGkQU8k4jXN3gJ2IaTr dUAQ== X-Gm-Message-State: AOAM53124exBqcc5rDOLQBVbHz1mwufPRuTy3eg9TPUUd/684nRVzDSm 9qHGRxZJLJICnzTcFyYdrYwt5A== X-Google-Smtp-Source: ABdhPJxp92IvagS0wrKAoIXx19PfMZVn7TaP2T3XpK59DEOLyqXHFCjs7oiBK2PdT/Jf8BLVsvugjA== X-Received: by 2002:adf:f60c:: with SMTP id t12mr10444494wrp.198.1594982982053; Fri, 17 Jul 2020 03:49:42 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id v7sm13971447wrp.45.2020.07.17.03.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 03:49:41 -0700 (PDT) From: "Basil L. Contovounesios" To: Jonas Bernoulli Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> Date: Fri, 17 Jul 2020 11:49:40 +0100 In-Reply-To: <20200716145456.17531-6-jonas@bernoul.li> (Jonas Bernoulli's message of "Thu, 16 Jul 2020 16:54:48 +0200") Message-ID: <875zamtnzv.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jonas Bernoulli writes: > --- > lisp/emacs-lisp/eldoc.el | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el > index 510dff9ed0..90dce4a317 100644 > --- a/lisp/emacs-lisp/eldoc.el > +++ b/lisp/emacs-lisp/eldoc.el > @@ -285,13 +285,13 @@ eldoc-minibuffer-message > (or (window-in-direction 'above (minibuffer-window)) > (minibuffer-selected-window) > (get-largest-window))) > - (when mode-line-format > - (unless (and (listp mode-line-format) > - (assq 'eldoc-mode-line-string mode-line-format)) > - (setq mode-line-format > - (list "" '(eldoc-mode-line-string > - (" " eldoc-mode-line-string " ")) > - mode-line-format)))) > + (when mode-line-format > + (unless (and (listp mode-line-format) > + (assq 'eldoc-mode-line-string mode-line-format)) > + (setq mode-line-format > + (list "" '(eldoc-mode-line-string > + (" " eldoc-mode-line-string " ")) > + mode-line-format)))) You can avoid reindenting this whole block by merging the conditions of the redundantly nested when and unless: (unless (if (consp mode-line-format) (assq 'eldoc-mode-line-string mode-line-format) (not mode-line-format)) (setq mode-line-format (list "" '(eldoc-mode-line-string (" " eldoc-mode-line-string " ")) mode-line-format))) or similar. > (setq eldoc-mode-line-string > (when (stringp format-string) > (apply #'format-message format-string args))) Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 17 14:19:35 2020 Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 18:19:35 +0000 Received: from localhost ([127.0.0.1]:58043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwUxL-00021S-BP for submit@debbugs.gnu.org; Fri, 17 Jul 2020 14:19:35 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwUxG-00021D-2z for 42397@debbugs.gnu.org; Fri, 17 Jul 2020 14:19:34 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id A0FD716617; Fri, 17 Jul 2020 20:19:28 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id XAwfLr5rieaX; Fri, 17 Jul 2020 20:19:28 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 716AF165CB; Fri, 17 Jul 2020 20:19:28 +0200 (CEST) From: Jonas Bernoulli To: Eli Zaretskii Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: <83pn8ukdvz.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> <83zh7zjm8w.fsf@gnu.org> <87tuy786vn.fsf@bernoul.li> <83pn8ukdvz.fsf@gnu.org> Date: Fri, 17 Jul 2020 20:19:07 +0200 Message-ID: <87d04ungx0.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> Since I cannot find such a message, I assume you manually modified those >> messages before sending. > > Right. And that is a mild annoyance, because it makes responding > slower, and I need to pay attention to the address headers, something > I'd rather not do. Sorry about that. > Can't you use BCC for that? (I'm not familiar with "git send-email" > enough to tell if this is possible.) Duh! That's what I should have done to begin with. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 17 14:23:40 2020 Received: (at 42397) by debbugs.gnu.org; 17 Jul 2020 18:23:40 +0000 Received: from localhost ([127.0.0.1]:58047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwV1H-00027m-SG for submit@debbugs.gnu.org; Fri, 17 Jul 2020 14:23:40 -0400 Received: from mail.hostpark.net ([212.243.197.30]:60860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwV1G-00027e-No for 42397@debbugs.gnu.org; Fri, 17 Jul 2020 14:23:39 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 94AE216617; Fri, 17 Jul 2020 20:23:37 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 5f0UlPaoDuTc; Fri, 17 Jul 2020 20:23:37 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 67036165CB; Fri, 17 Jul 2020 20:23:37 +0200 (CEST) From: Jonas Bernoulli To: "Basil L. Contovounesios" Subject: Re: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. In-Reply-To: <875zamtnzv.fsf@tcd.ie> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <875zamtnzv.fsf@tcd.ie> Date: Fri, 17 Jul 2020 20:23:37 +0200 Message-ID: <87a6zyngpi.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "Basil L. Contovounesios" writes: > Jonas Bernoulli writes: >> + (when mode-line-format >> + (unless (and (listp mode-line-format) >> + (assq 'eldoc-mode-line-string mode-line-format)) >> + (setq mode-line-format ...))) > > You can avoid reindenting this whole block by merging the conditions of > the redundantly nested when and unless: > > (unless (if (consp mode-line-format) > (assq 'eldoc-mode-line-string mode-line-format) > (not mode-line-format)) > (setq mode-line-format ...)) I suppose; but IMO this variant is trying to hard to be smart. > or similar. I think I will go with: (when (and mode-line-format (not (and (listp mode-line-format) (assq 'eldoc-mode-line-string mode-line-format)))) (setq mode-line-format ...)) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:35 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:35 +0000 Received: from localhost ([127.0.0.1]:37622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7r-0007Rf-EH for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:35 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7o-0007RU-7e for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:34 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 8250016B2A; Mon, 10 Aug 2020 23:14:30 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id HUjh_qgUlnTD; Mon, 10 Aug 2020 23:14:30 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 56A9015FD0; Mon, 10 Aug 2020 23:14:30 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 00/16] Use outline headings and some cosmetics Date: Mon, 10 Aug 2020 23:14:14 +0200 Message-Id: <20200810211430.22502-1-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200716144707.16857-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Here's v2. I believe I have addressed all the feedback. * Updated the heading conventions/tips in the manual to take the discussion that we had about "Code" on emacs-devel into account. * Made "Code" section empty accordingly in commits that call for that. * Adjusted the commit that removed some "end-of-section" headings to instead turn them into non-heading comments. See respective commit. * Fixed the regression pointed out by Robert. * Drew's question has been answered. * Took Basil's feedback into account. * Making an effort to send the patches in a less noisy fashion this time around. Cheers, Jonas Jonas Bernoulli (16): ; * lisp/epg.el (epg-signature-to-string): Use cl-case. ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias. Split EasyPG libraries into outline sections Merge two conditions and fix indentation * lisp/progmodes/compile.el: Remove unnecessary comments. ; * lisp/whitespace.el: Capitalize "Code" section heading. * lisp/mail/smtpmail.el: Use outline headings. * test/src/emacs-module-tests.el: Use proper outline headings. * lisp/obsolete/longlines.el: Use proper outline headings. * lisp/net/imap.el: Use proper outline headings * lisp/font-lock.el: Split the Commentary into subsections. * lisp/font-lock.el: No longer use headings as end of section markers. ; * lisp/emacs-lisp/autoload.el: Begin summary line with three semicolons. Update section heading conventions for libraries doc/lispref/tips.texi | 65 +++++++++++++++++++-------- lisp/emacs-lisp/autoload.el | 2 +- lisp/emacs-lisp/eldoc.el | 8 ++-- lisp/epa-dired.el | 1 + lisp/epa-file.el | 10 +++++ lisp/epa-hook.el | 1 + lisp/epa-mail.el | 10 +++++ lisp/epa.el | 38 ++++++++++------ lisp/epg-config.el | 7 +++ lisp/epg.el | 80 ++++++++++++++++++++-------------- lisp/font-lock.el | 30 ++++++------- lisp/mail/smtpmail.el | 10 +++-- lisp/net/imap.el | 30 ++++++++----- lisp/obsolete/longlines.el | 17 ++++---- lisp/progmodes/compile.el | 2 - lisp/whitespace.el | 2 +- test/src/emacs-module-tests.el | 21 +++------ 17 files changed, 208 insertions(+), 126 deletions(-) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:37 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:37 +0000 Received: from localhost ([127.0.0.1]:37625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7t-0007Ru-ME for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:37 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7s-0007Rl-7R for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:36 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 9E5E616B2A; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ECifRLhs5zrk; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 78A1A15FD0; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 01/16] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. Date: Mon, 10 Aug 2020 23:14:15 +0200 Message-Id: <20200810211430.22502-2-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) In this case we can greatly increase readability by using `cl-case' instead of `cond'. --- lisp/epg.el | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lisp/epg.el b/lisp/epg.el index 5b90bc290a..65decf3cf5 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -404,18 +404,13 @@ epg-signature-to-string (pubkey-algorithm (epg-signature-pubkey-algorithm signature)) (key-id (epg-signature-key-id signature))) (concat - (cond ((eq (epg-signature-status signature) 'good) - "Good signature from ") - ((eq (epg-signature-status signature) 'bad) - "Bad signature from ") - ((eq (epg-signature-status signature) 'expired) - "Expired signature from ") - ((eq (epg-signature-status signature) 'expired-key) - "Signature made by expired key ") - ((eq (epg-signature-status signature) 'revoked-key) - "Signature made by revoked key ") - ((eq (epg-signature-status signature) 'no-pubkey) - "No public key for ")) + (cl-case (epg-signature-status signature) + (good "Good signature from ") + (bad "Bad signature from ") + (expired "Expired signature from ") + (expired-key "Signature made by expired key ") + (revoked-key "Signature made by revoked key ") + (no-pubkey "No public key for ")) key-id (if user-id (concat " " -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:43 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:43 +0000 Received: from localhost ([127.0.0.1]:37628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7y-0007SC-S5 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:43 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7x-0007S4-Bh for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C029816B2A; Mon, 10 Aug 2020 23:14:40 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id itAJbJMTpmPs; Mon, 10 Aug 2020 23:14:40 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 9757015FD0; Mon, 10 Aug 2020 23:14:40 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 02/16] ; * lisp/epg.el (epg-signature-to-string): Tiny refactor. Date: Mon, 10 Aug 2020 23:14:16 +0200 Message-Id: <20200810211430.22502-3-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) `concat' treats arguments that are nil as if they were empty strings. We therefore do not have to write (if TEST THEN "") and can just use (and TEST THEN). --- lisp/epg.el | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/lisp/epg.el b/lisp/epg.el index 65decf3cf5..e53aa8caaa 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -412,24 +412,20 @@ epg-signature-to-string (revoked-key "Signature made by revoked key ") (no-pubkey "No public key for ")) key-id - (if user-id - (concat " " - (if (stringp user-id) - (epg--decode-percent-escape-as-utf-8 user-id) - (epg-decode-dn user-id))) - "") - (if (epg-signature-validity signature) - (format " (trust %s)" (epg-signature-validity signature)) - "") - (if (epg-signature-creation-time signature) - (format-time-string " created at %Y-%m-%dT%T%z" - (epg-signature-creation-time signature)) - "") - (if pubkey-algorithm - (concat " using " - (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist)) - (format "(unknown algorithm %d)" pubkey-algorithm))) - "")))) + (and user-id + (concat " " + (if (stringp user-id) + (epg--decode-percent-escape-as-utf-8 user-id) + (epg-decode-dn user-id)))) + (and (epg-signature-validity signature) + (format " (trust %s)" (epg-signature-validity signature))) + (and (epg-signature-creation-time signature) + (format-time-string " created at %Y-%m-%dT%T%z" + (epg-signature-creation-time signature))) + (and pubkey-algorithm + (concat " using " + (or (cdr (assq pubkey-algorithm epg-pubkey-algorithm-alist)) + (format "(unknown algorithm %d)" pubkey-algorithm))))))) (defun epg-verify-result-to-string (verify-result) "Convert VERIFY-RESULT to a human readable string." -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:51 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:51 +0000 Received: from localhost ([127.0.0.1]:37631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F84-0007SU-1l for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:51 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F82-0007SN-Gw for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E634516B2A; Mon, 10 Aug 2020 23:14:45 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 8pByfqgfLoBG; Mon, 10 Aug 2020 23:14:45 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B870115FD0; Mon, 10 Aug 2020 23:14:45 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 03/16] ; * lisp/epg.el (epg-no-data-reason-alist): Fix typo in message. Date: Mon, 10 Aug 2020 23:14:17 +0200 Message-Id: <20200810211430.22502-4-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/epg.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/epg.el b/lisp/epg.el index e53aa8caaa..df79988c48 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -123,7 +123,7 @@ epg-import-problem-reason-alist (defconst epg-no-data-reason-alist '((1 . "No armored data") - (2 . "Expected a packet but did not found one") + (2 . "Expected a packet but did not find one") (3 . "Invalid packet found, this may indicate a non OpenPGP message") (4 . "Signature expected but not found"))) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:53 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:53 +0000 Received: from localhost ([127.0.0.1]:37634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F89-0007Sq-C2 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:53 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F87-0007Sc-Lm for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:51 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 1819D16B2A; Mon, 10 Aug 2020 23:14:51 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id DnORb6W_GheN; Mon, 10 Aug 2020 23:14:50 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id E085F15FD0; Mon, 10 Aug 2020 23:14:50 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 04/16] * lisp/epa.el (epa--derived-mode-p): Remove unnecessary alias. Date: Mon, 10 Aug 2020 23:14:18 +0200 Message-Id: <20200810211430.22502-5-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) `derived-mode-p' was added twenty years ago in 6ad501012b9a9ddc26dd8ce1cef8332ee16d87df and by now we can just assume that it exists. --- lisp/epa.el | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lisp/epa.el b/lisp/epa.el index 3c7dd8309a..fc7ad5efab 100644 --- a/lisp/epa.el +++ b/lisp/epa.el @@ -1105,17 +1105,6 @@ epa-sign-region 'start-open t 'end-open t))))) -(defalias 'epa--derived-mode-p - (if (fboundp 'derived-mode-p) - #'derived-mode-p - (lambda (&rest modes) - "Non-nil if the current major mode is derived from one of MODES. -Uses the `derived-mode-parent' property of the symbol to trace backwards." - (let ((parent major-mode)) - (while (and (not (memq parent modes)) - (setq parent (get parent 'derived-mode-parent)))) - parent)))) - ;;;###autoload (defun epa-encrypt-region (start end recipients sign signers) "Encrypt the current region between START and END for RECIPIENTS. @@ -1227,8 +1216,7 @@ epa-import-keys (if (epg-context-result-for context 'import) (epa-display-info (epg-import-result-to-string (epg-context-result-for context 'import)))) - ;; FIXME: Why not use the (otherwise unused) epa--derived-mode-p? - (if (eq major-mode 'epa-key-list-mode) + (if (derived-mode-p 'epa-key-list-mode) (apply #'epa--list-keys epa-list-keys-arguments)))) ;;;###autoload -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:14:59 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:59 +0000 Received: from localhost ([127.0.0.1]:37637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8E-0007TB-IW for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:59 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8C-0007T1-RH for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:57 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 3DAD816B2A; Mon, 10 Aug 2020 23:14:56 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id jiqNEqt2Q6gd; Mon, 10 Aug 2020 23:14:56 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 0AF1A15FD0; Mon, 10 Aug 2020 23:14:56 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 05/16] Split EasyPG libraries into outline sections Date: Mon, 10 Aug 2020 23:14:19 +0200 Message-Id: <20200810211430.22502-6-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * lisp/epa-dired.el: lisp/epa-file.el: lisp/epa-hook.el: lisp/epa-mail.el: lisp/epa.el: lisp/epg-config.el: lisp/epg.el: Split into outline sections. * lisp/epg.el (epg-error): Move definition. --- lisp/epa-dired.el | 1 + lisp/epa-file.el | 10 ++++++++++ lisp/epa-hook.el | 1 + lisp/epa-mail.el | 10 ++++++++++ lisp/epa.el | 24 ++++++++++++++++++++++++ lisp/epg-config.el | 7 +++++++ lisp/epg.el | 27 ++++++++++++++++++++++++++- 7 files changed, 79 insertions(+), 1 deletion(-) diff --git a/lisp/epa-dired.el b/lisp/epa-dired.el index 9269ea9707..4ff1ba3394 100644 --- a/lisp/epa-dired.el +++ b/lisp/epa-dired.el @@ -1,4 +1,5 @@ ;;; epa-dired.el --- the EasyPG Assistant, dired extension -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno diff --git a/lisp/epa-file.el b/lisp/epa-file.el index bbd9279a9a..3b0cc84e5f 100644 --- a/lisp/epa-file.el +++ b/lisp/epa-file.el @@ -1,4 +1,5 @@ ;;; epa-file.el --- the EasyPG Assistant, transparent file encryption -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -21,10 +22,13 @@ ;; along with GNU Emacs. If not, see . ;;; Code: +;;; Dependencies (require 'epa) (require 'epa-hook) +;;; Options + (defcustom epa-file-cache-passphrase-for-symmetric-encryption nil "If non-nil, cache passphrase for symmetric encryption. @@ -49,6 +53,8 @@ epa-file-select-keys (const :tag "Don't ask" silent)) :group 'epa-file) +;;; Other + (defvar epa-file-passphrase-alist nil) (defun epa-file-passphrase-callback-function (context key-id file) @@ -72,6 +78,8 @@ epa-file-passphrase-callback-function passphrase)))) (epa-passphrase-callback-function context key-id file))) +;;; File Handler + (defvar epa-inhibit nil "Non-nil means don't try to decrypt .gpg files when operating on them.") @@ -311,6 +319,8 @@ epa-file-write-region (message "Wrote %s" buffer-file-name)))) (put 'write-region 'epa-file 'epa-file-write-region) +;;; Commands + (defun epa-file-select-keys () "Select recipients for encryption." (interactive) diff --git a/lisp/epa-hook.el b/lisp/epa-hook.el index a86f23eb68..6f12f8a6bf 100644 --- a/lisp/epa-hook.el +++ b/lisp/epa-hook.el @@ -1,4 +1,5 @@ ;;; epa-hook.el --- preloaded code to enable epa-file.el -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno diff --git a/lisp/epa-mail.el b/lisp/epa-mail.el index 63475256ca..6e6c0a498d 100644 --- a/lisp/epa-mail.el +++ b/lisp/epa-mail.el @@ -1,4 +1,5 @@ ;;; epa-mail.el --- the EasyPG Assistant, minor-mode for mail composer -*- lexical-binding: t -*- + ;; Copyright (C) 2006-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -21,10 +22,13 @@ ;; along with GNU Emacs. If not, see . ;;; Code: +;;; Dependencies (require 'epa) (require 'mail-utils) +;;; Local Mode + (defvar epa-mail-mode-map (let ((keymap (make-sparse-keymap))) (define-key keymap "\C-c\C-ed" 'epa-mail-decrypt) @@ -50,6 +54,8 @@ epa-mail-mode "A minor-mode for composing encrypted/clearsigned mails." nil " epa-mail" epa-mail-mode-map) +;;; Utilities + (defun epa-mail--find-usable-key (keys usage) "Find a usable key from KEYS for USAGE. USAGE would be `sign' or `encrypt'." @@ -64,6 +70,8 @@ epa-mail--find-usable-key (setq pointer (cdr pointer)))) (setq keys (cdr keys))))) +;;; Commands + ;;;###autoload (defun epa-mail-decrypt () "Decrypt OpenPGP armors in the current buffer. @@ -241,6 +249,8 @@ epa-mail-import-keys (interactive) (epa-import-armor-in-region (point-min) (point-max))) +;;; Global Mode + ;;;###autoload (define-minor-mode epa-global-mail-mode "Minor mode to hook EasyPG into Mail mode." diff --git a/lisp/epa.el b/lisp/epa.el index fc7ad5efab..713708f0c1 100644 --- a/lisp/epa.el +++ b/lisp/epa.el @@ -21,6 +21,7 @@ ;; along with GNU Emacs. If not, see . ;;; Code: +;;; Dependencies (require 'epg) (require 'font-lock) @@ -30,6 +31,8 @@ (require 'wid-edit)) (require 'derived) +;;; Options + (defgroup epa nil "The EasyPG Assistant" :version "23.1" @@ -73,6 +76,8 @@ epa-mail-aliases :group 'epa :version "24.4") +;;; Faces + (defgroup epa-faces nil "Faces for epa-mode." :version "23.1" @@ -146,6 +151,8 @@ epa-validity-face-alist :type '(repeat (cons symbol face)) :group 'epa-faces) +;;; Variables + (defvar epa-font-lock-keywords '(("^\\*" (0 'epa-mark)) @@ -252,6 +259,8 @@ epa-info-mode-map (defvar epa-exit-buffer-function #'quit-window) +;;; Key Widget + (define-widget 'epa-key 'push-button "Button for representing an epg-key object." :format "%[%v%]" @@ -293,6 +302,8 @@ epa--key-widget-help-echo (epg-sub-key-id (car (epg-key-sub-key-list (widget-get widget :value)))))) +;;; Modes + (define-derived-mode epa-key-list-mode special-mode "EPA Keys" "Major mode for `epa-list-keys'." (buffer-disable-undo) @@ -316,6 +327,9 @@ epa-info-mode (setq truncate-lines t buffer-read-only t)) +;;; Commands +;;;; Marking + (defun epa-mark-key (&optional arg) "Mark a key on the current line. If ARG is non-nil, unmark the key." @@ -338,11 +352,15 @@ epa-unmark-key (interactive "P") (epa-mark-key (not arg))) +;;;; Quitting + (defun epa-exit-buffer () "Exit the current buffer using `epa-exit-buffer-function'." (interactive) (funcall epa-exit-buffer-function)) +;;;; Listing and Selecting + (defun epa--insert-keys (keys) (save-excursion (save-restriction @@ -505,6 +523,8 @@ epa-select-keys (let ((keys (epg-list-keys context names secret))) (epa--select-keys prompt keys))) +;;;; Key Details + (defun epa-show-key () "Show a key on the current line." (interactive) @@ -591,6 +611,8 @@ epa--show-key (goto-char (point-min)) (pop-to-buffer (current-buffer)))) +;;;; Encryption and Signatures + (defun epa-display-info (info) (if epa-popup-info-window (save-selected-window @@ -1180,6 +1202,8 @@ epa-encrypt-region 'start-open t 'end-open t))))) +;;;; Key Management + ;;;###autoload (defun epa-delete-keys (keys &optional allow-secret) "Delete selected KEYS." diff --git a/lisp/epg-config.el b/lisp/epg-config.el index 1c42924652..9f0c7e4c50 100644 --- a/lisp/epg-config.el +++ b/lisp/epg-config.el @@ -22,6 +22,7 @@ ;; along with GNU Emacs. If not, see . ;;; Code: +;;; Prelude (eval-when-compile (require 'cl-lib)) @@ -34,6 +35,8 @@ epg-version-number (define-obsolete-variable-alias 'epg-bug-report-address 'report-emacs-bug-address "27.1") +;;; Options + (defgroup epg () "Interface to the GNU Privacy Guard (GnuPG)." :tag "EasyPG" @@ -106,6 +109,8 @@ epg-debug Note that the buffer name starts with a space." :type 'boolean) +;;; Constants + (defconst epg-gpg-minimum-version "1.4.3") (defconst epg-gpg2-minimum-version "2.1.6") @@ -133,6 +138,8 @@ epg-config--configuration-constructor-alist either `OpenPGP' or `CMS'. The second element is a function which constructs a configuration object (actually a plist).") +;;; "Configuration" + (defvar epg--configurations nil) ;;;###autoload diff --git a/lisp/epg.el b/lisp/epg.el index df79988c48..96af3ad4bc 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -1,4 +1,5 @@ ;;; epg.el --- the EasyPG Library -*- lexical-binding: t -*- + ;; Copyright (C) 1999-2000, 2002-2020 Free Software Foundation, Inc. ;; Author: Daiki Ueno @@ -21,10 +22,15 @@ ;; along with GNU Emacs. If not, see . ;;; Code: +;;; Prelude (require 'epg-config) (eval-when-compile (require 'cl-lib)) +(define-error 'epg-error "GPG error") + +;;; Variables + (defvar epg-user-id nil "GnuPG ID of your default identity.") @@ -41,6 +47,8 @@ epg-debug-buffer (defvar epg-agent-file nil) (defvar epg-agent-mtime nil) +;;; Enums + ;; from gnupg/common/openpgpdefs.h (defconst epg-cipher-algorithm-alist '((0 . "NONE") @@ -169,7 +177,8 @@ epg-dn-type-alist (defvar epg-prompt-alist nil) -(define-error 'epg-error "GPG error") +;;; Structs +;;;; Data Struct (cl-defstruct (epg-data (:constructor nil) @@ -180,6 +189,8 @@ 'epg-error (file nil :read-only t) (string nil :read-only t)) +;;;; Context Struct + (cl-defstruct (epg-context (:constructor nil) (:constructor epg-context--make @@ -218,6 +229,8 @@ 'epg-error (error-output "") error-buffer) +;;;; Context Methods + ;; This is not an alias, just so we can mark it as autoloaded. ;;;###autoload (defun epg-make-context (&optional protocol armor textmode include-certs @@ -281,6 +294,8 @@ epg-context-set-signers (declare (obsolete setf "25.1")) (setf (epg-context-signers context) signers)) +;;;; Other Structs + (cl-defstruct (epg-signature (:constructor nil) (:constructor epg-make-signature @@ -385,6 +400,8 @@ epg-context-set-signers secret-unchanged not-imported imports) +;;; Functions + (defun epg-context-result-for (context name) "Return the result of CONTEXT associated with NAME." (cdr (assq name (epg-context-result context)))) @@ -850,6 +867,8 @@ epg--prompt-GET_BOOL-untrusted_key.override (format "Untrusted key %s %s. Use anyway? " key-id user-id)) "Use untrusted key anyway? "))) +;;; Status Functions + (defun epg--status-GET_BOOL (context string) (let (inhibit-quit) (condition-case nil @@ -1225,6 +1244,8 @@ epg--status-IMPORT_RES (epg-context-result-for context 'import-status))) (epg-context-set-result-for context 'import-status nil))) +;;; Functions + (defun epg-passphrase-callback-function (context key-id _handback) (declare (obsolete epa-passphrase-callback-function "23.1")) (if (eq key-id 'SYM) @@ -1294,6 +1315,8 @@ epg--make-sub-key-1 (if (aref line 6) (epg--time-from-seconds (aref line 6))))) +;;; Public Functions + (defun epg-list-keys (context &optional name mode) "Return a list of epg-key objects matched with NAME. If MODE is nil or `public', only public keyring should be searched. @@ -2023,6 +2046,8 @@ epg-edit-key (epg-errors-to-string errors)))))) (epg-reset context))) +;;; Decode Functions + (defun epg--decode-percent-escape (string) (setq string (encode-coding-string string 'raw-text)) (let ((index 0)) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:03 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:03 +0000 Received: from localhost ([127.0.0.1]:37642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8J-0007U3-4L for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:03 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8H-0007TK-Uu for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:02 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 5C72916B2A; Mon, 10 Aug 2020 23:15:01 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id XZpRqG5o_nd6; Mon, 10 Aug 2020 23:15:01 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2EA5915FD0; Mon, 10 Aug 2020 23:15:01 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 06/16] Merge two conditions and fix indentation Date: Mon, 10 Aug 2020 23:14:20 +0200 Message-Id: <20200810211430.22502-7-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The motivation behind this change is that the indentation of some lines was outright wrong. If we address that issue, then we might as well also address the issue that some code is needlessly nested an additional level. That we can fix by merging the conditions. By doing these two changes in on commit we have to change the fewest lines. Even though we are moving to using just spaces for indentation of the modified lines, other lines in the same function are left alone and continue to us tabs+spaces for indentation. That is not "wrong", but just the style we are slowly migrating away from when touching lines for other reasons. Discussed in bug#42397. * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Merge two conditions and fix indentation. --- lisp/emacs-lisp/eldoc.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 19b3bd78ae..4825b5c5e6 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -289,13 +289,13 @@ eldoc-minibuffer-message (or (window-in-direction 'above (minibuffer-window)) (minibuffer-selected-window) (get-largest-window))) - (when mode-line-format - (unless (and (listp mode-line-format) - (assq 'eldoc-mode-line-string mode-line-format)) + (when (and mode-line-format + (not (and (listp mode-line-format) + (assq 'eldoc-mode-line-string mode-line-format)))) (setq mode-line-format (list "" '(eldoc-mode-line-string (" " eldoc-mode-line-string " ")) - mode-line-format)))) + mode-line-format))) (setq eldoc-mode-line-string (when (stringp format-string) (apply #'format-message format-string args))) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:08 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:08 +0000 Received: from localhost ([127.0.0.1]:37650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8O-0007VB-CX for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:08 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8N-0007V2-1s for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:07 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 7447F16B2A; Mon, 10 Aug 2020 23:15:06 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id NUrRvN9zvFDU; Mon, 10 Aug 2020 23:15:06 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 4DB9F15FD0; Mon, 10 Aug 2020 23:15:06 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 07/16] * lisp/progmodes/compile.el: Remove unnecessary comments. Date: Mon, 10 Aug 2020 23:14:21 +0200 Message-Id: <20200810211430.22502-8-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) These comments are unnecessary because the doc-strings that follow already cover the same ground, while being more concise. These comments were also prefixed with too many semicolons, causing them to be treated as outline headings. --- lisp/progmodes/compile.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index a76a3c44a3..0b9f417845 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -2373,12 +2373,10 @@ compilation-filter (set-marker min nil) (set-marker max nil)))))) -;;; test if a buffer is a compilation buffer, assuming we're in the buffer (defsubst compilation-buffer-internal-p () "Test if inside a compilation buffer." (local-variable-p 'compilation-locs)) -;;; test if a buffer is a compilation buffer, using compilation-buffer-internal-p (defsubst compilation-buffer-p (buffer) "Test if BUFFER is a compilation buffer." (with-current-buffer buffer -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:13 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:13 +0000 Received: from localhost ([127.0.0.1]:37653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8T-0007VU-Io for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:13 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8S-0007VL-6q for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:12 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 9AD5716B2A; Mon, 10 Aug 2020 23:15:11 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id yyGitcbXccTu; Mon, 10 Aug 2020 23:15:11 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 6CEE115FD0; Mon, 10 Aug 2020 23:15:11 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 08/16] ; * lisp/whitespace.el: Capitalize "Code" section heading. Date: Mon, 10 Aug 2020 23:14:22 +0200 Message-Id: <20200810211430.22502-9-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/whitespace.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/whitespace.el b/lisp/whitespace.el index 42c4b61daf..8a1bb8ade8 100644 --- a/lisp/whitespace.el +++ b/lisp/whitespace.el @@ -262,7 +262,7 @@ ;; ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -;;; code: +;;; Code: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:19 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:19 +0000 Received: from localhost ([127.0.0.1]:37656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8Y-0007Vo-Qv for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:19 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8X-0007Ve-C1 for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:18 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id C209616B2A; Mon, 10 Aug 2020 23:15:16 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id KSpm2ScdN1sB; Mon, 10 Aug 2020 23:15:16 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 957EF15FD0; Mon, 10 Aug 2020 23:15:16 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 09/16] * lisp/mail/smtpmail.el: Use outline headings. Date: Mon, 10 Aug 2020 23:14:23 +0200 Message-Id: <20200810211430.22502-10-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/mail/smtpmail.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/mail/smtpmail.el b/lisp/mail/smtpmail.el index f5c9432879..666395e0b9 100644 --- a/lisp/mail/smtpmail.el +++ b/lisp/mail/smtpmail.el @@ -53,6 +53,7 @@ ;; See http://www.ietf.org/rfc/rfc2554.txt ;;; Code: +;;; Dependencies (require 'sendmail) (require 'auth-source) @@ -61,12 +62,12 @@ (autoload 'message-make-message-id "message") (autoload 'rfc2104-hash "rfc2104") -;;; +;;; Options + (defgroup smtpmail nil "SMTP protocol for sending mail." :group 'mail) - (defcustom smtpmail-default-smtp-server nil "Specify default SMTP server. This only has effect if you specify it before loading the smtpmail library." @@ -172,8 +173,7 @@ smtpmail-retries :type 'integer :version "27.1") -;; End of customizable variables. - +;;; Variables (defvar smtpmail-address-buffer) (defvar smtpmail-recipient-address-list) @@ -192,6 +192,8 @@ smtpmail-auth-supported (defvar smtpmail-mail-address nil "Value to use for envelope-from address for mail from ambient buffer.") +;;; Functions + ;;;###autoload (defun smtpmail-send-it () (let ((errbuf (if mail-interactive -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:24 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:24 +0000 Received: from localhost ([127.0.0.1]:37659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8e-0007W7-2z for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:24 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8c-0007Vz-G4 for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:22 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DF01916B2A; Mon, 10 Aug 2020 23:15:21 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id fhMUnrijAv4Z; Mon, 10 Aug 2020 23:15:21 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id B47EB15FD0; Mon, 10 Aug 2020 23:15:21 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 10/16] * test/src/emacs-module-tests.el: Use proper outline headings. Date: Mon, 10 Aug 2020 23:14:24 +0200 Message-Id: <20200810211430.22502-11-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. --- test/src/emacs-module-tests.el | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el index 51b2ca0cd5..0fd8e1db49 100644 --- a/test/src/emacs-module-tests.el +++ b/test/src/emacs-module-tests.el @@ -24,6 +24,7 @@ ;; module in test/data/emacs-module. ;;; Code: +;;; Prelude (require 'cl-lib) (require 'ert) @@ -48,9 +49,7 @@ emacs-module-tests--generic (cl-defmethod emacs-module-tests--generic ((_ user-ptr)) 'user-ptr) -;; -;; Basic tests. -;; +;;; Basic tests (ert-deftest mod-test-sum-test () (should (= (mod-test-sum 1 2) 3)) @@ -103,9 +102,7 @@ module-function-object ">" eos) (prin1-to-string func))))) -;; -;; Non-local exists (throw, signal). -;; +;;; Non-local exists (throw, signal) (ert-deftest mod-test-non-local-exit-signal-test () (should-error (mod-test-signal)) @@ -142,9 +139,7 @@ mod-test-non-local-exit-funcall-throw (should (equal (mod-test-non-local-exit-funcall (lambda () (throw 'tag 32))) '(throw tag 32)))) -;; -;; String tests. -;; +;;; String tests (defun multiply-string (s n) "Return N copies of S concatenated together." @@ -168,9 +163,7 @@ mod-test-globref-reordered (ert-deftest mod-test-string-a-to-b-test () (should (string= (mod-test-string-a-to-b "aaa") "bbb"))) -;; -;; User-pointer tests. -;; +;;; User-pointer tests (ert-deftest mod-test-userptr-fun-test () (let* ((n 42) @@ -184,9 +177,7 @@ mod-test-userptr-fun-test ;; TODO: try to test finalizer -;; -;; Vector tests. -;; +;;; Vector tests (ert-deftest mod-test-vector-test () (dolist (s '(2 10 100 1000)) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:29 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:29 +0000 Received: from localhost ([127.0.0.1]:37662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8j-0007WO-9r for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:29 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8h-0007WG-Ju for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:27 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 08AA116B2A; Mon, 10 Aug 2020 23:15:27 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id TtWNndiQLD8c; Mon, 10 Aug 2020 23:15:26 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id D3C3415FD0; Mon, 10 Aug 2020 23:15:26 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 11/16] * lisp/obsolete/longlines.el: Use proper outline headings. Date: Mon, 10 Aug 2020 23:14:25 +0200 Message-Id: <20200810211430.22502-12-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. One heading is new. --- lisp/obsolete/longlines.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lisp/obsolete/longlines.el b/lisp/obsolete/longlines.el index 2fba49f402..cbe453aa6b 100644 --- a/lisp/obsolete/longlines.el +++ b/lisp/obsolete/longlines.el @@ -37,6 +37,7 @@ ;; Special thanks to Rod Smith for many useful bug reports. ;;; Code: +;;; Options (defgroup longlines nil "Automatic wrapping of long lines when loading files." @@ -76,7 +77,7 @@ longlines-show-effect :group 'longlines :type 'string) -;; Internal variables +;;; Internal variables (defvar longlines-wrap-beg nil) (defvar longlines-wrap-end nil) @@ -90,7 +91,7 @@ longlines-decoded (make-variable-buffer-local 'longlines-showing) (make-variable-buffer-local 'longlines-decoded) -;; Mode +;;; Mode (defvar message-indent-citation-function) @@ -210,7 +211,7 @@ longlines-mode-off major mode changes." (longlines-mode 0)) -;; Showing the effect of hard newlines in the buffer +;;; Showing the effect of hard newlines in the buffer (defun longlines-show-hard-newlines (&optional arg) "Make hard newlines visible by adding a face. @@ -252,7 +253,7 @@ longlines-unshow-hard-newlines (setq pos (text-property-not-all (1+ pos) (point-max) 'hard nil))) (restore-buffer-modified-p mod))) -;; Wrapping the paragraphs. +;;; Wrapping the paragraphs (defun longlines-wrap-region (beg end) "Wrap each successive line, starting with the line before BEG. @@ -402,7 +403,7 @@ longlines-encode-string (setq pos (string-match "\n" str (1+ pos)))) str)) -;; Auto wrap +;;; Auto wrap (defun longlines-auto-wrap (&optional arg) "Toggle automatic line wrapping. @@ -457,7 +458,7 @@ longlines-window-change-function (setq fill-column (- (window-width) dw)) (longlines-wrap-region (point-min) (point-max))))) -;; Isearch +;;; Isearch (defun longlines-search-function () (cond @@ -477,7 +478,7 @@ longlines-re-search-forward (let ((search-spaces-regexp " *[ \n]")) (re-search-forward string bound noerror count))) -;; Loading and saving +;;; Loading and saving (defun longlines-before-revert-hook () (add-hook 'after-revert-hook 'longlines-after-revert-hook nil t) @@ -492,7 +493,7 @@ longlines-after-revert-hook (list 'longlines "Automatically wrap long lines." nil nil 'longlines-encode-region t nil)) -;; Unloading +;;; Unloading (defun longlines-unload-function () "Unload the longlines library." -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:35 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:35 +0000 Received: from localhost ([127.0.0.1]:37665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8o-0007Wk-O9 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:34 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8m-0007WY-Oq for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:33 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 2D7DE16B2A; Mon, 10 Aug 2020 23:15:32 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id YD8ZeTAkTBUp; Mon, 10 Aug 2020 23:15:32 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id F3A6915FD0; Mon, 10 Aug 2020 23:15:31 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 12/16] * lisp/net/imap.el: Use proper outline headings Date: Mon, 10 Aug 2020 23:14:26 +0200 Message-Id: <20200810211430.22502-13-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. One heading is new. --- lisp/net/imap.el | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/lisp/net/imap.el b/lisp/net/imap.el index a492dc8c79..add19c5882 100644 --- a/lisp/net/imap.el +++ b/lisp/net/imap.el @@ -134,6 +134,7 @@ ;; ;;; Code: +;;; Dependencies (eval-when-compile (require 'cl-lib)) (require 'utf7) @@ -145,7 +146,7 @@ (declare-function digest-md5-digest-uri "ext:digest-md5") (declare-function digest-md5-challenge "ext:digest-md5") -;; User variables. +;;; User variables. (defgroup imap nil "Low-level IMAP issues." @@ -257,7 +258,7 @@ imap-store-password :group 'imap :type 'boolean) -;; Various variables. +;;; Various variables. (defvar imap-fetch-data-hook nil "Hooks called after receiving each FETCH response.") @@ -316,7 +317,9 @@ imap-logout-timeout an application program that uses this module specifies on a per-server basis.") -;; Internal constants. Change these and die. +;;; Internal constants + +;; Change these and die. (defconst imap-default-port 143) (defconst imap-default-ssl-port 993) @@ -348,7 +351,7 @@ imap-local-variables (defconst imap-log-buffer "*imap-log*") (defconst imap-debug-buffer "*imap-debug*") -;; Internal variables. +;;; Internal variables. (defvar imap-stream nil) (defvar imap-auth nil) @@ -437,7 +440,7 @@ imap-enable-exchange-bug-workaround canonical form fails.") -;; Utility functions: +;;; Utility functions (defun imap-remassoc (key alist) "Delete by side effect any elements of ALIST whose car is `equal' to KEY. @@ -489,7 +492,8 @@ imap-error-text (nth 3 (car imap-failed-tags)))) -;; Server functions; stream stuff: +;;; Server functions +;;;; Stream functions (defun imap-log (string-or-buffer) (when imap-log @@ -747,7 +751,7 @@ imap-starttls-open (message "imap: Connecting with STARTTLS...%s" (if done "done" "failed")) done)) -;; Server functions; authenticator stuff: +;;;; Authenticator functions (defun imap-interactive-login (buffer loginfunc) "Login to server in BUFFER. @@ -969,7 +973,7 @@ imap-digest-md5-auth (imap-send-command-1 "") (imap-ok-p (imap-wait-for-tag tag))))))) -;; Server functions: +;;; Server functions (defun imap-open-1 (buffer) (with-current-buffer buffer @@ -1228,7 +1232,7 @@ imap-logout-wait (imap-send-command-wait "LOGOUT" buffer))) -;; Mailbox functions: +;;; Mailbox functions (defun imap-mailbox-put (propname value &optional mailbox buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1520,7 +1524,7 @@ imap-mailbox-acl-delete identifier)))))) -;; Message functions: +;;; Message functions (defun imap-current-message (&optional buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1832,7 +1836,7 @@ imap-envelope-from (if (aref from 0) ">")))) -;; Internal functions. +;;; Internal functions. (defun imap-add-callback (tag func) (setq imap-callbacks (append (list (cons tag func)) imap-callbacks))) @@ -1969,7 +1973,7 @@ imap-arrival-filter (delete-region (point-min) (point-max))))))))) -;; Imap parser. +;;; Imap parser. (defsubst imap-forward () (or (eobp) (forward-char))) @@ -2850,6 +2854,8 @@ imap-parse-body (imap-forward) (nreverse body))))) +;;; Debug + (when imap-debug ; (untrace-all) (require 'trace) (buffer-disable-undo (get-buffer-create imap-debug-buffer)) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:39 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:39 +0000 Received: from localhost ([127.0.0.1]:37668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8t-0007X1-0X for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:39 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8r-0007Wu-TN for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:38 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 5014E16B2A; Mon, 10 Aug 2020 23:15:37 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id cy5ytAHL00cj; Mon, 10 Aug 2020 23:15:37 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 2277915FD0; Mon, 10 Aug 2020 23:15:37 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 13/16] * lisp/font-lock.el: Split the Commentary into subsections. Date: Mon, 10 Aug 2020 23:14:27 +0200 Message-Id: <20200810211430.22502-14-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) The "Commentary" was already split into multiple sections, but these sections where on the same level as "Commentary" itself, which is less convenient for users of `outline-minor-mode'. --- lisp/font-lock.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/font-lock.el b/lisp/font-lock.el index 5cda4a693d..cf88100ab5 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -51,7 +51,7 @@ ;; also the variable `font-lock-maximum-size'. Support modes for Font Lock ;; mode can be used to speed up Font Lock mode. See `font-lock-support-mode'. -;;; How Font Lock mode fontifies: +;;;; How Font Lock mode fontifies: ;; When Font Lock mode is turned on in a buffer, it (a) fontifies the entire ;; buffer and (b) installs one of its fontification functions on one of the @@ -96,7 +96,7 @@ ;; some syntactic parsers for common languages and a son-of-font-lock.el could ;; use them rather then relying so heavily on the keyword (regexp) pass. -;;; How Font Lock mode supports modes or is supported by modes: +;;;; How Font Lock mode supports modes or is supported by modes: ;; Modes that support Font Lock mode do so by defining one or more variables ;; whose values specify the fontification. Font Lock mode knows of these @@ -112,7 +112,7 @@ ;; Font Lock mode fontification behavior can be modified in a number of ways. ;; See the below comments and the comments distributed throughout this file. -;;; Constructing patterns: +;;;; Constructing patterns: ;; See the documentation for the variable `font-lock-keywords'. ;; @@ -120,7 +120,7 @@ ;; `font-lock-syntactic-keywords' can be generated via the function ;; `regexp-opt'. -;;; Adding patterns for modes that already support Font Lock: +;;;; Adding patterns for modes that already support Font Lock: ;; Though Font Lock highlighting patterns already exist for many modes, it's ;; likely there's something that you want fontified that currently isn't, even @@ -135,7 +135,7 @@ ;; other variables. For example, additional C types can be specified via the ;; variable `c-font-lock-extra-types'. -;;; Adding patterns for modes that do not support Font Lock: +;;;; Adding patterns for modes that do not support Font Lock: ;; Not all modes support Font Lock mode. If you (as a user of the mode) add ;; patterns for a new mode, you must define in your ~/.emacs a variable or @@ -155,7 +155,7 @@ ;; (set (make-local-variable 'font-lock-defaults) ;; '(foo-font-lock-keywords t)))) -;;; Adding Font Lock support for modes: +;;;; Adding Font Lock support for modes: ;; Of course, it would be better that the mode already supports Font Lock mode. ;; The package author would do something similar to above. The mode must -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:44 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:44 +0000 Received: from localhost ([127.0.0.1]:37671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8y-0007XJ-Ae for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:44 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8x-0007XB-1n for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:43 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 7347016B2A; Mon, 10 Aug 2020 23:15:42 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ZshrW0LchrtC; Mon, 10 Aug 2020 23:15:42 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 4302215FD0; Mon, 10 Aug 2020 23:15:42 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 14/16] * lisp/font-lock.el: No longer use headings as end of section markers. Date: Mon, 10 Aug 2020 23:14:28 +0200 Message-Id: <20200810211430.22502-15-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Each section ends right before the following section begins and IMO that means that it is unnecessary to mark the end of sections. For users of `outline-minor-mode' the old end-of-section markers were a distraction. They made it much harder to parse the overview outline state because each section heading was followed by a end-of-section marker that was formatted as a section heading. Because of this I wanted to remove the end-of-section markers. But as Eli pointed out these sections are long and not everyone uses `outline-minor-mode'. So instead of removing them, I am turning the end-of-section markers into regular comments (beginning with just two semicolons) instead of section headings (beginning with tree semicolons). That way users of `outline-minor-mode' won't be distracted by them and others can still benefit from the markers as before. --- lisp/font-lock.el | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lisp/font-lock.el b/lisp/font-lock.el index cf88100ab5..c633877e64 100644 --- a/lisp/font-lock.el +++ b/lisp/font-lock.el @@ -986,7 +986,7 @@ font-lock-after-unfontify-buffer ((bound-and-true-p lazy-lock-mode) (lazy-lock-after-unfontify-buffer)))) -;;; End of Font Lock Support mode. +;; End of Font Lock Support mode. ;;; Fontification functions. @@ -1393,7 +1393,7 @@ font-lock-fontify-block (font-lock-fontify-region (point) (mark))) ((error quit) (message "Fontifying block...%s" error-data))))))) -;;; End of Fontification functions. +;; End of Fontification functions. ;;; Additional text property functions. @@ -1485,7 +1485,7 @@ font-lock--remove-face-from-text-property (put-text-property start next prop new object)))))) (setq start (text-property-not-all next end prop nil object))))) -;;; End of Additional text property functions. +;; End of Additional text property functions. ;;; Syntactic regexp fontification functions. @@ -1591,7 +1591,7 @@ font-lock-fontify-syntactic-keywords-region (setq highlights (cdr highlights)))) (setq keywords (cdr keywords))))) -;;; End of Syntactic regexp fontification functions. +;; End of Syntactic regexp fontification functions. ;;; Syntactic fontification functions. @@ -1650,7 +1650,7 @@ font-lock-fontify-syntactically-region (setq state (parse-partial-sexp (point) end nil nil state 'syntax-table)))))) -;;; End of Syntactic fontification functions. +;; End of Syntactic fontification functions. ;;; Keyword regexp fontification functions. @@ -1784,9 +1784,9 @@ font-lock-fontify-keywords-region (setq keywords (cdr keywords))) (set-marker pos nil))) -;;; End of Keyword regexp fontification functions. +;; End of Keyword regexp fontification functions. -;; Various functions. +;;; Various functions. (defun font-lock-compile-keywords (keywords &optional syntactic-keywords) "Compile KEYWORDS into the form (t KEYWORDS COMPILED...) @@ -2102,7 +2102,7 @@ font-lock-regexp-grouping-construct "Font Lock mode face used to highlight grouping constructs in Lisp regexps." :group 'font-lock-faces) -;;; End of Color etc. support. +;; End of Color etc. support. ;;; Menu support. @@ -2204,7 +2204,7 @@ font-lock-regexp-grouping-construct ;; ;; Deactivate less/more fontification entries. ;; (setq font-lock-fontify-level nil)) -;;; End of Menu support. +;; End of Menu support. ;;; Various regexp information shared by several modes. ;; ;; Information specific to a single mode should go in its load library. -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:49 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:49 +0000 Received: from localhost ([127.0.0.1]:37674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F93-0007Xc-J3 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:49 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F92-0007XU-68 for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:48 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 950D616B2A; Mon, 10 Aug 2020 23:15:47 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id vTA36338eTzM; Mon, 10 Aug 2020 23:15:47 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 66DF315FD0; Mon, 10 Aug 2020 23:15:47 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 15/16] ; * lisp/emacs-lisp/autoload.el: Begin summary line with three semicolons. Date: Mon, 10 Aug 2020 23:14:29 +0200 Message-Id: <20200810211430.22502-16-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- lisp/emacs-lisp/autoload.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el index c76de43be9..ab5f9de891 100644 --- a/lisp/emacs-lisp/autoload.el +++ b/lisp/emacs-lisp/autoload.el @@ -1,4 +1,4 @@ -;; autoload.el --- maintain autoloads in loaddefs.el -*- lexical-binding: t -*- +;;; autoload.el --- maintain autoloads in loaddefs.el -*- lexical-binding: t -*- ;; Copyright (C) 1991-1997, 2001-2020 Free Software Foundation, Inc. -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 17:15:55 2020 Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:55 +0000 Received: from localhost ([127.0.0.1]:37677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F98-0007Xu-Rg for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:55 -0400 Received: from mail.hostpark.net ([212.243.197.30]:56222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F97-0007Xn-DU for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:53 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id CB3F816B2A; Mon, 10 Aug 2020 23:15:52 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ZULUrxF0aBax; Mon, 10 Aug 2020 23:15:52 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 939AC15FD0; Mon, 10 Aug 2020 23:15:52 +0200 (CEST) From: Jonas Bernoulli To: 42397@debbugs.gnu.org Subject: [PATCH v2 16/16] Update section heading conventions for libraries Date: Mon, 10 Aug 2020 23:14:30 +0200 Message-Id: <20200810211430.22502-17-jonas@bernoul.li> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * doc/lispref/tips.texi (Comment Tips): Update information on section headings to reflect common usage. Previously the tips stated that if the code is split up into multiple sections, then that should be done by splitting up the ";;; Code:" section into multiple sub-sections. However about half the libraries in Emacs instead use multiple top-level sections. We update the tips (aka conventions) to allow this common usage, but because it is awkward if there is a section named "Code", which contains only some of the code instead of all of it, we now recommend that that section should be empty in this case. We cannot just give up on the "Code:" section/heading because that is an old convention that is followed be nearly every library and because it is likely that there are some utilities out there that depend on its presence. This was discussed in https://lists.gnu.org/archive/html/emacs-devel/2020-07/msg00444.html https://lists.gnu.org/archive/html/emacs-devel/2020-08/msg00001.html --- doc/lispref/tips.texi | 65 ++++++++++++++++++++++++++++++------------- 1 file changed, 46 insertions(+), 19 deletions(-) diff --git a/doc/lispref/tips.texi b/doc/lispref/tips.texi index 5b09b2ccea..6292054d30 100644 --- a/doc/lispref/tips.texi +++ b/doc/lispref/tips.texi @@ -918,29 +918,56 @@ Comment Tips strings, though. @item ;;; -Comments that start with three semicolons, @samp{;;;}, should start at -the left margin. We use them -for comments which should be considered a -heading by Outline minor mode. By default, comments starting with -at least three semicolons (followed by a single space and a -non-whitespace character) are considered headings, comments starting -with two or fewer are not. Historically, triple-semicolon comments have -also been used for commenting out lines within a function, but this use -is discouraged. - -When commenting out entire functions, use two semicolons. - -@item ;;;; -Comments that start with four (or more) semicolons, @samp{;;;;}, -should be aligned to the left margin and are used for headings of -major sections of a program. For example: + +Comments that start with three (or more) semicolons, @samp{;;;}, +should start at the left margin. We use them for comments that should +be considered a heading by Outline minor mode. By default, comments +starting with at least three semicolons (followed by a single space +and a non-whitespace character) are considered section headings, +comments starting with two or fewer are not. + +(Historically, triple-semicolon comments have also been used for +commenting out lines within a function, but this use is discouraged in +favor of using just two semicolons. This also applies when commenting +out entire functions; when doing that use two semicolons as well.) + +Three semicolons are used for top-level sections, four for +sub-sections, five for sub-sub-sections and so on. + +Typically libraries have at least four top-level sections. For +example when the bodies of all of these sections are hidden: @smallexample -;;;; The kill ring +@group +;;; backquote.el --- implement the ` Lisp construct... +;;; Commentary:... +;;; Code:... +;;; backquote.el ends here +@end group @end smallexample -If you wish to have sub-headings under these heading, use more -semicolons to nest these sub-headings. +(In a sense the last line is not a section heading as it must +never be followed by any text; after all it marks the end of the +file.) + +For longer libraries it is advisable to split the code into multiple +sections. This can be done by splitting the @samp{Code:} section into +multiple sub-sections. Even though that was the only recommended +approach for a long time, many people have chosen to use multiple +top-level code sections instead. You may chose either style. + +Using multiple top-level code sections has the advanatage that it +avoids introducing an additional nesting level but it also means that +the section named @samp{Code} does not contain all the code, which is +awkward. To avoid that, you should put no code at all inside that +section; that way it can be considered a seperator instead of a +section heading. + +Finally, we recommend that you don't end headings with a colon or any +other punctuation for that matter. For historic reasons the +@samp{Code:} and @samp{Commentary:} headings end with a colon, but we +recommend that you don't do the same for other headings anyway. + @end table @noindent -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 12:54:19 2020 Received: (at 42397) by debbugs.gnu.org; 12 Aug 2020 16:54:19 +0000 Received: from localhost ([127.0.0.1]:45365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5u15-0000SG-1V for submit@debbugs.gnu.org; Wed, 12 Aug 2020 12:54:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5u12-0000S2-Hz for 42397@debbugs.gnu.org; Wed, 12 Aug 2020 12:54:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37757) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5u0w-0005nX-Km; Wed, 12 Aug 2020 12:54:10 -0400 Received: from [176.228.60.248] (port=2437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5u0v-0008D1-GS; Wed, 12 Aug 2020 12:54:09 -0400 Date: Wed, 12 Aug 2020 19:54:00 +0300 Message-Id: <838sejolef.fsf@gnu.org> From: Eli Zaretskii To: Jonas Bernoulli In-Reply-To: <20200810211430.22502-17-jonas@bernoul.li> (message from Jonas Bernoulli on Mon, 10 Aug 2020 23:14:30 +0200) Subject: Re: bug#42397: [PATCH v2 16/16] Update section heading conventions for libraries References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> <20200810211430.22502-17-jonas@bernoul.li> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42397 Cc: 42397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jonas Bernoulli > Date: Mon, 10 Aug 2020 23:14:30 +0200 > > * doc/lispref/tips.texi (Comment Tips): Update information on section > headings to reflect common usage. LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 16 14:43:32 2020 Received: (at submit) by debbugs.gnu.org; 16 Aug 2020 18:43:32 +0000 Received: from localhost ([127.0.0.1]:58474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7Ncy-0002TB-HZ for submit@debbugs.gnu.org; Sun, 16 Aug 2020 14:43:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:53982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7Ncw-0002T3-BD for submit@debbugs.gnu.org; Sun, 16 Aug 2020 14:43:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7Ncw-0002kQ-1Q for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2020 14:43:30 -0400 Received: from mail.hostpark.net ([212.243.197.30]:53810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7Ncu-0007WJ-Ea for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2020 14:43:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id F07C516109 for ; Sun, 16 Aug 2020 20:43:23 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 7FebaZ8KW1A5 for ; Sun, 16 Aug 2020 20:43:23 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id C3891160DD for ; Sun, 16 Aug 2020 20:43:23 +0200 (CEST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: Re: [PATCH 00/14] Use outline headings and some cosmetics In-Reply-To: <20200716144707.16857-1-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> Date: Sun, 16 Aug 2020 20:43:14 +0200 Message-ID: <87h7t2v3ct.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/16 14:43:24 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I have pushed the last iteration to master, so this issue can be closed. Thanks! Jonas From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 16 15:29:35 2020 Received: (at 42397) by debbugs.gnu.org; 16 Aug 2020 19:29:35 +0000 Received: from localhost ([127.0.0.1]:58549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OLX-000803-L3 for submit@debbugs.gnu.org; Sun, 16 Aug 2020 15:29:35 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:40267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OLV-0007zk-32 for 42397@debbugs.gnu.org; Sun, 16 Aug 2020 15:29:34 -0400 Received: by mail-yb1-f182.google.com with SMTP id q3so8250136ybp.7 for <42397@debbugs.gnu.org>; Sun, 16 Aug 2020 12:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=7wf+nMzz8aQXO0Zc3q9G+JTPme7NFOBl+KsLggpJjpk=; b=nNkvLFSs17kFLZCtfguQepEVHbLTzGpW185udee9dFgRtkn559bwtEWzlXX4EYwKpC kqr0GIri0QcI56a/WjurDkhkrdb/0U3v+hPpMDmTX1r0/ddOCWeILPA1xQqFIWspQM68 YLSJKdvBTAYLhufXlhUvQxwpmtWxZW2GWkda7dazx4LO81knmEAoF5FQwv7l7KpDO1gW Yq1c7WknwiA9m5sYIsrRRyTrAWDF/kkCMMBdCoUYxy9b2YNodZhe2mkShZl3ng43Rql4 5gbdbNTv4p4AgJ12DsZU8MXzYmKJQoU86N/n+mSMqWFTOLf6c4PSZCC44wGI8eb2p8lr Si8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=7wf+nMzz8aQXO0Zc3q9G+JTPme7NFOBl+KsLggpJjpk=; b=XStUYYBGuZtkKKRcNddYQpn94x/2eCyuCxgZXwYnpjCSzwU7v2VjWioGCKxkTv1wNM L8pXnNrCLZd4xczs0Z3DbwlPPIBOIXeQKmcRnGxiWvavVU4Gyyc4+72xx6iL8N2nWlWw 99wlSu8xL//zBZ8oKm5wiJYDHm7WLSTmUpFtFRd47njR9K7MhGeBSSkt0RvhY99A0dCO 87zvo9b8K7pZYMLG11RUo8fyT/b9/WHN5WGNr5/LM3tV9eTSBiYuhZk5gqStaNaodRax rlIfY5QcAnbBlMIrbQeI7XTAm+z9re5UtMxJ8Eb2MTbgUy8KsicZCc2wKwm/avD4BPjn pryg== X-Gm-Message-State: AOAM533/+AxpmSviIw/01YmCxnqp8MoqsMXa9nHQpl2CPPYlbkYoiomP t15fd+stSNk7xgbDJfTWWswJCgBoyeIyHbsATA9j1JbRTRM= X-Google-Smtp-Source: ABdhPJwPaUvpy3nMmQlXlTE8HZ2mrzAobYWu5H2brRRTX5wjHGgObsdtT279CXcIb2QQVJk75HLIM3NpnnjFkScTWlM= X-Received: by 2002:a25:4609:: with SMTP id t9mr15808469yba.231.1597606167534; Sun, 16 Aug 2020 12:29:27 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 16 Aug 2020 12:29:27 -0700 From: Stefan Kangas In-Reply-To: <87h7t2v3ct.fsf@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <87h7t2v3ct.fsf@bernoul.li> MIME-Version: 1.0 Date: Sun, 16 Aug 2020 12:29:26 -0700 Message-ID: Subject: Re: bug#42397: [PATCH 00/14] Use outline headings and some cosmetics To: Jonas Bernoulli , 42397@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 42397 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 42397 28.1 thanks Jonas Bernoulli writes: > I have pushed the last iteration to master, > so this issue can be closed. Thanks. Closing the bug now. Best regards, Stefan Kangas From unknown Thu Aug 21 23:00:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Sep 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator