GNU bug report logs - #42329
[PATCH] gnu: Add thin-provisioning-tools.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#42329: closed ([PATCH] gnu: Add thin-provisioning-tools.)
Date: Sun, 12 Jul 2020 18:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 12 Jul 2020 20:00:41 +0200
with message-id <20200712180041.hrjfi5pqso2d2s4c <at> gravity>
and subject line Re: [PATCH] gnu: Add thin-provisioning-tools.
has caused the debbugs.gnu.org bug report #42329,
regarding [PATCH] gnu: Add thin-provisioning-tools.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
42329: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=42329
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add thin-provisioning-tools.
Date: Sun, 12 Jul 2020 00:42:06 +0200

[Message part 3 (text/plain, inline)]

I use lvmcache (on ssd) for / (on spinning rust) which works fine.
But it writes the cache to the harddrive on every boot. In order to
debug (and maybe fix it), I think these tools (esp. cache_check) might
be useful...

[0001-gnu-Add-thin-provisioning-tools.patch (text/x-patch, inline)]

From 0307f8f0e8f4abb3506ae7f05c84bfe79b50518d Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike <at> rohleder.de>
Date: Sun, 12 Jul 2020 00:25:13 +0200
Subject: [PATCH] gnu: Add thin-provisioning-tools.

* gnu/packages/linux.scm (thin-provisioning-tools): New variable.
---
 gnu/packages/linux.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index bd7cbf183f..c010b3178b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -46,6 +46,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice <at> waegenei.re>
 ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 John Soo <jsoo1 <at> asu.edu>
+;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -73,6 +74,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages boost)
   #:use-module (gnu packages calendar)
   #:use-module (gnu packages check)
   #:use-module (gnu packages cpio)
@@ -3403,6 +3405,36 @@ mapper.  Kernel components are part of Linux-libre.")
                #t))))))
     (synopsis "Logical volume management for Linux (statically linked)")))
 
+(define-public thin-provisioning-tools
+  (package
+    (name "thin-provisioning-tools")
+    (version "0.8.5")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jthornber/thin-provisioning-tools.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "01wl8c0cjbx1smbhj8dx6av5bnw5775m58gasc3vqwvsj0s9hq19"))))
+    (build-system gnu-build-system)
+    (arguments
+     ;; doesnt build with --enable-testing
+     `(#:tests? #f))
+    (native-inputs
+     `(("automake" ,automake)
+       ("autoreconf" ,autoconf)))
+    (inputs
+     `(("boost" ,boost)
+       ("expat" ,expat)
+       ("libaio" ,libaio)))
+    (synopsis "Tools for manipulating the metadata of device-mapper targets")
+    (description "A suite of tools for manipulating the metadata of the
+dm-thin, dm-cache and dm-era device-mapper targets.")
+    (home-page "https://github.com/jthornber/thin-provisioning-tools")
+    (license license:gpl3+)))
+
 (define-public wireless-tools
   (package
     (name "wireless-tools")
-- 
2.27.0

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 42329-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add thin-provisioning-tools.
Date: Sun, 12 Jul 2020 20:00:41 +0200

[Message part 7 (text/plain, inline)]

On Sun, Jul 12, 2020 at 12:42:06AM +0200, Michael Rohleder wrote:
> I use lvmcache (on ssd) for / (on spinning rust) which works fine.
> But it writes the cache to the harddrive on every boot. In order to
> debug (and maybe fix it), I think these tools (esp. cache_check) might
> be useful...
> 

Thanks for the patch! I decided to expand the comment a bit:

;; Doesn't build with --enable-testing due to a function name collision
;; with glibc. Fixed upstream. TODO: Enable tests when 0.9.0 is released.

Apart from that, LGTM, so I pushed your patch as commit
a68430712fe623a61ba5eecfb8aa4547079a96c2.

Regards,
Jakub Kądziołka

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.