From unknown Sun Sep 14 01:17:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2020 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 42325@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159449496632717 (code B ref -1); Sat, 11 Jul 2020 19:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jul 2020 19:16:06 +0000 Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyk-0008Vd-9J for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:36156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyh-0008VK-18 for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juKyg-0005Pz-Q4 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juKye-0004Fh-E2 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Received: by mail-wm1-x32b.google.com with SMTP id q15so9376818wmj.2 for ; Sat, 11 Jul 2020 12:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=pw6hP7Rf1kVg+MkDNm64JUBQ1X9qgX2y6c3OdxMSKrf1ZBH4/BAA8RV1/JdGXHGKrB x8fPg5JYJs0zl3Yolw3BTDv5T8OIrqtxBBaJhfJA+m1dnK0qQRs4/xFX/RiRwSOL2ofT DgBTBDdkFP4hpgirBLvVtS7uKgXMLqHSi4mpB57q+lEO4t3J9Nf9FxA5MnQQXA7fYKcJ XySGCnQ+TWHVTLZ+VR+BS3tqzIpaPkLizaV/EBNVl9M9Y7z60R4TeM06tWMNu+Sq/Vib Pyhq5HQhgj9FvxGh2FNYKZqHcZ6oWlRfimX0GwJ95hhv86Zxg+nhzQcpBlON8ermreed f/iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=bpDcR8GeX+KaomBMUxPtwV200CBzyVs1sHxEHXrJ2dBzW7U7TOwdocR4SSp2qoNVPq Uq5Ku11lbWGuSNwGx3bptSWw+BhqC1IiEXN07CBG0SWPtWTOVj2JPwYuy1QZqbhRNsoh H6vvdNb9xfsixMcUIefTCqVKbTWJ9Kcf99peZrOjBYOa4Fd5HRKj2uom+APFQwxZPIyE kwpvkiFv5hufOmK42jpeomnJqu471aug0rKFaPSUGoXvpovnc88YnkJW4unyPqZH3hCf m3YsFxE/r1ZRTlo16MbsbOxeq4AXIQ6WDwsfC5MCvTcZPgkEvD807X9PRtLauPFcKt+3 82xA== X-Gm-Message-State: AOAM531qpKrPGbjseaMQJ77e4ABflVOaX5c6Mr9XaXV9lHh5P+Du3cW4 WHNWM29ZPqnCtQjicdJfHGgH74u/FhE= X-Google-Smtp-Source: ABdhPJxsmR1gxE1l/8mbod8IWY6ICwuhWKFBYSlRUZbxeBJ+edUt6zcgOPL9aZBHVjB3HtfswML73w== X-Received: by 2002:a1c:80d3:: with SMTP id b202mr11473117wmd.111.1594494958286; Sat, 11 Jul 2020 12:15:58 -0700 (PDT) Received: from carbon.localdomain ([2a01:e0a:252:7910:9149:82b1:6f24:5186]) by smtp.gmail.com with ESMTPSA id 207sm16974701wme.13.2020.07.11.12.15.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 12:15:57 -0700 (PDT) From: Matthias Meulien Date: Sat, 11 Jul 2020 21:15:57 +0200 Message-ID: <87h7udzwuq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=orontee@gmail.com; helo=mail-wm1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed When one call describe-mode from *Bookmark List* buffer, the displayed documentation for the Bookmark Menu major mode displays an incomplete hard-coded keymap: The useful key / (bookmark-bmenu-search) isn't listed. I propose to rely on derived-mode-make-docstring to put the mode's keymap in mode docstring and to remove the currently hardcoded keymap description. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-incomplete-keymap-description.patch >From e45b340980c9f347f4a2f0615006617bafd93260 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Sat, 11 Jul 2020 20:55:59 +0200 Subject: [PATCH] Fix incomplete keymap description * lisp/bookmark.el (bookmark-bmenu-mode): Rely on derived-mode-make-docstring to put the mode's keymap in mode docstring --- lisp/bookmark.el | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 5bb1698171..cf8d6e3241 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1745,36 +1745,7 @@ bookmark-bmenu-mode "Major mode for editing a list of bookmarks. Each line describes one of the bookmarks in Emacs. Letters do not insert themselves; instead, they are commands. -Bookmark names preceded by a \"*\" have annotations. -\\ -\\[bookmark-bmenu-mark] -- mark bookmark to be displayed. -\\[bookmark-bmenu-select] -- select bookmark of line point is on. - Also show bookmarks marked using m in other windows. -\\[bookmark-bmenu-toggle-filenames] -- toggle displaying of filenames (they may obscure long bookmark names). -\\[bookmark-bmenu-locate] -- display (in minibuffer) location of this bookmark. -\\[bookmark-bmenu-1-window] -- select this bookmark in full-frame window. -\\[bookmark-bmenu-2-window] -- select this bookmark in one window, - together with bookmark selected before this one in another window. -\\[bookmark-bmenu-this-window] -- select this bookmark in place of the bookmark menu buffer. -\\[bookmark-bmenu-other-window] -- select this bookmark in another window, - so the bookmark menu bookmark remains visible in its window. -\\[bookmark-bmenu-other-frame] -- select this bookmark in another frame. -\\[bookmark-bmenu-switch-other-window] -- switch the other window to this bookmark. -\\[bookmark-bmenu-rename] -- rename this bookmark (prompts for new name). -\\[bookmark-bmenu-relocate] -- relocate this bookmark's file (prompts for new file). -\\[bookmark-bmenu-delete] -- mark this bookmark to be deleted, and move down. -\\[bookmark-bmenu-delete-backwards] -- mark this bookmark to be deleted, and move up. -\\[bookmark-bmenu-execute-deletions] -- delete bookmarks marked with `\\[bookmark-bmenu-delete]'. -\\[bookmark-bmenu-save] -- save the current bookmark list in the default file. - With a prefix arg, prompts for a file to save in. -\\[bookmark-bmenu-load] -- load in a file of bookmarks (prompts for file.) -\\[bookmark-bmenu-unmark] -- remove all kinds of marks from current line. - With prefix argument, also move up one line. -\\[bookmark-bmenu-backup-unmark] -- back up a line and remove marks. -\\[bookmark-bmenu-show-annotation] -- show the annotation, if it exists, for the current bookmark - in another buffer. -\\[bookmark-bmenu-show-all-annotations] -- show the annotations of all bookmarks in another buffer. -\\[bookmark-bmenu-edit-annotation] -- edit the annotation for the current bookmark." +Bookmark names preceded by a \"*\" have annotations." (setq truncate-lines t) (setq buffer-read-only t)) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed In GNU Emacs 28.0.50 (build 22, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-06-30 built on carbon Repository revision: bc8089a3fa11161428c51439fd3b26fd6583345d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: mouse-2, RET: find function's definition uncompressing emacsbug.el.gz...done Note: file is write protected Mark set Mark saved where search started Mark set scroll-down-command: Beginning of buffer [8 times] Quit Type "q" in help window to restore its previous buffer. Finding changes in ~/Sources/emacs/... Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: fr_FR.UTF-8 value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode semantic-idle-scheduler-mode semantic-mru-bookmark-mode) S))) vc-parent-buffer: *vc-dir* highlight-changes-visible-mode: t show-paren-mode: t shell-dirtrack-mode: t minions-mode: t semantic-mode: t desktop-save-mode: t save-place-mode: t electric-pair-mode: t icomplete-mode: t global-so-long-mode: t global-auto-revert-mode: t auto-insert-mode: t text-scale-mode: t tooltip-mode: t global-eldoc-mode: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow emacsbug sendmail log-view log-edit pcvs-util add-log eieio-opt speedbar dframe help-fns radix-tree smerge-mode diff dabbrev tramp-cache hl-line calc-map calc-stat calc-vec calc-ext misearch multi-isearch mule-util calc-menu calc-aent calc calc-loaddefs calc-macs flow-fill etags fileloop sort gnus-cite smiley shr-color color mm-archive mail-extr gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 epa-file gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-cache whitespace sh-script smie executable rst generic bug-reference flyspell ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox goto-addr org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir gnus-sum url url-proxy url-privacy url-expand url-methods url-history mailcap shr url-cookie url-domsuf svg xml dom ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m semantic/wisent/python semantic/wisent/python-wy semantic/wisent semantic/wisent/wisent rx vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs eglot array jsonrpc ert debug backtrace xref flymake-proc flymake thingatpt warnings compile pcase url-util project imenu python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp conf-mode semantic/bovine/make semantic/decorate/include semantic/db-find semantic/db-ref semantic/decorate/mode semantic/decorate pulse semantic/dep semantic/bovine/make-by semantic/bovine display-line-numbers hilit-chg make-mode yasnippet-snippets yasnippet dired-aux paren vc-dir ewoc vc vc-dispatcher bash-completion shell cl-extra help-mode avoid minions carbon-custom cus-edit cus-start cus-load gnus-demon nntp gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc parse-time iso8601 gnus-spec gnus-win nnoo gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit gnus-dired dired-x dired dired-loaddefs org-capture org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities time-date noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs advice skeleton find-file vc-git diff-mode easy-mmode semantic/mru-bookmark ring semantic/db-mode semantic/idle semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn semantic/db eieio-base semantic/format ezimage semantic/tag-ls semantic/find semantic/ctxt semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local find-func cedet ispell desktop frameset server bookmark text-property-search pp saveplace elec-pair edmacro kmacro icomplete so-long autorevert filenotify autoinsert cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs generic-x face-remap proof-site proof-autoloads info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 716231 86353) (symbols 48 44640 61) (strings 32 173896 12445) (string-bytes 1 6166036) (vectors 16 75398) (vector-slots 8 1825868 200660) (floats 8 485 330) (intervals 56 25773 1448) (buffers 992 162)) -- Matthias --=-=-=-- From unknown Sun Sep 14 01:17:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2020 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Matthias Meulien , 42325@debbugs.gnu.org Received: via spool by 42325-submit@debbugs.gnu.org id=B42325.15944993337026 (code B ref 42325); Sat, 11 Jul 2020 20:29:01 +0000 Received: (at 42325) by debbugs.gnu.org; 11 Jul 2020 20:28:53 +0000 Received: from localhost ([127.0.0.1]:44970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juM7A-0001pF-RG for submit@debbugs.gnu.org; Sat, 11 Jul 2020 16:28:53 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juM78-0001p3-0Y for 42325@debbugs.gnu.org; Sat, 11 Jul 2020 16:28:50 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06BKOqHP107112; Sat, 11 Jul 2020 20:28:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ZAC3eU6P9dC6Nofjfnuag6Vx64lNKnUrUuoEotf8vKM=; b=hxKEfFPBIfhhsyGYW2s/q0YWGV42FXgFkdS7Qp0KKRPqSYVE0/f5YQ3Cv1tuKxaus2u4 Ao0XVNJ4vloerKiiJR8OFoAenF4GV2tfLwyc4VQgzh/FffQ7E6v9FcCh+ThWBW7vkNTL ENR1wNq+s4RmljM8JHejEgJiF27SPjFGhfvqbeKyVe04nd+bnQL0vcRG9TSfmU8RQh1N wcquHym8lTLRgHYobOqjs77Phk04pDuKP3zcng+xI9qDypKarcHrTLhWpE2kKupUrGmK BorgnpCyT8Y2YAmNVqmpH/ztVpPR4mTUE11vkHyd7fDqK2HR6F016UugL+h8XLLbJcQL wQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 32762n1x42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 11 Jul 2020 20:28:44 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06BKNQ1g124328; Sat, 11 Jul 2020 20:28:43 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 3273fbqqxa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Jul 2020 20:28:43 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06BKSbUQ019615; Sat, 11 Jul 2020 20:28:42 GMT MIME-Version: 1.0 Message-ID: <14cf9f7a-0c6b-4c26-b4b9-ee95a470ce15@default> Date: Sat, 11 Jul 2020 13:28:34 -0700 (PDT) From: Drew Adams References: <87h7udzwuq.fsf@gmail.com> In-Reply-To: <87h7udzwuq.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9679 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007110161 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9679 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 clxscore=1011 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007110161 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > When one call describe-mode from *Bookmark List* buffer, the > displayed documentation for the Bookmark Menu major mode displays > an incomplete hard-coded keymap: The useful key / > (bookmark-bmenu-search) isn't listed. I propose to rely on > derived-mode-make-docstring to put the mode's keymap in mode > docstring and to remove the currently hardcoded keymap > description. That's definitely a step backward, IMHO. Just add `/' to the list. A mode's `C-h m' documentation can, but need not, list all of its key bindings. (It can also tell users that they can use `C-h b'.) But more importantly, it should describe the mode, not just punt to say that it inherits from its parent. The doc of `derived-mode-make-docstring' should, and I think does, make clear that it provides only rudimentary, fallback help in the (hopefully rare) case where there is no other such help. "Construct a docstring for a new mode if none is provided." ^^^^^^^^^^^^^^^^^^^ It doesn't say that it's a good idea to not provide a doc string for a derived mode, and to instead use this to construct one. Thank goodness. Providing a doc string is normal. Not providing one is to be avoided, and IMO, is a bug from a user point of view. There's little excuse for copping out and not providing a doc string. There's even less excuse for doing that for a mode's doc. And there's still less excuse for _replacing_ hand-written help with such a poor, generic, robotic fallback. Please just do the right thing, adding the help you think is missing. And provide whatever other manual updates you think might help. [To be clear, this doesn't affect me or my code. Bookmark+ doesn't use the mode help provided by vanilla bookmark.el. I'm just expressing my concern for vanilla Emacs here.] From unknown Sun Sep 14 01:17:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Matthias Meulien Subject: bug#42325: closed (Re: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description) Message-ID: References: <83a6zxi7fq.fsf@gnu.org> <87h7udzwuq.fsf@gmail.com> X-Gnu-PR-Message: they-closed 42325 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 42325@debbugs.gnu.org Date: Sat, 18 Jul 2020 07:56:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1595058961-18929-1" This is a multi-part message in MIME format... ------------=_1595058961-18929-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 42325@debbugs.gnu.org. --=20 42325: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D42325 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1595058961-18929-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 42325-done) by debbugs.gnu.org; 18 Jul 2020 07:55:32 +0000 Received: from localhost ([127.0.0.1]:58391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwhgx-0004uY-Jc for submit@debbugs.gnu.org; Sat, 18 Jul 2020 03:55:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwhgv-0004uL-Ma for 42325-done@debbugs.gnu.org; Sat, 18 Jul 2020 03:55:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47135) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwhgq-0001RC-Ch; Sat, 18 Jul 2020 03:55:24 -0400 Received: from [176.228.60.248] (port=4412 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jwhgi-0001Hn-NA; Sat, 18 Jul 2020 03:55:20 -0400 Date: Sat, 18 Jul 2020 10:55:05 +0300 Message-Id: <83a6zxi7fq.fsf@gnu.org> From: Eli Zaretskii To: Matthias Meulien In-Reply-To: <87h7udzwuq.fsf@gmail.com> (message from Matthias Meulien on Sat, 11 Jul 2020 21:15:57 +0200) Subject: Re: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description References: <87h7udzwuq.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42325-done Cc: 42325-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Matthias Meulien > Date: Sat, 11 Jul 2020 21:15:57 +0200 > > When one call describe-mode from *Bookmark List* buffer, the > displayed documentation for the Bookmark Menu major mode displays > an incomplete hard-coded keymap: The useful key / > (bookmark-bmenu-search) isn't listed. I propose to rely on > derived-mode-make-docstring to put the mode's keymap in mode > docstring and to remove the currently hardcoded keymap > description. Thanks. As Drew points out, there's no need to show the entire set of commands, so I just added '/' to the list. ------------=_1595058961-18929-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jul 2020 19:16:06 +0000 Received: from localhost ([127.0.0.1]:44920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyk-0008Vd-9J for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:36156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1juKyh-0008VK-18 for submit@debbugs.gnu.org; Sat, 11 Jul 2020 15:16:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juKyg-0005Pz-Q4 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:52270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1juKye-0004Fh-E2 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2020 15:16:02 -0400 Received: by mail-wm1-x32b.google.com with SMTP id q15so9376818wmj.2 for ; Sat, 11 Jul 2020 12:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=pw6hP7Rf1kVg+MkDNm64JUBQ1X9qgX2y6c3OdxMSKrf1ZBH4/BAA8RV1/JdGXHGKrB x8fPg5JYJs0zl3Yolw3BTDv5T8OIrqtxBBaJhfJA+m1dnK0qQRs4/xFX/RiRwSOL2ofT DgBTBDdkFP4hpgirBLvVtS7uKgXMLqHSi4mpB57q+lEO4t3J9Nf9FxA5MnQQXA7fYKcJ XySGCnQ+TWHVTLZ+VR+BS3tqzIpaPkLizaV/EBNVl9M9Y7z60R4TeM06tWMNu+Sq/Vib Pyhq5HQhgj9FvxGh2FNYKZqHcZ6oWlRfimX0GwJ95hhv86Zxg+nhzQcpBlON8ermreed f/iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=VIFtNlHPU4KxI7d7NjsrsWn8mRnzRjbAuJR934JGWEc=; b=bpDcR8GeX+KaomBMUxPtwV200CBzyVs1sHxEHXrJ2dBzW7U7TOwdocR4SSp2qoNVPq Uq5Ku11lbWGuSNwGx3bptSWw+BhqC1IiEXN07CBG0SWPtWTOVj2JPwYuy1QZqbhRNsoh H6vvdNb9xfsixMcUIefTCqVKbTWJ9Kcf99peZrOjBYOa4Fd5HRKj2uom+APFQwxZPIyE kwpvkiFv5hufOmK42jpeomnJqu471aug0rKFaPSUGoXvpovnc88YnkJW4unyPqZH3hCf m3YsFxE/r1ZRTlo16MbsbOxeq4AXIQ6WDwsfC5MCvTcZPgkEvD807X9PRtLauPFcKt+3 82xA== X-Gm-Message-State: AOAM531qpKrPGbjseaMQJ77e4ABflVOaX5c6Mr9XaXV9lHh5P+Du3cW4 WHNWM29ZPqnCtQjicdJfHGgH74u/FhE= X-Google-Smtp-Source: ABdhPJxsmR1gxE1l/8mbod8IWY6ICwuhWKFBYSlRUZbxeBJ+edUt6zcgOPL9aZBHVjB3HtfswML73w== X-Received: by 2002:a1c:80d3:: with SMTP id b202mr11473117wmd.111.1594494958286; Sat, 11 Jul 2020 12:15:58 -0700 (PDT) Received: from carbon.localdomain ([2a01:e0a:252:7910:9149:82b1:6f24:5186]) by smtp.gmail.com with ESMTPSA id 207sm16974701wme.13.2020.07.11.12.15.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 12:15:57 -0700 (PDT) From: Matthias Meulien To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description Date: Sat, 11 Jul 2020 21:15:57 +0200 Message-ID: <87h7udzwuq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=orontee@gmail.com; helo=mail-wm1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed When one call describe-mode from *Bookmark List* buffer, the displayed documentation for the Bookmark Menu major mode displays an incomplete hard-coded keymap: The useful key / (bookmark-bmenu-search) isn't listed. I propose to rely on derived-mode-make-docstring to put the mode's keymap in mode docstring and to remove the currently hardcoded keymap description. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-incomplete-keymap-description.patch >From e45b340980c9f347f4a2f0615006617bafd93260 Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Sat, 11 Jul 2020 20:55:59 +0200 Subject: [PATCH] Fix incomplete keymap description * lisp/bookmark.el (bookmark-bmenu-mode): Rely on derived-mode-make-docstring to put the mode's keymap in mode docstring --- lisp/bookmark.el | 31 +------------------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 5bb1698171..cf8d6e3241 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1745,36 +1745,7 @@ bookmark-bmenu-mode "Major mode for editing a list of bookmarks. Each line describes one of the bookmarks in Emacs. Letters do not insert themselves; instead, they are commands. -Bookmark names preceded by a \"*\" have annotations. -\\ -\\[bookmark-bmenu-mark] -- mark bookmark to be displayed. -\\[bookmark-bmenu-select] -- select bookmark of line point is on. - Also show bookmarks marked using m in other windows. -\\[bookmark-bmenu-toggle-filenames] -- toggle displaying of filenames (they may obscure long bookmark names). -\\[bookmark-bmenu-locate] -- display (in minibuffer) location of this bookmark. -\\[bookmark-bmenu-1-window] -- select this bookmark in full-frame window. -\\[bookmark-bmenu-2-window] -- select this bookmark in one window, - together with bookmark selected before this one in another window. -\\[bookmark-bmenu-this-window] -- select this bookmark in place of the bookmark menu buffer. -\\[bookmark-bmenu-other-window] -- select this bookmark in another window, - so the bookmark menu bookmark remains visible in its window. -\\[bookmark-bmenu-other-frame] -- select this bookmark in another frame. -\\[bookmark-bmenu-switch-other-window] -- switch the other window to this bookmark. -\\[bookmark-bmenu-rename] -- rename this bookmark (prompts for new name). -\\[bookmark-bmenu-relocate] -- relocate this bookmark's file (prompts for new file). -\\[bookmark-bmenu-delete] -- mark this bookmark to be deleted, and move down. -\\[bookmark-bmenu-delete-backwards] -- mark this bookmark to be deleted, and move up. -\\[bookmark-bmenu-execute-deletions] -- delete bookmarks marked with `\\[bookmark-bmenu-delete]'. -\\[bookmark-bmenu-save] -- save the current bookmark list in the default file. - With a prefix arg, prompts for a file to save in. -\\[bookmark-bmenu-load] -- load in a file of bookmarks (prompts for file.) -\\[bookmark-bmenu-unmark] -- remove all kinds of marks from current line. - With prefix argument, also move up one line. -\\[bookmark-bmenu-backup-unmark] -- back up a line and remove marks. -\\[bookmark-bmenu-show-annotation] -- show the annotation, if it exists, for the current bookmark - in another buffer. -\\[bookmark-bmenu-show-all-annotations] -- show the annotations of all bookmarks in another buffer. -\\[bookmark-bmenu-edit-annotation] -- edit the annotation for the current bookmark." +Bookmark names preceded by a \"*\" have annotations." (setq truncate-lines t) (setq buffer-read-only t)) -- 2.20.1 --=-=-= Content-Type: text/plain; format=flowed In GNU Emacs 28.0.50 (build 22, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-06-30 built on carbon Repository revision: bc8089a3fa11161428c51439fd3b26fd6583345d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Recent messages: mouse-2, RET: find function's definition uncompressing emacsbug.el.gz...done Note: file is write protected Mark set Mark saved where search started Mark set scroll-down-command: Beginning of buffer [8 times] Quit Type "q" in help window to restore its previous buffer. Finding changes in ~/Sources/emacs/... Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: fr_FR.UTF-8 value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode semantic-idle-scheduler-mode semantic-mru-bookmark-mode) S))) vc-parent-buffer: *vc-dir* highlight-changes-visible-mode: t show-paren-mode: t shell-dirtrack-mode: t minions-mode: t semantic-mode: t desktop-save-mode: t save-place-mode: t electric-pair-mode: t icomplete-mode: t global-so-long-mode: t global-auto-revert-mode: t auto-insert-mode: t text-scale-mode: t tooltip-mode: t global-eldoc-mode: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow emacsbug sendmail log-view log-edit pcvs-util add-log eieio-opt speedbar dframe help-fns radix-tree smerge-mode diff dabbrev tramp-cache hl-line calc-map calc-stat calc-vec calc-ext misearch multi-isearch mule-util calc-menu calc-aent calc calc-loaddefs calc-macs flow-fill etags fileloop sort gnus-cite smiley shr-color color mm-archive mail-extr gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 epa-file gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-cache whitespace sh-script smie executable rst generic bug-reference flyspell ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox goto-addr org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir gnus-sum url url-proxy url-privacy url-expand url-methods url-history mailcap shr url-cookie url-domsuf svg xml dom ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m semantic/wisent/python semantic/wisent/python-wy semantic/wisent semantic/wisent/wisent rx vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs eglot array jsonrpc ert debug backtrace xref flymake-proc flymake thingatpt warnings compile pcase url-util project imenu python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp conf-mode semantic/bovine/make semantic/decorate/include semantic/db-find semantic/db-ref semantic/decorate/mode semantic/decorate pulse semantic/dep semantic/bovine/make-by semantic/bovine display-line-numbers hilit-chg make-mode yasnippet-snippets yasnippet dired-aux paren vc-dir ewoc vc vc-dispatcher bash-completion shell cl-extra help-mode avoid minions carbon-custom cus-edit cus-start cus-load gnus-demon nntp gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc parse-time iso8601 gnus-spec gnus-win nnoo gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit gnus-dired dired-x dired dired-loaddefs org-capture org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities time-date noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs advice skeleton find-file vc-git diff-mode easy-mmode semantic/mru-bookmark ring semantic/db-mode semantic/idle semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn semantic/db eieio-base semantic/format ezimage semantic/tag-ls semantic/find semantic/ctxt semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local find-func cedet ispell desktop frameset server bookmark text-property-search pp saveplace elec-pair edmacro kmacro icomplete so-long autorevert filenotify autoinsert cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs generic-x face-remap proof-site proof-autoloads info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 716231 86353) (symbols 48 44640 61) (strings 32 173896 12445) (string-bytes 1 6166036) (vectors 16 75398) (vector-slots 8 1825868 200660) (floats 8 485 330) (intervals 56 25773 1448) (buffers 992 162)) -- Matthias --=-=-=-- ------------=_1595058961-18929-1-- From unknown Sun Sep 14 01:17:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#42325: 28.0.50; [PATCH] Incomplete keymap in Bookmark Menu mode description Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jul 2020 10:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 42325-done@debbugs.gnu.org Received: via spool by 42325-done@debbugs.gnu.org id=D42325.15950663706142 (code D ref 42325); Sat, 18 Jul 2020 10:00:01 +0000 Received: (at 42325-done) by debbugs.gnu.org; 18 Jul 2020 09:59:30 +0000 Received: from localhost ([127.0.0.1]:58427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwjcv-0001b0-Re for submit@debbugs.gnu.org; Sat, 18 Jul 2020 05:59:30 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:41139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwjct-0001ak-Sy for 42325-done@debbugs.gnu.org; Sat, 18 Jul 2020 05:59:29 -0400 Received: by mail-wr1-f49.google.com with SMTP id z15so13460950wrl.8 for <42325-done@debbugs.gnu.org>; Sat, 18 Jul 2020 02:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h1hu6LE6lr4z6KHyeuTK5paVQGk20v2rHU0H4HZvXiM=; b=vVFU/qvnPm915F/4abd0M04m5yNv01CB2eVx5Ig6bOA+FESU8IWWIwoJP8Rr6sduQV FiiE93d64FRQ48O3jX7t34A7sU6TZxMtuW0l34WigQrihbMuMMd2tcqpxpuSwPIgesok hKkWa27fWIgVZ1f8EeiskSnTKPc3L1bOVKYMQADXtH4Q6RjVjQi+n78L2NbXsjoaZ7qs W1bND+ZdxExsxyfCGLWmG8i/o+JrRRgSyf0rM4qT059nGArtgYpManVK1kMCgE8KdJxa kS15AEAB4peKj+pxlYjsE5e8UrbQ7R2KFuwI1ETzeLEQ+PhnkjD/alGwGQArAe9TxUld AbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h1hu6LE6lr4z6KHyeuTK5paVQGk20v2rHU0H4HZvXiM=; b=KtWYTU7T5ImRiG7d47a4mNi2dptWXbRFzUw6G/Via1SwUEd5rwg52ukIyEaz0Bfidy VSWSyIv5eOJ1kavcHK9rkcfKMWVJprl9UiQmEvAOOI46nca27tVzHKuq8vUwCrTAEbxp nCKNI5MjUwOYiwtru14yj3TCHrqeTYv7jSZc+3r5ZHAd/k+FMZA7B8gHHDXuVRBw7/29 Vj0sgQhvHmqO2cjgQtulw3whia4HDFk3l3j+5FmFvFX6XFfqe0891MpscBW1LuoJE91K zc/rZr0fiFN3sZTWC3/t5RzZgY85Mbvo8OKPqtPtEQcvX/eVMesaY00SXi/kmrIFRNY/ HJUw== X-Gm-Message-State: AOAM532gbKKdDqsD2nQvLAIEjy+s0TsW0z9GkdYsxKgbon17lx/4EMqs DG9+sn4qvoR1xfDQi3EBrN9RcJ7li3wH6KtL0uleWQ== X-Google-Smtp-Source: ABdhPJwWRb+EBCr/rmzJjHtsqB7Q8ALEVE8kXri1nDdw9g82LyHOgdXfLQb2Xwp2/R2fex6Q/oPxODkKJXyWH3Sni0Q= X-Received: by 2002:adf:8b50:: with SMTP id v16mr14756097wra.188.1595066361892; Sat, 18 Jul 2020 02:59:21 -0700 (PDT) MIME-Version: 1.0 References: <87h7udzwuq.fsf@gmail.com> <83a6zxi7fq.fsf@gnu.org> In-Reply-To: <83a6zxi7fq.fsf@gnu.org> From: Matthias Meulien Date: Sat, 18 Jul 2020 11:59:10 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000e4d0c405aab453f0" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e4d0c405aab453f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you. Le sam. 18 juil. 2020 09:55, Eli Zaretskii a =C3=A9crit : > > From: Matthias Meulien > > Date: Sat, 11 Jul 2020 21:15:57 +0200 > > > > When one call describe-mode from *Bookmark List* buffer, the > > displayed documentation for the Bookmark Menu major mode displays > > an incomplete hard-coded keymap: The useful key / > > (bookmark-bmenu-search) isn't listed. I propose to rely on > > derived-mode-make-docstring to put the mode's keymap in mode > > docstring and to remove the currently hardcoded keymap > > description. > > Thanks. > > As Drew points out, there's no need to show the entire set of > commands, so I just added '/' to the list. > --000000000000e4d0c405aab453f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you.

Le sam. 18 juil. 2020 09:55, Eli Zaretskii &l= t;eliz@gnu.org> a =C3=A9crit=C2=A0:<= br>
> From: Matthias Meulien <oron= tee@gmail.com>
> Date: Sat, 11 Jul 2020 21:15:57 +0200
>
> When one call describe-mode from *Bookmark List* buffer, the
> displayed documentation for the Bookmark Menu major mode displays
> an incomplete hard-coded keymap: The useful key /
> (bookmark-bmenu-search) isn't listed. I propose to rely on
> derived-mode-make-docstring to put the mode's keymap in mode
> docstring and to remove the currently hardcoded keymap
> description.

Thanks.

As Drew points out, there's no need to show the entire set of
commands, so I just added '/' to the list.
--000000000000e4d0c405aab453f0--