GNU bug report logs - #42306
[PATCH] gnu: Add nfs4-acl-tools

Previous Next

Full log

Message #8 received at 42306 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Lars-Dominik Braun <ldb <at> leibniz-psychology.org>, 42306 <at> debbugs.gnu.org
Subject: Re: [bug#42306] [PATCH] gnu: Add nfs4-acl-tools
Date: Sat, 25 Jul 2020 17:20:00 +0200

[Message part 1 (text/plain, inline)]

Hello!

Sorry for the late reply...

The patch mostly LGTM, but no longer applies.  Can you rebase it on
current master?  Meanwhile, a few comments:

Lars-Dominik Braun <ldb <at> leibniz-psychology.org> writes:

> * gnu/packages/acl.scm (nfs4-acl-tools): New variable.
> * gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.
> * gnu/local.mk: Add it.

[...]

> +    (synopsis "This package contains commandline ACL utilities for the Linux
> +NFSv4 client")

Just "Command line ACL utilities for NFS"

> +    (description "Provides the commandline utilities nfs4_setfacl and
> +nfs4_getfacl, which are similar to their POSIX equivalents.")

Descriptions OTOH should be complete sentences, something like:

"This package provides the command line utilities
@command{nfs4_setfacl} and @command{nfs4_getfacl} [...]".

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.